Skip to contentSkip to conversation

atm: slight optimization of addr compare

PATCH In review Ding Tianhong 1 participant 1 message Jan 8, 2014

Subsystems (3)
Networking Network drivers ATM
lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH 11/19 atm: slight optimization of addr compare

Use possibly more efficient ether_addr_equal
instead of memcmp.

Cc Chas Williams <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Yang Yingliang <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
---
 drivers/atm/nicstar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/atm/nicstar.c +2 -2
index 5aca5f4..9587e95 100644
@@ -52,6 +52,7 @@
 #include <asm/io.h>
 #include <asm/uaccess.h>
 #include <linux/atomic.h>
+#include <linux/etherdevice.h>
 #include "nicstar.h"
 #ifdef CONFIG_ATM_NICSTAR_USE_SUNI
 #include "suni.h"

@@ -781,8 +782,7 @@ static int ns_init_card(int i, struct pci_dev *pcidev)
 	if (mac[i] == NULL || !mac_pton(mac[i], card->atmdev->esi)) {
 		nicstar_read_eprom(card->membase, NICSTAR_EPROM_MAC_ADDR_OFFSET,
 				   card->atmdev->esi, 6);
-		if (memcmp(card->atmdev->esi, "\x00\x00\x00\x00\x00\x00", 6) ==
-		    0) {
+		if (ether_addr_equal(card->atmdev->esi, "\x00\x00\x00\x00\x00\x00")) {
 			nicstar_read_eprom(card->membase,
 					   NICSTAR_EPROM_MAC_ADDR_OFFSET_ALT,
 					   card->atmdev->esi, 6);
Signature · 1 line
1.8.0