Skip to content

slight optimization of addr compare for some modules

Ding Tianhong lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19net: freescale: remove unused compare_addr()drivers/net/ethernet/freescale/ucc_geth.c+0 -50 replies
2/19net: pcnet: slight optimization of addr comparedrivers/net/ethernet/amd/pcnet32.c+1 -10 replies
3/19net: atl1: slight optimization of addr comparedrivers/net/ethernet/atheros/atlx/atl1.c+2 -10 replies
4/19hamradio: slight optimization of addr comparedrivers/net/hamradio/bpqether.c+1 -10 replies
5/19ppp: slight optimization of addr comparedrivers/net/ppp/pppoe.c+2 -20 replies
6/19batman-adv: use batadv_compare_eth for concisenet/batman-adv/originator.c net/batman-adv/translation-table.c+2 -22 replies
7/19zd1211rw: slight optimization of addr comparedrivers/net/wireless/zd1211rw/zd_mac.c+2 -30 replies
8/19ozwpan: slight optimization of addr comparedrivers/staging/ozwpan/ozcdev.c drivers/staging/ozwpan/ozproto.c+4 -31 reply
9/19infiniband: slight optimization of addr comparedrivers/infiniband/hw/nes/nes_cm.c+1 -20 replies
10/19mac8011: slight optimization of addr comparenet/mac80211/iface.c+3 -40 replies
11/19atm: slight optimization of addr comparedrivers/atm/nicstar.c+2 -20 replies
12/19isdn: slight optimization of addr comparedrivers/isdn/i4l/isdn_net.c+2 -20 replies
13/19media: dvb_core: slight optimization of addr comparedrivers/media/dvb-core/dvb_net.c+6 -40 replies
14/19hostap: slight optimization of addr comparedrivers/net/wireless/hostap/hostap_80211_tx.c drivers/net/wireless/hostap/hostap_ap.c drivers/net/wireless/hostap/hostap_hw.c +2 more+22 -240 replies
15/19cw1200: slight optimization of addr comparedrivers/net/wireless/cw1200/sta.c drivers/net/wireless/cw1200/txrx.c+4 -40 replies
16/19ipw2x00: slight optimization of addr comparedrivers/net/wireless/ipw2x00/ipw2200.c drivers/net/wireless/ipw2x00/libipw_rx.c+22 -220 replies
17/19mwifiex: slight optimization of addr comparedrivers/net/wireless/mwifiex/11n.c drivers/net/wireless/mwifiex/sta_cmdresp.c drivers/net/wireless/mwifiex/sta_rx.c+3 -41 reply
18/19rtlwifi: slight optimization of addr comparedrivers/net/wireless/rtlwifi/cam.c+2 -20 replies
19/19wireless: slight optimization of addr comparedrivers/net/wireless/adm8211.c drivers/net/wireless/brcm80211/brcmfmac/p2p.c drivers/net/wireless/hostap/hostap_80211_rx.c +3 more+13 -130 replies

Reviews trailers per patch

3 of 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMauro Carvalho ChehabAntonio QuartulliRupesh Gujare
SeriesA-b
1/19
2/19
3/19
4/19
5/19
6/19A-b
7/19
8/19A-b
9/19
10/19
11/19
12/19
13/19A-b
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v3.6 00/19] slight optimization of addr compare for some modules

Joe Perches add ether_addr_equal_unaligned to test if possibly unaligned to u16 Ethernet addresses are equal.

If CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is set, this uses the slightly faster generic routine ether_addr_equal, otherwise this uses memcmp.

So I use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp for slight optimization.

v2: Because a lot of places are already using 16b aligned MAC
address for both operands, so use the ether_addr_equal to instead of ether_addr_equal_unaligned.Thanks for Joe, Alex and Antonio's opinions.
Also remove the patch for bridge.

v3: According Joe's suggestion, the patch
(net: slight optimization of addr compare for some modules) should be broken into several patches, and it will be good to review for maintainers. So I will send rest of the patches for first step, and next step, I will seperate the netdev patch and send them by another patchset for net-next.
also fix some changelog.

v3.5 Change some style for patch 8 and patch 13. Thanks for
Sergei's suggestion.

v3.6 Change some style for patch 13 and add

Best Regards
Ding

Ding Tianhong (5):
net: freescale: remove unused compare_addr()
net: pcnet: slight optimization of addr compare
net: atl1: slight optimization of addr compare
hamradio: slight optimization of addr compare
ppp: slight optimization of addr compare

Tan Xiaojun (3):
batman-adv: use batadv_compare_eth for concise
zd1211rw: slight optimization of addr compare
ozwpan: slight optimization of addr compare

Wang Weidong (2):
infiniband: slight optimization of addr compare
mac8011: slight optimization of addr compare

Weilong Chen (6):
hostap: slight optimization of addr compare
cw1200: slight optimization of addr compare
ipw2x00: slight optimization of addr compare
mwifiex: slight optimization of addr compare
rtlwifi: slight optimization of addr compare
wireless: slight optimization of addr compare

Yang Yingliang (3):
atm: slight optimization of addr compare
isdn: slight optimization of addr compare
media: dvb_core: slight optimization of addr compare

 drivers/atm/nicstar.c                         |  4 ++--
 drivers/infiniband/hw/nes/nes_cm.c            |  3 +--
 drivers/isdn/i4l/isdn_net.c                   |  4 ++--
 drivers/media/dvb-core/dvb_net.c              |  8 +++----
 drivers/net/ethernet/amd/pcnet32.c            |  2 +-
 drivers/net/ethernet/atheros/atlx/atl1.c      |  3 ++-
 drivers/net/ethernet/freescale/ucc_geth.c     |  5 ----
 drivers/net/hamradio/bpqether.c               |  2 +-
 drivers/net/ppp/pppoe.c                       |  4 ++--
 drivers/net/wireless/adm8211.c                |  2 +-
 drivers/net/wireless/brcm80211/brcmfmac/p2p.c |  7 +++---
 drivers/net/wireless/cw1200/sta.c             |  5 ++--
 drivers/net/wireless/cw1200/txrx.c            |  3 +--
 drivers/net/wireless/hostap/hostap_80211_rx.c |  8 +++----
 drivers/net/wireless/hostap/hostap_80211_tx.c |  4 ++--
 drivers/net/wireless/hostap/hostap_ap.c       | 28 +++++++++++-----------
 drivers/net/wireless/hostap/hostap_hw.c       |  2 +-
 drivers/net/wireless/hostap/hostap_ioctl.c    |  4 ++--
 drivers/net/wireless/hostap/hostap_main.c     |  8 +++----
 drivers/net/wireless/ipw2x00/ipw2200.c        | 34 +++++++++++++--------------
 drivers/net/wireless/ipw2x00/libipw_rx.c      | 10 ++++----
 drivers/net/wireless/mwifiex/11n.c            |  2 +-
 drivers/net/wireless/mwifiex/sta_cmdresp.c    |  3 +--
 drivers/net/wireless/mwifiex/sta_rx.c         |  2 +-
 drivers/net/wireless/prism54/isl_ioctl.c      |  3 ++-
 drivers/net/wireless/rtlwifi/cam.c            |  4 ++--
 drivers/net/wireless/ti/wl1251/main.c         |  2 +-
 drivers/net/wireless/wl3501_cs.c              |  4 ++--
 drivers/net/wireless/zd1211rw/zd_mac.c        |  5 ++--
 drivers/staging/ozwpan/ozcdev.c               |  2 +-
 drivers/staging/ozwpan/ozproto.c              |  5 ++--
 net/batman-adv/originator.c                   |  2 +-
 net/batman-adv/translation-table.c            |  2 +-
 net/mac80211/iface.c                          |  7 +++---
 34 files changed, 92 insertions(+), 101 deletions(-)
Signature · 1 line
1.8.0