mwifiex: slight optimization of addr compare

PATCH In review Ding Tianhong 2 participants 2 messages Jan 8, 2014

Subsystems (3)

Networking Network drivers Networking drivers (wireless)

lore

Share & tools

lore

Ding Tianhong

author

2014-01-08 02:54 UTC #0 lore raw

PATCH 17/19 mwifiex: slight optimization of addr compare

Use possibly more efficient ether_addr_equal
instead of memcmp.

Cc Bing Zhao <[email protected]>

Cc John W. Linville <[email protected]>

Cc [email protected]

Signed-off-by Weilong Chen <[email protected]>

Signed-off-by Ding Tianhong <[email protected]>

---
 drivers/net/wireless/mwifiex/11n.c         | 2 +-
 drivers/net/wireless/mwifiex/sta_cmdresp.c | 3 +--
 drivers/net/wireless/mwifiex/sta_rx.c      | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

drivers/net/wireless/mwifiex/11n.c +1 -1

index 0b803c0..6261f8c 100644
@@ -483,7 +483,7 @@ mwifiex_get_ba_tbl(struct mwifiex_private *priv, int tid, u8 *ra)
 
 	spin_lock_irqsave(&priv->tx_ba_stream_tbl_lock, flags);
 	list_for_each_entry(tx_ba_tsr_tbl, &priv->tx_ba_stream_tbl_ptr, list) {
-		if (!memcmp(tx_ba_tsr_tbl->ra, ra, ETH_ALEN) &&
+		if (ether_addr_equal_unaligned(tx_ba_tsr_tbl->ra, ra) &&
 		    tx_ba_tsr_tbl->tid == tid) {
 			spin_unlock_irqrestore(&priv->tx_ba_stream_tbl_lock,
 					       flags);

drivers/net/wireless/mwifiex/sta_cmdresp.c +1 -2

index 5511946..24523e4 100644
@@ -782,8 +782,7 @@ static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv,
 	}
 
 	/* If BSSID is diff, modify current BSS parameters */
-	if (memcmp(priv->curr_bss_params.bss_descriptor.mac_address,
-		   ibss_coal_resp->bssid, ETH_ALEN)) {
+	if (!ether_addr_equal(priv->curr_bss_params.bss_descriptor.mac_address, ibss_coal_resp->bssid)) {
 		/* BSSID */
 		memcpy(priv->curr_bss_params.bss_descriptor.mac_address,
 		       ibss_coal_resp->bssid, ETH_ALEN);

drivers/net/wireless/mwifiex/sta_rx.c +1 -1

index 0bb510d..4651d67 100644
@@ -224,7 +224,7 @@ int mwifiex_process_sta_rx_packet(struct mwifiex_private *priv,
 	 * directly to os. Don't pass thru rx reordering
 	 */
 	if (!IS_11N_ENABLED(priv) ||
-	    memcmp(priv->curr_addr, rx_pkt_hdr->eth803_hdr.h_dest, ETH_ALEN)) {
+	    !ether_addr_equal_unaligned(priv->curr_addr, rx_pkt_hdr->eth803_hdr.h_dest)) {
 		mwifiex_process_rx_packet(priv, skb);
 		return ret;
 	}

Signature · 1 line

1.8.0

SGkgRGluZywNCg0KPiAtCWlmIChtZW1jbXAocHJpdi0+Y3Vycl9ic3NfcGFyYW1zLmJzc19kZXNj cmlwdG9yLm1hY19hZGRyZXNzLA0KPiAtCQkgICBpYnNzX2NvYWxfcmVzcC0+YnNzaWQsIEVUSF9B TEVOKSkgew0KPiArCWlmICghZXRoZXJfYWRkcl9lcXVhbChwcml2LT5jdXJyX2Jzc19wYXJhbXMu YnNzX2Rlc2NyaXB0b3IubWFjX2FkZHJlc3MsIGlic3NfY29hbF9yZXNwLT5ic3NpZCkpDQoNClN0 aWxsIHdyb25nLi4uIDspDQoNCkhhdmUgeW91IGFjdHVhbGx5IHJ1biB0aGUgY2hlY2twYXRjaC5w bCBzY3JpcHQ/DQoNCkJ5IHRoZSB3YXksIHlvdXIgc3ViamVjdCBwcmVmaXggIlBBVENIIHYzLjYi IGlzIGNvbmZ1c2luZy4gSXQgb3VnaHQgdG8gYmUgIlBBVENIIHY2IiwgSSBndWVzcy4NCg0KVGhh bmtzLA0KQmluZw0KDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html