batman-adv: use batadv_compare_eth for concise

PATCH In review Ding Tianhong 2 participants 3 messages Jan 8, 2014

Subsystems (3)

Networking Network drivers Batman advanced

lore

Share & tools

lore

Ding Tianhong

author

2014-01-08 02:53 UTC #0 lore raw

PATCH 6/19 batman-adv: use batadv_compare_eth for concise

It is better to use batadv_compate_eth instead of memcpy for concise style.

Cc Marek Lindner <[email protected]>

Cc Simon Wunderlich <[email protected]>

Cc Antonio Quartulli <[email protected]>

Cc "David S. Miller" <[email protected]>

Cc [email protected]

Signed-off-by Tan Xiaojun <[email protected]>

Signed-off-by Ding Tianhong <[email protected]>

Acked-by Antonio Quartulli <[email protected]>

---
 net/batman-adv/originator.c        | 2 +-
 net/batman-adv/translation-table.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

net/batman-adv/originator.c +1 -1

index 8ab1434..803ab4b 100644
@@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
 	const void *data1 = container_of(node, struct batadv_orig_node,
 					 hash_entry);
 
-	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+	return batadv_compare_eth(data1, data2);
 }
 
 /**

net/batman-adv/translation-table.c +1 -1

index 4add57d..06506e6 100644
@@ -51,7 +51,7 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
 	const void *data1 = container_of(node, struct batadv_tt_common_entry,
 					 hash_entry);
 
-	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+	return batadv_compare_eth(data1, data2);
 }
 
 /**

Signature · 1 line

1.8.0

Antonio Quartulli

2014-01-08 07:06 UTC #1 lore raw

Quoted 13 lines · Ding Tianhong

It is better to use batadv_compate_eth instead of memcpy for concise style.
Cc Marek Lindner <[email protected]>
Cc Simon Wunderlich <[email protected]>
Cc Antonio Quartulli <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Tan Xiaojun <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
Acked-by Antonio Quartulli <[email protected]>

Am I wrong or this patch has already been merged in net-next (together with other patches from this series)?

Regards,

Signature · 1 line

Antonio Quartulli

Ding Tianhong

author

2014-01-08 07:32 UTC #2 lore raw

Quoted 15 lines · Antonio Quartulli

Quoted 13 lines · Ding Tianhong
It is better to use batadv_compate_eth instead of memcpy for concise style.
Cc Marek Lindner <[email protected]>
Cc Simon Wunderlich <[email protected]>
Cc Antonio Quartulli <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Tan Xiaojun <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
Acked-by Antonio Quartulli <[email protected]>

Quoted 8 lines

Am I wrong or this patch has already been merged in net-next (together with other patches from this series)?
Regards,

Yes， it is already in net-next, so miss it, thanks.

Regards
Ding