Skip to contentSkip to conversation

MX31: Add basic support for Freescale i.MX31 PDK board.

PATCH Superseded Fabio Estevam 2 participants 2 messages Jun 10, 2009

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 5/6 MX31: Add basic support for Freescale i.MX31 PDK board.

Hi Wolfgang,

Quoted 22 lines · Wolfgang Denk
Quoted 5 lines
MAINTAINERS +0 -0
@@ -527,6 +527,10 @@ Thomas Elste <[email protected]>

?
? ??? modnet50???

ARM720T (NET+50)

MAINTAINERS

Quoted 4 lines

?

MAINTAINERS +3 -0
+Fabio Estevam <[email protected]>
+
+??? mx31pdk???

??? i.MX31

Quoted 2 lines

+
? Peter Figuli <[email protected]>

Is this correct? It's quite unusal that somebody? becomes? maintainer
of? a? port? who? seems to have not
been involved with it at all - at
least I cannot see his name in any of the Signed-off-by lines nor? in
any (C) lines or anywhere else?

Quoted 1 line

Fabio, do you agree?

Magnus told me off the list that he has no interest in becoming the board maintainer and asked me if I could be the maintainer for the MX31PDK.

We have been working on the MX31PDK U-boot port for quite some time.

If you prefer to assign someone else, that's no problem for me.

Quoted 16 lines

...

MAINTAINERS

Quoted 3 lines
MAINTAINERS +3 -0
+int board_init(void)
+{
+??? /* CS5: CPLD incl. network

controller */

MAINTAINERS

Quoted 9 lines

+??? __REG(CSCR_U(5)) = 0x0000d843;
+??? __REG(CSCR_L(5)) = 0x22252521;
+??? __REG(CSCR_A(5)) = 0x22220a00;

MAINTAINERS +6 -0
+
+??? /* Setup UART1 and SPI2 pins */
+??? mx31_uart1_hw_init();
+??? mx31_spi2_hw_init();
+
+??? gd->bd->bi_arch_number =

MACH_TYPE_MX31_3DS; /* board id for linux */

Quoted 3 lines

Hm... that's the MACH ID for the Freescale MX31_3DS board. You are
talking about PDK instead. Are these two really the same?

Yes, they are the same.
In Linux we also refer to mx31pdk board and its machine type is MX31_3DS.

Quoted 16 lines
Quoted 2 lines

+??? gd->bd->bi_boot_params =

PHYS_SDRAM_1 + 0x100;

MAINTAINERS

Quoted 7 lines
MAINTAINERS +7 -0
+
+??? return 0;
+}
+
+int checkboard(void)
+{
+??? printf("Board: i.MX31 MAX PDK

(3DS)\n");

It seems they are the same?

Quoted 1 line

+/* Disabled due to compilation errors in cmd_bootm.c

(IMLS seems to require

Quoted 8 lines
Quoted 2 lines

+ * that CFG_NO_FLASH is undefined).
+ */

Incorrect multiline comment style.

Quoted 1 line

+#define CONFIG_ENV_IS_NOWHERE??? 1

Why don't you put the environment in NAND?

With the current patchset only booting from NAND is supported. The NAND driver has not been added yet.

Regards,

Fabio Estevam

#1 lore raw

PATCH v3 5/6 MX31: Add basic support for Freescale i.MX31 PDK board.

Dear Fabio,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 2 lines

Fabio, do you agree?

Magnus told me off the list that he has no interest in becoming the board m= aintainer and asked me if I could be the maintainer for the MX31PDK.

We have been working on the MX31PDK U-boot port for quite some time.

I see.

Quoted 1 line

If you prefer to assign someone else, that's no problem for me.

No - please don't misunderstand me. I'm happy if you take responsibility for this board. I just wanted to make sure that you don't get assigned a task which you were not even aware of.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is is no reason for any individual to have a computer in  their
home.      -- Ken Olsen (President of Digital Equipment Corporation),
              Convention of the World Future Society, in Boston, 1977