Skip to contentSkip to conversation

ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12

PATCH New Sylwester Nawrocki 2 participants 2 messages Apr 11, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12

Exynos4212/4412 has different clock for the PL330 MDMA, ensure the clock is properly assigned for these newer SoCs.

---
 arch/arm/boot/dts/exynos4x12.dtsi |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/exynos4x12.dtsi +6 -0
index c4a9306..19589c6 100644
@@ -243,4 +243,10 @@
 		clock-names = "biu", "ciu";
 		status = "disabled";
 	};
+
+	amba {
+		mdma at 12850000 {
+			clocks = <&clock CLK_MDMA2>;
+		};
+	};
 };
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: Fix PL330 MDMA clock assignment for Exynos4x12

Hi Sylwester,

Quoted 15 lines · Sylwester Nawrocki

Exynos4212/4412 has different clock for the PL330 MDMA, ensure the clock is properly assigned for these newer SoCs.

---
  arch/arm/boot/dts/exynos4x12.dtsi |    6 ++++++
  1 file changed, 6 insertions(+)
arch/arm/boot/dts/exynos4x12.dtsi +0 -0
index c4a9306..19589c6 100644

arch/arm/boot/dts/exynos4x12.dtsi line 252

Quoted 10 lines
arch/arm/boot/dts/exynos4x12.dtsi +6 -0
@@ -243,4 +243,10 @@
  		clock-names = "biu", "ciu";
  		status = "disabled";
  	};
+
+	amba {
+		mdma at 12850000 {
+			clocks = <&clock CLK_MDMA2>;
+		};
+	};
  };

Since the ID for CLK_MDMA2 was added mistakenly, instead of reusing CLK_MDMA and it was not used by any device tree files anyway, I believe the better fix would be to simply change the clock definition in Exynos 4 clock driver to use CLK_MDMA for both SoC families.

Best regards,
Tomasz