Skip to contentSkip to conversation

ARM: dts: fixed gpio key node for exynos4412

PATCH Applied Beomho Seo 2 participants 2 messages May 2, 2014

Subsystems (2)

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore

Beomho Seo

author
#0 lore raw

PATCH v2 3/3 ARM: dts: fixed gpio key node for exynos4412

This patch fixed gpio key device node.
First, fix incorrect gpio property.
And then, add ok-key node where locate bottom center. I have tested on exynos4412-trats2 board.

---
Changes in v2:
- None.

---
 arch/arm/boot/dts/exynos4412-trats2.dts |   22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)
arch/arm/boot/dts/exynos4412-trats2.dts +16 -6
index d599215..41305e2 100644
@@ -87,18 +87,18 @@
 		compatible = "gpio-keys";
 
 		key-down {
-			interrupt-parent = <&gpj1>;
-			interrupts = <2 0>;
-			gpios = <&gpj1 2 1>;
+			interrupt-parent = <&gpx3>;
+			interrupts = <3 0>;
+			gpios = <&gpx3 3 1>;
 			linux,code = <114>;
 			label = "volume down";
 			debounce-interval = <10>;
 		};
 
 		key-up {
-			interrupt-parent = <&gpj1>;
-			interrupts = <1 0>;
-			gpios = <&gpj1 1 1>;
+			interrupt-parent = <&gpx2>;
+			interrupts = <2 0>;
+			gpios = <&gpx2 2 1>;
 			linux,code = <115>;
 			label = "volume up";
 			debounce-interval = <10>;
@@ -113,6 +113,16 @@
 			debounce-interval = <10>;
 			gpio-key,wakeup;
 		};
+
+		key-ok {
+			interrupt-parent = <&gpx0>;
+			interrupts = <1 0>;
+			gpios = <&gpx0 1 1>;
+			linux,code = <139>;
+			label = "ok";
+			debounce-inteval = <10>;
+			gpio-key,wakeup;
+		};
 	};
 
 	adc: adc@126C0000 {
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Beomho,

Quoted 4 lines · Beomho Seo

This patch fixed gpio key device node.
First, fix incorrect gpio property.
And then, add ok-key node where locate bottom center. I have tested on exynos4412-trats2 board.

While at it, could you also remove interrupt-parent and interrupts properties from nodes of the keys? They have been added here by a mistake and they are not part of the gpio-keys device tree bindings.

Best regards,
Tomasz