Skip to contentSkip to conversation

xfs: remove redundant stat assignment in xfs_bulkstat_one_int

PATCH In review Jeff Liu 1 participant 1 message Jun 3, 2014 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH v3 1/10 xfs: remove redundant stat assignment in xfs_bulkstat_one_int

From: Jie Liu <[email protected]>

Remove the redundant BULKSTAT_RV_NOTHING assignment in case of call xfs_iget() failed at xfs_bulkstat_one_int().

Reviewed-by Christoph Hellwig <[email protected]>
Signed-off-by Jie Liu <[email protected]>
---
 fs/xfs/xfs_itable.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
fs/xfs/xfs_itable.c +1 -4
index cb64f22..2e7b397 100644
@@ -76,10 +76,8 @@ xfs_bulkstat_one_int(
 	error = xfs_iget(mp, NULL, ino,
 			 (XFS_IGET_DONTCACHE | XFS_IGET_UNTRUSTED),
 			 XFS_ILOCK_SHARED, &ip);
-	if (error) {
-		*stat = BULKSTAT_RV_NOTHING;
+	if (error)
 		goto out_free;
-	}
 
 	ASSERT(ip != NULL);
 	ASSERT(ip->i_imap.im_blkno != 0);

@@ -136,7 +134,6 @@ xfs_bulkstat_one_int(
 	IRELE(ip);
 
 	error = formatter(buffer, ubsize, ubused, buf);
-
 	if (!error)
 		*stat = BULKSTAT_RV_DIDONE;
Signature · 6 lines
1.8.3.2

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs