xfs_ioc_bulkstat code refactoring and consolidation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest10 patches 5 repliesIn review
- v210 patches 16 repliesSuperseded
- v110 patches 17 repliesSuperseded
v3->v2 from the cover letter
- one major bug fix is at xfs_bulkstat_ag_ichunk() regarding the user buffer pointer operations, it should be defined as a pointer-to-pointer since it would be updated inside xfs_bulkstat_ag_ichunk().
- separate xfs_inumber consolidate patch into two patches, the first one fix the formater function return value and consolidate the codes, another one does the actual logic changes for better error handling.
- Add a separate patch to get rid of the redundant user buffer count checks at xfs_bulkstat()
- fixed agino calculation issue at xfs_bulkstat_grab_ichunk().
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | xfs: remove redundant stat assignment in xfs_bulkstat_one_intfs/ | +1 | 0 replies | |
| 2/10 | xfs: remove xfs_bulkstat_singlefs/ fs/ fs/ | +2 | 0 replies | |
| 3/10 | xfs: consolidate xfs_inumbersfs/ fs/ | +35 | 0 replies | |
| 4/10 | xfs: fix error handling at xfs_inumbersfs/ | +37 | 1 reply | |
| 5/10 | xfs: remove redundant user buffer count checks at xfs_bulkstatfs/ | +0 | 0 replies | |
| 6/10 | xfs: fix error handling at xfs_bulkstatfs/ | +6 | 0 replies | |
| 7/10 | xfs: introduce xfs_bulkstat_ichunk_rafs/ | +32 | 0 replies | |
| 8/10 | xfs: introduce xfs_bulkstat_grab_ichunkfs/ | +69 | 0 replies | |
| 9/10 | xfs: introduce xfs_bulkstat_ag_ichunkfs/ fs/ | +105 | 0 replies | |
| 10/10 | xfs: mark xfs_qm_quotacheck as staticfs/ fs/ | +94 | 0 replies |
Reviews trailers per patch
4 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Jie Liu |
|---|---|---|
| 1/10 | R-b | |
| 2/10 | R-b | |
| 3/10 | ||
| 4/10 | ||
| 5/10 | ||
| 6/10 | ||
| 7/10 | R-b | |
| 8/10 | ||
| 9/10 | ||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 00/10] xfs_ioc_bulkstat code refactoring and consolidation
Hi folk,
This is the revised patches for xfs_ioc_bulkstat consolidation and code refactoring. As per Christoph's comments, I'm not include the per AG inumber patch in this series given that I don't actually introduce the relevant inumbers interface now. Similar to that reason, I also dropped the per AG bulkstat patch, it would be included in parallel quota check series.
v3->v2:
- one major bug fix is at xfs_bulkstat_ag_ichunk() regarding the user buffer pointer operations, it should be defined as a pointer-to-pointer since it would be updated inside xfs_bulkstat_ag_ichunk().
- separate xfs_inumber consolidate patch into two patches, the first one fix the formater function return value and consolidate the codes, another one does the actual logic changes for better error handling.
- Add a separate patch to get rid of the redundant user buffer count checks at xfs_bulkstat()
- fixed agino calculation issue at xfs_bulkstat_grab_ichunk().
v2: http://oss.sgi.com/archives/xfs/2014-04/msg00554.html
v1: http://oss.sgi.com/archives/xfs/2013-12/msg00901.html
Any comments are welcome!
Cheers,
-Jeff
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs