Skip to contentSkip to conversation

xfs: consolidate xfs_inumbers

PATCH In review Jeff Liu 1 participant 1 message Jun 3, 2014 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH v3 3/10 xfs: consolidate xfs_inumbers

From: Jie Liu <[email protected]>

Consolidate xfs_inumbers() to make the formatter function return correct error and make the source code looks a bit neat.

Signed-off-by Jie Liu <[email protected]>
---
 fs/xfs/xfs_ioctl32.c |  4 +--
 fs/xfs/xfs_itable.c  | 71 ++++++++++++++++++++++++----------------------------
 2 files changed, 35 insertions(+), 40 deletions(-)
fs/xfs/xfs_ioctl32.c +2 -2
index 944d5ba..8080a2e 100644
@@ -102,7 +102,7 @@ xfs_compat_growfs_rt_copyin(
 STATIC int
 xfs_inumbers_fmt_compat(
 	void			__user *ubuffer,
-	const xfs_inogrp_t	*buffer,
+	const struct xfs_inogrp	*buffer,
 	long			count,
 	long			*written)
 {

@@ -113,7 +113,7 @@ xfs_inumbers_fmt_compat(
 		if (put_user(buffer[i].xi_startino,   &p32[i].xi_startino) ||
 		    put_user(buffer[i].xi_alloccount, &p32[i].xi_alloccount) ||
 		    put_user(buffer[i].xi_allocmask,  &p32[i].xi_allocmask))
-			return -XFS_ERROR(EFAULT);
+			return XFS_ERROR(EFAULT);
 	}
 	*written = count * sizeof(*p32);
 	return 0;
fs/xfs/xfs_itable.c +33 -38

122 lines not on this page · raw message

Signature · 6 lines
1.8.3.2

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs