Skip to contentSkip to conversation

Documentation, intel_pstate: Add a description of the intel_pstate internal governors

PATCH In review Prarit Bhargava 4 participants 6 messages Jun 5, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation, intel_pstate: Add a description of the intel_pstate internal governors

The current documentation is incomplete wrt the intel_pstate internal governors. The confusion comes from the general use internal governors which also use the names performance and powersave. This patch differentiates between the two sets of governors.

Cc Dirk Brandewie <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Russell King <[email protected]>
Cc Jesper Nilsson <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ramkumar Ramachandra <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
---
 Documentation/cpu-freq/governors.txt    |    2 +-
 Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/cpu-freq/governors.txt +1 -1
index 77ec215..c15aa75 100644
@@ -36,7 +36,7 @@ Contents:
 1. What Is A CPUFreq Governor?
 ==============================
 
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
 cpu frequency scaling algorithms only offer the CPU to be set to one
 frequency. In order to offer dynamic frequency scaling, the cpufreq
 core must be able to tell these drivers of a "target frequency". So
Documentation/cpu-freq/intel-pstate.txt +8 -0
index e742d21..ce894cc 100644
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
 logic for selecting the current P state is contained within the
 driver; no external governor is used by the cpufreq core.
 
+The Intel P-state driver has two internal governors, performance and
+powersave.  These governors differ from the general use governors of the
+same name in the kernel.  The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core.  The
+internal powersave governor, selects the appropriate P state based on the
+current load on the CPU.
+
 Intel SandyBridge+ processors are supported.
 
 New sysfs files for controlling P state selection have been added to
Signature · 1 line
1.7.9.3
maintainer
#1 lore raw
Quoted 39 lines · Prarit Bhargava

The current documentation is incomplete wrt the intel_pstate internal governors. The confusion comes from the general use internal governors which also use the names performance and powersave. This patch differentiates between the two sets of governors.

Cc Dirk Brandewie <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Russell King <[email protected]>
Cc Jesper Nilsson <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ramkumar Ramachandra <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
---
 Documentation/cpu-freq/governors.txt    |    2 +-
 Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/cpu-freq/governors.txt +1 -1
index 77ec215..c15aa75 100644
@@ -36,7 +36,7 @@ Contents:
 1. What Is A CPUFreq Governor?
 ==============================
 
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
 cpu frequency scaling algorithms only offer the CPU to be set to one
 frequency. In order to offer dynamic frequency scaling, the cpufreq
 core must be able to tell these drivers of a "target frequency". So
Documentation/cpu-freq/intel-pstate.txt +0 -0
index e742d21..ce894cc 100644

Documentation/cpu-freq/intel-pstate.txt assumed to implement internal governors by the cpufreq core. All the · line 13

Quoted 5 lines
Documentation/cpu-freq/intel-pstate.txt +2 -0
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
 logic for selecting the current P state is contained within the
 driver; no external governor is used by the cpufreq core.
 
+The Intel P-state driver has two internal governors, performance and
+powersave.  These governors differ from the general use governors of the

s/general use/generally used ??

Quoted 12 lines
Documentation/cpu-freq/intel-pstate.txt +6 -1
+same name in the kernel.  The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core.  The
+internal powersave governor, selects the appropriate P state based on the
+current load on the CPU.
+
 Intel SandyBridge+ processors are supported.
 
 New sysfs files for controlling P state selection have been added to
--

1.7.9.3

#2 lore raw

PATCH 1/1 Documentation, intel_pstate: Add a description of the intel_pstate internal governors [v2]

The current documentation is incomplete wrt the intel_pstate internal governors. The confusion comes from the general use internal governors which also use the names performance and powersave. This patch differentiates between the two sets of governors.

Cc Viresh Kumar <[email protected]>
Cc Dirk Brandewie <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Russell King <[email protected]>
Cc Jesper Nilsson <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ramkumar Ramachandra <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

[v2]: text update

---
 Documentation/cpu-freq/governors.txt    |    2 +-
 Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/cpu-freq/governors.txt +1 -1
index 77ec215..c15aa75 100644
@@ -36,7 +36,7 @@ Contents:
 1. What Is A CPUFreq Governor?
 ==============================
 
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
 cpu frequency scaling algorithms only offer the CPU to be set to one
 frequency. In order to offer dynamic frequency scaling, the cpufreq
 core must be able to tell these drivers of a "target frequency". So
Documentation/cpu-freq/intel-pstate.txt +8 -0
index e742d21..2edd8d9 100644
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
 logic for selecting the current P state is contained within the
 driver; no external governor is used by the cpufreq core.
 
+The Intel P-state driver has two internal governors, performance and
+powersave.  These governors differ from the generally used governors of the
+same name in the kernel.  The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core.  The
+internal powersave governor, selects the appropriate P state based on the
+current load on the CPU.
+
 Intel SandyBridge+ processors are supported.
 
 New sysfs files for controlling P state selection have been added to
Signature · 1 line
1.7.9.3
Acked-by on v1 1/1
#3 lore raw

Re: [PATCH] Documentation, intel_pstate: Add a description of the intel_pstate internal governors [v2]

Quoted 5 lines · Prarit Bhargava

The current documentation is incomplete wrt the intel_pstate internal governors. The confusion comes from the general use internal governors which also use the names performance and powersave. This patch differentiates between the two sets of governors.

Quoted 12 lines
Cc Viresh Kumar <[email protected]>
Cc Dirk Brandewie <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Russell King <[email protected]>
Cc Jesper Nilsson <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ramkumar Ramachandra <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Quoted 39 lines

[v2]: text update

---
  Documentation/cpu-freq/governors.txt    |    2 +-
  Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
  2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/cpu-freq/governors.txt +1 -1
index 77ec215..c15aa75 100644
@@ -36,7 +36,7 @@ Contents:
  1. What Is A CPUFreq Governor?
  ==============================
 
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
  cpu frequency scaling algorithms only offer the CPU to be set to one
  frequency. In order to offer dynamic frequency scaling, the cpufreq
  core must be able to tell these drivers of a "target frequency". So
Documentation/cpu-freq/intel-pstate.txt +8 -0
index e742d21..2edd8d9 100644
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
  logic for selecting the current P state is contained within the
  driver; no external governor is used by the cpufreq core.
 
+The Intel P-state driver has two internal governors, performance and
+powersave.  These governors differ from the generally used governors of the
+same name in the kernel.  The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core.  The
+internal powersave governor, selects the appropriate P state based on the
+current load on the CPU.
+
  Intel SandyBridge+ processors are supported.
 
  New sysfs files for controlling P state selection have been added to
reviewer
#4 lore raw

Re: [PATCH] Documentation, intel_pstate: Add a description of the intel_pstate internal governors [v2]

In reply to Prarit Bhargava
Quoted 41 lines · Prarit Bhargava

The current documentation is incomplete wrt the intel_pstate internal governors. The confusion comes from the general use internal governors which also use the names performance and powersave. This patch differentiates between the two sets of governors.

Cc Viresh Kumar <[email protected]>
Cc Dirk Brandewie <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Russell King <[email protected]>
Cc Jesper Nilsson <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ramkumar Ramachandra <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

[v2]: text update

---
 Documentation/cpu-freq/governors.txt    |    2 +-
 Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/cpu-freq/governors.txt +1 -1
index 77ec215..c15aa75 100644
@@ -36,7 +36,7 @@ Contents:
 1. What Is A CPUFreq Governor?
 ==============================
 
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
 cpu frequency scaling algorithms only offer the CPU to be set to one
 frequency. In order to offer dynamic frequency scaling, the cpufreq
 core must be able to tell these drivers of a "target frequency". So
Documentation/cpu-freq/intel-pstate.txt +0 -0
index e742d21..2edd8d9 100644

Documentation/cpu-freq/intel-pstate.txt assumed to implement internal governors by the cpufreq core. All the · line 17

Quoted 9 lines
Documentation/cpu-freq/intel-pstate.txt +6 -0
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
 logic for selecting the current P state is contained within the
 driver; no external governor is used by the cpufreq core.
 
+The Intel P-state driver has two internal governors, performance and
+powersave.  These governors differ from the generally used governors of the
+same name in the kernel.  The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core.  The
+internal powersave governor, selects the appropriate P state based on the

no comma here ---------------^

Quoted 6 lines
Documentation/cpu-freq/intel-pstate.txt +2 -0
+current load on the CPU.
+
 Intel SandyBridge+ processors are supported.
 
 New sysfs files for controlling P state selection have been added to
Signature · 1 line
~Randy
#5 lore raw

PATCH 1/1 Documentation, intel_pstate: Add a description of the intel_pstate internal governors [v3]

The current documentation is incomplete wrt the intel_pstate internal governors. The confusion comes from the general use internal governors which also use the names performance and powersave. This patch differentiates between the two sets of governors.

Cc Viresh Kumar <[email protected]>
Cc Dirk Brandewie <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Russell King <[email protected]>
Cc Jesper Nilsson <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ramkumar Ramachandra <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

[v2]: text update
[v3]: text update

---
 Documentation/cpu-freq/governors.txt    |    2 +-
 Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/cpu-freq/governors.txt +1 -1
index 77ec215..c15aa75 100644
@@ -36,7 +36,7 @@ Contents:
 1. What Is A CPUFreq Governor?
 ==============================
 
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
 cpu frequency scaling algorithms only offer the CPU to be set to one
 frequency. In order to offer dynamic frequency scaling, the cpufreq
 core must be able to tell these drivers of a "target frequency". So
Documentation/cpu-freq/intel-pstate.txt +8 -0
index e742d21..7e9db8f 100644
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
 logic for selecting the current P state is contained within the
 driver; no external governor is used by the cpufreq core.
 
+The Intel P-state driver has two internal governors, performance and
+powersave.  These governors differ from the generally used governors of the
+same name in the kernel.  The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core.  The
+internal powersave governor selects the appropriate P state based on the
+current load on the CPU.
+
 Intel SandyBridge+ processors are supported.
 
 New sysfs files for controlling P state selection have been added to
Signature · 1 line
1.7.9.3