Skip to contentSkip to conversation

bcache-tools: Adding package.

PATCH Superseded Jean-Christophe DUBOIS 2 participants 5 messages Aug 5, 2014

v3 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 bcache-tools: Adding package.

This is the bcache tools, required to setup the linux bcache feature of the Linux kernel.

---
Changes v1 to v2
* remove 'support' word from comment statement in Config.in.
* use github helper to get the project site instead of hardcoded URL.
Changes v2 to v3
* Added bcache-tools description in Config help
* Added bcache-tools URL in Config help
* Added BR2_LARGEFILE BR2_USE_WCHAR and BR2_USE_MMU dependencies in Config.
* Added BR2_PACKAGE_UTIL_LINUX selection in Config
* Added new requirements in Config comment.
* use POST_EXTRACT_HOOKS to modify Makefile
* pass $(TARGET_CONFIGURE_OPTS) in env variables to $(MAKE)
* create man8 dir as part of PRE_INSTALL_TARGET_HOOKS

---
 package/Config.in                    |  1 +
 package/bcache-tools/Config.in       | 22 ++++++++++++++++++
 package/bcache-tools/bcache-tools.mk | 44 ++++++++++++++++++++++++++++++++++++
 3 files changed, 67 insertions(+)
 create mode 100644 package/bcache-tools/Config.in
 create mode 100644 package/bcache-tools/bcache-tools.mk
package/Config.in +1 -0
index 4520ba6..dc2f418 100644
@@ -280,6 +280,7 @@ endmenu
 	source "package/a10disp/Config.in"
 	source "package/acpid/Config.in"
 	source "package/avrdude/Config.in"
+	source "package/bcache-tools/Config.in"
 	source "package/cdrkit/Config.in"
 	source "package/cryptsetup/Config.in"
 	source "package/cwiid/Config.in"
package/bcache-tools/Config.in new file +22 -0
new file mode 100644
index 0000000..383ba1f
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_BCACHE_TOOLS
+	bool "bcache tools"
+	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_LARGEFILE # util-linux
+	depends on BR2_USE_WCHAR # util-linux
+	depends on BR2_USE_MMU # util-linux (libblkid)
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
+	help
+	  Bcache is a Linux kernel block layer cache. It allows one or
+	  more fast disk drives such as flash-based solid state drives (SSDs)
+	  to act as a cache for one or more slower hard disk drives.
+
+	  http://bcache.evilpiepirate.org/
+
+	  This is the user space bcache tools, required to setup the linux
+	  bcache feature of the Linux kernel.
+
+comment "bcache-tools needs udev /dev management and a toolchain w/ largefile, wchar"
+	depends on BR2_USE_MMU
+        depends on !BR2_PACKAGE_HAS_UDEV || !BR2_LARGEFILE || !BR2_USE_WCHAR
package/bcache-tools/bcache-tools.mk new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw

PATCH v3 1/1 bcache-tools: Adding package.

Hi Jean-Christophe,

Quoted 71 lines

This is the bcache tools, required to setup the linux bcache feature of the Linux kernel.

---
Changes v1 to v2
* remove 'support' word from comment statement in Config.in.
* use github helper to get the project site instead of hardcoded URL.
Changes v2 to v3
* Added bcache-tools description in Config help
* Added bcache-tools URL in Config help
* Added BR2_LARGEFILE BR2_USE_WCHAR and BR2_USE_MMU dependencies in Config.
* Added BR2_PACKAGE_UTIL_LINUX selection in Config
* Added new requirements in Config comment.
* use POST_EXTRACT_HOOKS to modify Makefile
* pass $(TARGET_CONFIGURE_OPTS) in env variables to $(MAKE)
* create man8 dir as part of PRE_INSTALL_TARGET_HOOKS

---
  package/Config.in                    |  1 +
  package/bcache-tools/Config.in       | 22 ++++++++++++++++++
  package/bcache-tools/bcache-tools.mk | 44 ++++++++++++++++++++++++++++++++++++
  3 files changed, 67 insertions(+)

create mode 100644 package/bcache-tools/Config.in create mode 100644 package/bcache-tools/bcache-tools.mk

package/Config.in +1 -0
index 4520ba6..dc2f418 100644
@@ -280,6 +280,7 @@ endmenu
  	source "package/a10disp/Config.in"
  	source "package/acpid/Config.in"
  	source "package/avrdude/Config.in"
+	source "package/bcache-tools/Config.in"
  	source "package/cdrkit/Config.in"
  	source "package/cryptsetup/Config.in"
  	source "package/cwiid/Config.in"
package/bcache-tools/Config.in new file +22 -0
new file mode 100644
index 0000000..383ba1f
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_BCACHE_TOOLS
+	bool "bcache tools"
+	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_LARGEFILE # util-linux
+	depends on BR2_USE_WCHAR # util-linux
+	depends on BR2_USE_MMU # util-linux (libblkid)
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
+	help
+	  Bcache is a Linux kernel block layer cache. It allows one or
+	  more fast disk drives such as flash-based solid state drives (SSDs)
+	  to act as a cache for one or more slower hard disk drives.
+
+	  http://bcache.evilpiepirate.org/
+
+	  This is the user space bcache tools, required to setup the linux
+	  bcache feature of the Linux kernel.
+
+comment "bcache-tools needs udev /dev management and a toolchain w/ largefile, wchar"
+	depends on BR2_USE_MMU
+        depends on !BR2_PACKAGE_HAS_UDEV || !BR2_LARGEFILE || !BR2_USE_WCHAR
package/bcache-tools/bcache-tools.mk new file +0 -0
new file mode 100644
index 0000000..36f0b22

package/bcache-tools/bcache-tools.mk line 9

Quoted 9 lines
package/bcache-tools/bcache-tools.mk new file +9 -0
@@ -0,0 +1,44 @@
+################################################################################
+#
+# bcache-tools
+#
+################################################################################
+
+BCACHE_TOOLS_VERSION = 1.0.7
+BCACHE_TOOLS_SITE = $(call github,g2p,bcache-tools,v$(BCACHE_TOOLS_VERSION))
+BCACHE_TOOLS_SOURCE = v$(BCACHE_TOOLS_VERSION).zip

This should be:

BCACHE_TOOLS_VERSION = v1.0.7
BCACHE_TOOLS_SITE = $(call github,g2p,bcache-tools,$(BCACHE_TOOLS_VERSION))

Regards,
Jerzy

Quoted 35 lines
package/bcache-tools/bcache-tools.mk new file +35 -0
+BCACHE_TOOLS_LICENSE = GPLv2
+BCACHE_TOOLS_LICENSE_FILES = COPYING
+BCACHE_TOOLS_DEPENDENCIES = host-pkgconf util-linux eudev
+
+define BCACHE_TOOLS_EXTRACT_CMDS
+	unzip -d $(BUILD_DIR) $(DL_DIR)/$(BCACHE_TOOLS_SOURCE)
+endef
+
+# We need to use the BR2 host pkg-config binary in the Makefile
+define BCACHE_TOOLS_FIX_PKGCONFIG
+	$(SED) 's^`pkg-config^`$(PKG_CONFIG_HOST_BINARY)^' \
+		$(BCACHE_TOOLS_DIR)/Makefile
+endef
+
+BCACHE_TOOLS_POST_EXTRACT_HOOKS += BCACHE_TOOLS_FIX_PKGCONFIG
+
+# We pass $(TARGET_CONFIGURE_OPTS) as environment variable to allow
+# the bcache-tools Makefile to alter CFLAGS
+define BCACHE_TOOLS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+# The bcache-tools Makefile expects the man8 directory to exist.
+define BCACHE_TOOLS_INSTALL_MAN8
+	$(INSTALL) -m 0755 -d $(TARGET_DIR)/usr/share/man/man8
+endef
+
+BCACHE_TOOLS_PRE_INSTALL_TARGET_HOOKS += BCACHE_TOOLS_INSTALL_MAN8
+
+define BCACHE_TOOLS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
#2 lore raw

PATCH v3 1/1 bcache-tools: Adding package.

Le 08/05/2014 09:33 AM, Jerzy Grzegorek a ?crit :

Quoted 23 lines

Hi Jean-Christophe,

Quoted 15 lines

index 0000000..36f0b22

package/bcache-tools/bcache-tools.mk new file +8 -0
@@ -0,0 +1,44 @@
+################################################################################ 
 
+#
+# bcache-tools
+#
+################################################################################ 
 
+
+BCACHE_TOOLS_VERSION = 1.0.7
+BCACHE_TOOLS_SITE = $(call 
Quoted 2 lines

github,g2p,bcache-tools,v$(BCACHE_TOOLS_VERSION)) +BCACHE_TOOLS_SOURCE = v$(BCACHE_TOOLS_VERSION).zip

This should be:

Quoted 6 lines

BCACHE_TOOLS_VERSION = v1.0.7
BCACHE_TOOLS_SITE = $(call
github,g2p,bcache-tools,$(BCACHE_TOOLS_VERSION))

Regards,
Jerzy

I tried this before but this is not working because when unzipped the bcache-tools directory is named bcache-tools-1.0.7 and not bcache-tools-v1.0.7.

JC

#3 lore raw

PATCH v3 1/1 bcache-tools: Adding package.

Hi Jean-Christophe,

Quoted 28 lines

Le 08/05/2014 09:33 AM, Jerzy Grzegorek a ?crit :

Quoted 27 lines

Hi Jean-Christophe,

Quoted 15 lines

index 0000000..36f0b22

package/bcache-tools/bcache-tools.mk new file +8 -0
@@ -0,0 +1,44 @@
+################################################################################ 
 
+#
+# bcache-tools
+#
+################################################################################ 
 
+
+BCACHE_TOOLS_VERSION = 1.0.7
+BCACHE_TOOLS_SITE = $(call 
Quoted 2 lines

github,g2p,bcache-tools,v$(BCACHE_TOOLS_VERSION)) +BCACHE_TOOLS_SOURCE = v$(BCACHE_TOOLS_VERSION).zip

This should be:

BCACHE_TOOLS_VERSION = v1.0.7
BCACHE_TOOLS_SITE = $(call
github,g2p,bcache-tools,$(BCACHE_TOOLS_VERSION))

Quoted 8 lines
Quoted 2 lines

Regards,
Jerzy

I tried this before but this is not working because when unzipped the bcache-tools directory is named bcache-tools-1.0.7 and not bcache-tools-v1.0.7.

JC

Did you remove:
define BCACHE_TOOLS_EXTRACT_CMDS

     unzip -d $(BUILD_DIR) $(DL_DIR)/$(BCACHE_TOOLS_SOURCE)

endef
?

Regards,
Jerzy

Quoted 3 lines
#4 lore raw

PATCH v3 1/1 bcache-tools: Adding package.

Le 08/05/2014 03:14 PM, Jerzy Grzegorek a ?crit :

Quoted 38 lines

Hi Jean-Christophe,

Quoted 35 lines

Le 08/05/2014 09:33 AM, Jerzy Grzegorek a ?crit :

Quoted 23 lines

Hi Jean-Christophe,

Quoted 15 lines

index 0000000..36f0b22

package/bcache-tools/bcache-tools.mk new file +8 -0
@@ -0,0 +1,44 @@
+################################################################################ 
 
+#
+# bcache-tools
+#
+################################################################################ 
 
+
+BCACHE_TOOLS_VERSION = 1.0.7
+BCACHE_TOOLS_SITE = $(call 
Quoted 2 lines

github,g2p,bcache-tools,v$(BCACHE_TOOLS_VERSION)) +BCACHE_TOOLS_SOURCE = v$(BCACHE_TOOLS_VERSION).zip

This should be:

Quoted 6 lines

BCACHE_TOOLS_VERSION = v1.0.7
BCACHE_TOOLS_SITE = $(call
github,g2p,bcache-tools,$(BCACHE_TOOLS_VERSION))

Regards,
Jerzy

I tried this before but this is not working because when unzipped the bcache-tools directory is named bcache-tools-1.0.7 and not bcache-tools-v1.0.7.

Quoted 7 lines
Quoted 1 line

JC

Did you remove:
define BCACHE_TOOLS_EXTRACT_CMDS

    unzip -d $(BUILD_DIR) $(DL_DIR)/$(BCACHE_TOOLS_SOURCE)

endef
?

This does not solve the problem directly because then buildroot assumes the downloaded file is a tar.gz file while it is a zip file (so the tar command does not work).

However, switching the dowloaded file type to tar.gz in the .mk file does the trick (obviously github supports both even if only the zip file is advertized) and we can then use the v1.0.7 (the complete git tag) as BCACHE_TOOLS_VERSION.

Another version on its way.

Thanks

JC

Quoted 9 lines

Regards,
Jerzy

Quoted 3 lines