Skip to contentSkip to conversation

patch for coccinelle's Makefile

Cocci Francois BERENGER 3 participants 10 messages Aug 28, 2014 – Aug 29, 2014

lore
Share & tools
lore
#1 lore raw
Quoted 1 line · Francois BERENGER

I think the uninstall target can be made much simpler and robust.

Could you explain? I am not at all familiar with the code.

thanks,
julia

#2 lore raw
Quoted 5 lines · Julia Lawall
Quoted 1 line · Francois BERENGER

I think the uninstall target can be made much simpler and robust.

Could you explain? I am not at all familiar with the code.

Rather than removing things one by one in [...]/share/coccinelle/* you can remove directly [...]/share/coccinelle .

This is more robust since some of the things in [...]/share/coccinelle/* are not installed by all make targets but were nonetheless listed by the uninstall target (which would fail with an exit 1, which is a problem when you package things for opam).

Signature · 2 lines
Regards,
Francois.
#3 lore raw
Quoted 7 lines · Francois BERENGER
Quoted 5 lines · Julia Lawall
Quoted 1 line · Francois BERENGER

I think the uninstall target can be made much simpler and robust.

Could you explain? I am not at all familiar with the code.

Quoted 7 lines

Rather than removing things one by one in [...]/share/coccinelle/* you can remove directly [...]/share/coccinelle .

This is more robust since some of the things in [...]/share/coccinelle/* are not installed by all make targets but were nonetheless listed by the uninstall target (which would fail with an exit 1, which is a problem when you package things for opam).

OK, what worries me is that what you suggest seems rather obvious, but I don't know why it was not originally done that way. I will try to find out.

julia

#6 lore raw

[Cocci] Improvements for the build specification?

Quoted 1 line

Probably. I don't know m4 though.

I know this macro programming language to some degree.

Unfortunately, further improvements on the affected build specification are blocked by Julia so far. How do you find the chances to change such a situation?

Regards,
Markus

#7 lore raw

[Cocci] Improvements for the build specification?

Quoted 6 lines · SF Markus Elfring
Quoted 1 line

Probably. I don't know m4 though.

I know this macro programming language to some degree.

Unfortunately, further improvements on the affected build specification are blocked by Julia so far. How do you find the chances to change such a situation?

I was just reporting upstream some patch I had to introduce in order to package coccinelle for OPAM so that 'make uninstall' always return success.

I was also kind of probing the activity of the ML and liveliness of the coccinelle community, which I always do when starting to use a new open source tool. ;)

Coccinelle looks great, I am amazed.

PS: http://opam.ocaml.org/

Signature · 2 lines
Regards,
Francois.
#8 lore raw

[Cocci] Improvements for the build specification?

Quoted 2 lines

I was just reporting upstream some patch I had to introduce in order to package coccinelle for OPAM so that 'make uninstall' always return success.

Would you dare to extend your knowledge about the software "Autotools" and "automake" besides package management for OCaml?
How do you think about to find any more developers who try to fiddle with M4 programming?

Regards,
Markus

#9 lore raw
In reply to Francois BERENGER
Quoted 1 line

I think the uninstall target can be made much simpler and robust.

How do think about to combine also the affected file deletion commands into fewer calls with longer parameter lists if your prefer still to adjust a Make file directly?
(I imagine that improvements for other build scripts would be more useful, wouldn't it?)

Regards,
Markus