patch for coccinelle's Makefile
I think the uninstall target can be made much simpler and robust.
Regards,
Francois.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opam.patch
Type: text/x-patch
Size: 1547 bytes
Desc: not available
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20140828/0857a8a0/attachment.bin>
Quoted 1 line · Francois BERENGER
I think the uninstall target can be made much simpler and robust.
Could you explain? I am not at all familiar with the code.
thanks,
julia
Quoted 5 lines · Julia Lawall
Quoted 1 line · Francois BERENGER
I think the uninstall target can be made much simpler and robust.
Could you explain? I am not at all familiar with the code.
Rather than removing things one by one in [...]/share/coccinelle/* you can remove directly [...]/share/coccinelle .
This is more robust since some of the things in [...]/share/coccinelle/* are not installed by all make targets but were nonetheless listed by the uninstall target (which would fail with an exit 1, which is a problem when you package things for opam).
Signature · 2 lines
Regards, Francois.
Quoted 7 lines · Francois BERENGER
Quoted 5 lines · Julia Lawall
Quoted 1 line · Francois BERENGER
I think the uninstall target can be made much simpler and robust.
Could you explain? I am not at all familiar with the code.
Quoted 7 lines
Rather than removing things one by one in [...]/share/coccinelle/* you can remove directly [...]/share/coccinelle .
This is more robust since some of the things in [...]/share/coccinelle/* are not installed by all make targets but were nonetheless listed by the uninstall target (which would fail with an exit 1, which is a problem when you package things for opam).
OK, what worries me is that what you suggest seems rather obvious, but I don't know why it was not originally done that way. I will try to find out.
julia
[Cocci] patch for c's Makefile
In reply to Francois BERENGERQuoted 1 line
I think the uninstall target can be made much simpler and robust.
Should the build specification be corrected instead of an "old" generated Make file?
https://github.com/coccinelle/coccinelle/blob/282fdcd007ab47a0684a2b7add0f88181d4f32da/configure.ac#L1
Regards,
Markus
[Cocci] patch for c's Makefile
Quoted 4 lines · SF Markus Elfring
Quoted 1 line
I think the uninstall target can be made much simpler and robust.
Should the build specification be corrected instead of an "old" generated Make file?
https://github.com/coccinelle/coccinelle/blob/282fdcd007ab47a0684a2b7add0f88181d4f32da/configure.ac#L1
Probably. I don't know m4 though.
Signature · 2 lines
Regards, Francois.
[Cocci] Improvements for the build specification?
Quoted 1 line
Probably. I don't know m4 though.
I know this macro programming language to some degree.
Unfortunately, further improvements on the affected build specification are blocked by Julia so far. How do you find the chances to change such a situation?
Regards,
Markus
[Cocci] Improvements for the build specification?
Quoted 6 lines · SF Markus Elfring
Quoted 1 line
Probably. I don't know m4 though.
I know this macro programming language to some degree.
Unfortunately, further improvements on the affected build specification are blocked by Julia so far. How do you find the chances to change such a situation?
I was just reporting upstream some patch I had to introduce in order to package coccinelle for OPAM so that 'make uninstall' always return success.
I was also kind of probing the activity of the ML and liveliness of the coccinelle community, which I always do when starting to use a new open source tool. ;)
Coccinelle looks great, I am amazed.
Signature · 2 lines
Regards, Francois.
[Cocci] Improvements for the build specification?
Quoted 2 lines
I was just reporting upstream some patch I had to introduce in order to package coccinelle for OPAM so that 'make uninstall' always return success.
Would you dare to extend your knowledge about the software "Autotools" and "automake" besides package management for OCaml?
How do you think about to find any more developers who try to fiddle with M4 programming?
Regards,
Markus
Quoted 1 line
I think the uninstall target can be made much simpler and robust.
How do think about to combine also the affected file deletion commands into fewer calls with longer parameter lists if your prefer still to adjust a Make file directly?
(I imagine that improvements for other build scripts would be more useful, wouldn't it?)
Regards,
Markus