Skip to contentSkip to conversation

sched: fix confusing PFA_NO_NEW_PRIVS constant

PATCH Superseded Zefan Li 2 participants 2 messages Sep 22, 2014

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Zefan Li

author
#0 lore raw

PATCH v2 1/3 sched: fix confusing PFA_NO_NEW_PRIVS constant

Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags") defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing because it is used as bit number. Redefine it as decimal bit number.

Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.

[ lizf: slightly modified subject and changelog ]

---

The other two patches don't need to be updated, so no need to resend them.

---
 include/linux/sched.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sched.h +1 -1
index 5c2c885..4557765 100644
@@ -1957,7 +1957,7 @@ static inline void memalloc_noio_restore(unsigned int flags)
 }
 
 /* Per-process atomic flags. */
-#define PFA_NO_NEW_PRIVS 0x00000001	/* May not gain new privileges. */
+#define PFA_NO_NEW_PRIVS 0	/* May not gain new privileges. */
 
 static inline bool task_no_new_privs(struct task_struct *p)
 {
Signature · 1 line
1.8.0.2
maintainer
#1 lore raw
Quoted 10 lines · Zefan Li

Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags") defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing because it is used as bit number. Redefine it as decimal bit number.

Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.

[ lizf: slightly modified subject and changelog ]

All the patches look good to me. I can't say I'm a big fan of function defining macros but I don't have prettier alternatives either. Once Peter/Ingo acks the patches, I'll route them through cgroup/for-3.17-fixes.

Thanks.

Signature · 1 line
tejun