sched: fix confusing PFA_NO_NEW_PRIVS constant
PATCH v2 1/3 sched: fix confusing PFA_NO_NEW_PRIVS constant
Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags") defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing because it is used as bit number. Redefine it as decimal bit number.
Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.
---
The other two patches don't need to be updated, so no need to resend them.
--- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/sched.h +1 -1
@@ -1957,7 +1957,7 @@ static inline void memalloc_noio_restore(unsigned int flags) }/* Per-process atomic flags. */ -#define PFA_NO_NEW_PRIVS 0x00000001/* May not gain new privileges. */ +#define PFA_NO_NEW_PRIVS 0/* May not gain new privileges. */ static inline bool task_no_new_privs (struct task_struct *p) {
Signature · 1 line
1.8.0.2
Tejun Heo
maintainerQuoted 10 lines · Zefan Li
Commit
1d4457f99928("sched: moveno_new_privsinto new atomic flags") definedPFA_NO_NEW_PRIVSas hexadecimal value, but it is confusing because it is used as bit number. Redefine it as decimal bit number.Note this changes the bit position of
PFA_NOW_NEW_PRIVSfrom 1 to 0.Signed-off-by Tetsuo Handa <penguin-kernel-JPay3/[email protected]>Acked-by Kees Cook <[email protected]>[ lizf: slightly modified subject and changelog ]Signed-off-by Zefan Li <[email protected]>
All the patches look good to me. I can't say I'm a big fan of function defining macros but I don't have prettier alternatives either. Once Peter/Ingo acks the patches, I'll route them through cgroup/for-3.17-fixes.
Thanks.
Signature · 1 line
tejun