bandwidthd: Version bump to handle indirect deps properly
PATCH 1/1 bandwidthd: Version bump to handle indirect deps properly
Thanks to Romain Naor, Baruch Siach and Thomas Petazzoni, I've solved the build issues in certain cases for bandwidthd.
The issue was that libpcap and libpng would depend on other libraries and upon testing for pcap/libpng the tests would fail due to not being able to find the other libraries.
Bandwidthd's configure script now uses pkg-config for libpng and pcap-config for libpcap. pcap-config's path is specified in configure's arguments.
Some other tweaks have been made including the layout and flow of configure.ac is a bit more logical, and the handling of postgres and sqlite has been tweaked. Finally, the test for X.Org has been removed.
--- package/bandwidthd/bandwidthd.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
package/bandwidthd/bandwidthd.mk +3 -3
@@ -4,18 +4,18 @@ # ################################################################################ -BANDWIDTHD_VERSION = v2.0.1-auto-r08 +BANDWIDTHD_VERSION = v2.0.1-auto-r11 BANDWIDTHD_SITE = $(call github,nroach44,bandwidthd,$(BANDWIDTHD_VERSION)) # Specified as "any version of the GPL that is current as of your # download" by upstream. BANDWIDTHD_LICENSE = GPL -BANDWIDTHD_DEPENDENCIES = gd libpng libpcap +BANDWIDTHD_DEPENDENCIES = gd libpng libpcap host-pkgconf BANDWIDTHD_AUTORECONF = YES -BANDWIDTHD_CONF_OPTS += --without-x +BANDWIDTHD_CONF_OPTS += --with-pcap-config=$(STAGING_DIR)/usr/bin/pcap-config ifeq ($(BR2_PACKAGE_BANDWIDTHD_POSTGRESQL),y) BANDWIDTHD_DEPENDENCIES += postgresql
Signature · 1 line
2.1.1
PATCH 1/1 bandwidthd: Version bump to handle indirect deps properly
Nathaniel, All,
On 2014-10-19 16:55 +0800, Nathaniel Roach spake thusly:
Quoted 1 line
Thanks to Romain Naor, Baruch Siach and Thomas Petazzoni, I've
Romain Naour, I believe... ;-)
Quoted 10 lines
solved the build issues in certain cases for bandwidthd.
The issue was that libpcap and libpng would depend on other libraries and upon testing for pcap/libpng the tests would fail due to not being able to find the other libraries.
Bandwidthd's configure script now uses pkg-config for libpng and pcap-config for libpcap. pcap-config's path is specified in configure's arguments.
Quoted 7 lines
Some other tweaks have been made including the layout and flow of configure.ac is a bit more logical, and the handling of postgres and sqlite has been tweaked. Finally, the test for X.Org has been removed.
Usually, when some people helped with the patch, it is customary (but not mandatory) to add them in Cc: lines below the SoB line. ;-)
Regards,
Yann E. MORIN.
Quoted 37 lines
--- package/bandwidthd/bandwidthd.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)package/bandwidthd/bandwidthd.mk +3
-3@@ -4,18 +4,18 @@ # ################################################################################ -BANDWIDTHD_VERSION = v2.0.1-auto-r08 +BANDWIDTHD_VERSION = v2.0.1-auto-r11 BANDWIDTHD_SITE = $(call github,nroach44,bandwidthd,$(BANDWIDTHD_VERSION)) # Specified as "any version of the GPL that is current as of your # download" by upstream. BANDWIDTHD_LICENSE = GPL -BANDWIDTHD_DEPENDENCIES = gd libpng libpcap +BANDWIDTHD_DEPENDENCIES = gd libpng libpcap host-pkgconf BANDWIDTHD_AUTORECONF = YES -BANDWIDTHD_CONF_OPTS += --without-x +BANDWIDTHD_CONF_OPTS += --with-pcap-config=$(STAGING_DIR)/usr/bin/pcap-config ifeq ($(BR2_PACKAGE_BANDWIDTHD_POSTGRESQL),y) BANDWIDTHD_DEPENDENCIES += postgresqlSignature · 6 lines
2.1.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 bandwidthd: Version bump to handle indirect deps properly
Quoted 6 lines · Yann E. MORIN
Nathaniel, All,
On 2014-10-19 16:55 +0800, Nathaniel Roach spake thusly:
Quoted 1 line
Thanks to Romain Naor, Baruch Siach and Thomas Petazzoni, I've
Romain Naour, I believe... ;-)
Damn it...
Quoted 19 lines
Quoted 11 lines
solved the build issues in certain cases for bandwidthd.
The issue was that libpcap and libpng would depend on other libraries and upon testing for pcap/libpng the tests would fail due to not being able to find the other libraries.
Bandwidthd's configure script now uses pkg-config for libpng and pcap-config for libpcap. pcap-config's path is specified in configure's arguments.
Quoted 7 lines
Some other tweaks have been made including the layout and flow of configure.ac is a bit more logical, and the handling of postgres and sqlite has been tweaked. Finally, the test for X.Org has been removed.
Quoted 8 lines
Usually, when some people helped with the patch, it is customary (but not mandatory) to add them in Cc: lines below the SoB line. ;-)
Reviewed-by "Yann E. MORIN" <[email protected]>Regards,
Yann E. MORIN.
I'll send a fixed one through shortly.
PATCH 1/1 bandwidthd: Version bump to handle indirect deps properly
Nathaniel, All,
On 2014-10-19 17:59 +0800, Nathaniel Roach spake thusly:
Quoted 32 lines · Yann E. MORIN
Quoted 6 lines
Nathaniel, All,
On 2014-10-19 16:55 +0800, Nathaniel Roach spake thusly:
Quoted 1 line
Thanks to Romain Naor, Baruch Siach and Thomas Petazzoni, I've
Romain Naour, I believe... ;-)
Damn it...
Quoted 22 lines
Quoted 11 lines
solved the build issues in certain cases for bandwidthd.
The issue was that libpcap and libpng would depend on other libraries and upon testing for pcap/libpng the tests would fail due to not being able to find the other libraries.
Bandwidthd's configure script now uses pkg-config for libpng and pcap-config for libpcap. pcap-config's path is specified in configure's arguments.
Quoted 7 lines
Some other tweaks have been made including the layout and flow of configure.ac is a bit more logical, and the handling of postgres and sqlite has been tweaked. Finally, the test for X.Org has been removed.
Usually, when some people helped with the patch, it is customary (but not mandatory) to add them in Cc: lines below the SoB line. ;-)
Quoted 7 lines
Quoted 5 lines
Reviewed-by "Yann E. MORIN" <[email protected]>Regards,
Yann E. MORIN.I'll send a fixed one through shortly.
No need I guess, the typo can be fixed by whoever applies the patch.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'