Skip to contentSkip to conversation

ls1:config: Add USB support for ls1021atwr

PATCH New Ramneek Mehresh 2 participants 6 messages Oct 21, 2014 – Jan 15, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ls1:config: Add USB support for ls1021atwr

Add USB EHCI/XHCI support for ls1021atwr platform and making xHCI as default mode

---
 include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
include/configs/ls1021atwr.h +28 -0
index 45b2272..109e58c 100644
@@ -28,6 +28,34 @@
 #define CONFIG_SYS_INIT_RAM_SIZE	OCRAM_SIZE
 
 /*
+ * USB
+ */
+/*EHCI Support*/
+/*#define CONFIG_HAS_FSL_DR_USB*/
+
+#ifdef CONFIG_HAS_FSL_DR_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_FSL
+#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
+#endif
+
+/*XHCI Support*/
+#define CONFIG_HAS_FSL_XHCI_USB
+
+#ifdef CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT        1
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS     1
+#endif
+
+#if defined(CONFIG_HAS_FSL_DR_USB) || defined(CONFIG_HAS_FSL_XHCI_USB)
+#define CONFIG_CMD_USB
+#define CONFIG_USB_STORAGE
+#define CONFIG_CMD_EXT2
+#endif
+
+/*
  * Generic Timer Definitions
  */
 #define GENERIC_TIMER_CLK		12500000
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 ls1:config: Add XHCI support for ls1021aqds

Add USB XHCI support for ls1021aqds platform and
making this as default mode

---
 include/configs/ls1021aqds.h | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
include/configs/ls1021aqds.h +16 -5
index fd43a3e..c6f83b2 100644
@@ -275,19 +275,30 @@ unsigned long get_board_ddr_clk(void);
 /*
  * USB
  */
-#define CONFIG_HAS_FSL_DR_USB
+/*EHCI Support*/
+/*#define CONFIG_HAS_FSL_DR_USB*/
 
 #ifdef CONFIG_HAS_FSL_DR_USB
 #define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_FSL
+#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
+#endif
 
-#ifdef CONFIG_USB_EHCI
+/*XHCI Support*/
+#define CONFIG_HAS_FSL_XHCI_USB
+
+#ifdef CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT	1
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	1
+#endif
+
+#if defined(CONFIG_HAS_FSL_DR_USB) || defined(CONFIG_HAS_FSL_XHCI_USB)
 #define CONFIG_CMD_USB
 #define CONFIG_USB_STORAGE
-#define CONFIG_USB_EHCI_FSL
-#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
 #define CONFIG_CMD_EXT2
 #endif
-#endif
 
 /*
  * eTSEC
Signature · 1 line
1.8.3.1
#2 lore raw

PATCH 1/1 ls1:config: Add XHCI support for ls1021aqds

Quoted 8 lines · Ramneek Mehresh

Add USB XHCI support for ls1021aqds platform and
making this as default mode

---
 include/configs/ls1021aqds.h | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

Please verify this patch on the latest u-boot. I saw compiling errors.

York

#3 lore raw

PATCH 1/1 ls1:config: Add USB support for ls1021atwr

In reply to Ramneek Mehresh
Quoted 8 lines · Ramneek Mehresh

Add USB EHCI/XHCI support for ls1021atwr platform and making xHCI as default mode

---
 include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Please verify this patch on the latest u-boot. I saw compiling errors.

York

#4 lore raw

PATCH 1/1 ls1:config: Add USB support for ls1021atwr

Quoted 4 lines · York Sun
Quoted 3 lines · Ramneek Mehresh

Add USB EHCI/XHCI support for ls1021atwr platform and making xHCI as default mode

Quoted 8 lines
Quoted 5 lines
---
 include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Please verify this patch on the latest u-boot. I saw compiling errors.

Please fix. This patch cause compiling errors on all ls1021atwr boards. If this patch depends on other patches, please put into comment so I can apply them in order.

+drivers/usb/host/built-in.o: In function `usb_lowlevel_init':
+drivers/usb/host/xhci.c:948: undefined reference to xhci_hcd_init' +drivers/usb/host/built-in.o: In function usb_lowlevel_stop':
+drivers/usb/host/xhci.c:1025: undefined reference to `xhci_hcd_stop' +arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion fail ../../bfd/elf32-arm.c:7498
+arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion fail ../../bfd/elf32-arm.c:13830
+make[1]: *** [u-boot] Error 139
+make: *** [sub-make] Error 2

York

#5 lore raw

PATCH 1/1 ls1:config: Add USB support for ls1021atwr

Quoted 21 lines

-----Original Message-----
From: Sun York-R58495
Sent: Thursday, January 15, 2015 12:16 AM
To: Mehresh Ramneek-B31383; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr

Quoted 10 lines · York Sun
Quoted 8 lines · Ramneek Mehresh

Add USB EHCI/XHCI support for ls1021atwr platform and making xHCI as default mode

---
 include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
Quoted 6 lines
Quoted 2 lines

Please verify this patch on the latest u-boot. I saw compiling errors.

Please fix. This patch cause compiling errors on all ls1021atwr boards. If this patch depends on other patches, please put into comment so I can apply them in order.

Hi York, this patch depends on http://patchwork.ozlabs.org/patch/373593/
which is under review, and has comments from Marex. For this patch, we have dependency on IP team, and that's taking lot of time

Quoted 16 lines
(quoted diff) +6 -0
+drivers/usb/host/built-in.o: In function `usb_lowlevel_init':
+drivers/usb/host/xhci.c:948: undefined reference to `xhci_hcd_init'
+drivers/usb/host/built-in.o: In function `usb_lowlevel_stop':
+drivers/usb/host/xhci.c:1025: undefined reference to `xhci_hcd_stop'
+arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion
+fail

../../bfd/elf32-arm.c:7498

(quoted diff) +2 -0
+arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion
+fail

../../bfd/elf32-arm.c:13830

(quoted diff) +2 -0
+make[1]: *** [u-boot] Error 139
+make: *** [sub-make] Error 2

York