Skip to contentSkip to conversation

Getting a 'no-ack' tx status?

DISCUSSION Ben Greear 2 participants 3 messages Feb 27, 2015 – Mar 2, 2015 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

Someone reported to me that they never see the tx_done->no_ack flag set on their AP, even when stations are falling off the network due to not receiving ACKs.

	if (tx_done->no_ack)
		info->flags &= ~IEEE80211_TX_STAT_ACK;

I am having no luck finding the corresponding code in the 10.1.467 firmware that would cause this to work, but maybe I am just not looking in the right place.

Has anyone done any testing to see if ath10k actually reports ACK failures properly back up the stack?

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#1 lore raw

I think I managed to hack the CT firmware to return the tx-completion status (OK, XRETRY, DROP) when it is returning the tx-rate info, and patched the driver to pay attention to it...

A brief test showed some failed-retry counters reported by the mac80211 stack, so that looks promising.

Will do some more testing when I get a chance.

Thanks,
Ben

Quoted 18 lines · Ben Greear

Someone reported to me that they never see the tx_done->no_ack flag set on their AP, even when stations are falling off the network due to not receiving ACKs.

	if (tx_done->no_ack)
		info->flags &= ~IEEE80211_TX_STAT_ACK;

I am having no luck finding the corresponding code in the 10.1.467 firmware that would cause this to work, but maybe I am just not looking in the right place.

Has anyone done any testing to see if ath10k actually reports ACK failures properly back up the stack?

Thanks,
Ben

Signature · 7 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
In reply to Ben Greear
Quoted 8 lines · Ben Greear

Someone reported to me that they never see the tx_done->no_ack flag set on their AP, even when stations are falling off the network due to not receiving ACKs.

        if (tx_done->no_ack)
                info->flags &= ~IEEE80211_TX_STAT_ACK;
Quoted 6 lines

I am having no luck finding the corresponding code in the 10.1.467 firmware that would cause this to work, but maybe I am just not looking in the right place.

Has anyone done any testing to see if ath10k actually reports ACK failures properly back up the stack?

IIRC 10.1 firmware had a missing condition for that so it reported all frames as ACKed even if that wasn't the case.

I believe this has been fixed in 10.2.

Michał

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k