fsl_ssi: fix of_property_read_u32_array return value check

PATCH Applied Maciej S. Szmigiero 2 participants 2 messages Mar 4, 2015 – Mar 5, 2015

Subsystems (3)

Sound ASoC Freescale SoC sound drivers

lore

Share & tools

lore

Maciej S. Szmigiero

author

2015-03-04 21:48 UTC #0 lore raw

PATCH 1/1 fsl_ssi: fix of_property_read_u32_array return value check

of_property_read_u32_array returns 0 on success,
so the return value shouldn't be inverted twice,
first on assignment then in condition expression.

Signed-off-by Maciej Szmigiero <[email protected]>

sound/soc/fsl/fsl_ssi.c +1 -1

@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
 	ssi_private->dma_params_tx.addr = ssi_private->ssi_phys + CCSR_SSI_STX0;
 	ssi_private->dma_params_rx.addr = ssi_private->ssi_phys + CCSR_SSI_SRX0;
 
-	ret = !of_property_read_u32_array(np, "dmas", dmas, 4);
+	ret = of_property_read_u32_array(np, "dmas", dmas, 4);
 	if (ssi_private->use_dma && !ret && dmas[2] == IMX_DMATYPE_SSI_DUAL) {
 		ssi_private->use_dual_fifo = true;
 		/* When using dual fifo mode, we need to keep watermark

Mark Brown

maintainer Applied

2015-03-05 01:01 UTC #1 lore raw

Quoted 5 lines · Maciej S. Szmigiero

of_property_read_u32_array returns 0 on success,
so the return value shouldn't be inverted twice,
first on assignment then in condition expression.
Signed-off-by Maciej Szmigiero <[email protected]>

Applied, thanks.