Skip to contentSkip to conversation

Follow-up to RGMII mode clarification: am65-cpsw fix + checkpatch

PATCH Applied Matthias Schiffer 6 participants 15 messages Jun 24, 2025 – Jul 14, 2025

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

v2 cover Follow-up to RGMII mode clarification: am65-cpsw fix + checkpatch

Following previous discussion [1] and the documentation update by Andrew [2]:

Fix up the mode to account for the fixed TX delay on the AM65 CPSW Ethernet controllers, similar to the way the icssg-prueth does it. For backwards compatibility, the "impossible" modes that claim to have a delay on the PCB are still accepted, but trigger a warning message.

As Andrew suggested, I have also added a checkpatch check that requires a comment for any RGMII mode that is not "rgmii-id".

No Device Trees are updated to avoid the warning for now, to give other projects syncing the Linux Device Trees some time to fix their drivers as well. I intend to submit an equivalent change for U-Boot's am65-cpsw-nuss driver as soon as the changes are accepted for Linux.

Changelog v2:

- Previous patch 1/4 has been dropped, has it has been replaced by [2]
- Patches 1/3, 2/3: collected review and ack tags
- Patch 3/3:
- Fixed multiple typos noted during review
- Extended to check .dtso in addition to .dts and .dtsi
- Changed CHK() to WARN(), so the warning triggers without --strict

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
commit c360eb0c3ccb ("dt-bindings: net: ethernet-controller: Add informative text about RGMII delays")
Patch series v1: https://lore.kernel.org/all/[email protected]/

Matthias Schiffer (3):
dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay
checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

 Documentation/dev-tools/checkpatch.rst        |  9 +++++++
 .../bindings/net/ti,k3-am654-cpsw-nuss.yaml   |  2 +-
 drivers/net/ethernet/ti/am65-cpsw-nuss.c      | 27 +++++++++++++++++--
 scripts/checkpatch.pl                         | 12 +++++++++
 4 files changed, 47 insertions(+), 3 deletions(-)
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
#1 lore raw

PATCH v2 1/3 dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example

k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID mode is not actually possible and will result in a warning from the driver going forward.

---
 .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml +1 -1
index 7b3d948f187df..a959c1d7e643a 100644
@@ -284,7 +284,7 @@ examples:
                     ti,syscon-efuse = <&mcu_conf 0x200>;
                     phys = <&phy_gmii_sel 1>;
 
-                    phy-mode = "rgmii-rxid";
+                    phy-mode = "rgmii-id";
                     phy-handle = <&phy0>;
                 };
             };
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
Reviewed-by on v2 1/3
#2 lore raw

Re: [PATCH net-next v2 1/3] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example

Quoted 8 lines · Matthias Schiffer

k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID mode is not actually possible and will result in a warning from the driver going forward.

Regards,
Siddharth.

#3 lore raw

PATCH v2 2/3 net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

In reply to Matthias Schiffer

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 27 ++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)
drivers/net/ethernet/ti/am65-cpsw-nuss.c +25 -2
index f20d1ff192efe..519757e618ad0 100644
@@ -2602,6 +2602,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		return -ENOENT;
 
 	for_each_child_of_node(node, port_np) {
+		phy_interface_t phy_if;
 		struct am65_cpsw_port *port;
 		u32 port_id;
 
@@ -2667,14 +2668,36 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 
 		/* get phy/link info */
 		port->slave.port_np = of_node_get(port_np);
-		ret = of_get_phy_mode(port_np, &port->slave.phy_if);
+		ret = of_get_phy_mode(port_np, &phy_if);
 		if (ret) {
 			dev_err(dev, "%pOF read phy-mode err %d\n",
 				port_np, ret);
 			goto of_node_put;
 		}
 
-		ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET, port->slave.phy_if);
+		/* CPSW controllers supported by this driver have a fixed
+		 * internal TX delay in RGMII mode. Fix up PHY mode to account
+		 * for this and warn about Device Trees that claim to have a TX
+		 * delay on the PCB.
+		 */
+		switch (phy_if) {
+		case PHY_INTERFACE_MODE_RGMII_ID:
+			phy_if = PHY_INTERFACE_MODE_RGMII_RXID;
+			break;
+		case PHY_INTERFACE_MODE_RGMII_TXID:
+			phy_if = PHY_INTERFACE_MODE_RGMII;
+			break;
+		case PHY_INTERFACE_MODE_RGMII:
+		case PHY_INTERFACE_MODE_RGMII_RXID:
+			dev_warn(dev,
+				 "RGMII mode without internal TX delay unsupported; please fix your Device Tree\n");
+			break;
+		default:
+			break;
+		}
+
+		port->slave.phy_if = phy_if;
+		ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET, phy_if);
 		if (ret)
 			goto of_node_put;
 
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
#4 lore raw

Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

On Tue, Jun 24, 2025 at 12:53:33PM +0200, Matthias Schiffer wrote:

Hello Matthias,

Quoted 44 lines

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 27 ++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)
drivers/net/ethernet/ti/am65-cpsw-nuss.c +8 -2
index f20d1ff192efe..519757e618ad0 100644
@@ -2602,6 +2602,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		return -ENOENT;
 
 	for_each_child_of_node(node, port_np) {
+		phy_interface_t phy_if;
 		struct am65_cpsw_port *port;
 		u32 port_id;
 
@@ -2667,14 +2668,36 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 
 		/* get phy/link info */
 		port->slave.port_np = of_node_get(port_np);
-		ret = of_get_phy_mode(port_np, &port->slave.phy_if);
+		ret = of_get_phy_mode(port_np, &phy_if);
 		if (ret) {
 			dev_err(dev, "%pOF read phy-mode err %d\n",
 				port_np, ret);
 			goto of_node_put;
 		}
 
-		ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET, port->slave.phy_if);
+		/* CPSW controllers supported by this driver have a fixed
+		 * internal TX delay in RGMII mode. Fix up PHY mode to account
+		 * for this and warn about Device Trees that claim to have a TX
+		 * delay on the PCB.
+		 */
+		switch (phy_if) {

drivers/net/ethernet/ti/am65-cpsw-nuss.c static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common) · line 2693

Quoted 10 lines
drivers/net/ethernet/ti/am65-cpsw-nuss.c +10 -0
+		case PHY_INTERFACE_MODE_RGMII_ID:
+			phy_if = PHY_INTERFACE_MODE_RGMII_RXID;
+			break;
+		case PHY_INTERFACE_MODE_RGMII_TXID:
+			phy_if = PHY_INTERFACE_MODE_RGMII;
+			break;
+		case PHY_INTERFACE_MODE_RGMII:
+		case PHY_INTERFACE_MODE_RGMII_RXID:
+			dev_warn(dev,
+				 "RGMII mode without internal TX delay unsupported; please fix your Device Tree\n");

Existing users designed boards and enabled Ethernet functionality using "rgmii-rxid" in the device-tree and implementing the PCB traces in a way that they interpret "rgmii-rxid". So their (mis)interpretation of it is being challenged by the series. While it is true that we are updating the bindings and driver to move towards the correct definition, I believe that the above message would cause confusion. Would it be alright to update it to something similar to:

"Interpretation of RGMII delays has been corrected; no functional impact; please fix your Device Tree"

Regards,
Siddharth.

#5 lore raw

Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

Quoted 67 lines · Siddharth Vadapalli

On Tue, Jun 24, 2025 at 12:53:33PM +0200, Matthias Schiffer wrote:

Hello Matthias,

Quoted 44 lines

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 27 ++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)
drivers/net/ethernet/ti/am65-cpsw-nuss.c +8 -2
index f20d1ff192efe..519757e618ad0 100644
@@ -2602,6 +2602,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		return -ENOENT;
 
 	for_each_child_of_node(node, port_np) {
+		phy_interface_t phy_if;
 		struct am65_cpsw_port *port;
 		u32 port_id;
 
@@ -2667,14 +2668,36 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 
 		/* get phy/link info */
 		port->slave.port_np = of_node_get(port_np);
-		ret = of_get_phy_mode(port_np, &port->slave.phy_if);
+		ret = of_get_phy_mode(port_np, &phy_if);
 		if (ret) {
 			dev_err(dev, "%pOF read phy-mode err %d\n",
 				port_np, ret);
 			goto of_node_put;
 		}
 
-		ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET, port->slave.phy_if);
+		/* CPSW controllers supported by this driver have a fixed
+		 * internal TX delay in RGMII mode. Fix up PHY mode to account
+		 * for this and warn about Device Trees that claim to have a TX
+		 * delay on the PCB.
+		 */
+		switch (phy_if) {

drivers/net/ethernet/ti/am65-cpsw-nuss.c static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common) · line 2693

Quoted 10 lines
drivers/net/ethernet/ti/am65-cpsw-nuss.c +10 -0
+		case PHY_INTERFACE_MODE_RGMII_ID:
+			phy_if = PHY_INTERFACE_MODE_RGMII_RXID;
+			break;
+		case PHY_INTERFACE_MODE_RGMII_TXID:
+			phy_if = PHY_INTERFACE_MODE_RGMII;
+			break;
+		case PHY_INTERFACE_MODE_RGMII:
+		case PHY_INTERFACE_MODE_RGMII_RXID:
+			dev_warn(dev,
+				 "RGMII mode without internal TX delay unsupported; please fix your Device Tree\n");

Existing users designed boards and enabled Ethernet functionality using "rgmii-rxid" in the device-tree and implementing the PCB traces in a way that they interpret "rgmii-rxid". So their (mis)interpretation of it is being challenged by the series. While it is true that we are updating the bindings and driver to move towards the correct definition, I believe that the above message would cause confusion. Would it be alright to update it to something similar to:

Quoted 1 line

"Interpretation of RGMII delays has been corrected; no functional impact; please fix your Device Tree"

It is dev_warn() not dev_err(), so it should be read as a warning. And the device will continue to probe and work. So I think the message is O.K. What we don't want is DT developers thinking they can just ignore it. So i would keep it reasonably strongly worded.

Andrew

#6 lore raw

Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

Quoted 68 lines · Andrew Lunn
Quoted 67 lines · Siddharth Vadapalli

On Tue, Jun 24, 2025 at 12:53:33PM +0200, Matthias Schiffer wrote:

Hello Matthias,

Quoted 44 lines

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 27 ++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)
drivers/net/ethernet/ti/am65-cpsw-nuss.c +8 -2
index f20d1ff192efe..519757e618ad0 100644
@@ -2602,6 +2602,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 		return -ENOENT;
 
 	for_each_child_of_node(node, port_np) {
+		phy_interface_t phy_if;
 		struct am65_cpsw_port *port;
 		u32 port_id;
 
@@ -2667,14 +2668,36 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 
 		/* get phy/link info */
 		port->slave.port_np = of_node_get(port_np);
-		ret = of_get_phy_mode(port_np, &port->slave.phy_if);
+		ret = of_get_phy_mode(port_np, &phy_if);
 		if (ret) {
 			dev_err(dev, "%pOF read phy-mode err %d\n",
 				port_np, ret);
 			goto of_node_put;
 		}
 
-		ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET, port->slave.phy_if);
+		/* CPSW controllers supported by this driver have a fixed
+		 * internal TX delay in RGMII mode. Fix up PHY mode to account
+		 * for this and warn about Device Trees that claim to have a TX
+		 * delay on the PCB.
+		 */
+		switch (phy_if) {

drivers/net/ethernet/ti/am65-cpsw-nuss.c static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common) · line 2693

Quoted 10 lines
drivers/net/ethernet/ti/am65-cpsw-nuss.c +10 -0
+		case PHY_INTERFACE_MODE_RGMII_ID:
+			phy_if = PHY_INTERFACE_MODE_RGMII_RXID;
+			break;
+		case PHY_INTERFACE_MODE_RGMII_TXID:
+			phy_if = PHY_INTERFACE_MODE_RGMII;
+			break;
+		case PHY_INTERFACE_MODE_RGMII:
+		case PHY_INTERFACE_MODE_RGMII_RXID:
+			dev_warn(dev,
+				 "RGMII mode without internal TX delay unsupported; please fix your Device Tree\n");

Existing users designed boards and enabled Ethernet functionality using "rgmii-rxid" in the device-tree and implementing the PCB traces in a way that they interpret "rgmii-rxid". So their (mis)interpretation of it is being challenged by the series. While it is true that we are updating the bindings and driver to move towards the correct definition, I believe that the above message would cause confusion. Would it be alright to update it to something similar to:

Quoted 6 lines
Quoted 1 line

"Interpretation of RGMII delays has been corrected; no functional impact; please fix your Device Tree"

It is dev_warn() not dev_err(), so it should be read as a warning. And the device will continue to probe and work. So I think the message is O.K. What we don't want is DT developers thinking they can just ignore it. So i would keep it reasonably strongly worded.

Thank you for the clarification. I have no further concerns and the patch looks good to me.

Regards,
Siddharth.

#7 lore raw

Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

In reply to Matthias Schiffer

Hi,

Quoted 9 lines · Matthias Schiffer

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

For whatever reason, this patch is breaking network on our board (just transmission). We have rgmii-id in our devicetree which is now modified to be just rgmii-rxid. The board has a TI AM67A (J722S) with a Broadcom BCM54210E PHY. I'm not sure, if AM67A MAC doesn't add any delay or if it's too small. I'll need to ask around if there are any measurements but my colleague doing the measurements is on holiday at the moment.

-michael

#8 lore raw

Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

Quoted 13 lines · Michael Walle

Hi,

Quoted 9 lines · Matthias Schiffer

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

Quoted 7 lines

For whatever reason, this patch is breaking network on our board (just transmission). We have rgmii-id in our devicetree which is now modified to be just rgmii-rxid. The board has a TI AM67A (J722S) with a Broadcom BCM54210E PHY. I'm not sure, if AM67A MAC doesn't add any delay or if it's too small. I'll need to ask around if there are any measurements but my colleague doing the measurements is on holiday at the moment.

I agree, we need to see if this is a AM65 vs AM67 issue. rgmii-id would be correct if the MAC is not adding delays.

Do you have access to the datasheets for both? Can you do a side by side comparison for the section which describes the fixed TX delay?

Andrew

#9 lore raw

Re: [PATCH net-next v2 2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay

Hi,

Quoted 20 lines · Andrew Lunn
Quoted 11 lines · Michael Walle
Quoted 9 lines · Matthias Schiffer

All am65-cpsw controllers have a fixed TX delay, so the PHY interface mode must be fixed up to account for this.

Modes that claim to a delay on the PCB can't actually work. Warn people to update their Device Trees if one of the unsupported modes is specified.

Quoted 7 lines

For whatever reason, this patch is breaking network on our board (just transmission). We have rgmii-id in our devicetree which is now modified to be just rgmii-rxid. The board has a TI AM67A (J722S) with a Broadcom BCM54210E PHY. I'm not sure, if AM67A MAC doesn't add any delay or if it's too small. I'll need to ask around if there are any measurements but my colleague doing the measurements is on holiday at the moment.

Quoted 5 lines

I agree, we need to see if this is a AM65 vs AM67 issue. rgmii-id would be correct if the MAC is not adding delays.

Do you have access to the datasheets for both? Can you do a side by side comparison for the section which describes the fixed TX delay?

The datasheets and TRMs of the SoC are public of the SoC. According to the AM67A TRM the delay should be 1.2ns if I'm reading it correctly. The BCM PHY requires a setup time of -0.9ns (min). So, is should work (?), but it doesn't. I'm also not aware of any routing skew between the signals. But as I said, I'll have to check with my colleague next week.

-michael

#10 lore raw

PATCH v2 3/3 checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

In reply to Matthias Schiffer

Historically, the RGMII PHY modes specified in Device Trees have been used inconsistently, often referring to the usage of delays on the PHY side rather than describing the board; many drivers still implement this incorrectly.

Require a comment in Devices Trees using these modes (usually mentioning that the delay is realized on the PCB), so we can avoid adding more incorrect uses (or will at least notice which drivers still need to be fixed).

---
 Documentation/dev-tools/checkpatch.rst |  9 +++++++++
 scripts/checkpatch.pl                  | 12 ++++++++++++
 2 files changed, 21 insertions(+)
Documentation/dev-tools/checkpatch.rst +9 -0
index 76bd0ddb00416..d5c47e560324f 100644
@@ -495,6 +495,15 @@ Comments
 
     See: https://lore.kernel.org/lkml/20131006222342.GT19510@leaf/
 
+  **UNCOMMENTED_RGMII_MODE**
+    Historically, the RGMII PHY modes specified in Device Trees have been
+    used inconsistently, often referring to the usage of delays on the PHY
+    side rather than describing the board.
+
+    PHY modes "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock
+    signal to be delayed on the PCB; this unusual configuration should be
+    described in a comment. If they are not (meaning that the delay is realized
+    internally in the MAC or PHY), "rgmii-id" is the correct PHY mode.
 
 Commit message
 --------------
scripts/checkpatch.pl +12 -0
index 664f7b7a622c2..f597734d83cc0 100755
@@ -3741,6 +3741,18 @@ sub process {
 			}
 		}
 
+# Check for RGMII phy-mode with delay on PCB
+		if ($realfile =~ /\.(dts|dtsi|dtso)$/ &&
+		    $line =~ /^\+\s*(phy-mode|phy-connection-type)\s*=\s*"/ &&
+		    !ctx_has_comment($first_line, $linenr)) {
+			my $prop = $1;
+			my $mode = get_quoted_string($line, $rawline);
+			if ($mode =~ /^"rgmii(?:|-rxid|-txid)"$/) {
+				WARN("UNCOMMENTED_RGMII_MODE",
+				     "$prop $mode without comment -- delays on the PCB should be described, otherwise use \"rgmii-id\"\n" . $herecurr);
+			}
+		}
+
 # check for using SPDX license tag at beginning of files
 		if ($realline == $checklicenseline) {
 			if ($rawline =~ /^[ \+]\s*\#\!\s*\//) {
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
Reviewed-by on v2 3/3
#11 lore raw

Re: [PATCH net-next v2 3/3] checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

Quoted 5 lines · Matthias Schiffer

Historically, the RGMII PHY modes specified in Device Trees have been used inconsistently, often referring to the usage of delays on the PHY side rather than describing the board; many drivers still implement this incorrectly.

Quoted 7 lines

Require a comment in Devices Trees using these modes (usually mentioning that the delay is realized on the PCB), so we can avoid adding more incorrect uses (or will at least notice which drivers still need to be fixed).

One question, how should this be merged? The two DT patches might want to go via the TI DT Maintainer. And this patch via the checkpatch Maintainer? Or do you plan to merge it some other way?

Andrew

#12 lore raw

Re: [PATCH net-next v2 3/3] checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

Quoted 12 lines · Andrew Lunn
Quoted 10 lines · Matthias Schiffer

Historically, the RGMII PHY modes specified in Device Trees have been used inconsistently, often referring to the usage of delays on the PHY side rather than describing the board; many drivers still implement this incorrectly.

Require a comment in Devices Trees using these modes (usually mentioning that the delay is realized on the PCB), so we can avoid adding more incorrect uses (or will at least notice which drivers still need to be fixed).

Quoted 6 lines
Quoted 2 lines

One question, how should this be merged? The two DT patches might want to go via the TI DT Maintainer. And this patch via the checkpatch Maintainer? Or do you plan to merge it some other way?

The first two patches should go via net-next I think (the first is DT bindings only, the second one modifies the AM65-CPSW driver), although I would prefer to get a review/ack from a TI maintainer, too.

I don't know what tree checkpatch usually goes through, MAINTAINERS doesn't list a specific repo. The whole series could be merged via net-next if that's fine with the checkpatch maintainers.

Best,
Matthias

Quoted 4 lines

Andrew

Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/
maintainer
#13 lore raw

Re: [PATCH net-next v2 3/3] checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

Quoted 3 lines · Matthias Schiffer

I don't know what tree checkpatch usually goes through, MAINTAINERS doesn't list a specific repo. The whole series could be merged via net-next if that's fine with the checkpatch maintainers.

Merging via net-next is fine with me.

Andrew Morton is the typical upstream path for random checkpatch changes.

#14 lore raw
In reply to Matthias Schiffer
This series was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 9 lines · On Tue, 24 Jun 2025 12:53:31 +0200 you wrote:

Following previous discussion [1] and the documentation update by Andrew [2]:

Fix up the mode to account for the fixed TX delay on the AM65 CPSW Ethernet controllers, similar to the way the icssg-prueth does it. For backwards compatibility, the "impossible" modes that claim to have a delay on the PCB are still accepted, but trigger a warning message.

[...]

Here is the summary with links:
- [net-next,v2,1/3] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example

    https://git.kernel.org/netdev/net-next/c/9b357ea52523
  - [net-next,v2,2/3] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay
    https://git.kernel.org/netdev/net-next/c/ca13b249f291
  - [net-next,v2,3/3] checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes
    https://git.kernel.org/netdev/net-next/c/e02adac7c84b

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html