Skip to contentSkip to conversation

e1000e: Increase pause and refresh time

PATCH New Paul Menzel 2 participants 4 messages May 17, 2019 – Jun 21, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: Increase pause and refresh time

From: Miguel Bernal Marin <[email protected]>
Date: Mon, 27 Mar 2017 16:01:56 -0600

---
Miguel, it?d be great, if you could write a commit message stating the motivation for that change, that means, why is it preferable to increase these values, and set the pause time unconditionally.

  drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ethernet/intel/e1000e/netdev.c
index ce4aaa9f2163..597d3ca19555 100644

drivers/net/ethernet/intel/e1000e/netdev.c +2 -2
@@ -4047,12 +4047,12 @@ void e1000e_reset(struct e1000_adapter *adapter)
  	case e1000_pch_lpt:
  	case e1000_pch_spt:
  	case e1000_pch_cnp:
-		fc->refresh_time = 0x0400;
+		fc->refresh_time = 0xFFFF;
+		fc->pause_time = 0xFFFF;
 
  		if (adapter->netdev->mtu <= ETH_DATA_LEN) {
  			fc->high_water = 0x05C20;
  			fc->low_water = 0x05048;
-			fc->pause_time = 0x0650;
  			break;
  		}
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 e1000e: Increase pause and refresh time

Quoted 24 lines · Paul Menzel

From: Miguel Bernal Marin <[email protected]>
Date: Mon, 27 Mar 2017 16:01:56 -0600

---
Miguel, it?d be great, if you could write a commit message stating the motivation for that change, that means, why is it preferable to increase these values, and set the pause time unconditionally.

 ?drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--

?1 file changed, 2 insertions(+), 2 deletions(-)

drivers/net/ethernet/intel/e1000e/netdev.c +0 -1
index ce4aaa9f2163..597d3ca19555 100644
@@ -4047,12 +4047,12 @@ void e1000e_reset(struct e1000_adapter *adapter)
 ???? case e1000_pch_lpt:
 ???? case e1000_pch_spt:
 ???? case e1000_pch_cnp:
-??????? fc->refresh_time = 0x0400;

drivers/net/ethernet/intel/e1000e/netdev.c void e1000e_reset(struct e1000_adapter *adapter) · line 4058

Quoted 10 lines
drivers/net/ethernet/intel/e1000e/netdev.c +2 -1
+??????? fc->refresh_time = 0xFFFF;
+??????? fc->pause_time = 0xFFFF;
 
 ???????? if (adapter->netdev->mtu <= ETH_DATA_LEN) {
 ???????????? fc->high_water = 0x05C20;
 ???????????? fc->low_water = 0x05048;
-??????????? fc->pause_time = 0x0650;
 ???????????? break;
 ???????? }
 

I am good with this patch.

#2 lore raw

PATCH 1/1 e1000e: Increase pause and refresh time

Quoted 28 lines · Sasha
Quoted 27 lines · Paul Menzel

From: Miguel Bernal Marin <[email protected]>
Date: Mon, 27 Mar 2017 16:01:56 -0600

---
Miguel, it?d be great, if you could write a commit message stating the motivation for that change, that means, why is it preferable to increase these values, and set the pause time unconditionally.

??drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++-- ??1 file changed, 2 insertions(+), 2 deletions(-)

drivers/net/ethernet/intel/e1000e/netdev.c +0 -0
index ce4aaa9f2163..597d3ca19555 100644
@@ -4047,12 +4047,12 @@ void e1000e_reset(struct e1000_adapter *adapter)

????? case e1000_pch_lpt:
????? case e1000_pch_spt:
????? case e1000_pch_cnp:
-??????? fc->refresh_time = 0x0400;
+??????? fc->refresh_time = 0xFFFF;
+??????? fc->pause_time = 0xFFFF;

Quoted 12 lines
Quoted 7 lines

????????? if (adapter->netdev->mtu <= ETH_DATA_LEN) { ????????????? fc->high_water = 0x05C20; ????????????? fc->low_water = 0x05048; -??????????? fc->pause_time = 0x0650; ????????????? break;
????????? }

I am good with this patch.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#3 lore raw

PATCH 1/1 e1000e: Increase pause and refresh time

In reply to Paul Menzel
Quoted 6 lines · Paul Menzel

From: Miguel Bernal Marin <[email protected]>
Date: Mon, 27 Mar 2017 16:01:56 -0600

Quoted 8 lines

---
Miguel, it?d be great, if you could write a commit message stating the motivation for that change, that means, why is it preferable to increase these values, and set the pause time unconditionally.

  drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Yes, a commit message explaining ramifiations of the change would be great. But from a functional perspective across my regression systems: