Skip to contentSkip to conversation

ARM: dts: Add LEDs on odroid XU3 board

PATCH RESEND Applied Markus Reichl 4 participants 5 messages May 8, 2015

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Markus Reichl

author
#0 lore raw

PATCH RESEND 1/1 ARM: dts: Add LEDs on odroid XU3 board

This patch adds the RGB-LED on XU3 as 3 gpio-leds.

Tested-by Anand Moon <[email protected]>
Signed-off-by Markus Reichl <[email protected]>

---
It is derived from hardkernel's 3.10 tree.

---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm/boot/dts/exynos5422-odroidxu3.dts +24 -0
index a519c86..0a32302 100644
@@ -278,6 +278,30 @@
 	rtc@101E0000 {
 		status = "okay";
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		heartbeat {
+			label = "blue:heartbeart";
+			gpios = <&gpb2 2 0>;
+			default-state = "off";
+			linux,default-trigger = "heartbeat";
+		};
+
+		eMMC {
+			label = "green:eMMC";
+			gpios = <&gpb2 1 0>;
+			default-state = "off";
+			linux,default-trigger = "mmc0";
+		};
+
+		microSD {
+			label = "red:microSD";
+			gpios = <&gpx2 3 0>;
+			default-state = "off";
+			linux,default-trigger = "mmc1";
+		};
+	};
 };
 
 &hdmi {
Signature · 1 line
1.9.1
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 3 lines · Markus Reichl

This patch adds the RGB-LED on XU3 as 3 gpio-leds.

Tested-by Anand Moon <[email protected]>

Unfortunately I could not found on LKML email from Anand that he tested it. You sent the patch first time on 2nd of April - without Anand's tested-by. On 13th of April it appeared with his tag.

Guys, even when you work closely please send all tags publicly on LKML so everyone could see them.

Anand, do you confirm the tested-by?

Quoted 2 lines
Signed-off-by Markus Reichl <[email protected]> --- It is

derived from hardkernel's 3.10 tree.

Hmmm... Whose original code it was? Shouldn't there be someone else Signed-off-by here?

Best regards,
Krzysztof
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVTGsoAAoJEME3ZuaGi4PXbPAP/jDFtVian19v6L1MsnPYGJtk xD+V+JhpgcDWRaxTIBlS3xdcrTO1Ci/+C/b1Me7a1amczvNPEL2iT53d0rSDX+QA UufqWylu0n/QScthCOn3en0ghGibCoAT2d5hIyeAMPPka66xBrIgkp7ZffOQfpnR +rNyouireSHm38Mu2utyRPUACiS/KMps1GFZ8uNy+I/JZ1hVjiZulqHItvBSpPh/ Vaya0BupC9D6zNfp3lBjSJBgjuFSe+v2GCqjpcZIiACLs6t31J/jrzo1Sthc24jC d15SD/H484P3r9yvERLwUMc7s+e8d4f9yFN3X2eIT1mKzrKbPlRZ4jKfmlHi2nO9 4mnfI2S7D6YpLTax997ESPb6KSLkcxstrT6ISham1sz2E3Ge/JbkJGrv4jZbgzot KVO+I4BHVDHb8J5Rw8c2oUQsyqoEB3qHDVbnCZXsWRL8KLylVse+h01pp3zyuMTW OmC0zLKY+4I1Webj9DCCaFlA8w3UDnD5AvEd3zU77RkShYop8MIU8ltvTbIOOyvH NPejZKx0fPHksKEMypWWfF8z7LIMI+tVON2WJ5O4zKg5lh9X0a2MCRlYAAoxM3Gu iSOEe6c/+CrnsVWlEynfUTshdU0FUxcw5296puQMEX52jQVBWHY8plIgoUdDW2j+ hz9CTaBt5uq46wb+KhOa
=IxJs
-----END PGP SIGNATURE-----

author
#2 lore raw

Hi Krzysztof,

Am 08.05.2015 um 09:52 schrieb Krzysztof Kozlowski:

Quoted 12 lines · Markus Reichl
Quoted 3 lines

This patch adds the RGB-LED on XU3 as 3 gpio-leds.

Tested-by Anand Moon <[email protected]>

Unfortunately I could not found on LKML email from Anand that he tested it. You sent the patch first time on 2nd of April - without Anand's tested-by. On 13th of April it appeared with his tag.

Guys, even when you work closely please send all tags publicly on LKML so everyone could see them.

Quoted 7 lines

Anand, do you confirm the tested-by?

Quoted 2 lines
Signed-off-by Markus Reichl <[email protected]> --- It is

derived from hardkernel's 3.10 tree.

Hmmm... Whose original code it was? Shouldn't there be someone else Signed-off-by here?

I sent a mail to HK guys to get the respective contact address for another signed-off tag.

After this and Anand's tag I'll come back with a resend.

Quoted 5 lines

Best regards,
Krzysztof

Best Regards,

Signature · 1 line
Markus Reichl
Tested-by
#3 lore raw

Hi Markus/Krzysztof,

Tested-by Anand Moon <[email protected]>

I have tested this patch.

-Anand Moon

Quoted 36 lines · Markus Reichl

Hi Krzysztof,

Am 08.05.2015 um 09:52 schrieb Krzysztof Kozlowski:

Quoted 12 lines · Markus Reichl
Quoted 3 lines

This patch adds the RGB-LED on XU3 as 3 gpio-leds.

Tested-by Anand Moon <[email protected]>

Unfortunately I could not found on LKML email from Anand that he tested it. You sent the patch first time on 2nd of April - without Anand's tested-by. On 13th of April it appeared with his tag.

Guys, even when you work closely please send all tags publicly on LKML so everyone could see them.

Quoted 7 lines

Anand, do you confirm the tested-by?

Quoted 2 lines
Signed-off-by Markus Reichl <[email protected]> --- It is

derived from hardkernel's 3.10 tree.

Hmmm... Whose original code it was? Shouldn't there be someone else Signed-off-by here?

I sent a mail to HK guys to get the respective contact address for another signed-off tag.

After this and Anand's tag I'll come back with a resend.

Quoted 5 lines

Best regards,
Krzysztof

Best Regards,
--
Markus Reichl

Applied
#4 lore raw
In reply to Markus Reichl
Quoted 35 lines · Markus Reichl

This patch adds the RGB-LED on XU3 as 3 gpio-leds.

Tested-by Anand Moon <[email protected]>
Signed-off-by Markus Reichl <[email protected]>

---
It is derived from hardkernel's 3.10 tree.

---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm/boot/dts/exynos5422-odroidxu3.dts +17 -0
index a519c86..0a32302 100644
@@ -278,6 +278,30 @@
 	rtc@101E0000 {
 		status = "okay";
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		heartbeat {
+			label = "blue:heartbeart";
+			gpios = <&gpb2 2 0>;
+			default-state = "off";
+			linux,default-trigger = "heartbeat";
+		};
+
+		eMMC {
+			label = "green:eMMC";
+			gpios = <&gpb2 1 0>;
+			default-state = "off";
+			linux,default-trigger = "mmc0";
+		};
+

arch/arm/boot/dts/exynos5422-odroidxu3.dts line 307

Quoted 10 lines
arch/arm/boot/dts/exynos5422-odroidxu3.dts +7 -0
+		microSD {
+			label = "red:microSD";
+			gpios = <&gpx2 3 0>;
+			default-state = "off";
+			linux,default-trigger = "mmc1";
+		};
+	};
 };
 
 &hdmi {

Applied, thanks.

- Kukjin