Skip to contentSkip to conversation

package/at: updated version from 3.1.13 to 3.1.16

PATCH Superseded Francesco Nwokeka 3 participants 4 messages Sep 7, 2015

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 package/at: updated version from 3.1.13 to 3.1.16

---
 package/at/at.hash | 9 +++++----
 package/at/at.mk   | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)
package/at/at.hash +5 -4
index 481c937..86f523b 100644
@@ -1,4 +1,5 @@
-# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.13-2%2Bdeb7u1.dsc
-sha1	9873e0c38403ef58364912d0b505fd20798fd400  at_3.1.13.orig.tar.gz
-sha256	3a8b90868d615d21a92f4986ea9a823886329af8fae8dd7ab4eed9b273bca072  at_3.1.13.orig.tar.gz
-md5	1da61af6c29e323abaaf13ee1a8dad79  at_3.1.13.orig.tar.gz
+# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
+
+sha1    5ad64a471d0ed9985541e918e096f69dc2963cf0 123174 at_3.1.16.orig.tar.gz
+sha256  cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1 at_3.1.16.orig.tar.gz
+md5 d05da75d9b75d93917ffb16ab48b1e19 at_3.1.16.orig.tar.gz
package/at/at.mk +1 -1
index 1504e32..8865360 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.13
+AT_VERSION = 3.1.16
 AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
 AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
 # missing deps for parsetime.l
Signature · 1 line
2.5.1
#1 lore raw

PATCH 1/5 package/at: updated version from 3.1.13 to 3.1.16

Dear Francesco Nwokeka,

Quoted 26 lines · Francesco Nwokeka
---
 package/at/at.hash | 9 +++++----
 package/at/at.mk   | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)
package/at/at.hash +5 -4
index 481c937..86f523b 100644
@@ -1,4 +1,5 @@
-# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.13-2%2Bdeb7u1.dsc
-sha1	9873e0c38403ef58364912d0b505fd20798fd400  at_3.1.13.orig.tar.gz
-sha256	3a8b90868d615d21a92f4986ea9a823886329af8fae8dd7ab4eed9b273bca072  at_3.1.13.orig.tar.gz
-md5	1da61af6c29e323abaaf13ee1a8dad79  at_3.1.13.orig.tar.gz
+# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
+
+sha1    5ad64a471d0ed9985541e918e096f69dc2963cf0 123174 at_3.1.16.orig.tar.gz
+sha256  cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1 at_3.1.16.orig.tar.gz
+md5 d05da75d9b75d93917ffb16ab48b1e19 at_3.1.16.orig.tar.gz
package/at/at.mk +0 -0
index 1504e32..8865360 100644

package/at/at.mk line 10

Quoted 8 lines
package/at/at.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.13
+AT_VERSION = 3.1.16
 AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
 AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
 # missing deps for parsetime.l

after applying your patch, I can't build at:

Quoted 1 line
Quoted 1 line
Quoted 1 line

at 3.1.16 Patching

Applying 0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch using patch:
patching file configure.ac
Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file configure.ac.rej Patch failed! Please fix 0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch!

This is because you need to "remove unneeded"/tweak patches at the same time you are bumping the version.

You patch series should be testable at any step of the series.

Also, when you send a new patch with superseded an old one, please mark the old one as "superseded" in Patchwork.

Regards,

Vincent.

#2 lore raw

PATCH 1/5 package/at: updated version from 3.1.13 to 3.1.16

Quoted 1 line

Also, when you send a new patch with superseded an old one, please mark

s/with superseded/that supersedes/

#3 lore raw

PATCH 1/5 package/at: updated version from 3.1.13 to 3.1.16

In reply to Vicente Olivert Riera
Quoted 50 lines · Vicente Olivert Riera

Dear Francesco Nwokeka,

Quoted 26 lines · Francesco Nwokeka
---
 package/at/at.hash | 9 +++++----
 package/at/at.mk   | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)
package/at/at.hash +5 -4
index 481c937..86f523b 100644
@@ -1,4 +1,5 @@
-# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.13-2%2Bdeb7u1.dsc
-sha1	9873e0c38403ef58364912d0b505fd20798fd400  at_3.1.13.orig.tar.gz
-sha256	3a8b90868d615d21a92f4986ea9a823886329af8fae8dd7ab4eed9b273bca072  at_3.1.13.orig.tar.gz
-md5	1da61af6c29e323abaaf13ee1a8dad79  at_3.1.13.orig.tar.gz
+# From http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at/at_3.1.16-1.dsc
+
+sha1    5ad64a471d0ed9985541e918e096f69dc2963cf0 123174 at_3.1.16.orig.tar.gz
+sha256  cb9af59c6a54edce9536ba629841055409d1f89d8ae26494727a97141fb4d5c1 at_3.1.16.orig.tar.gz
+md5 d05da75d9b75d93917ffb16ab48b1e19 at_3.1.16.orig.tar.gz
package/at/at.mk +0 -0
index 1504e32..8865360 100644

package/at/at.mk line 10

Quoted 8 lines
package/at/at.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-AT_VERSION = 3.1.13
+AT_VERSION = 3.1.16
 AT_SOURCE = at_$(AT_VERSION).orig.tar.gz
 AT_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/at
 # missing deps for parsetime.l

after applying your patch, I can't build at:

Quoted 1 line
Quoted 1 line
Quoted 1 line

at 3.1.16 Patching

Applying 0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch using patch:
patching file configure.ac
Reversed (or previously applied) patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file configure.ac.rej Patch failed! Please fix 0001-configure.ac-remove-manual-compiler-check-with-AC_TR.patch!

Quoted 4 lines

This is because you need to "remove unneeded"/tweak patches at the same time you are bumping the version.

You patch series should be testable at any step of the series.

In other words: use 'git rebase -i' to squash all 5 patches into a single patch
that updates both the at version and all the at patches.

Also, when updating a series, include 'v2', 'v3', ... in the patch title (which
you can do with 'git send-email -v3'). Also include a changelog in the commit message that keeps track of what has changed since your previous submissions. Put the changelog below your Signed-off-by, separated by ---

See http://buildroot.org/manual.html#_patch_revision_changelog

Quoted 2 lines

Also, when you send a new patch with superseded an old one, please mark the old one as "superseded" in Patchwork.

Vicente, care to update the manual with this hint?

Regards,
Arnout

Quoted 8 lines

Regards,

Vincent.
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF