Skip to contentSkip to conversation

Add Cygnus PCIe Serdes/PHY support

PATCH In review Ray Jui 3 participants 12 messages Sep 21, 2015 – Oct 6, 2015

Subsystems (3)
lore
Share & tools
lore

Ray Jui

author maintainer
#0 lore raw

v5 cover Add Cygnus PCIe Serdes/PHY support

This patch series adds support for the Cygnus PCIe PHY

This patch series is based on Linux v4.3-rc1 and is avaliable in:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-v5

Changes from v4:
- Add comment to explain the required 50 ms wait after PCIe AFE is brought
up
- Change some of 'dev_info' print to 'dev_dbg'

Changes from v3:
- Modify the driver to use child node to represent each PCIe PHY
- Update device tree binding document and examples accordingly
- Add owner filed in phy ops

Changes from v2:
- Dropped MDC/MDIO bus driver since it's not needed to enable/disable the analog-front-end of the PCIe Serdes on Cygnus
- Optimized delay waiting for PCIe analog-front-end to be fully enabled
- Reduce the #phy-cell to 1 since now the MDIO PHY ID is not required

Changes from v1:
- Move the MDC/MDIO bus driver from drivers/phy/* to drivers/bus/*
- Make the PCIe PHY device node child node of the MDIO bus
- Change the PCIe PHY driver to tristate so it can be compiled as a module
- Other minor changes

Ray Jui (2):
dt-bindings: Add Cygnus PCIe PHY binding doc
phy: cygnus: pcie: Add Cygnus PCIe PHY support

 .../bindings/phy/brcm,cygnus-pcie-phy.txt          |  47 +++++
 drivers/phy/Kconfig                                |   9 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/phy-bcm-cygnus-pcie.c                  | 213 +++++++++++++++++++++
 4 files changed, 270 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
 create mode 100644 drivers/phy/phy-bcm-cygnus-pcie.c
Signature · 1 line
1.9.1
author maintainer
#1 lore raw

PATCH v5 1/2 dt-bindings: Add Cygnus PCIe PHY binding doc

Add DT binding document for Broadcom Cygnus PCIe PHYs

---
 .../bindings/phy/brcm,cygnus-pcie-phy.txt          | 47 ++++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt new file +47 -0
new file mode 100644
index 0000000..761c4bc
@@ -0,0 +1,47 @@
+Broadcom Cygnus PCIe PHY
+
+Required properties:
+- compatible: must be "brcm,cygnus-pcie-phy"
+- reg: base address and length of the PCIe PHY block
+- #address-cells: must be 1
+- #size-cells: must be 0
+
+Each PCIe PHY should be represented by a child node
+
+Required properties For the child node:
+- reg: the PHY ID
+0 - PCIe RC 0
+1 - PCIe RC 1
+- #phy-cells: must be 0
+
+Example:
+	pcie_phy: phy@0301d0a0 {
+		compatible = "brcm,cygnus-pcie-phy";
+		reg = <0x0301d0a0 0x14>;
+
+		pcie0_phy: phy@0 {
+			reg = <0>;
+			#phy-cells = <0>;
+		};
+
+		pcie1_phy: phy@1 {
+			reg = <1>;
+			#phy-cells = <0>;
+		};
+	};
+
+	/* users of the PCIe phy */
+
+	pcie0: pcie@18012000 {
+		...
+		...
+		phys = <&pcie0_phy>;
+		phy-names = "pcie-phy";
+	};
+
+	pcie1: pcie@18013000 {
+		...
+		...
+		phys = <pcie1_phy>;
+		phy-names = "pcie-phy";
+	};
Signature · 1 line
1.9.1
author maintainer
#2 lore raw

PATCH v5 2/2 phy: cygnus: pcie: Add Cygnus PCIe PHY support

In reply to Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

---
 drivers/phy/Kconfig               |   9 ++
 drivers/phy/Makefile              |   1 +
 drivers/phy/phy-bcm-cygnus-pcie.c | 213 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 223 insertions(+)
 create mode 100644 drivers/phy/phy-bcm-cygnus-pcie.c
drivers/phy/Kconfig +9 -0
index 47da573..947bae2 100644
@@ -371,4 +371,13 @@ config PHY_BRCMSTB_SATA
 	  Enable this to support the SATA3 PHY on 28nm Broadcom STB SoCs.
 	  Likely useful only with CONFIG_SATA_BRCMSTB enabled.
 
+config PHY_CYGNUS_PCIE
+	tristate "Broadcom Cygnus PCIe PHY driver"
+	depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
+	select GENERIC_PHY
+	default ARCH_BCM_CYGNUS
+	help
+	  Enable this to support the Broadcom Cygnus PCIe PHY.
+	  If unsure, say N.
+
 endmenu
drivers/phy/Makefile +1 -0
index a5b18c1..fdce78d 100644
@@ -46,3 +46,4 @@ obj-$(CONFIG_PHY_QCOM_UFS) 	+= phy-qcom-ufs-qmp-14nm.o
 obj-$(CONFIG_PHY_TUSB1210)		+= phy-tusb1210.o
 obj-$(CONFIG_PHY_BRCMSTB_SATA)		+= phy-brcmstb-sata.o
 obj-$(CONFIG_PHY_PISTACHIO_USB)		+= phy-pistachio-usb.o
+obj-$(CONFIG_PHY_CYGNUS_PCIE)		+= phy-bcm-cygnus-pcie.o
drivers/phy/phy-bcm-cygnus-pcie.c new file +213 -0

213 lines not on this page · raw message

Signature · 1 line
1.9.1
#3 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

Quoted 254 lines
---
 drivers/phy/Kconfig               |   9 ++
 drivers/phy/Makefile              |   1 +
 drivers/phy/phy-bcm-cygnus-pcie.c | 213 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 223 insertions(+)
 create mode 100644 drivers/phy/phy-bcm-cygnus-pcie.c
drivers/phy/Kconfig +9 -0
index 47da573..947bae2 100644
@@ -371,4 +371,13 @@ config PHY_BRCMSTB_SATA
 	  Enable this to support the SATA3 PHY on 28nm Broadcom STB SoCs.
 	  Likely useful only with CONFIG_SATA_BRCMSTB enabled.
 
+config PHY_CYGNUS_PCIE
+	tristate "Broadcom Cygnus PCIe PHY driver"
+	depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
+	select GENERIC_PHY
+	default ARCH_BCM_CYGNUS
+	help
+	  Enable this to support the Broadcom Cygnus PCIe PHY.
+	  If unsure, say N.
+
 endmenu
drivers/phy/Makefile +1 -0
index a5b18c1..fdce78d 100644
@@ -46,3 +46,4 @@ obj-$(CONFIG_PHY_QCOM_UFS) 	+= phy-qcom-ufs-qmp-14nm.o
 obj-$(CONFIG_PHY_TUSB1210)		+= phy-tusb1210.o
 obj-$(CONFIG_PHY_BRCMSTB_SATA)		+= phy-brcmstb-sata.o
 obj-$(CONFIG_PHY_PISTACHIO_USB)		+= phy-pistachio-usb.o
+obj-$(CONFIG_PHY_CYGNUS_PCIE)		+= phy-bcm-cygnus-pcie.o
drivers/phy/phy-bcm-cygnus-pcie.c new file +213 -0
new file mode 100644
index 0000000..7ad72b7
@@ -0,0 +1,213 @@
+/*
+ * Copyright (C) 2015 Broadcom Corporation
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/phy/phy.h>
+#include <linux/platform_device.h>
+
+#define PCIE_CFG_OFFSET         0x00
+#define PCIE1_PHY_IDDQ_SHIFT    10
+#define PCIE0_PHY_IDDQ_SHIFT    2
+
+enum cygnus_pcie_phy_id {
+	CYGNUS_PHY_PCIE0 = 0,
+	CYGNUS_PHY_PCIE1,
+	MAX_NUM_PHYS,
+};
+
+struct cygnus_pcie_phy_core;
+
+/**
+ * struct cygnus_pcie_phy - Cygnus PCIe PHY device
+ * @core: pointer to the Cygnus PCIe PHY core control
+ * @id: internal ID to identify the Cygnus PCIe PHY
+ * @phy: pointer to the kernel PHY device
+ */
+struct cygnus_pcie_phy {
+	struct cygnus_pcie_phy_core *core;
+	enum cygnus_pcie_phy_id id;
+	struct phy *phy;
+};
+
+/**
+ * struct cygnus_pcie_phy_core - Cygnus PCIe PHY core control
+ * @dev: pointer to device
+ * @base: base register
+ * @lock: mutex to protect access to individual PHYs
+ * @phys: pointer to Cygnus PHY device
+ */
+struct cygnus_pcie_phy_core {
+	struct device *dev;
+	void __iomem *base;
+	struct mutex lock;
+	struct cygnus_pcie_phy phys[MAX_NUM_PHYS];
+};
+
+static int cygnus_pcie_power_config(struct cygnus_pcie_phy *phy, bool enable)
+{
+	struct cygnus_pcie_phy_core *core = phy->core;
+	unsigned shift;
+	u32 val;
+
+	mutex_lock(&core->lock);
+
+	switch (phy->id) {
+	case CYGNUS_PHY_PCIE0:
+		shift = PCIE0_PHY_IDDQ_SHIFT;
+		break;
+
+	case CYGNUS_PHY_PCIE1:
+		shift = PCIE1_PHY_IDDQ_SHIFT;
+		break;
+
+	default:
+		mutex_unlock(&core->lock);
+		dev_err(core->dev, "PCIe PHY %d invalid\n", phy->id);
+		return -EINVAL;
+	}
+
+	if (enable) {
+		val = readl(core->base + PCIE_CFG_OFFSET);
+		val &= ~BIT(shift);
+		writel(val, core->base + PCIE_CFG_OFFSET);
+		/*
+		 * Wait 50 ms for the PCIe Serdes to stabilize after the analog
+		 * front end is brought up
+		 */
+		msleep(50);
+	} else {
+		val = readl(core->base + PCIE_CFG_OFFSET);
+		val |= BIT(shift);
+		writel(val, core->base + PCIE_CFG_OFFSET);
+	}
+
+	mutex_unlock(&core->lock);
+	dev_dbg(core->dev, "PCIe PHY %d %s\n", phy->id,
+		enable ? "enabled" : "disabled");
+	return 0;
+}
+
+static int cygnus_pcie_phy_power_on(struct phy *p)
+{
+	struct cygnus_pcie_phy *phy = phy_get_drvdata(p);
+
+	return cygnus_pcie_power_config(phy, true);
+}
+
+static int cygnus_pcie_phy_power_off(struct phy *p)
+{
+	struct cygnus_pcie_phy *phy = phy_get_drvdata(p);
+
+	return cygnus_pcie_power_config(phy, false);
+}
+
+static struct phy_ops cygnus_pcie_phy_ops = {
+	.power_on = cygnus_pcie_phy_power_on,
+	.power_off = cygnus_pcie_phy_power_off,
+	.owner = THIS_MODULE,
+};
+
+static int cygnus_pcie_phy_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct device_node *node = dev->of_node, *child;
+	struct cygnus_pcie_phy_core *core;
+	struct phy_provider *provider;
+	struct resource *res;
+	unsigned cnt = 0;
+
+	if (of_get_child_count(node) == 0) {
+		dev_err(dev, "PHY no child node\n");
+		return -ENODEV;
+	}
+
+	core = devm_kzalloc(dev, sizeof(*core), GFP_KERNEL);
+	if (!core)
+		return -ENOMEM;
+
+	core->dev = dev;
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	core->base = devm_ioremap_resource(dev, res);
+	if (IS_ERR(core->base))
+		return PTR_ERR(core->base);
+
+	mutex_init(&core->lock);
+
+	for_each_available_child_of_node(node, child) {
+		unsigned int id;
+		struct cygnus_pcie_phy *p;
+
+		if (of_property_read_u32(child, "reg", &id)) {
+			dev_err(dev, "missing reg property for %s\n",
+				child->name);
+			return -EINVAL;
+		}
+
+		if (id >= MAX_NUM_PHYS) {
+			dev_err(dev, "invalid PHY id: %u\n", id);
+			return -EINVAL;
+		}
+
+		if (core->phys[id].phy) {
+			dev_err(dev, "duplicated PHY id: %u\n", id);
+			return -EINVAL;
+		}
+
+		p = &core->phys[id];
+		p->phy = devm_phy_create(dev, child, &cygnus_pcie_phy_ops);
+		if (IS_ERR(p->phy)) {
+			dev_err(dev, "failed to create PHY\n");
+			return PTR_ERR(p->phy);
+		}
+
+		p->core = core;
+		p->id = id;
+		phy_set_drvdata(p->phy, p);
+		cnt++;
+	}
+
+	dev_set_drvdata(dev, core);
+
+	provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+	if (IS_ERR(provider)) {
+		dev_err(dev, "failed to register PHY provider\n");
+		return PTR_ERR(provider);
+	}
+
+	dev_dbg(dev, "registered %u PCIe PHY(s)\n", cnt);
+
+	return 0;
+}
+
+static const struct of_device_id cygnus_pcie_phy_match_table[] = {
+	{ .compatible = "brcm,cygnus-pcie-phy" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, cygnus_pcie_phy_match_table);
+
+static struct platform_driver cygnus_pcie_phy_driver = {
+	.driver = {
+		.name = "cygnus-pcie-phy",
+		.of_match_table = cygnus_pcie_phy_match_table,
+	},
+	.probe = cygnus_pcie_phy_probe,
+};
+module_platform_driver(cygnus_pcie_phy_driver);
+
+MODULE_AUTHOR("Ray Jui <[email protected]>");
+MODULE_DESCRIPTION("Broadcom Cygnus PCIe PHY driver");
+MODULE_LICENSE("GPL v2");
author maintainer
#4 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

Hi Kishon,

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

Quoted 5 lines

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

We have a pool of maintainers to maintain all iProc based device drivers (including this PCIe PHY driver for Cygnus):

BROADCOM IPROC ARM ARCHITECTURE

M:      Ray Jui <[email protected]>
M:      Scott Branden <[email protected]>
M:      Jon Mason <[email protected]>
L:      [email protected] (moderated for non-subscribers)
L:      [email protected]
T:      git git://github.com/broadcom/cygnus-linux.git
S:      Maintained
N:      iproc
N:      cygnus
N:      nsp

...
...

That should be sufficient, correct?

Thanks,

Ray

#5 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

Hi,

Quoted 35 lines · Ray Jui

Hi Kishon,

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

Quoted 5 lines

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

We have a pool of maintainers to maintain all iProc based device drivers (including this PCIe PHY driver for Cygnus):

BROADCOM IPROC ARM ARCHITECTURE

M:      Ray Jui <[email protected]>
M:      Scott Branden <[email protected]>
M:      Jon Mason <[email protected]>
L:      [email protected] (moderated for non-subscribers)
L:      [email protected]
T:      git git://github.com/broadcom/cygnus-linux.git
S:      Maintained
N:      iproc
N:      cygnus
N:      nsp
Quoted 4 lines

...
...

That should be sufficient, correct?

yes. I think you might still have to add this?
F: drivers/phy/phy-bcm-cygnus-pcie.c

Thanks
Kishon

#6 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

Quoted 41 lines · Kishon Vijay Abraham I

Hi,

Quoted 38 lines · Ray Jui

Hi Kishon,

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

Quoted 5 lines

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

We have a pool of maintainers to maintain all iProc based device drivers (including this PCIe PHY driver for Cygnus):

BROADCOM IPROC ARM ARCHITECTURE

M:      Ray Jui <[email protected]>
M:      Scott Branden <[email protected]>
M:      Jon Mason <[email protected]>
L:      [email protected] (moderated for non-subscribers)
L:      [email protected]
T:      git git://github.com/broadcom/cygnus-linux.git
S:      Maintained
N:      iproc
N:      cygnus
N:      nsp

...
...

Quoted 4 lines
Quoted 1 line

That should be sufficient, correct?

yes. I think you might still have to add this?
F: drivers/phy/phy-bcm-cygnus-pcie.c

The regular expression should already cover that file, what would be the benefit of explicitly listing this additional file?

Signature · 1 line
Florian
#7 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

Hi.

Quoted 42 lines · Florian Fainelli
Quoted 41 lines · Kishon Vijay Abraham I

Hi,

Quoted 38 lines · Ray Jui

Hi Kishon,

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

Quoted 5 lines

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

We have a pool of maintainers to maintain all iProc based device drivers (including this PCIe PHY driver for Cygnus):

BROADCOM IPROC ARM ARCHITECTURE

M:      Ray Jui <[email protected]>
M:      Scott Branden <[email protected]>
M:      Jon Mason <[email protected]>
L:      [email protected] (moderated for non-subscribers)
L:      [email protected]
T:      git git://github.com/broadcom/cygnus-linux.git
S:      Maintained
N:      iproc
N:      cygnus
N:      nsp

...
...

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

That should be sufficient, correct?

yes. I think you might still have to add this?
F: drivers/phy/phy-bcm-cygnus-pcie.c

The regular expression should already cover that file, what would be the benefit of explicitly listing this additional file?

Indeed. Sorry for the noise.

Thanks
Kishon

author maintainer
#8 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

In reply to Kishon Vijay Abraham I
Quoted 41 lines · Kishon Vijay Abraham I

Hi,

Quoted 38 lines · Ray Jui

Hi Kishon,

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

Quoted 5 lines

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

We have a pool of maintainers to maintain all iProc based device drivers (including this PCIe PHY driver for Cygnus):

BROADCOM IPROC ARM ARCHITECTURE

M:      Ray Jui <[email protected]>
M:      Scott Branden <[email protected]>
M:      Jon Mason <[email protected]>
L:      [email protected] (moderated for non-subscribers)
L:      [email protected]
T:      git git://github.com/broadcom/cygnus-linux.git
S:      Maintained
N:      iproc
N:      cygnus
N:      nsp

...
...

Quoted 8 lines
Quoted 1 line

That should be sufficient, correct?

yes. I think you might still have to add this?
F: drivers/phy/phy-bcm-cygnus-pcie.c

Thanks
Kishon

I think the following should already helped to take care of it?
N: cygnus

Ray

#9 lore raw

Re: [PATCH v5 2/2] phy: cygnus: pcie: Add Cygnus PCIe PHY support

Quoted 49 lines · Ray Jui
Quoted 46 lines · Kishon Vijay Abraham I

Hi,

Quoted 35 lines · Ray Jui

Hi Kishon,

Quoted 12 lines · Kishon Vijay Abraham I

Hi,

Quoted 7 lines · Ray Jui

This patch adds the PCIe PHY support for the Broadcom PCIe RC interface on Cygnus

Quoted 5 lines

merged this driver to linux-phy tree. Can you send a separate patch adding yourself as the maintainer of this driver?

Thanks
Kishon

We have a pool of maintainers to maintain all iProc based device drivers (including this PCIe PHY driver for Cygnus):

BROADCOM IPROC ARM ARCHITECTURE

M:      Ray Jui <[email protected]>
M:      Scott Branden <[email protected]>
M:      Jon Mason <[email protected]>
L:      [email protected] (moderated for non-subscribers)
L:      [email protected]
T:      git git://github.com/broadcom/cygnus-linux.git
S:      Maintained
N:      iproc
N:      cygnus
N:      nsp
Quoted 4 lines

...
...

That should be sufficient, correct?

yes. I think you might still have to add this?
F: drivers/phy/phy-bcm-cygnus-pcie.c

Quoted 6 lines
Quoted 3 lines

Thanks
Kishon

I think the following should already helped to take care of it?
N: cygnus

yes.. you are right!

-Kishon

author maintainer
#10 lore raw
In reply to Ray Jui

Hi Kishon,

Is there any more change that you want me to make with this patch series?

Thanks,

Ray

Quoted 39 lines · Ray Jui

This patch series adds support for the Cygnus PCIe PHY

This patch series is based on Linux v4.3-rc1 and is avaliable in:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-v5

Changes from v4:
- Add comment to explain the required 50 ms wait after PCIe AFE is brought
up
- Change some of 'dev_info' print to 'dev_dbg'

Changes from v3:
- Modify the driver to use child node to represent each PCIe PHY
- Update device tree binding document and examples accordingly
- Add owner filed in phy ops

Changes from v2:
- Dropped MDC/MDIO bus driver since it's not needed to enable/disable the analog-front-end of the PCIe Serdes on Cygnus
- Optimized delay waiting for PCIe analog-front-end to be fully enabled
- Reduce the #phy-cell to 1 since now the MDIO PHY ID is not required

Changes from v1:
- Move the MDC/MDIO bus driver from drivers/phy/* to drivers/bus/*
- Make the PCIe PHY device node child node of the MDIO bus
- Change the PCIe PHY driver to tristate so it can be compiled as a module
- Other minor changes

Ray Jui (2):
dt-bindings: Add Cygnus PCIe PHY binding doc
phy: cygnus: pcie: Add Cygnus PCIe PHY support

 .../bindings/phy/brcm,cygnus-pcie-phy.txt          |  47 +++++
 drivers/phy/Kconfig                                |   9 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/phy-bcm-cygnus-pcie.c                  | 213 +++++++++++++++++++++
 4 files changed, 270 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
 create mode 100644 drivers/phy/phy-bcm-cygnus-pcie.c
#11 lore raw

Hi,

Quoted 3 lines · Ray Jui

Hi Kishon,

Is there any more change that you want me to make with this patch series?

Nope. The patch looks good, I'll be merging it soonish.

Thanks
Kishon

Quoted 45 lines

Thanks,

Ray

Quoted 39 lines · Ray Jui

This patch series adds support for the Cygnus PCIe PHY

This patch series is based on Linux v4.3-rc1 and is avaliable in:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-v5

Changes from v4:
- Add comment to explain the required 50 ms wait after PCIe AFE is brought
up
- Change some of 'dev_info' print to 'dev_dbg'

Changes from v3:
- Modify the driver to use child node to represent each PCIe PHY
- Update device tree binding document and examples accordingly
- Add owner filed in phy ops

Changes from v2:
- Dropped MDC/MDIO bus driver since it's not needed to enable/disable the analog-front-end of the PCIe Serdes on Cygnus
- Optimized delay waiting for PCIe analog-front-end to be fully enabled
- Reduce the #phy-cell to 1 since now the MDIO PHY ID is not required

Changes from v1:
- Move the MDC/MDIO bus driver from drivers/phy/* to drivers/bus/*
- Make the PCIe PHY device node child node of the MDIO bus
- Change the PCIe PHY driver to tristate so it can be compiled as a module
- Other minor changes

Ray Jui (2):
dt-bindings: Add Cygnus PCIe PHY binding doc
phy: cygnus: pcie: Add Cygnus PCIe PHY support

 .../bindings/phy/brcm,cygnus-pcie-phy.txt          |  47 +++++
 drivers/phy/Kconfig                                |   9 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/phy-bcm-cygnus-pcie.c                  | 213 +++++++++++++++++++++
 4 files changed, 270 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
 create mode 100644 drivers/phy/phy-bcm-cygnus-pcie.c