net: dsa: add missing kfree on remove

PATCH In review Neil Armstrong 1 participant 1 message Oct 6, 2015

Subsystems (3)

Networking Network drivers Networking DSA

lore

Share & tools

lore

Neil Armstrong

author

2015-10-06 14:39 UTC #0 lore raw

PATCH v3 1/5 net: dsa: add missing kfree on remove

To prevent memory leakage on unbinding, add missing kfree calls. Includes minor cosmetic change to make patch clean.

Signed-off-by Neil Armstrong <[email protected]>

---
 net/dsa/dsa.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

net/dsa/dsa.c +4 -1

index c59fa5d..ed9d43f 100644
@@ -914,8 +914,10 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
 	for (i = 0; i < dst->pd->nr_chips; i++) {
 		struct dsa_switch *ds = dst->ds[i];
 
-		if (ds != NULL)
+		if (ds) {
 			dsa_switch_destroy(ds);
+			kfree(ds);
+		}
 	}
 }

@@ -924,6 +926,7 @@ static int dsa_remove(struct platform_device *pdev)
 	struct dsa_switch_tree *dst = platform_get_drvdata(pdev);
 
 	dsa_remove_dst(dst);
+	kfree(dst);
 	dsa_of_remove(&pdev->dev);
 
 	return 0;

Signature · 1 line

1.9.1