net: wireless: ath: Remove unneeded variable ret returning 0

PATCH Superseded Punit Vara 3 participants 5 messages Oct 22, 2015 – Oct 27, 2015

Subsystems (3)

Networking Network drivers Qualcomm WCN36XX wireless driver

lore

Share & tools

lore

Punit Vara

author

2015-10-22 18:47 UTC #0 lore raw

PATCH v4 14/15 net: wireless: ath: Remove unneeded variable ret returning 0

Remove black line suggested by Sergei

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck:

Unneeded variable: "ret". Return "0" on line 980

Remove unneeded variable ret created to return zero.

Signed-off-by Punit Vara <[email protected]>

---
 drivers/net/wireless/ath/wcn36xx/main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/net/wireless/ath/wcn36xx/main.c +1 -3

index 900e72a..94bcc08 100644
@@ -935,8 +935,6 @@ static const struct ieee80211_ops wcn36xx_ops = {
 
 static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
 {
-	int ret = 0;
-
 	static const u32 cipher_suites[] = {
 		WLAN_CIPHER_SUITE_WEP40,
 		WLAN_CIPHER_SUITE_WEP104,

@@ -977,7 +975,7 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
 	wcn->hw->sta_data_size = sizeof(struct wcn36xx_sta);
 	wcn->hw->vif_data_size = sizeof(struct wcn36xx_vif);
 
-	return ret;
+	return 0;
 }
 
 static int wcn36xx_platform_get_resources(struct wcn36xx *wcn,

Signature · 1 line

2.5.3

Sergei Shtylyov

2015-10-22 18:56 UTC #1 lore raw

Quoted 1 line · Punit Vara

Remove black line suggested by Sergei

Such kind of comments should be under the --- tear line.

Quoted 9 lines

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck:
Unneeded variable: "ret". Return "0" on line 980
Remove unneeded variable ret created to return zero.
Signed-off-by Punit Vara <[email protected]>

[...]

MBR, Sergei

punit vara

author

2015-10-26 20:00 UTC #2 lore raw

Quoted 13 lines · Sergei Shtylyov

Quoted 1 line · Punit Vara
Remove black line suggested by Sergei
Such kind of comments should be under the --- tear line.
Quoted 6 lines
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck:
Unneeded variable: "ret". Return "0" on line 980

Quoted 8 lines

Quoted 3 lines
Remove unneeded variable ret created to return zero.
Signed-off-by Punit Vara <[email protected]>
[...]
MBR, Sergei

Thanks you Sergei for review.

Actually I didnt know You have replied to this mail because this was gone in some other folder of my mail box .. I will send this patch again as you suggested . Will my other patches which are already correct be added to wireless tree ? or I have to resend everything ?

Kalle Valo

2015-10-27 08:12 UTC #3 lore raw

Quoted 2 lines · punit vara

Will my other patches which are already correct be added to wireless tree ? or I have to resend everything ?

Yes, please resend the whole patchset. I don't apply patches individually from a patchset, it's just too time consuming and error prone.

Also, as you seem to be new here, I don't recommend sending big patchsets in the beginning. Start slow, send just few a patch or two at a time, and once you gain more experience send bigger patchsets.

Signature · 1 line

Kalle Valo

punit vara

author

2015-10-27 19:09 UTC #4 lore raw

Quoted 9 lines · Kalle Valo

Quoted 2 lines · punit vara
Will my other patches which are already correct be added to wireless tree ? or I have to resend everything ?
Yes, please resend the whole patchset. I don't apply patches individually from a patchset, it's just too time consuming and error prone.

Quoted 6 lines

Also, as you seem to be new here, I don't recommend sending big patchsets in the beginning. Start slow, send just few a patch or two at a time, and once you gain more experience send bigger patchsets.
--
Kalle Valo

Next time I will send 2-3 patches only . This time I have resent you all the patches that I have created before . Thank you for suggestion.