Skip to contentSkip to conversation

leds: avoid module usage in non-modular code

PATCH In review Paul Gortmaker 3 participants 6 messages Dec 13, 2015 – Dec 15, 2015 LED

lore
Share & tools
lore
#0 lore raw

cover leds: avoid module usage in non-modular code

This series of commits is a part of a larger project to ensure people don't reference modular support functions in non-modular code. Overall there was roughly 5k lines of dead code in the kernel due to this. So far we've fixed several areas, like tty, x86, net, ... and we continue to work on other areas.

There are several reasons to not use module support for code that can never be built as a module, but the big ones are:

(1) it is easy to accidentally code up unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn includes nearly everything else.

For the LED subsystem, there are just three commits. Two are basically trivial remapping to the appropriate non-modular counterparts. The third also has a change to block driver unbinding since that doesn't make any sense and it allows us to delete the .remove code. We've already made similar unbind changes like this in drivers/tty.

Patches created on linux-next and build tested for ARM allmodconfig.

Paul.
---

Cc Bryan Wu <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Jacek Anaszewski <[email protected]>
Cc Richard Purdie <[email protected]>

Paul Gortmaker (3):
drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular drivers/leds: make leds-syscon.c explicitly non-modular

 drivers/leds/leds-syscon.c              | 18 +++---------------
 drivers/leds/trigger/ledtrig-cpu.c      | 26 +-------------------------
 drivers/leds/trigger/ledtrig-ide-disk.c | 14 +-------------
 3 files changed, 5 insertions(+), 53 deletions(-)
Signature · 1 line
2.6.1
#1 lore raw

PATCH 1/3 drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular

The Kconfig for this driver is currently:

config LEDS_TRIGGER_CPU
bool "LED CPU Trigger"

...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments.

Cc Bryan Wu <[email protected]>
Cc Richard Purdie <[email protected]>
Cc Jacek Anaszewski <[email protected]>
Cc Linus Walleij <[email protected]>
---
 drivers/leds/trigger/ledtrig-cpu.c | 26 +-------------------------
 1 file changed, 1 insertion(+), 25 deletions(-)
drivers/leds/trigger/ledtrig-cpu.c +1 -25
index aec0f02b6b3e..938467fb82be 100644
@@ -19,7 +19,6 @@
  *
  */
 
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/slab.h>
@@ -140,27 +139,4 @@ static int __init ledtrig_cpu_init(void)
 
 	return 0;
 }
-module_init(ledtrig_cpu_init);
-
-static void __exit ledtrig_cpu_exit(void)
-{
-	int cpu;
-
-	unregister_cpu_notifier(&ledtrig_cpu_nb);
-
-	for_each_possible_cpu(cpu) {
-		struct led_trigger_cpu *trig = &per_cpu(cpu_trig, cpu);
-
-		led_trigger_unregister_simple(trig->_trig);
-		trig->_trig = NULL;
-		memset(trig->name, 0, MAX_NAME_LEN);
-	}
-
-	unregister_syscore_ops(&ledtrig_cpu_syscore_ops);
-}
-module_exit(ledtrig_cpu_exit);
-
-MODULE_AUTHOR("Linus Walleij <[email protected]>");
-MODULE_AUTHOR("Bryan Wu <[email protected]>");
-MODULE_DESCRIPTION("CPU LED trigger");
-MODULE_LICENSE("GPL");
+device_initcall(ledtrig_cpu_init);
Signature · 1 line
2.6.1
Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular

Quoted 15 lines · Paul Gortmaker

The Kconfig for this driver is currently:

config LEDS_TRIGGER_CPU
bool "LED CPU Trigger"

...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments.

Quoted 6 lines
Cc Bryan Wu <[email protected]>
Cc Richard Purdie <[email protected]>
Cc Jacek Anaszewski <[email protected]>
Cc Linus Walleij <[email protected]>

Yours,
Linus Walleij

#3 lore raw

PATCH 2/3 drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular

In reply to Paul Gortmaker

The Kconfig for this driver is currently:

config LEDS_TRIGGER_IDE_DISK
bool "LED IDE Disk Trigger"

...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments.

Cc Bryan Wu <[email protected]>
Cc Richard Purdie <[email protected]>
Cc Jacek Anaszewski <[email protected]>
---
 drivers/leds/trigger/ledtrig-ide-disk.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/leds/trigger/ledtrig-ide-disk.c +1 -13
index 2cd7c0cf5924..c02a3ac3cd2b 100644
@@ -11,7 +11,6 @@
  *
  */
 
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/leds.h>
@@ -33,15 +32,4 @@ static int __init ledtrig_ide_init(void)
 	led_trigger_register_simple("ide-disk", &ledtrig_ide);
 	return 0;
 }
-
-static void __exit ledtrig_ide_exit(void)
-{
-	led_trigger_unregister_simple(ledtrig_ide);
-}
-
-module_init(ledtrig_ide_init);
-module_exit(ledtrig_ide_exit);
-
-MODULE_AUTHOR("Richard Purdie <[email protected]>");
-MODULE_DESCRIPTION("LED IDE Disk Activity Trigger");
-MODULE_LICENSE("GPL");
+device_initcall(ledtrig_ide_init);
Signature · 1 line
2.6.1
#4 lore raw

PATCH 3/3 drivers/leds: make leds-syscon.c explicitly non-modular

In reply to Paul Gortmaker

The Kconfig currently controlling compilation of this code is:

drivers/leds/Kconfig:config LEDS_SYSCON
drivers/leds/Kconfig: bool "LED support for LEDs on system controllers"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers.

Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

---
 drivers/leds/leds-syscon.c | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)
drivers/leds/leds-syscon.c +3 -15
index b88900d721e4..3be40f74f12a 100644
@@ -20,7 +20,7 @@
  * MA 02111-1307 USA
  */
 #include <linux/io.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/of_device.h>
 #include <linux/of_address.h>
 #include <linux/platform_device.h>
@@ -139,29 +139,17 @@ static int syscon_led_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int syscon_led_remove(struct platform_device *pdev)
-{
-	struct syscon_led *sled = platform_get_drvdata(pdev);
-
-	led_classdev_unregister(&sled->cdev);
-	/* Turn it off */
-	regmap_update_bits(sled->map, sled->offset, sled->mask, 0);
-	return 0;
-}
-
 static const struct of_device_id of_syscon_leds_match[] = {
 	{ .compatible = "register-bit-led", },
 	{},
 };
 
-MODULE_DEVICE_TABLE(of, of_syscon_leds_match);
-
 static struct platform_driver syscon_led_driver = {
 	.probe		= syscon_led_probe,
-	.remove		= syscon_led_remove,
 	.driver		= {
 		.name	= "leds-syscon",
 		.of_match_table = of_syscon_leds_match,
+		.suppress_bind_attrs = true,
 	},
 };
-module_platform_driver(syscon_led_driver);
+builtin_platform_driver(syscon_led_driver);
Signature · 1 line
2.6.1
#5 lore raw
In reply to Paul Gortmaker
Quoted 37 lines · Paul Gortmaker

This series of commits is a part of a larger project to ensure people don't reference modular support functions in non-modular code. Overall there was roughly 5k lines of dead code in the kernel due to this. So far we've fixed several areas, like tty, x86, net, ... and we continue to work on other areas.

There are several reasons to not use module support for code that can never be built as a module, but the big ones are:

(1) it is easy to accidentally code up unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn includes nearly everything else.

For the LED subsystem, there are just three commits. Two are basically trivial remapping to the appropriate non-modular counterparts. The third also has a change to block driver unbinding since that doesn't make any sense and it allows us to delete the .remove code. We've already made similar unbind changes like this in drivers/tty.

Patches created on linux-next and build tested for ARM allmodconfig.

Paul.
---

Cc Bryan Wu <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Jacek Anaszewski <[email protected]>
Cc Richard Purdie <[email protected]>

Paul Gortmaker (3):
drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular drivers/leds: make leds-syscon.c explicitly non-modular

Quoted 5 lines
  drivers/leds/leds-syscon.c              | 18 +++---------------
  drivers/leds/trigger/ledtrig-cpu.c      | 26 +-------------------------
  drivers/leds/trigger/ledtrig-ide-disk.c | 14 +-------------
  3 files changed, 5 insertions(+), 53 deletions(-)

Patch set applied, thanks.

Signature · 2 lines
Best Regards,
Jacek Anaszewski