arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for compressed kernel image
PATCH v4 1/1 arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for compressed kernel image
The COMPRESSED_INSTALL kconfig does not sound very meaningful.
Rename from COMPRESSED_INSTALL kconfig to KERNEL_IMAGE_COMPRESSED_INSTALL.
--- arch/arm64/Kconfig | 6 +++--- arch/arm64/Makefile | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/Kconfig +3 -3
@@ -2337,11 +2337,11 @@ config EFI allow the kernel to be booted as an EFI application. This is only useful on systems that have UEFI firmware. -config COMPRESSED_INSTALL - bool "Install compressed image by default" +config KERNEL_IMAGE_COMPRESSED_INSTALL + bool "Install compressed kernel image by default" help This makes the regular "make install" install the compressed - image we built, not the legacy uncompressed one. + kernel image we built, not the legacy uncompressed one. You can check that a compressed image works for you by doing "make zinstall" first, and verifying that everything is fine
arch/arm64/Makefile +3 -3
@@ -182,7 +182,7 @@ $(BOOT_TARGETS): vmlinux Image.%: Image $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ -ifeq ($(CONFIG_COMPRESSED_INSTALL),y) +ifeq ($(CONFIG_KERNEL_IMAGE_COMPRESSED_INSTALL),y) DEFAULT_KBUILD_IMAGE = $(KBUILD_IMAGE) else DEFAULT_KBUILD_IMAGE = $(boot)/Image
@@ -235,8 +235,8 @@ define archhelp echo '* Image.gz - Compressed kernel image (arch/$(ARCH)/boot/Image.gz)' echo ' Image - Uncompressed kernel image (arch/$(ARCH)/boot/Image)' echo ' image.fit - Flat Image Tree (arch/$(ARCH)/boot/image.fit)' - echo ' install - Install kernel (compressed if COMPRESSED_INSTALL set)' - echo ' zinstall - Install compressed kernel' + echo ' install - Install kernel image (compressed if KERNEL_IMAGE_COMPRESSED_INSTALL is set)' + echo ' zinstall - Install compressed kernel image' echo ' Install using (your) ~/bin/installkernel or' echo ' (distribution) /sbin/installkernel or' echo ' install to $$(INSTALL_PATH) and run lilo'
Signature · 1 line
2.45.2
Will Deacon
maintainerQuoted 10 lines · Sedat Dilek
The
COMPRESSED_INSTALLkconfig does not sound very meaningful.Rename from
COMPRESSED_INSTALLkconfig toKERNEL_IMAGE_COMPRESSED_INSTALL.Fixes commit 4c7be57f2 ("arm64: allow installing compressed image by default")Signed-off-by Sedat Dilek <[email protected]>--- arch/arm64/Kconfig | 6 +++--- arch/arm64/Makefile | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
Hmm, I'm not sure I see the point of this tbh. I think the code is fine as it is.
Will
Quoted 6 lines · Will Deacon
Quoted 5 lines · Sedat Dilek
The
COMPRESSED_INSTALLkconfig does not sound very meaningful.Rename from
COMPRESSED_INSTALLkconfig toKERNEL_IMAGE_COMPRESSED_INSTALL.Fixes commit 4c7be57f2 ("arm64: allow installing compressed image by default")
"Fixes:" tag should only be used for patches that fix real functional problems in the code.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Sedat Dilek <[email protected]>--- arch/arm64/Kconfig | 6 +++--- arch/arm64/Makefile | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)Hmm, I'm not sure I see the point of this tbh. I think the code is fine as it is.
Agreed, only thing this patch does is to add "kernel image" prefix in the config as well in related descriptions which in itself does not make this any better. As Will mentioned, it is better to leave this unchanged.