Skip to contentSkip to conversation

ARM: dts: Add operating-points-v2 tables for TI platforms

PATCH Superseded Dave Gerlach 2 participants 7 messages Sep 1, 2016 – Sep 14, 2016 Device tree bindings

lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: Add operating-points-v2 tables for TI platforms

Hi,
This is v2 of the series to add operating-points-v2 tables for am335x, am437x, dra7, and am57x platforms, but really just updates the already merged v1 found here [1].

It seems v1 was merged without the binding being finalized so this series just updates the nodes that are already present in order to work with the new bindings coming in v2 of the ti-cpufreq driver series which will follow shortly.

Regards,
Dave

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/430205.html

Dave Gerlach (3):
ARM: dts: am33xx: Change operating-points-v2 table to am3352 version
ARM: dts: am4372: Change operating-points-v2 table to am4372 version
ARM: dts: dra7: Change operating-points-v2 table to dra7 version

 arch/arm/boot/dts/am33xx.dtsi | 2 +-
 arch/arm/boot/dts/am4372.dtsi | 2 +-
 arch/arm/boot/dts/dra7.dtsi   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.9.0
#1 lore raw

PATCH v2 1/3 ARM: dts: am33xx: Change operating-points-v2 table to am3352 version

The operating-points-v2 table got merged before the binding had stabilized so update the compatible string to am3352 version.

---
 arch/arm/boot/dts/am33xx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am33xx.dtsi +1 -1
index 98748c61ed99..a07212914130 100644
@@ -57,7 +57,7 @@
 	};
 
 	cpu0_opp_table: opp_table0 {
-		compatible = "operating-points-v2";
+		compatible = "operating-points-v2-ti-am3352-cpu";
 
 		/*
 		 * The three following nodes are marked with opp-suspend
Signature · 1 line
2.9.0
#2 lore raw

PATCH v2 2/3 ARM: dts: am4372: Change operating-points-v2 table to am4372 version

In reply to Dave Gerlach

The operating-points-v2 table got merged before the binding had stabilized so update the compatible string to am4372 version.

---
 arch/arm/boot/dts/am4372.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am4372.dtsi +1 -1
index 0fadae5396e1..cdadcd793229 100644
@@ -53,7 +53,7 @@
 	};
 
 	cpu0_opp_table: opp_table0 {
-		compatible = "operating-points-v2";
+		compatible = "operating-points-v2-ti-am4372-cpu";
 
 		opp50 at 300000000 {
 			opp-hz = /bits/ 64 <300000000>;
Signature · 1 line
2.9.0
#3 lore raw

PATCH v2 3/3 ARM: dts: dra7: Change operating-points-v2 table to dra7 version

In reply to Dave Gerlach

The operating-points-v2 table got merged before the binding had stabilized so update the compatible string to dra7 version.

---
 arch/arm/boot/dts/dra7.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/dra7.dtsi +1 -1
index d9bfb94a2992..c138eca85efd 100644
@@ -99,7 +99,7 @@
 	};
 
 	cpu0_opp_table: opp_table0 {
-		compatible = "operating-points-v2";
+		compatible = "operating-points-v2-ti-dra7-cpu";
 		opp-shared;
 
 		opp_nom at 1000000000 {
Signature · 1 line
2.9.0
#4 lore raw

v2 cover ARM: dts: Add operating-points-v2 tables for TI platforms

In reply to Dave Gerlach

Hi,

Quoted 9 lines · Dave Gerlach

Hi,
This is v2 of the series to add operating-points-v2 tables for am335x, am437x, dra7, and am57x platforms, but really just updates the already merged v1 found here [1].

It seems v1 was merged without the binding being finalized so this series just updates the nodes that are already present in order to work with the new bindings coming in v2 of the ti-cpufreq driver series which will follow shortly.

Assuming this will have to wait based on what you mentioned about am335x cpufreq regression. I guess you'll instead send few patches to revert?

Regards,

Tony

Quoted 15 lines

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/430205.html

Dave Gerlach (3):
ARM: dts: am33xx: Change operating-points-v2 table to am3352 version
ARM: dts: am4372: Change operating-points-v2 table to am4372 version
ARM: dts: dra7: Change operating-points-v2 table to dra7 version

 arch/arm/boot/dts/am33xx.dtsi | 2 +-
 arch/arm/boot/dts/am4372.dtsi | 2 +-
 arch/arm/boot/dts/dra7.dtsi   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.9.0
#5 lore raw

v2 cover ARM: dts: Add operating-points-v2 tables for TI platforms

Hi Tony,

Quoted 8 lines · Tony Lindgren

Hi,

Quoted 5 lines · Dave Gerlach

Hi,
This is v2 of the series to add operating-points-v2 tables for am335x, am437x, dra7, and am57x platforms, but really just updates the already merged v1 found here [1].

Quoted 9 lines
Quoted 4 lines

It seems v1 was merged without the binding being finalized so this series just updates the nodes that are already present in order to work with the new bindings coming in v2 of the ti-cpufreq driver series which will follow shortly.

Assuming this will have to wait based on what you mentioned about am335x cpufreq regression. I guess you'll instead send few patches to revert?

Correct, these should not be merged, I will be sending a fixup series until this series is ready.

I needed to resend the ti-cpufreq driver at [2] to get a response about the dt binding and other updates Viresh asked for and sent this to update the merged nodes so they would work with the driver. But the driver has not been merged yet, so in order to re-enable the previously existing cpufreq support on those platforms I must revert three patches from v1 [1] of this series that got merged, which I will send.

I also found that 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver") which went in v4.6-rc1 had already broken the existing cpufreq support on am335x and dra7xx, so it's been missing for some time. I can send a patch fixing that as well but I will need to remove it once the ti-cpufreq driver in [2] below gets merged as that driver must create the cpufreq-dt platform device instead of cpufreq-dt-platdev. So I will send a series that can fix cpufreq until ti-cpufreq is ready which will give us better support for more OPPs on am335x, am437x (which has no implementation today), and dra7xx.

Regards,
Dave

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/430205.html
[2] http://www.spinics.net/lists/devicetree/msg141152.html

Quoted 19 lines

Regards,

Tony

Quoted 15 lines

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/430205.html

Dave Gerlach (3):
ARM: dts: am33xx: Change operating-points-v2 table to am3352 version
ARM: dts: am4372: Change operating-points-v2 table to am4372 version
ARM: dts: dra7: Change operating-points-v2 table to dra7 version

  arch/arm/boot/dts/am33xx.dtsi | 2 +-
  arch/arm/boot/dts/am4372.dtsi | 2 +-
  arch/arm/boot/dts/dra7.dtsi   | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

--
2.9.0

#6 lore raw

v2 cover ARM: dts: Add operating-points-v2 tables for TI platforms

Quoted 8 lines · Dave Gerlach
Quoted 4 lines · Tony Lindgren

Assuming this will have to wait based on what you mentioned about am335x cpufreq regression. I guess you'll instead send few patches to revert?

Correct, these should not be merged, I will be sending a fixup series until this series is ready.

OK

Quoted 7 lines

I needed to resend the ti-cpufreq driver at [2] to get a response about the dt binding and other updates Viresh asked for and sent this to update the merged nodes so they would work with the driver. But the driver has not been merged yet, so in order to re-enable the previously existing cpufreq support on those platforms I must revert three patches from v1 [1] of this series that got merged, which I will send.

Quoted 8 lines

I also found that 7694ca6e1d6f ("cpufreq: omap: Use generic platdev driver") which went in v4.6-rc1 had already broken the existing cpufreq support on am335x and dra7xx, so it's been missing for some time. I can send a patch fixing that as well but I will need to remove it once the ti-cpufreq driver in [2] below gets merged as that driver must create the cpufreq-dt platform device instead of cpufreq-dt-platdev. So I will send a series that can fix cpufreq until ti-cpufreq is ready which will give us better support for more OPPs on am335x, am437x (which has no implementation today), and dra7xx.

OK yeah let's fix the regression & thanks for the update.

Regards,

Tony