usbredir: free vm_change_state_handler in usbredir destroy dispatch
PATCH 1/1 usbredir: free vm_change_state_handler in usbredir destroy dispatch
From: Li Qiang <[email protected]>
In usbredir destroy dispatch function, it doesn't free the vm change state handler once registered in usbredir_realize function. This will lead a memory leak issue. This patch avoid this.
Signed-off-by Li Qiang <[email protected]>
--- hw/usb/redirect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
hw/usb/redirect.c +4 -1
@@ -132,6 +132,7 @@ struct USBRedirDevice {struct usbredirfilter_rule *filter_rules;int filter_rules_count;int compatible_speedmask; +VMChangeStateEntry *vmstate; };#define TYPE_USB_REDIR "usb-redir"
@@ -1411,7 +1412,8 @@ static void usbredir_realize(USBDevice *udev, Error **errp) usbredir_chardev_read, usbredir_chardev_event, dev, NULL, true); -qemu_add_vm_change_state_handler (usbredir_vm_state_change, dev); + dev->vmstate = +qemu_add_vm_change_state_handler (usbredir_vm_state_change, dev); }static void usbredir_cleanup_device_queues (USBRedirDevice *dev)
@@ -1450,6 +1452,7 @@ static void usbredir_handle_destroy(USBDevice *udev) }free (dev->filter_rules); +qemu_del_vm_change_state_handler (dev->vmstate); }static int usbredir_check_filter (USBRedirDevice *dev)
Signature · 1 line
1.8.3.1
Hi
Quoted 8 lines · Li Qiang
From: Li Qiang <[email protected]>
In usbredir destroy dispatch function, it doesn't free the vm change state handler once registered in
usbredir_realizefunction. This will lead a memory leak issue. This patch avoid this.Signed-off-by Li Qiang <[email protected]>
Reviewed-by Marc-André Lureau <[email protected]>
Quoted 40 lines
--- hw/usb/redirect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)hw/usb/redirect.c +3
-1@@ -132,6 +132,7 @@ struct USBRedirDevice {struct usbredirfilter_rule *filter_rules;int filter_rules_count;int compatible_speedmask; +VMChangeStateEntry *vmstate; };#define TYPE_USB_REDIR "usb-redir"@@ -1411,7 +1412,8 @@ static void usbredir_realize(USBDevice *udev, Error **errp) usbredir_chardev_read, usbredir_chardev_event, dev, NULL, true); -qemu_add_vm_change_state_handler (usbredir_vm_state_change, dev); + dev->vmstate = +qemu_add_vm_change_state_handler (usbredir_vm_state_change, dev); }static void
usbredir_cleanup_device_queues(USBRedirDevice *dev)hw/usb/redirect.c +1
-1@@ -1450,6 +1452,7 @@ static void usbredir_handle_destroy(USBDevice *udev) }free (dev->filter_rules); +qemu_del_vm_change_state_handler (dev->vmstate); }static int usbredir_check_filter (USBRedirDevice *dev) --1.8.3.1
Quoted 1 line
--
Marc-André Lureau