drm/plane-helper: Add the missing declaration of drm_atomic_state
Subsystems (2)
PATCH RESEND 1/1 drm/plane-helper: Add the missing declaration of drm_atomic_state
Add the missing declaration of struct drm_atomic_state to fix the compile error below:
error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]
--- include/drm/drm_plane_helper.h | 1 + 1 file changed, 1 insertion(+)
include/drm/drm_plane_helper.h +1 -0
@@ -30,6 +30,7 @@ struct drm_crtc;struct drm_framebuffer ;struct drm_modeset_acquire_ctx ;struct drm_plane ; +struct drm_atomic_state ; int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc, struct drm_framebuffer *fb,
Signature · 1 line
2.25.1
Thomas Zimmermann
maintainerHi
Am 15.12.22 um 04:01 schrieb Ma Jun:
Quoted 16 lines
Add the missing declaration of struct
drm_atomic_stateto fix the compile error below:error: 'struct
drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]Signed-off-by Ma Jun <[email protected]>--- include/drm/drm_plane_helper.h | 1 + 1 file changed, 1 insertion(+)include/drm/drm_plane_helper.h +0
-0
include/drm/drm_plane_helper.h struct drm_crtc; · line 33
Quoted 4 lines
include/drm/drm_plane_helper.h +1
-0@@ -30,6 +30,7 @@ struct drm_crtc;struct drm_framebuffer ;struct drm_modeset_acquire_ctx ;struct drm_plane ; +struct drm_atomic_state ;
Thanks for the patch. Please sort the forward declarations alphabetically.
Best regards
Thomas
Quoted 3 lines
include/drm/drm_plane_helper.h +0
-0int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc, struct drm_framebuffer *fb,
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Quoted 14 lines · Thomas Zimmermann
Hi
Am 15.12.22 um 04:01 schrieb Ma Jun:
Quoted 11 lines
Add the missing declaration of struct
drm_atomic_stateto fix the compile error below:error: 'struct
drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]Signed-off-by Ma Jun <[email protected]>--- include/drm/drm_plane_helper.h | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
include/drm/drm_plane_helper.h struct drm_crtc; · line 33
Quoted 9 lines
include/drm/drm_plane_helper.h +1
-0@@ -30,6 +30,7 @@ struct drm_crtc;struct drm_framebuffer ;struct drm_modeset_acquire_ctx ;struct drm_plane ; +struct drm_atomic_state ;Thanks for the patch. Please sort the forward declarations alphabetically.
Thanks for review. Will fix in v2
Regards,
Ma Jun
Quoted 7 lines
Best regards
ThomasQuoted 3 lines
include/drm/drm_plane_helper.h +0
-0int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc, struct drm_framebuffer *fb,