arm64: Introduce CIX P1 (SKY1) SoC
Subsystems (4)
v4 cover arm64: Introduce CIX P1 (SKY1) SoC
Cixtech P1 (internal name sky1) is high performance generic Armv9 SoC. Orion O6 is the world's first open source Arm V9 Motherboard built by Radxa. You could find brief introduction for SoC and related boards at:
https://radxa.com/products/orion/o6#overview
In this series, we add initial SoC and board support for Kernel building. Patch 1-2: Add dt-binding doc for CIX and its sky1 SoC
Patch 3: add related maintainers entry
Patch 4-5: add Arm64 build support
Patch 6: add initial dts support for SoC and Orion O6 board
To run upstream kernel at Orion O6 board, you need to use BIOS released by Radxa:
https://docs.radxa.com/en/orion/o6/bios/install-bios
Changes for v4:
- Move add MAINTAINERS entry patch to the last, and add two dts files entry in it.
- Add three Krzysztof Kozlowski's Reviewed-by Tags
- For sky1.dtsi, makes below changes:
- Add ppi-partition entry for gic-v3 node, and let pmu-a520 and pmu-a720's interrupt entry get its handle
- Remove gic-v3's #redistributor-regions and redistributor-stride properties
- Change gic-v3's #interrupt-cells as 4, and change all interrupt specifiers accordingly
- Remove "arm,no-tick-in-suspend" for timer due to global counter is at always-on power domain
- Remove timer's clock frequency due to firmware has already set it
Changes for v3:
- Patch 1: Add Krzysztof Kozlowski's Acked-by Tag
- Patch 2: Add Krzysztof Kozlowski's Reviewed-by Tag
- Patch 6: Fix two dts coding sytle issues
Changes for v2:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=vendor-prefixes.yaml make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=arm/cix.yaml make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Re-order the patch set, and move vendor-perfixes to the 1st patch.
- Patch 4: Ordered Kconfig config entry by alpha-numerically
- Patch 5: Corrects the Ack tag's name
- Patch 6: see below.
1) Corrects the SoF tag's name
2) Fix several coding sytle issues
3) move linux,cma node to dts file
4) delete memory node, memory size is passed by firmware
5) delete uart2 node which will be added in future patches
6) Improve for pmu and cpu node to stands for more specific cpu model
7) Improve the timer node and add hypervisor virtual timer irq
Fugang Duan (1):
arm64: Kconfig: add ARCH_CIX for cix silicons
Peter Chen (5):
dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd.
dt-bindings: arm: add CIX P1 (SKY1) SoC
arm64: defconfig: Enable CIX SoC
arm64: dts: cix: add initial CIX P1(SKY1) dts support
MAINTAINERS: Add CIX SoC maintainer entry
.../devicetree/bindings/arm/cix.yaml | 26 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 10 + arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/cix/Makefile | 2 + arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 26 ++ arch/arm64/boot/dts/cix/sky1.dtsi | 222 ++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 9 files changed, 296 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/cix.yaml create mode 100644 arch/arm64/boot/dts/cix/Makefile create mode 100644 arch/arm64/boot/dts/cix/sky1-orion-o6.dts create mode 100644 arch/arm64/boot/dts/cix/sky1.dtsi
Signature · 1 line
2.25.1
PATCH v4 1/6 dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd.
CIX Technology Group Co., Ltd. is a high performance Arm SoC design company. Link: https://www.cixtech.com/.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -302,6 +302,8 @@ patternProperties: description: Cirrus Logic, Inc. "^cisco,.*": description: Cisco Systems, Inc. + "^cix,.*": + description: CIX Technology Group Co., Ltd. "^clockwork,.*": description: Clockwork Tech LLC "^cloos,.*":
Signature · 1 line
2.25.1
PATCH v4 2/6 dt-bindings: arm: add CIX P1 (SKY1) SoC
In reply to Peter ChenAdd device tree bindings for CIX P1 (Internal name sky1) Arm SoC, it consists several SoC models like CP8180, CD8180, etc.
--- .../devicetree/bindings/arm/cix.yaml | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/cix.yaml
Documentation/devicetree/bindings/arm/cix.yaml new file +26 -0
@@ -0,0 +1,26 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/cix.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: CIX platforms + +maintainers: + - Peter Chen <[email protected]> + - Fugang Duan <[email protected]> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Radxa Orion O6 + items: + - const: radxa,orion-o6 + - const: cix,sky1 + +additionalProperties: true + +...
Signature · 1 line
2.25.1
PATCH v4 3/6 arm64: Kconfig: add ARCH_CIX for cix silicons
In reply to Peter ChenFrom: Fugang Duan <[email protected]>
Add ARCH_CIX for CIX SoC series support.
---
Changes for v4:
- Add Krzysztof Kozlowski's Reviewed-by Tag
arch/arm64/Kconfig.platforms | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/Kconfig.platforms +6 -0
@@ -106,6 +106,12 @@ config ARCH_BLAIZE help This enables support for the Blaize SoC family +config ARCH_CIX + bool "Cixtech SoC family" + help + This enables support for the Cixtech SoC family, + like P1(sky1). + config ARCH_EXYNOS bool "Samsung Exynos SoC family" select COMMON_CLK_SAMSUNG
Signature · 1 line
2.25.1
PATCH v4 4/6 arm64: defconfig: Enable CIX SoC
In reply to Peter ChenEnable CIX SoC support at ARM64 defconfig
---
Changes for v4:
- Add Krzysztof Kozlowski's Reviewed-by Tag
arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -45,6 +45,7 @@ CONFIG_ARCH_BCMBCA=y CONFIG_ARCH_BRCMSTB=y CONFIG_ARCH_BERLIN=y CONFIG_ARCH_BLAIZE=y +CONFIG_ARCH_CIX=y CONFIG_ARCH_EXYNOS=y CONFIG_ARCH_SPARX5=y CONFIG_ARCH_K3=y
Signature · 1 line
2.25.1
PATCH v4 5/6 arm64: dts: cix: add initial CIX P1(SKY1) dts support
In reply to Peter ChenCIX SKY1 SoC is high performance Armv9 SoC designed by Cixtech, and Orion O6 is open source motherboard launched by Radxa. See below for detail:
https://docs.radxa.com/en/orion/o6/getting-started/introduction
In this commit, it only adds limited components for running initramfs at Orion O6.
---
Changes for v4:
- Add ppi-partition entry for gic-v3 node, and let pmu-a520 and pmu-a720's interrupt entry get its handle
- Remove gic-v3's #redistributor-regions and redistributor-stride properties
- Change gic-v3's #interrupt-cells as 4, and change all interrupt specifiers accordingly
- Remove "arm,no-tick-in-suspend" for timer due to global counter is at always-on power domain
- Remove timer's clock frequency due to firmware has already set it
- Add Krzysztof Kozlowski's reviewed-by
Changes for v3:
- Fix two dts coding sytle issues
Changes for v2:
- Corrects the SoF tag's name
- Fix several coding sytle issues
- move linux,cma node to dts file
- delete memory node, memory size is passed by firmware
- delete uart2 node which will be added in future patches
- Improve for pmu and cpu node to stands for more specific cpu model
- Improve the timer node and add hypervisor virtual timer irq
- Pass "make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb"
arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/cix/Makefile | 2 + arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 26 +++ arch/arm64/boot/dts/cix/sky1.dtsi | 222 ++++++++++++++++++++++ 4 files changed, 251 insertions(+) create mode 100644 arch/arm64/boot/dts/cix/Makefile create mode 100644 arch/arm64/boot/dts/cix/sky1-orion-o6.dts create mode 100644 arch/arm64/boot/dts/cix/sky1.dtsi
arch/arm64/boot/dts/Makefile +1 -0
@@ -13,6 +13,7 @@ subdir-y += bitmain subdir-y += blaize subdir-y += broadcom subdir-y += cavium +subdir-y += cix subdir-y += exynos subdir-y += freescale subdir-y += hisilicon
arch/arm64/boot/dts/cix/Makefile new file +2 -0
@@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0 +dtb-$(CONFIG_ARCH_CIX) += sky1-orion-o6.dtb
arch/arm64/boot/dts/cix/sky1-orion-o6.dts new file +26 -0
@@ -0,0 +1,26 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright 2025 Cix Technology Group Co., Ltd. + * + */ + +/dts-v1/; + +#include "sky1.dtsi" +/ { + model = "Radxa Orion O6"; + compatible = "radxa,orion-o6", "cix,sky1"; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + linux,cma { + compatible = "shared-dma-pool"; + reusable; + size = <0x0 0x28000000>; + linux,cma-default; + }; + }; +};
arch/arm64/boot/dts/cix/sky1.dtsi new file +222 -0
222 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v4 5/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Quoted 5 lines · Peter Chen
arch/arm64/boot/dts/cix/sky1.dtsi new file +4
-0+ pmu-a520 { + compatible = "arm,cortex-a520-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition0>; + };
arch/arm64/boot/dts/cix/sky1.dtsi line 169
Quoted 10 lines
arch/arm64/boot/dts/cix/sky1.dtsi new file +10
-0+ + pmu-a720 { + compatible = "arm,cortex-a720-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition1>; + }; + + pmu-spe { + compatible = "arm,statistical-profiling-extension-v1"; + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW 0>; + };
SPE should follow the same model as the PMU, as each CPU has its own SPE implementation, exposing different micro-architectural details.
The rest looks OK.
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Re: [PATCH v4 5/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Quoted 11 lines · Marc Zyngier
Quoted 10 lines · Peter Chen
arch/arm64/boot/dts/cix/sky1.dtsi new file +9
-0+ pmu-a520 { + compatible = "arm,cortex-a520-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition0>; + }; + + pmu-a720 { + compatible = "arm,cortex-a720-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition1>; + };
Quoted 9 lines
arch/arm64/boot/dts/cix/sky1.dtsi line 169
Quoted 5 lines
arch/arm64/boot/dts/cix/sky1.dtsi new file +5
-0+ + pmu-spe { + compatible = "arm,statistical-profiling-extension-v1"; + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW 0>; + };SPE should follow the same model as the PMU, as each CPU has its own SPE implementation, exposing different micro-architectural details.
Hi Marc,
Thanks for your reply. But there is only one compatible string "statistical-profiling-extension-v1" at drivers/perf/arm_spe_pmu.c, how could differentiate pmu-spe-a720 and pmu-spe-a520, do I need to change arm_spe_pmu.c as well?
Signature · 2 lines
Best regards, Peter
Re: [PATCH v4 5/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Quoted 23 lines · Peter Chen
Quoted 11 lines · Marc Zyngier
Quoted 10 lines · Peter Chen
arch/arm64/boot/dts/cix/sky1.dtsi new file +9
-0+ pmu-a520 { + compatible = "arm,cortex-a520-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition0>; + }; + + pmu-a720 { + compatible = "arm,cortex-a720-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition1>; + };Quoted 9 lines
arch/arm64/boot/dts/cix/sky1.dtsi line 169
Quoted 5 lines
arch/arm64/boot/dts/cix/sky1.dtsi new file +5
-0+ + pmu-spe { + compatible = "arm,statistical-profiling-extension-v1"; + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW 0>; + };SPE should follow the same model as the PMU, as each CPU has its own SPE implementation, exposing different micro-architectural details.
Quoted 6 lines
Hi Marc,
Thanks for your reply. But there is only one compatible string "statistical-profiling-extension-v1" at
drivers/perf/arm_spe_pmu.c, how could differentiate pmu-spe-a720 and pmu-spe-a520, do I need to changearm_spe_pmu.cas well?
I don't think there is a need to have different compatible. The driver can probe which CPU this is on, and work out the implemented subfeatures from the PMSIDR_EL1 register. New compatible strings are better avoided when there is a way to probe/discover the HW (and in most cases, there is).
Note that this equally applies to TRBE, which also explicitly deals with interrupt partitioning and yet only has a single compatible. Please consider adding TRBE support when you repost this series.
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Re: [PATCH v4 5/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Quoted 35 lines · Marc Zyngier
Quoted 22 lines · Marc Zyngier
Quoted 11 lines
Quoted 10 lines · Peter Chen
arch/arm64/boot/dts/cix/sky1.dtsi new file +9
-0+ pmu-a520 { + compatible = "arm,cortex-a520-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition0>; + }; + + pmu-a720 { + compatible = "arm,cortex-a720-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition1>; + };Quoted 9 lines
arch/arm64/boot/dts/cix/sky1.dtsi line 169
Quoted 5 lines
arch/arm64/boot/dts/cix/sky1.dtsi new file +5
-0+ + pmu-spe { + compatible = "arm,statistical-profiling-extension-v1"; + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW 0>; + };SPE should follow the same model as the PMU, as each CPU has its own SPE implementation, exposing different micro-architectural details.
Quoted 6 lines
Hi Marc,
Thanks for your reply. But there is only one compatible string "statistical-profiling-extension-v1" at
drivers/perf/arm_spe_pmu.c, how could differentiate pmu-spe-a720 and pmu-spe-a520, do I need to changearm_spe_pmu.cas well?I don't think there is a need to have different compatible. The driver can probe which CPU this is on, and work out the implemented subfeatures from the
PMSIDR_EL1register. New compatible strings are better avoided when there is a way to probe/discover the HW (and in most cases, there is).
Quoted 4 lines
Note that this equally applies to TRBE, which also explicitly deals with interrupt partitioning and yet only has a single compatible. Please consider adding TRBE support when you repost this series.
Hi Marc,
Thanks for your comment, we need to discuss it internally. Since it is very initial dts support for CIX sky1 SoC, I will delete pmu-spe support at this time, and add better support for it when adding more components next time.
Signature · 2 lines
Best regards, Peter
Re: [PATCH v4 5/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Quoted 42 lines · Peter Chen
Quoted 35 lines · Marc Zyngier
Quoted 22 lines · Marc Zyngier
Quoted 11 lines
Quoted 10 lines · Peter Chen
arch/arm64/boot/dts/cix/sky1.dtsi new file +9
-0+ pmu-a520 { + compatible = "arm,cortex-a520-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition0>; + }; + + pmu-a720 { + compatible = "arm,cortex-a720-pmu"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW &ppi_partition1>; + };Quoted 9 lines
arch/arm64/boot/dts/cix/sky1.dtsi line 169
Quoted 5 lines
arch/arm64/boot/dts/cix/sky1.dtsi new file +5
-0+ + pmu-spe { + compatible = "arm,statistical-profiling-extension-v1"; + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW 0>; + };SPE should follow the same model as the PMU, as each CPU has its own SPE implementation, exposing different micro-architectural details.
Quoted 6 lines
Hi Marc,
Thanks for your reply. But there is only one compatible string "statistical-profiling-extension-v1" at
drivers/perf/arm_spe_pmu.c, how could differentiate pmu-spe-a720 and pmu-spe-a520, do I need to changearm_spe_pmu.cas well?I don't think there is a need to have different compatible. The driver can probe which CPU this is on, and work out the implemented subfeatures from the
PMSIDR_EL1register. New compatible strings are better avoided when there is a way to probe/discover the HW (and in most cases, there is).Quoted 4 lines
Note that this equally applies to TRBE, which also explicitly deals with interrupt partitioning and yet only has a single compatible. Please consider adding TRBE support when you repost this series.
Quoted 6 lines
Hi Marc,
Thanks for your comment, we need to discuss it internally. Since it is very initial dts support for CIX sky1 SoC, I will delete pmu-spe support at this time, and add better support for it when adding more components next time.
And therefore making this machine even less useful than it already is?
<s> I think this is a great plan. </s>
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
PATCH v4 6/6 MAINTAINERS: Add CIX SoC maintainer entry
In reply to Peter ChenUsing this entry as the maintainers information for CIX SKY series SoCs.
---
Changes for v4
- Add two dts files as maintained files
MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)
MAINTAINERS +10 -0
@@ -2354,6 +2354,16 @@ F: arch/arm/boot/compressed/misc-ep93xx.h F: arch/arm/mach-ep93xx/ F: drivers/iio/adc/ep93xx_adc.c +ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsi + ARM/CLKDEV SUPPORT M: Russell King <[email protected]> L: [email protected] (moderated for non-subscribers)
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerRe: [PATCH v4 6/6] MAINTAINERS: Add CIX SoC maintainer entry
Quoted 18 lines · Peter Chen
Using this entry as the maintainers information for CIX SKY series SoCs.
Acked-by Fugang Duan <[email protected]>Signed-off-by Peter Chen <[email protected]>---
Changes for v4
- Add two dts files as maintained filesMAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)MAINTAINERS +0
-0@@ -2354,6 +2354,16 @@ F: arch/arm/boot/compressed/misc-ep93xx.h F: arch/arm/mach-ep93xx/ F: drivers/iio/adc/ep93xx_adc.c
MAINTAINERS F: arch/arm/boot/compressed/misc-ep93xx.h · line 2365
Quoted 10 lines
MAINTAINERS +9
-0+ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsi
Instead:arch/arm64/boot/dts/cix/
or if you think there will be more different architectures coming from cix, which you will not maintain, then useful would be a "sky" subdirectory.
Best regards,
Krzysztof
Re: [PATCH v4 6/6] MAINTAINERS: Add CIX SoC maintainer entry
Quoted 35 lines · Krzysztof Kozlowski
EXTERNAL EMAIL
Quoted 18 lines · Peter Chen
Using this entry as the maintainers information for CIX SKY series SoCs.
Acked-by Fugang Duan <[email protected]>Signed-off-by Peter Chen <[email protected]>---
Changes for v4
- Add two dts files as maintained filesMAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)MAINTAINERS +0
-0@@ -2354,6 +2354,16 @@ F: arch/arm/boot/compressed/misc-ep93xx.h F: arch/arm/mach-ep93xx/ F: drivers/iio/adc/ep93xx_adc.cMAINTAINERS F: arch/arm/boot/compressed/misc-ep93xx.h · line 2365
Quoted 10 lines
MAINTAINERS +9
-0+ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsiInstead:
arch/arm64/boot/dts/cix/
Quoted 3 lines
or if you think there will be more different architectures coming from cix, which you will not maintain, then useful would be a "sky" subdirectory.
Hi Krzysztof,
Thanks for your comment, CIX is Arm SoC based silicon design company, we may have different SoC style for middle end in future. So, for that SoC series, it may not name sky.
Signature · 2 lines
Best regards, Peter
Re: [PATCH v4 6/6] MAINTAINERS: Add CIX SoC maintainer entry
On Thu, Mar 20, 2025 at 06:49:47PM +0800, Peter Chen wrote:
(...)
Quoted 13 lines
Quoted 13 lines
MAINTAINERS F: arch/arm/boot/compressed/misc-ep93xx.h · line 2365
Quoted 9 lines
MAINTAINERS +9
-0+ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsiInstead:
arch/arm64/boot/dts/cix/
Quoted 8 lines
Quoted 3 lines
or if you think there will be more different architectures coming from cix, which you will not maintain, then useful would be a "sky" subdirectory.
Hi Krzysztof,
Thanks for your comment, CIX is Arm SoC based silicon design company, we may have different SoC style for middle end in future. So, for that SoC series, it may not name sky.
I believe the idea is that the file should either say
+F: arch/arm64/boot/dts/cix/
if the two of you intend to be maintainers for everything under cix/. You don't need to list every specific file.
Otherwise it should say
+F: arch/arm64/boot/dts/cix/sky/
with its own subdirectory if you only intend to be maintaining the sky family.
Quoted 4 lines
--
Best regards,
Peter
Re: [PATCH v4 6/6] MAINTAINERS: Add CIX SoC maintainer entry
Quoted 27 lines · Kajetan Puchalski
Quoted 14 lines
Quoted 14 lines
MAINTAINERS F: arch/arm/boot/compressed/misc-ep93xx.h · line 2365
Quoted 10 lines
MAINTAINERS +9
-0+ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsiInstead:
arch/arm64/boot/dts/cix/Quoted 8 lines
Quoted 3 lines
or if you think there will be more different architectures coming from cix, which you will not maintain, then useful would be a "sky" subdirectory.
Hi Krzysztof,
Thanks for your comment, CIX is Arm SoC based silicon design company, we may have different SoC style for middle end in future. So, for that SoC series, it may not name sky.
I believe the idea is that the file should either say
+F:
arch/arm64/boot/dts/cix/
Quoted 8 lines
if the two of you intend to be maintainers for everything under cix/. You don't need to list every specific file.
Otherwise it should say
+F:
arch/arm64/boot/dts/cix/sky/with its own subdirectory if you only intend to be maintaining the sky family.
Hi Kajetan & Krzysztof,
Thanks for your valuable comments. We prefer maintain the entire CIX architecture under one entry, I will change maintain information like below:
ARM/CIX SOC SUPPORT
M: Peter Chen <[email protected]>
M: Fugang Duan <[email protected]>
R: CIX Linux Kernel Upstream Group <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Maintained
F: Documentation/devicetree/bindings/arm/cix.yaml
F: arch/arm64/boot/dts/cix/
Signature · 2 lines
Best regards, Peter
Krzysztof Kozlowski
maintainerRe: [PATCH v4 6/6] MAINTAINERS: Add CIX SoC maintainer entry
In reply to Peter ChenQuoted 36 lines · Peter Chen
Quoted 35 lines · Krzysztof Kozlowski
EXTERNAL EMAIL
Quoted 18 lines · Peter Chen
Using this entry as the maintainers information for CIX SKY series SoCs.
Acked-by Fugang Duan <[email protected]>Signed-off-by Peter Chen <[email protected]>---
Changes for v4
- Add two dts files as maintained filesMAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)MAINTAINERS +0
-0@@ -2354,6 +2354,16 @@ F: arch/arm/boot/compressed/misc-ep93xx.h F: arch/arm/mach-ep93xx/ F: drivers/iio/adc/ep93xx_adc.cMAINTAINERS F: arch/arm/boot/compressed/misc-ep93xx.h · line 2365
Quoted 10 lines
MAINTAINERS +9
-0+ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsiInstead:
arch/arm64/boot/dts/cix/
Quoted 8 lines
Quoted 3 lines
or if you think there will be more different architectures coming from cix, which you will not maintain, then useful would be a "sky" subdirectory.
Hi Krzysztof,
Thanks for your comment, CIX is Arm SoC based silicon design company, we may have different SoC style for middle end in future. So, for that SoC series, it may not name sky.
Your Kconfig says ARCH_CIX :/
Anyway, listing individual files is pointless, so if you are not going to maintain entire arch, then create subdir. Otherwise why creating so many entries? The biggest upstreamed SoC vendor (by number of SoCs and boards has one entry.
Best regards,
Krzysztof
Arnd Bergmann
maintainerRe: [PATCH v4 6/6] MAINTAINERS: Add CIX SoC maintainer entry
In reply to Peter ChenMAINTAINERS F: arch/arm/boot/compressed/misc-ep93xx.h · line 2366
Quoted 10 lines · Peter Chen
MAINTAINERS +10
-0+ARM/CIX SKY ARM ARCHITECTURE +M: Peter Chen <[email protected]> +M: Fugang Duan <[email protected]> +R: CIX Linux Kernel Upstream Group <[email protected]> +L: [email protected] (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/arm/cix.yaml +F: arch/arm64/boot/dts/cix/sky1-orion-o6.dts +F: arch/arm64/boot/dts/cix/sky1.dtsi +
Looks good to me. You can also add a regex keyword entry such as
K: \bcix\b
to match any filenames that have 'cix' as a whole word.
Arnd
Quoted 15 lines · Peter Chen
Cixtech P1 (internal name sky1) is high performance generic Armv9 SoC. Orion O6 is the world's first open source Arm V9 Motherboard built by Radxa. You could find brief introduction for SoC and related boards at:
https://radxa.com/products/orion/o6#overviewIn this series, we add initial SoC and board support for Kernel building. Patch 1-2: Add dt-binding doc for CIX and its sky1 SoC
Patch 3: add related maintainers entry
Patch 4-5: add Arm64 build support
Patch 6: add initial dts support for SoC and Orion O6 boardTo run upstream kernel at Orion O6 board, you need to use BIOS released by Radxa:
https://docs.radxa.com/en/orion/o6/bios/install-bios
Quoted 10 lines
Changes for v4:
- Move addMAINTAINERSentry patch to the last, and add two dts files entry in it.
- Add three Krzysztof Kozlowski's Reviewed-by Tags
- Forsky1.dtsi, makes below changes:
- Add ppi-partition entry for gic-v3 node, and let pmu-a520 and pmu-a720's interrupt entry get its handle
- Remove gic-v3's #redistributor-regions and redistributor-stride properties
- Change gic-v3's #interrupt-cells as 4, and change all interrupt specifiers accordingly
- Remove "arm,no-tick-in-suspend" for timer due to global counter is at always-on power domain
- Remove timer's clock frequency due to firmware has already set it
Hi Arnd,
I assume this series (all patches) will go your tree, right?
Peter
Quoted 51 lines
Changes for v3:
- Patch 1: Add Krzysztof Kozlowski's Acked-by Tag
- Patch 2: Add Krzysztof Kozlowski's Reviewed-by Tag
- Patch 6: Fix two dts coding sytle issuesChanges for v2:
- Pass dts build check with below commands:
make O=$OUTKNLdt_binding_checkDT_SCHEMA_FILES=vendor-prefixes.yaml make O=$OUTKNLdt_binding_checkDT_SCHEMA_FILES=arm/cix.yaml make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Re-order the patch set, and move vendor-perfixes to the 1st patch.
- Patch 4: OrderedKconfigconfig entry by alpha-numerically
- Patch 5: Corrects the Ack tag's name
- Patch 6: see below.
1) Corrects the SoF tag's name
2) Fix several coding sytle issues
3) move linux,cma node to dts file
4) delete memory node, memory size is passed by firmware
5) delete uart2 node which will be added in future patches
6) Improve for pmu and cpu node to stands for more specific cpu model
7) Improve the timer node and add hypervisor virtual timer irqFugang Duan (1):
arm64:Kconfig: addARCH_CIXfor cix siliconsPeter Chen (5):
dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd.
dt-bindings: arm: add CIX P1 (SKY1) SoC
arm64: defconfig: Enable CIX SoC
arm64: dts: cix: add initial CIX P1(SKY1) dts support
MAINTAINERS: Add CIX SoC maintainer entry.../devicetree/bindings/arm/cix.yaml | 26 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 10 + arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/cix/Makefile | 2 + arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 26 ++ arch/arm64/boot/dts/cix/sky1.dtsi | 222 ++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 9 files changed, 296 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/cix.yaml create mode 100644 arch/arm64/boot/dts/cix/Makefile create mode 100644 arch/arm64/boot/dts/cix/sky1-orion-o6.dts create mode 100644 arch/arm64/boot/dts/cix/sky1.dtsiSignature · 1 line
2.25.1
Signature · 2 lines
Best regards, Peter
Quoted 27 lines · Peter Chen
Quoted 15 lines · Peter Chen
Cixtech P1 (internal name sky1) is high performance generic Armv9 SoC. Orion O6 is the world's first open source Arm V9 Motherboard built by Radxa. You could find brief introduction for SoC and related boards at:
https://radxa.com/products/orion/o6#overviewIn this series, we add initial SoC and board support for Kernel building. Patch 1-2: Add dt-binding doc for CIX and its sky1 SoC
Patch 3: add related maintainers entry
Patch 4-5: add Arm64 build support
Patch 6: add initial dts support for SoC and Orion O6 boardTo run upstream kernel at Orion O6 board, you need to use BIOS released by Radxa:
https://docs.radxa.com/en/orion/o6/bios/install-biosQuoted 10 lines
Changes for v4:
- Move addMAINTAINERSentry patch to the last, and add two dts files entry in it.
- Add three Krzysztof Kozlowski's Reviewed-by Tags
- Forsky1.dtsi, makes below changes:
- Add ppi-partition entry for gic-v3 node, and let pmu-a520 and pmu-a720's interrupt entry get its handle
- Remove gic-v3's #redistributor-regions and redistributor-stride properties
- Change gic-v3's #interrupt-cells as 4, and change all interrupt specifiers accordingly
- Remove "arm,no-tick-in-suspend" for timer due to global counter is at always-on power domain
- Remove timer's clock frequency due to firmware has already set it
Quoted 4 lines
Hi Arnd,
I assume this series (all patches) will go your tree, right?
A gentle ping, thanks.
Peter
Quoted 58 lines
Peter
Quoted 51 lines
Changes for v3:
- Patch 1: Add Krzysztof Kozlowski's Acked-by Tag
- Patch 2: Add Krzysztof Kozlowski's Reviewed-by Tag
- Patch 6: Fix two dts coding sytle issuesChanges for v2:
- Pass dts build check with below commands:
make O=$OUTKNLdt_binding_checkDT_SCHEMA_FILES=vendor-prefixes.yaml make O=$OUTKNLdt_binding_checkDT_SCHEMA_FILES=arm/cix.yaml make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Re-order the patch set, and move vendor-perfixes to the 1st patch.
- Patch 4: OrderedKconfigconfig entry by alpha-numerically
- Patch 5: Corrects the Ack tag's name
- Patch 6: see below.
1) Corrects the SoF tag's name
2) Fix several coding sytle issues
3) move linux,cma node to dts file
4) delete memory node, memory size is passed by firmware
5) delete uart2 node which will be added in future patches
6) Improve for pmu and cpu node to stands for more specific cpu model
7) Improve the timer node and add hypervisor virtual timer irqFugang Duan (1):
arm64:Kconfig: addARCH_CIXfor cix siliconsPeter Chen (5):
dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd.
dt-bindings: arm: add CIX P1 (SKY1) SoC
arm64: defconfig: Enable CIX SoC
arm64: dts: cix: add initial CIX P1(SKY1) dts support
MAINTAINERS: Add CIX SoC maintainer entry.../devicetree/bindings/arm/cix.yaml | 26 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 10 + arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/cix/Makefile | 2 + arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 26 ++ arch/arm64/boot/dts/cix/sky1.dtsi | 222 ++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 9 files changed, 296 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/cix.yaml create mode 100644 arch/arm64/boot/dts/cix/Makefile create mode 100644 arch/arm64/boot/dts/cix/sky1-orion-o6.dts create mode 100644 arch/arm64/boot/dts/cix/sky1.dtsiSignature · 1 line
2.25.1Signature · 2 lines
Best regards, Peter
Signature · 2 lines
Best regards, Peter