drm/vblank: refactoring and cleanups
Subsystems (2)
cover drm/vblank: refactoring and cleanups
Mostly, pass vblank around a lot more instead of dev, pipe pair. This allows cleanup of pipe bounds checks, etc.
BR,
Jani.
Jani Nikula (23):
drm/vblank: remove drm_wait_one_vblank() completely drm/vblank: remove superfluous pipe check
drm/vblank: add return value to drm_crtc_wait_one_vblank() drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc()
helpers more
drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc() drm/vblank: pass vlank to drm_vblank_get()/_put()/_count() drm/vblank: pass vblank to drm_update_vblank_count() drm/vblank: pass vblank to drm_handle_vblank_events() drm/vblank: use the vblank based interfaces more drm/vblank: pass vblank to drm_queue_vblank_event() drm/vblank: pass vblank to drm_wait_vblank_reply() drm/vblank: pass vblank to drm_vblank_count_and_time() drm/vblank: pass vblank to drm_reset_vblank_timestamp() drm/vblank: pass vblank to store_vblank()
drm/vblank: pass vblank to drm_vblank_enable()
drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore() drm/vblank: add drm_crtc_from_vblank() helper
drm/vblank: pass vblank to __get_vblank_counter() and
drm_max_vblank_count()
drm/vblank: pass vblank to __{enable,disable}_vblank() drm/vblank: pass vblank to drm_get_last_vbltimestamp() drm/vblank: pass vblank to drm_vblank_disable_and_save(), make static drm/vblank: reduce pipe checks
drm/vblank: clean up debug logging
Thomas Zimmermann (1):
drm/vblank: Unexport drm_wait_one_vblank()
drivers/gpu/drm/drm_internal.h | 7 +- drivers/gpu/drm/drm_vblank.c | 470 ++++++++++++++---------------- drivers/gpu/drm/drm_vblank_work.c | 12 +- include/drm/drm_vblank.h | 3 +- 4 files changed, 224 insertions(+), 268 deletions(-)
Signature · 1 line
2.47.3
PATCH 1/24 drm/vblank: Unexport drm_wait_one_vblank()
From: Thomas Zimmermann <[email protected]>
Make drm_wait_on_vblank() static. The function is an internal interface and not invoked directly by drivers.
--- drivers/gpu/drm/drm_vblank.c | 14 +------------- include/drm/drm_vblank.h | 1 - 2 files changed, 1 insertion(+), 14 deletions(-)
drivers/gpu/drm/drm_vblank.c +1 -13
@@ -1286,18 +1286,7 @@ void drm_crtc_vblank_put(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_put); -/** -* drm_wait_one_vblank - wait for one vblank -* @dev: DRM device -* @pipe: CRTC index -* -* This waits for one vblank to pass on @pipe, using the irq driver interfaces. -* It is a failure to call this when the vblank irq for @pipe is disabled, e.g. -* due to lack of driver support or because the crtc is off. -* -* This is the legacy version of drm_crtc_wait_one_vblank(). -*/ -void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe) +static void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe) {struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);int ret;
@@ -1321,7 +1310,6 @@ void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)drm_vblank_put (dev, pipe); } -EXPORT_SYMBOL (drm_wait_one_vblank);/** * drm_crtc_wait_one_vblank - wait for one vblank
include/drm/drm_vblank.h +0 -1
@@ -302,7 +302,6 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe);bool drm_crtc_handle_vblank (struct drm_crtc *crtc);int drm_crtc_vblank_get (struct drm_crtc *crtc);void drm_crtc_vblank_put (struct drm_crtc *crtc); -void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe);void drm_crtc_wait_one_vblank (struct drm_crtc *crtc);void drm_crtc_vblank_off (struct drm_crtc *crtc);void drm_crtc_vblank_reset (struct drm_crtc *crtc);
Signature · 1 line
2.47.3
Thomas Zimmermann
maintainerRe: [PATCH 01/24] drm/vblank: Unexport drm_wait_one_vblank()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 4 lines
From: Thomas Zimmermann <[email protected]>
Make
drm_wait_on_vblank()static. The function is an internal interface and not invoked directly by drivers.
I forgot about that patch. Thanks for picking it up.
Quoted 52 lines
Signed-off-by Thomas Zimmermann <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_vblank.c | 14 +------------- include/drm/drm_vblank.h | 1 - 2 files changed, 1 insertion(+), 14 deletions(-)drivers/gpu/drm/drm_vblank.c +1
-13@@ -1286,18 +1286,7 @@ void drm_crtc_vblank_put(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_put); -/** -* drm_wait_one_vblank - wait for one vblank -* @dev: DRM device -* @pipe: CRTC index -* -* This waits for one vblank to pass on @pipe, using the irq driver interfaces. -* It is a failure to call this when the vblank irq for @pipe is disabled, e.g. -* due to lack of driver support or because the crtc is off. -* -* This is the legacy version of drm_crtc_wait_one_vblank(). -*/ -void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe) +static void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe) {struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);int ret;@@ -1321,7 +1310,6 @@ void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)drm_vblank_put (dev, pipe); } -EXPORT_SYMBOL (drm_wait_one_vblank);/** * drm_crtc_wait_one_vblank - wait for one vblank include/drm/drm_vblank.h +0
-1@@ -302,7 +302,6 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe);bool drm_crtc_handle_vblank (struct drm_crtc *crtc);int drm_crtc_vblank_get (struct drm_crtc *crtc);void drm_crtc_vblank_put (struct drm_crtc *crtc); -void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe);void drm_crtc_wait_one_vblank (struct drm_crtc *crtc);void drm_crtc_vblank_off (struct drm_crtc *crtc);void drm_crtc_vblank_reset (struct drm_crtc *crtc);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 2/24 drm/vblank: remove drm_wait_one_vblank() completely
In reply to Jani NikulaThere's really no need for the extra static function at all.
--- drivers/gpu/drm/drm_vblank.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-)
drivers/gpu/drm/drm_vblank.c +11 -14
@@ -1286,8 +1286,18 @@ void drm_crtc_vblank_put(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_put); -static void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe) +/** +* drm_crtc_wait_one_vblank - wait for one vblank +* @crtc: DRM crtc +* +* This waits for one vblank to pass on @crtc, using the irq driver interfaces. +* It is a failure to call this when the vblank irq for @crtc is disabled, e.g. +* due to lack of driver support or because the crtc is off. +*/ +void drm_crtc_wait_one_vblank (struct drm_crtc *crtc) { +struct drm_device *dev = crtc->dev; +int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);int ret;u64 last;
@@ -1310,19 +1320,6 @@ static void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)drm_vblank_put (dev, pipe); } - -/** -* drm_crtc_wait_one_vblank - wait for one vblank -* @crtc: DRM crtc -* -* This waits for one vblank to pass on @crtc, using the irq driver interfaces. -* It is a failure to call this when the vblank irq for @crtc is disabled, e.g. -* due to lack of driver support or because the crtc is off. -*/ -void drm_crtc_wait_one_vblank (struct drm_crtc *crtc) -{ -drm_wait_one_vblank (crtc->dev,drm_crtc_index (crtc)); -}EXPORT_SYMBOL (drm_crtc_wait_one_vblank);/**
Signature · 1 line
2.47.3
Re: [PATCH 02/24] drm/vblank: remove drm_wait_one_vblank() completely
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
There's really no need for the extra static function at all.
Signed-off-by Jani Nikula <[email protected]>
Quoted 48 lines
--- drivers/gpu/drm/drm_vblank.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-)drivers/gpu/drm/drm_vblank.c +11
-14@@ -1286,8 +1286,18 @@ void drm_crtc_vblank_put(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_put); -static void drm_wait_one_vblank (struct drm_device *dev,unsigned int pipe) +/** +* drm_crtc_wait_one_vblank - wait for one vblank +* @crtc: DRM crtc +* +* This waits for one vblank to pass on @crtc, using the irq driver interfaces. +* It is a failure to call this when the vblank irq for @crtc is disabled, e.g. +* due to lack of driver support or because the crtc is off. +*/ +void drm_crtc_wait_one_vblank (struct drm_crtc *crtc) { +struct drm_device *dev = crtc->dev; +int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);int ret;u64 last;@@ -1310,19 +1320,6 @@ static void drm_wait_one_vblank(struct drm_device *dev, unsigned int pipe)drm_vblank_put (dev, pipe); } - -/** -* drm_crtc_wait_one_vblank - wait for one vblank -* @crtc: DRM crtc -* -* This waits for one vblank to pass on @crtc, using the irq driver interfaces. -* It is a failure to call this when the vblank irq for @crtc is disabled, e.g. -* due to lack of driver support or because the crtc is off. -*/ -void drm_crtc_wait_one_vblank (struct drm_crtc *crtc) -{ -drm_wait_one_vblank (crtc->dev,drm_crtc_index (crtc)); -}EXPORT_SYMBOL (drm_crtc_wait_one_vblank);/**
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 3/24 drm/vblank: remove superfluous pipe check
In reply to Jani NikulaNow that the pipe is crtc->pipe, there's no need to check it's within range.
--- drivers/gpu/drm/drm_vblank.c | 3 --- 1 file changed, 3 deletions(-)
drivers/gpu/drm/drm_vblank.c +0 -3
@@ -1302,9 +1302,6 @@ void drm_crtc_wait_one_vblank(struct drm_crtc *crtc)int ret;u64 last; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; - ret =drm_vblank_get (dev, pipe);if (drm_WARN (dev, ret,"vblank not available on crtc %i, ret=%i\n" , pipe, ret))
Signature · 1 line
2.47.3
Re: [PATCH 03/24] drm/vblank: remove superfluous pipe check
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 4 lines
Now that the pipe is
crtc->pipe, there's no need to check it's within range.Signed-off-by Jani Nikula <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/drm_vblank.c | 3 --- 1 file changed, 3 deletions(-)drivers/gpu/drm/drm_vblank.c +0
-3@@ -1302,9 +1302,6 @@ void drm_crtc_wait_one_vblank(struct drm_crtc *crtc)int ret;u64 last; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; - ret =drm_vblank_get (dev, pipe);if (drm_WARN (dev, ret,"vblank not available on crtc %i, ret=%i\n" , pipe, ret))
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 4/24 drm/vblank: add return value to drm_crtc_wait_one_vblank()
In reply to Jani NikulaLet drivers deal with the vblank wait failures if they so desire. If the current warning backtrace gets toned down to a simple warning message, the drivers may wish to add the backtrace themselves.
--- drivers/gpu/drm/drm_vblank.c | 8 ++++++-- include/drm/drm_vblank.h | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_vblank.c +6 -2
@@ -1293,8 +1293,10 @@ EXPORT_SYMBOL(drm_crtc_vblank_put);* This waits for one vblank to pass on @crtc, using the irq driver interfaces. * It is a failure to call this when the vblank irq for @crtc is disabled, e.g. * due to lack of driver support or because the crtc is off. +* +* Returns: 0 on success, negative error on failures. */ -void drm_crtc_wait_one_vblank (struct drm_crtc *crtc) +int drm_crtc_wait_one_vblank (struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev;int pipe =drm_crtc_index (crtc);
@@ -1305,7 +1307,7 @@ void drm_crtc_wait_one_vblank(struct drm_crtc *crtc) ret =drm_vblank_get (dev, pipe);if (drm_WARN (dev, ret,"vblank not available on crtc %i, ret=%i\n" , pipe, ret)) -return ; +return ret; last =drm_vblank_count (dev, pipe);
@@ -1316,6 +1318,8 @@ void drm_crtc_wait_one_vblank(struct drm_crtc *crtc)drm_WARN (dev, ret ==0 ,"vblank wait timed out on crtc %i\n" , pipe);drm_vblank_put (dev, pipe); + +return ret ?0 : -ETIMEDOUT ; }EXPORT_SYMBOL (drm_crtc_wait_one_vblank);
include/drm/drm_vblank.h +1 -1
@@ -302,7 +302,7 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe);bool drm_crtc_handle_vblank (struct drm_crtc *crtc);int drm_crtc_vblank_get (struct drm_crtc *crtc);void drm_crtc_vblank_put (struct drm_crtc *crtc); -void drm_crtc_wait_one_vblank (struct drm_crtc *crtc); +int drm_crtc_wait_one_vblank (struct drm_crtc *crtc);void drm_crtc_vblank_off (struct drm_crtc *crtc);void drm_crtc_vblank_reset (struct drm_crtc *crtc); void drm_crtc_vblank_on_config(struct drm_crtc *crtc,
Signature · 1 line
2.47.3
PATCH 5/24 drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc() helpers more
In reply to Jani NikulaWe have the helpers to avoid open coding dev->vblank[pipe] access.
--- drivers/gpu/drm/drm_vblank.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_vblank.c +6 -4
@@ -551,7 +551,7 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs) dev->num_crtcs = num_crtcs;for (i =0 ; i < num_crtcs; i++) { -struct drm_vblank_crtc *vblank = &dev->vblank[i]; +struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, i); vblank->dev = dev; vblank->pipe = i;
@@ -605,7 +605,9 @@ EXPORT_SYMBOL(drm_dev_has_vblank);*/ wait_queue_head_t *drm_crtc_vblank_waitqueue (struct drm_crtc *crtc) { -return &crtc->dev->vblank[drm_crtc_index (crtc)].queue; +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); + +return &vblank->queue; }EXPORT_SYMBOL (drm_crtc_vblank_waitqueue);
@@ -710,7 +712,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( {struct drm_device *dev = crtc->dev;unsigned int pipe = crtc->index; -struct drm_vblank_crtc *vblank = &dev->vblank[pipe]; +struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);struct timespec64 ts_etime, ts_vblank_time;ktime_t stime, etime;bool vbl_status;
@@ -1782,7 +1784,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (pipe >= dev->num_crtcs)return -EINVAL ; - vblank = &dev->vblank[pipe]; + vblank =drm_vblank_crtc (dev, pipe);/* If the counter is currently enabled and accurate, short-circuit * queries to return the cached timestamp of the last vblank.
Signature · 1 line
2.47.3
Re: [PATCH 05/24] drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc() helpers more
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
We have the helpers to avoid open coding dev->vblank[pipe] access.
Signed-off-by Jani Nikula <[email protected]>
Quoted 46 lines
--- drivers/gpu/drm/drm_vblank.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_vblank.c +6
-4@@ -551,7 +551,7 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs) dev->num_crtcs = num_crtcs;for (i =0 ; i < num_crtcs; i++) { -struct drm_vblank_crtc *vblank = &dev->vblank[i]; +struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, i); vblank->dev = dev; vblank->pipe = i;@@ -605,7 +605,9 @@ EXPORT_SYMBOL(drm_dev_has_vblank);*/ wait_queue_head_t *drm_crtc_vblank_waitqueue (struct drm_crtc *crtc) { -return &crtc->dev->vblank[drm_crtc_index (crtc)].queue; +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); + +return &vblank->queue; }EXPORT_SYMBOL (drm_crtc_vblank_waitqueue);@@ -710,7 +712,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( {struct drm_device *dev = crtc->dev;unsigned int pipe = crtc->index; -struct drm_vblank_crtc *vblank = &dev->vblank[pipe]; +struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);struct timespec64 ts_etime, ts_vblank_time;ktime_t stime, etime;bool vbl_status;@@ -1782,7 +1784,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (pipe >= dev->num_crtcs)return -EINVAL ; - vblank = &dev->vblank[pipe]; + vblank =drm_vblank_crtc (dev, pipe);/* If the counter is currently enabled and accurate, short-circuit * queries to return the cached timestamp of the last vblank.
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 6/24 drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
In reply to Jani NikulaUse the higher level function where crtc is available.
--- drivers/gpu/drm/drm_vblank.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_vblank.c +2 -2
@@ -712,7 +712,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( {struct drm_device *dev = crtc->dev;unsigned int pipe = crtc->index; -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);struct timespec64 ts_etime, ts_vblank_time;ktime_t stime, etime;bool vbl_status;
@@ -1302,7 +1302,7 @@ int drm_crtc_wait_one_vblank(struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev;int pipe =drm_crtc_index (crtc); -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int ret;u64 last;
Signature · 1 line
2.47.3
Re: [PATCH 06/24] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the higher level function where crtc is available.
Signed-off-by Jani Nikula <[email protected]>
Is there a long-term plan to replace drm_vblank_crtc() entirely? Otherwise this looks a bit pointless.
Quoted 26 lines
--- drivers/gpu/drm/drm_vblank.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_vblank.c +2
-2@@ -712,7 +712,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( {struct drm_device *dev = crtc->dev;unsigned int pipe = crtc->index; -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);struct timespec64 ts_etime, ts_vblank_time;ktime_t stime, etime;bool vbl_status;@@ -1302,7 +1302,7 @@ int drm_crtc_wait_one_vblank(struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev;int pipe =drm_crtc_index (crtc); -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int ret;u64 last;
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Re: [PATCH 06/24] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
Quoted 9 lines · Thomas Zimmermann
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the higher level function where crtc is available.
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>Is there a long-term plan to replace
drm_vblank_crtc()entirely? Otherwise this looks a bit pointless.
Well, almost entirely. There are a few cases (plus the one that Ville mentioned later in the series) that need to operate on dev + pipe alone. The main point is that when you have a crtc and use that for the source of pipe, you don't have to do range checks on the pipe. This becomes gradually more evident in the series.
BR,
Jani.
Quoted 27 lines
Quoted 27 lines
--- drivers/gpu/drm/drm_vblank.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_vblank.c +2
-2@@ -712,7 +712,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( {struct drm_device *dev = crtc->dev;unsigned int pipe = crtc->index; -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);struct timespec64 ts_etime, ts_vblank_time;ktime_t stime, etime;bool vbl_status;@@ -1302,7 +1302,7 @@ int drm_crtc_wait_one_vblank(struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev;int pipe =drm_crtc_index (crtc); -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int ret;u64 last;
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH 06/24] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
Quoted 8 lines · Jani Nikula
Quoted 7 lines · Thomas Zimmermann
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the higher level function where crtc is available.
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>
Quoted 8 lines
Quoted 2 lines
Is there a long-term plan to replace
drm_vblank_crtc()entirely? Otherwise this looks a bit pointless.Well, almost entirely. There are a few cases (plus the one that Ville mentioned later in the series) that need to operate on dev + pipe alone. The main point is that when you have a crtc and use that for the source of pipe, you don't have to do range checks on the pipe. This becomes gradually more evident in the series.
I've actaully been thinking about doing the exact opposite. Ie. switch drm_vblank.c over to drm_vblank_crtc completely.
That is one of those things that might help with implementing pipe/crtc virtualization in i915. We basically want all interrupt stuff (including vblanks) to be tied to our hardware pipes and not the uapi drm_crtc. So we'd make drm_vblank_crtc==pipe, and introduce some kind of dynamic drm_crtc<->drm_vblank_crtc mapping for the uapi facing parts of drm_vblank.c...
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH 06/24] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
Quoted 21 lines · Ville Syrjälä
Quoted 8 lines · Jani Nikula
Quoted 7 lines · Thomas Zimmermann
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the higher level function where crtc is available.
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>Quoted 8 lines
Quoted 2 lines
Is there a long-term plan to replace
drm_vblank_crtc()entirely? Otherwise this looks a bit pointless.Well, almost entirely. There are a few cases (plus the one that Ville mentioned later in the series) that need to operate on dev + pipe alone. The main point is that when you have a crtc and use that for the source of pipe, you don't have to do range checks on the pipe. This becomes gradually more evident in the series.
I've actaully been thinking about doing the exact opposite. Ie. switch
drm_vblank.cover todrm_vblank_crtccompletely.
Quoted 6 lines
That is one of those things that might help with implementing pipe/crtc virtualization in i915. We basically want all interrupt stuff (including vblanks) to be tied to our hardware pipes and not the uapi
drm_crtc. So we'd make drm_vblank_crtc==pipe, and introduce some kind of dynamic drm_crtc<->drm_vblank_crtc mapping for the uapi facing parts ofdrm_vblank.c...
Ugh, so you're saying the series at hand is counter-productive?
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH 06/24] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
Quoted 22 lines · Jani Nikula
Quoted 21 lines · Ville Syrjälä
Quoted 8 lines · Jani Nikula
Quoted 7 lines · Thomas Zimmermann
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the higher level function where crtc is available.
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>Quoted 8 lines
Quoted 2 lines
Is there a long-term plan to replace
drm_vblank_crtc()entirely? Otherwise this looks a bit pointless.Well, almost entirely. There are a few cases (plus the one that Ville mentioned later in the series) that need to operate on dev + pipe alone. The main point is that when you have a crtc and use that for the source of pipe, you don't have to do range checks on the pipe. This becomes gradually more evident in the series.
I've actaully been thinking about doing the exact opposite. Ie. switch
drm_vblank.cover todrm_vblank_crtccompletely.
Quoted 8 lines
Quoted 6 lines
That is one of those things that might help with implementing pipe/crtc virtualization in i915. We basically want all interrupt stuff (including vblanks) to be tied to our hardware pipes and not the uapi
drm_crtc. So we'd make drm_vblank_crtc==pipe, and introduce some kind of dynamic drm_crtc<->drm_vblank_crtc mapping for the uapi facing parts ofdrm_vblank.c...Ugh, so you're saying the series at hand is counter-productive?
No, I think it's fine for the most part. The only worry would be anything that starts to depend on drm_crtc rather than drm_vblank_crtc, but I don't think you had a lot of that.
Signature · 2 lines
Ville Syrjälä Intel
Thomas Zimmermann
maintainerRe: [PATCH 06/24] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()
In reply to Ville SyrjäläHi
Am 11.11.25 um 17:00 schrieb Ville Syrjälä:
Quoted 18 lines · Jani Nikula
Quoted 7 lines · Thomas Zimmermann
Quoted 6 lines
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the higher level function where crtc is available.
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>Quoted 7 lines
Quoted 2 lines
Is there a long-term plan to replace
drm_vblank_crtc()entirely? Otherwise this looks a bit pointless.Well, almost entirely. There are a few cases (plus the one that Ville mentioned later in the series) that need to operate on dev + pipe alone. The main point is that when you have a crtc and use that for the source of pipe, you don't have to do range checks on the pipe. This becomes gradually more evident in the series.
I've actaully been thinking about doing the exact opposite. Ie. switch
drm_vblank.cover todrm_vblank_crtccompletely.
Quoted 6 lines
That is one of those things that might help with implementing pipe/crtc virtualization in i915. We basically want all interrupt stuff (including vblanks) to be tied to our hardware pipes and not the uapi
drm_crtc. So we'd make drm_vblank_crtc==pipe, and introduce some kind of dynamic drm_crtc<->drm_vblank_crtc mapping for the uapi facing parts ofdrm_vblank.c...
IMHO there needs to be clear documentation what exactly a pipe is and how it relates to a CRTC. And it's got to remain simple for simple hardware.
Best regards
Thomas
Quoted 1 line
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 7/24 drm/vblank: pass vlank to drm_vblank_get()/_put()/_count()
In reply to Jani NikulaPass struct drm_vblank_crtc * to drm_vblank_get(), drm_vblank_put(), and drm_vblank_count(). They'll figure out the vblank pointer as the first thing anyway, so it's handy to pass it when available. We can also rely on vblank having a valid pipe, and can reduce the number of checks we do.
Add underscore prefixed helpers for using dev/pipe until we've converted all users to pass in the vblank. Directly convert the call sites that already have the vblank pointer available.
--- drivers/gpu/drm/drm_internal.h | 6 +-- drivers/gpu/drm/drm_vblank.c | 77 ++++++++++++++++++------------- drivers/gpu/drm/drm_vblank_work.c | 12 ++--- 3 files changed, 55 insertions(+), 40 deletions(-)
drivers/gpu/drm/drm_internal.h +3 -3
@@ -101,9 +101,9 @@ static inline bool drm_vblank_passed(u64 seq, u64 ref) }void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe); -int drm_vblank_get (struct drm_device *dev,unsigned int pipe); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe); -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe); +int drm_vblank_get (struct drm_vblank_crtc *vblank); +void drm_vblank_put (struct drm_vblank_crtc *vblank); +u64 drm_vblank_count (struct drm_vblank_crtc *vblank);/* drm_vblank_work.c */ static inline void drm_vblank_flush_worker (struct drm_vblank_crtc *vblank)
drivers/gpu/drm/drm_vblank.c +46 -31
211 lines not on this page · raw message
drivers/gpu/drm/drm_vblank_work.c +6 -6
@@ -58,7 +58,7 @@ void drm_handle_vblank_works(struct drm_vblank_crtc *vblank)continue ;list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank);kthread_queue_work (vblank->worker, &work->base); wake = true; }
@@ -80,7 +80,7 @@ void drm_vblank_cancel_pending_works(struct drm_vblank_crtc *vblank)list_for_each_entry_safe (work, next, &vblank->pending_work, node) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); }wake_up_all (&vblank->work_wait_queue);
@@ -129,7 +129,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, goto out;if (list_empty (&work->node)) { - ret =drm_vblank_get (dev, vblank->pipe); + ret =drm_vblank_get (vblank);if (ret <0 ) goto out; }else if (work->count == count) {
@@ -140,7 +140,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, } work->count = count; - cur_vbl =drm_vblank_count (dev, vblank->pipe); + cur_vbl =drm_vblank_count (vblank); passed =drm_vblank_passed (cur_vbl, count);if (passed) drm_dbg_core(dev,
@@ -148,7 +148,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, vblank->pipe, count, cur_vbl);if (!nextonmiss && passed) { -drm_vblank_put (dev, vblank->pipe); +drm_vblank_put (vblank); ret =kthread_queue_work (vblank->worker, &work->base);if (rescheduling) {
@@ -193,7 +193,7 @@ bool drm_vblank_work_cancel_sync(struct drm_vblank_work *work)spin_lock_irq (&dev->event_lock);if (!list_empty (&work->node)) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); ret = true; }
Signature · 1 line
2.47.3
Thomas Zimmermann
maintainerRe: [PATCH 07/24] drm/vblank: pass vlank to drm_vblank_get()/_put()/_count()
s/vlank/vblank in the commit headline
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 5 lines
Pass struct
drm_vblank_crtc* todrm_vblank_get(),drm_vblank_put(), anddrm_vblank_count(). They'll figure out the vblank pointer as the first thing anyway, so it's handy to pass it when available. We can also rely on vblank having a valid pipe, and can reduce the number of checks we do.
I do agree that drm_vblank_crtc should be out go-to structure for these interfaces with wrappers around that do the lookup if necessary.
Quoted 17 lines
Add underscore prefixed helpers for using dev/pipe until we've converted all users to pass in the vblank. Directly convert the call sites that already have the vblank pointer available.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_internal.h | 6 +-- drivers/gpu/drm/drm_vblank.c | 77 ++++++++++++++++++------------- drivers/gpu/drm/drm_vblank_work.c | 12 ++--- 3 files changed, 55 insertions(+), 40 deletions(-)drivers/gpu/drm/drm_internal.h +0
-0
drivers/gpu/drm/drm_internal.h static inline bool drm_vblank_passed(u64 seq, u64 ref) · line 106
Quoted 9 lines
drivers/gpu/drm/drm_internal.h +3
-3@@ -101,9 +101,9 @@ static inline bool drm_vblank_passed(u64 seq, u64 ref) }void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe); -int drm_vblank_get (struct drm_device *dev,unsigned int pipe); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe); -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe); +int drm_vblank_get (struct drm_vblank_crtc *vblank); +void drm_vblank_put (struct drm_vblank_crtc *vblank); +u64 drm_vblank_count (struct drm_vblank_crtc *vblank);
Why no call these helpers drm_vblank_crtc_<func>() ? That would avoid the underscored helper and have clear naming guidelines for later such functions.
Quoted 293 lines
drivers/gpu/drm/drm_internal.h +0
-0/* drm_vblank_work.c */ static inline void drm_vblank_flush_worker (struct drm_vblank_crtc *vblank)drivers/gpu/drm/drm_vblank.c +46
-31@@ -384,14 +384,10 @@ static void drm_update_vblank_count(struct drm_device *dev, unsigned int pipe,store_vblank (dev, pipe, diff, t_vblank, cur_vblank); } -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe) +u64 drm_vblank_count (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);u64 count; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return 0 ; - count =atomic64_read (&vblank->count);/* @@ -406,6 +402,14 @@ u64 drm_vblank_count(struct drm_device *dev, unsigned int pipe)return count; } +static u64 _drm_vblank_count (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return 0 ; + +return drm_vblank_count (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_accurate_vblank_count - retrieve the master vblank counter * @crtc: which counter to retrieve @@ -431,7 +435,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)spin_lock_irqsave (&dev->vblank_time_lock, flags);drm_update_vblank_count (dev, pipe, false); - vblank =drm_vblank_count (dev, pipe); + vblank =_drm_vblank_count (dev, pipe);spin_unlock_irqrestore (&dev->vblank_time_lock, flags);@@ -935,7 +939,7 @@ drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,*/ u64 drm_crtc_vblank_count (struct drm_crtc *crtc) { -return drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); +return _drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_count);@@ -1208,18 +1212,16 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)return ret; } -int drm_vblank_get (struct drm_device *dev,unsigned int pipe) +int drm_vblank_get (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +int pipe = vblank->pipe;unsigned long irqflags;int ret =0 ;if (!drm_dev_has_vblank (dev))return -EINVAL ; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return -EINVAL ; -spin_lock_irqsave (&dev->vbl_lock, irqflags);/* Going from 0->1 means we have to enable interrupts again */ if (atomic_add_return (1 , &vblank->refcount) ==1 ) {@@ -1235,6 +1237,14 @@ int drm_vblank_get(struct drm_device *dev, unsigned int pipe)return ret; } +static int _drm_vblank_get (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return -EINVAL ; + +return drm_vblank_get (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_vblank_get - get a reference count on vblank events * @crtc: which CRTC to own @@ -1247,18 +1257,15 @@ int drm_vblank_get(struct drm_device *dev, unsigned int pipe)*/ int drm_crtc_vblank_get (struct drm_crtc *crtc) { -return drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); +return _drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_get); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe) +void drm_vblank_put (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;int vblank_offdelay = vblank->config.offdelay_ms; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -if (drm_WARN_ON (dev,atomic_read (&vblank->refcount) ==0 ))return ;@@ -1274,6 +1281,14 @@ void drm_vblank_put(struct drm_device *dev, unsigned int pipe) } } +static void _drm_vblank_put (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return ; + +drm_vblank_put (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_vblank_put - give up ownership of vblank events * @crtc: which counter to give up @@ -1284,7 +1299,7 @@ void drm_vblank_put(struct drm_device *dev, unsigned int pipe)*/ void drm_crtc_vblank_put (struct drm_crtc *crtc) { -drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); +_drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_put);@@ -1306,20 +1321,20 @@ int drm_crtc_wait_one_vblank(struct drm_crtc *crtc)int ret;u64 last; - ret =drm_vblank_get (dev, pipe); + ret =drm_vblank_get (vblank);if (drm_WARN (dev, ret,"vblank not available on crtc %i, ret=%i\n" , pipe, ret))return ret; - last =drm_vblank_count (dev, pipe); + last =drm_vblank_count (vblank); ret =wait_event_timeout (vblank->queue, - last !=drm_vblank_count (dev, pipe), + last !=drm_vblank_count (vblank),msecs_to_jiffies (1000 ));drm_WARN (dev, ret ==0 ,"vblank wait timed out on crtc %i\n" , pipe); -drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret ?0 : -ETIMEDOUT ; }@@ -1385,7 +1400,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)"wanted %llu, current %llu\n" , e->sequence, seq);list_del (&e->base.link); -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); }@@ -1661,7 +1676,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe, e->sequence = req_seq;if (drm_vblank_passed (seq, req_seq)) { -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); vblwait->reply.sequence = seq; }else {@@ -1678,7 +1693,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe,spin_unlock_irq (&dev->event_lock);kfree (e); err_put: -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);return ret; }@@ -1796,14 +1811,14 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return 0 ; } - ret =drm_vblank_get (dev, pipe); + ret =_drm_vblank_get (dev, pipe);if (ret) {drm_dbg_core (dev,"crtc %d failed to acquire vblank counter, %d\n" , pipe, ret);return ret; } - seq =drm_vblank_count (dev, pipe); + seq =_drm_vblank_count (dev, pipe);switch (vblwait->request.type & _DRM_VBLANK_TYPES_MASK) {case _DRM_VBLANK_RELATIVE:@@ -1839,7 +1854,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , req_seq, pipe); wait =wait_event_interruptible_timeout (vblank->queue, -drm_vblank_passed (drm_vblank_count (dev, pipe), req_seq) || +drm_vblank_passed (_drm_vblank_count (dev, pipe), req_seq) || !READ_ONCE (vblank->enabled),msecs_to_jiffies (3000 ));@@ -1869,7 +1884,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, } done: -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);return ret; }@@ -1895,7 +1910,7 @@ static void drm_handle_vblank_events(struct drm_device *dev, unsigned int pipe) e->sequence, seq);list_del (&e->base.link); -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); }drivers/gpu/drm/drm_vblank_work.c +6
-6@@ -58,7 +58,7 @@ void drm_handle_vblank_works(struct drm_vblank_crtc *vblank)continue ;list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank);kthread_queue_work (vblank->worker, &work->base); wake = true; }@@ -80,7 +80,7 @@ void drm_vblank_cancel_pending_works(struct drm_vblank_crtc *vblank)list_for_each_entry_safe (work, next, &vblank->pending_work, node) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); }wake_up_all (&vblank->work_wait_queue);@@ -129,7 +129,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, goto out;if (list_empty (&work->node)) { - ret =drm_vblank_get (dev, vblank->pipe); + ret =drm_vblank_get (vblank);if (ret <0 ) goto out; }else if (work->count == count) {@@ -140,7 +140,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, } work->count = count; - cur_vbl =drm_vblank_count (dev, vblank->pipe); + cur_vbl =drm_vblank_count (vblank); passed =drm_vblank_passed (cur_vbl, count);if (passed) drm_dbg_core(dev,@@ -148,7 +148,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, vblank->pipe, count, cur_vbl);if (!nextonmiss && passed) { -drm_vblank_put (dev, vblank->pipe); +drm_vblank_put (vblank); ret =kthread_queue_work (vblank->worker, &work->base);if (rescheduling) {@@ -193,7 +193,7 @@ bool drm_vblank_work_cancel_sync(struct drm_vblank_work *work)spin_lock_irq (&dev->event_lock);if (!list_empty (&work->node)) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); ret = true; }
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Re: [PATCH 07/24] drm/vblank: pass vlank to drm_vblank_get()/_put()/_count()
Quoted 31 lines · Thomas Zimmermann
s/vlank/vblank in the commit headline
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 5 lines
Pass struct
drm_vblank_crtc* todrm_vblank_get(),drm_vblank_put(), anddrm_vblank_count(). They'll figure out the vblank pointer as the first thing anyway, so it's handy to pass it when available. We can also rely on vblank having a valid pipe, and can reduce the number of checks we do.I do agree that
drm_vblank_crtcshould be out go-to structure for these interfaces with wrappers around that do the lookup if necessary.Quoted 19 lines
Add underscore prefixed helpers for using dev/pipe until we've converted all users to pass in the vblank. Directly convert the call sites that already have the vblank pointer available.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_internal.h | 6 +-- drivers/gpu/drm/drm_vblank.c | 77 ++++++++++++++++++------------- drivers/gpu/drm/drm_vblank_work.c | 12 ++--- 3 files changed, 55 insertions(+), 40 deletions(-)drivers/gpu/drm/drm_internal.h +0
-0@@ -101,9 +101,9 @@ static inline bool drm_vblank_passed(u64 seq, u64 ref) }
Quoted 11 lines
drivers/gpu/drm/drm_internal.h static inline bool drm_vblank_passed(u64 seq, u64 ref) · line 106
Quoted 7 lines
drivers/gpu/drm/drm_internal.h +3
-3void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe); -int drm_vblank_get (struct drm_device *dev,unsigned int pipe); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe); -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe); +int drm_vblank_get (struct drm_vblank_crtc *vblank); +void drm_vblank_put (struct drm_vblank_crtc *vblank); +u64 drm_vblank_count (struct drm_vblank_crtc *vblank);Why no call these helpers drm_vblank_crtc_<func>() ? That would avoid the underscored helper and have clear naming guidelines for later such functions.
I didn't really pay much attention to it. There's a lot of crtc in the names already, so I guess the convention would then be:
drm_crtc_vblank_*(struct drm_crtc *crtc, ...) drm_vblank_crtc_*(struct drm_vblank_crtc *vblank, ...)
No big deal for me to rename if you think that's a good convention.
The underscored helpers are temporary, and will get removed later in the series. IMO the series is easier to review that way. Of course cleaner if we don't have to add them in the first place.
BR,
Jani.
Quoted 294 lines
Quoted 294 lines
drivers/gpu/drm/drm_internal.h +0
-0/* drm_vblank_work.c */ static inline void drm_vblank_flush_worker (struct drm_vblank_crtc *vblank)drivers/gpu/drm/drm_vblank.c +46
-31@@ -384,14 +384,10 @@ static void drm_update_vblank_count(struct drm_device *dev, unsigned int pipe,store_vblank (dev, pipe, diff, t_vblank, cur_vblank); } -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe) +u64 drm_vblank_count (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);u64 count; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return 0 ; - count =atomic64_read (&vblank->count);/* @@ -406,6 +402,14 @@ u64 drm_vblank_count(struct drm_device *dev, unsigned int pipe)return count; } +static u64 _drm_vblank_count (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return 0 ; + +return drm_vblank_count (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_accurate_vblank_count - retrieve the master vblank counter * @crtc: which counter to retrieve @@ -431,7 +435,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)spin_lock_irqsave (&dev->vblank_time_lock, flags);drm_update_vblank_count (dev, pipe, false); - vblank =drm_vblank_count (dev, pipe); + vblank =_drm_vblank_count (dev, pipe);spin_unlock_irqrestore (&dev->vblank_time_lock, flags);@@ -935,7 +939,7 @@ drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,*/ u64 drm_crtc_vblank_count (struct drm_crtc *crtc) { -return drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); +return _drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_count);@@ -1208,18 +1212,16 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)return ret; } -int drm_vblank_get (struct drm_device *dev,unsigned int pipe) +int drm_vblank_get (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +int pipe = vblank->pipe;unsigned long irqflags;int ret =0 ;if (!drm_dev_has_vblank (dev))return -EINVAL ; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return -EINVAL ; -spin_lock_irqsave (&dev->vbl_lock, irqflags);/* Going from 0->1 means we have to enable interrupts again */ if (atomic_add_return (1 , &vblank->refcount) ==1 ) {@@ -1235,6 +1237,14 @@ int drm_vblank_get(struct drm_device *dev, unsigned int pipe)return ret; } +static int _drm_vblank_get (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return -EINVAL ; + +return drm_vblank_get (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_vblank_get - get a reference count on vblank events * @crtc: which CRTC to own @@ -1247,18 +1257,15 @@ int drm_vblank_get(struct drm_device *dev, unsigned int pipe)*/ int drm_crtc_vblank_get (struct drm_crtc *crtc) { -return drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); +return _drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_get); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe) +void drm_vblank_put (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;int vblank_offdelay = vblank->config.offdelay_ms; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -if (drm_WARN_ON (dev,atomic_read (&vblank->refcount) ==0 ))return ;@@ -1274,6 +1281,14 @@ void drm_vblank_put(struct drm_device *dev, unsigned int pipe) } } +static void _drm_vblank_put (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return ; + +drm_vblank_put (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_vblank_put - give up ownership of vblank events * @crtc: which counter to give up @@ -1284,7 +1299,7 @@ void drm_vblank_put(struct drm_device *dev, unsigned int pipe)*/ void drm_crtc_vblank_put (struct drm_crtc *crtc) { -drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); +_drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_put);@@ -1306,20 +1321,20 @@ int drm_crtc_wait_one_vblank(struct drm_crtc *crtc)int ret;u64 last; - ret =drm_vblank_get (dev, pipe); + ret =drm_vblank_get (vblank);if (drm_WARN (dev, ret,"vblank not available on crtc %i, ret=%i\n" , pipe, ret))return ret; - last =drm_vblank_count (dev, pipe); + last =drm_vblank_count (vblank); ret =wait_event_timeout (vblank->queue, - last !=drm_vblank_count (dev, pipe), + last !=drm_vblank_count (vblank),msecs_to_jiffies (1000 ));drm_WARN (dev, ret ==0 ,"vblank wait timed out on crtc %i\n" , pipe); -drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret ?0 : -ETIMEDOUT ; }@@ -1385,7 +1400,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)"wanted %llu, current %llu\n" , e->sequence, seq);list_del (&e->base.link); -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); }@@ -1661,7 +1676,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe, e->sequence = req_seq;if (drm_vblank_passed (seq, req_seq)) { -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); vblwait->reply.sequence = seq; }else {@@ -1678,7 +1693,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe,spin_unlock_irq (&dev->event_lock);kfree (e); err_put: -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);return ret; }@@ -1796,14 +1811,14 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return 0 ; } - ret =drm_vblank_get (dev, pipe); + ret =_drm_vblank_get (dev, pipe);if (ret) {drm_dbg_core (dev,"crtc %d failed to acquire vblank counter, %d\n" , pipe, ret);return ret; } - seq =drm_vblank_count (dev, pipe); + seq =_drm_vblank_count (dev, pipe);switch (vblwait->request.type & _DRM_VBLANK_TYPES_MASK) {case _DRM_VBLANK_RELATIVE:@@ -1839,7 +1854,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , req_seq, pipe); wait =wait_event_interruptible_timeout (vblank->queue, -drm_vblank_passed (drm_vblank_count (dev, pipe), req_seq) || +drm_vblank_passed (_drm_vblank_count (dev, pipe), req_seq) || !READ_ONCE (vblank->enabled),msecs_to_jiffies (3000 ));@@ -1869,7 +1884,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, } done: -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);return ret; }@@ -1895,7 +1910,7 @@ static void drm_handle_vblank_events(struct drm_device *dev, unsigned int pipe) e->sequence, seq);list_del (&e->base.link); -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); }drivers/gpu/drm/drm_vblank_work.c +6
-6@@ -58,7 +58,7 @@ void drm_handle_vblank_works(struct drm_vblank_crtc *vblank)continue ;list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank);kthread_queue_work (vblank->worker, &work->base); wake = true; }@@ -80,7 +80,7 @@ void drm_vblank_cancel_pending_works(struct drm_vblank_crtc *vblank)list_for_each_entry_safe (work, next, &vblank->pending_work, node) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); }wake_up_all (&vblank->work_wait_queue);@@ -129,7 +129,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, goto out;if (list_empty (&work->node)) { - ret =drm_vblank_get (dev, vblank->pipe); + ret =drm_vblank_get (vblank);if (ret <0 ) goto out; }else if (work->count == count) {@@ -140,7 +140,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, } work->count = count; - cur_vbl =drm_vblank_count (dev, vblank->pipe); + cur_vbl =drm_vblank_count (vblank); passed =drm_vblank_passed (cur_vbl, count);if (passed) drm_dbg_core(dev,@@ -148,7 +148,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, vblank->pipe, count, cur_vbl);if (!nextonmiss && passed) { -drm_vblank_put (dev, vblank->pipe); +drm_vblank_put (vblank); ret =kthread_queue_work (vblank->worker, &work->base);if (rescheduling) {@@ -193,7 +193,7 @@ bool drm_vblank_work_cancel_sync(struct drm_vblank_work *work)spin_lock_irq (&dev->event_lock);if (!list_empty (&work->node)) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); ret = true; }
Signature · 1 line
Jani Nikula, Intel
Thomas Zimmermann
maintainerRe: [PATCH 07/24] drm/vblank: pass vlank to drm_vblank_get()/_put()/_count()
Hi
Am 11.11.25 um 09:53 schrieb Jani Nikula:
Quoted 40 lines · Thomas Zimmermann
Quoted 29 lines
s/vlank/vblank in the commit headline
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 5 lines
Pass struct
drm_vblank_crtc* todrm_vblank_get(),drm_vblank_put(), anddrm_vblank_count(). They'll figure out the vblank pointer as the first thing anyway, so it's handy to pass it when available. We can also rely on vblank having a valid pipe, and can reduce the number of checks we do.I do agree that
drm_vblank_crtcshould be out go-to structure for these interfaces with wrappers around that do the lookup if necessary.Quoted 18 lines
Add underscore prefixed helpers for using dev/pipe until we've converted all users to pass in the vblank. Directly convert the call sites that already have the vblank pointer available.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_internal.h | 6 +-- drivers/gpu/drm/drm_vblank.c | 77 ++++++++++++++++++------------- drivers/gpu/drm/drm_vblank_work.c | 12 ++--- 3 files changed, 55 insertions(+), 40 deletions(-)drivers/gpu/drm/drm_internal.h +0
-0@@ -101,9 +101,9 @@ static inline bool drm_vblank_passed(u64 seq, u64 ref) }Quoted 10 lines
drivers/gpu/drm/drm_internal.h static inline bool drm_vblank_passed(u64 seq, u64 ref) · line 106
Quoted 7 lines
drivers/gpu/drm/drm_internal.h +3
-3void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe); -int drm_vblank_get (struct drm_device *dev,unsigned int pipe); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe); -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe); +int drm_vblank_get (struct drm_vblank_crtc *vblank); +void drm_vblank_put (struct drm_vblank_crtc *vblank); +u64 drm_vblank_count (struct drm_vblank_crtc *vblank);Why no call these helpers drm_vblank_crtc_<func>() ? That would avoid the underscored helper and have clear naming guidelines for later such functions.
Quoted 8 lines
I didn't really pay much attention to it. There's a lot of crtc in the names already, so I guess the convention would then be:
drm_crtc_vblank_*(struct drm_crtc *crtc, ...) drm_vblank_crtc_*(struct drm_vblank_crtc *vblank, ...)No big deal for me to rename if you think that's a good convention.
Right. The third pattern would be
drm_vblank_*(struct drm_device, int pipe, ...)
The implementation would then gradually move towards using drm_vblank_crtc_ where possible. Makes sense to me and would avoid any intermediate helpers.
Best regards
Thomas
Quoted 301 lines
The underscored helpers are temporary, and will get removed later in the series. IMO the series is easier to review that way. Of course cleaner if we don't have to add them in the first place.
BR,
Jani.Quoted 293 lines
Quoted 293 lines
drivers/gpu/drm/drm_internal.h +0
-0/* drm_vblank_work.c */ static inline void drm_vblank_flush_worker (struct drm_vblank_crtc *vblank)drivers/gpu/drm/drm_vblank.c +46
-31@@ -384,14 +384,10 @@ static void drm_update_vblank_count(struct drm_device *dev, unsigned int pipe,store_vblank (dev, pipe, diff, t_vblank, cur_vblank); } -u64 drm_vblank_count (struct drm_device *dev,unsigned int pipe) +u64 drm_vblank_count (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);u64 count; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return 0 ; - count =atomic64_read (&vblank->count);/* @@ -406,6 +402,14 @@ u64 drm_vblank_count(struct drm_device *dev, unsigned int pipe)return count; } +static u64 _drm_vblank_count (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return 0 ; + +return drm_vblank_count (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_accurate_vblank_count - retrieve the master vblank counter * @crtc: which counter to retrieve @@ -431,7 +435,7 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)spin_lock_irqsave (&dev->vblank_time_lock, flags);drm_update_vblank_count (dev, pipe, false); - vblank =drm_vblank_count (dev, pipe); + vblank =_drm_vblank_count (dev, pipe);spin_unlock_irqrestore (&dev->vblank_time_lock, flags);@@ -935,7 +939,7 @@ drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,*/ u64 drm_crtc_vblank_count (struct drm_crtc *crtc) { -return drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); +return _drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_count);@@ -1208,18 +1212,16 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)return ret; } -int drm_vblank_get (struct drm_device *dev,unsigned int pipe) +int drm_vblank_get (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +int pipe = vblank->pipe;unsigned long irqflags;int ret =0 ;if (!drm_dev_has_vblank (dev))return -EINVAL ; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return -EINVAL ; -spin_lock_irqsave (&dev->vbl_lock, irqflags);/* Going from 0->1 means we have to enable interrupts again */ if (atomic_add_return (1 , &vblank->refcount) ==1 ) {@@ -1235,6 +1237,14 @@ int drm_vblank_get(struct drm_device *dev, unsigned int pipe)return ret; } +static int _drm_vblank_get (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return -EINVAL ; + +return drm_vblank_get (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_vblank_get - get a reference count on vblank events * @crtc: which CRTC to own @@ -1247,18 +1257,15 @@ int drm_vblank_get(struct drm_device *dev, unsigned int pipe)*/ int drm_crtc_vblank_get (struct drm_crtc *crtc) { -return drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); +return _drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_get); -void drm_vblank_put (struct drm_device *dev,unsigned int pipe) +void drm_vblank_put (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;int vblank_offdelay = vblank->config.offdelay_ms; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -if (drm_WARN_ON (dev,atomic_read (&vblank->refcount) ==0 ))return ;@@ -1274,6 +1281,14 @@ void drm_vblank_put(struct drm_device *dev, unsigned int pipe) } } +static void _drm_vblank_put (struct drm_device *dev,unsigned int pipe) +{ +if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) +return ; + +drm_vblank_put (drm_vblank_crtc (dev, pipe)); +} +/** * drm_crtc_vblank_put - give up ownership of vblank events * @crtc: which counter to give up @@ -1284,7 +1299,7 @@ void drm_vblank_put(struct drm_device *dev, unsigned int pipe)*/ void drm_crtc_vblank_put (struct drm_crtc *crtc) { -drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); +_drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_put);@@ -1306,20 +1321,20 @@ int drm_crtc_wait_one_vblank(struct drm_crtc *crtc)int ret;u64 last; - ret =drm_vblank_get (dev, pipe); + ret =drm_vblank_get (vblank);if (drm_WARN (dev, ret,"vblank not available on crtc %i, ret=%i\n" , pipe, ret))return ret; - last =drm_vblank_count (dev, pipe); + last =drm_vblank_count (vblank); ret =wait_event_timeout (vblank->queue, - last !=drm_vblank_count (dev, pipe), + last !=drm_vblank_count (vblank),msecs_to_jiffies (1000 ));drm_WARN (dev, ret ==0 ,"vblank wait timed out on crtc %i\n" , pipe); -drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret ?0 : -ETIMEDOUT ; }@@ -1385,7 +1400,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)"wanted %llu, current %llu\n" , e->sequence, seq);list_del (&e->base.link); -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); }@@ -1661,7 +1676,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe, e->sequence = req_seq;if (drm_vblank_passed (seq, req_seq)) { -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); vblwait->reply.sequence = seq; }else {@@ -1678,7 +1693,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe,spin_unlock_irq (&dev->event_lock);kfree (e); err_put: -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);return ret; }@@ -1796,14 +1811,14 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return 0 ; } - ret =drm_vblank_get (dev, pipe); + ret =_drm_vblank_get (dev, pipe);if (ret) {drm_dbg_core (dev,"crtc %d failed to acquire vblank counter, %d\n" , pipe, ret);return ret; } - seq =drm_vblank_count (dev, pipe); + seq =_drm_vblank_count (dev, pipe);switch (vblwait->request.type & _DRM_VBLANK_TYPES_MASK) {case _DRM_VBLANK_RELATIVE:@@ -1839,7 +1854,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , req_seq, pipe); wait =wait_event_interruptible_timeout (vblank->queue, -drm_vblank_passed (drm_vblank_count (dev, pipe), req_seq) || +drm_vblank_passed (_drm_vblank_count (dev, pipe), req_seq) || !READ_ONCE (vblank->enabled),msecs_to_jiffies (3000 ));@@ -1869,7 +1884,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, } done: -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);return ret; }@@ -1895,7 +1910,7 @@ static void drm_handle_vblank_events(struct drm_device *dev, unsigned int pipe) e->sequence, seq);list_del (&e->base.link); -drm_vblank_put (dev, pipe); +_drm_vblank_put (dev, pipe);send_vblank_event (dev, e, seq, now); }drivers/gpu/drm/drm_vblank_work.c +6
-6@@ -58,7 +58,7 @@ void drm_handle_vblank_works(struct drm_vblank_crtc *vblank)continue ;list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank);kthread_queue_work (vblank->worker, &work->base); wake = true; }@@ -80,7 +80,7 @@ void drm_vblank_cancel_pending_works(struct drm_vblank_crtc *vblank)list_for_each_entry_safe (work, next, &vblank->pending_work, node) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); }wake_up_all (&vblank->work_wait_queue);@@ -129,7 +129,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, goto out;if (list_empty (&work->node)) { - ret =drm_vblank_get (dev, vblank->pipe); + ret =drm_vblank_get (vblank);if (ret <0 ) goto out; }else if (work->count == count) {@@ -140,7 +140,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, } work->count = count; - cur_vbl =drm_vblank_count (dev, vblank->pipe); + cur_vbl =drm_vblank_count (vblank); passed =drm_vblank_passed (cur_vbl, count);if (passed) drm_dbg_core(dev,@@ -148,7 +148,7 @@ int drm_vblank_work_schedule(struct drm_vblank_work *work, vblank->pipe, count, cur_vbl);if (!nextonmiss && passed) { -drm_vblank_put (dev, vblank->pipe); +drm_vblank_put (vblank); ret =kthread_queue_work (vblank->worker, &work->base);if (rescheduling) {@@ -193,7 +193,7 @@ bool drm_vblank_work_cancel_sync(struct drm_vblank_work *work)spin_lock_irq (&dev->event_lock);if (!list_empty (&work->node)) {list_del_init (&work->node); -drm_vblank_put (vblank->dev, vblank->pipe); +drm_vblank_put (vblank); ret = true; }
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 8/24 drm/vblank: pass vblank to drm_update_vblank_count()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
drivers/gpu/drm/drm_vblank.c +11 -10
@@ -292,10 +292,11 @@ static void drm_reset_vblank_timestamp(struct drm_device *dev, unsigned int pipe* Note: caller must hold &drm_device.vbl_lock since this reads & writes * device vblank fields. */ -static void drm_update_vblank_count (struct drm_device *dev,unsigned int pipe, +static void drm_update_vblank_count (struct drm_vblank_crtc *vblank,bool in_vblank_irq) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;u32 cur_vblank, diff;bool rc;ktime_t t_vblank;
@@ -424,8 +425,8 @@ static u64 _drm_vblank_count(struct drm_device *dev, unsigned int pipe)u64 drm_crtc_accurate_vblank_count (struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc); -u64 vblank; +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); +u64 vblank_count;unsigned long flags; drm_WARN_ONCE(dev, drm_debug_enabled(DRM_UT_VBL) &&
@@ -434,12 +435,12 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)spin_lock_irqsave (&dev->vblank_time_lock, flags); -drm_update_vblank_count (dev, pipe, false); - vblank =_drm_vblank_count (dev, pipe); +drm_update_vblank_count (vblank, false); + vblank_count =drm_vblank_count (vblank);spin_unlock_irqrestore (&dev->vblank_time_lock, flags); -return vblank; +return vblank_count; }EXPORT_SYMBOL (drm_crtc_accurate_vblank_count);
@@ -490,7 +491,7 @@ void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe)* this time. This makes the count account for the entire time * between drm_crtc_vblank_on() and drm_crtc_vblank_off(). */ -drm_update_vblank_count (dev, pipe, false); +drm_update_vblank_count (vblank, false);__disable_vblank (dev, pipe); vblank->enabled = false;
@@ -1197,7 +1198,7 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)if (ret) {atomic_dec (&vblank->refcount); }else { -drm_update_vblank_count (dev, pipe,0 ); +drm_update_vblank_count (vblank,0 );/* drm_update_vblank_count() includes a wmb so we just * need to ensure that the compiler emits the write * to mark the vblank as enabled after the call
@@ -1957,7 +1958,7 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe)return false; } -drm_update_vblank_count (dev, pipe, true); +drm_update_vblank_count (vblank, true);spin_unlock (&dev->vblank_time_lock);
Signature · 1 line
2.47.3
Re: [PATCH 08/24] drm/vblank: pass vblank to drm_update_vblank_count()
Hi
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 1 line
Use the vblank pointer instead of a dev, pipe pair to simplify code.
I always thought the code could benefit from this change. Great to see it happen.
Quoted 2 lines
Signed-off-by Jani Nikula <[email protected]>
For this patch and the others, I assume that some interfaces might change there names as we discussed.
Quoted 76 lines
--- drivers/gpu/drm/drm_vblank.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)drivers/gpu/drm/drm_vblank.c +11
-10@@ -292,10 +292,11 @@ static void drm_reset_vblank_timestamp(struct drm_device *dev, unsigned int pipe* Note: caller must hold &drm_device.vbl_lock since this reads & writes * device vblank fields. */ -static void drm_update_vblank_count (struct drm_device *dev,unsigned int pipe, +static void drm_update_vblank_count (struct drm_vblank_crtc *vblank,bool in_vblank_irq) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;u32 cur_vblank, diff;bool rc;ktime_t t_vblank;@@ -424,8 +425,8 @@ static u64 _drm_vblank_count(struct drm_device *dev, unsigned int pipe)u64 drm_crtc_accurate_vblank_count (struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc); -u64 vblank; +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); +u64 vblank_count;unsigned long flags; drm_WARN_ONCE(dev, drm_debug_enabled(DRM_UT_VBL) &&@@ -434,12 +435,12 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)spin_lock_irqsave (&dev->vblank_time_lock, flags); -drm_update_vblank_count (dev, pipe, false); - vblank =_drm_vblank_count (dev, pipe); +drm_update_vblank_count (vblank, false); + vblank_count =drm_vblank_count (vblank);spin_unlock_irqrestore (&dev->vblank_time_lock, flags); -return vblank; +return vblank_count; }EXPORT_SYMBOL (drm_crtc_accurate_vblank_count);@@ -490,7 +491,7 @@ void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe)* this time. This makes the count account for the entire time * between drm_crtc_vblank_on() and drm_crtc_vblank_off(). */ -drm_update_vblank_count (dev, pipe, false); +drm_update_vblank_count (vblank, false);__disable_vblank (dev, pipe); vblank->enabled = false;@@ -1197,7 +1198,7 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)if (ret) {atomic_dec (&vblank->refcount); }else { -drm_update_vblank_count (dev, pipe,0 ); +drm_update_vblank_count (vblank,0 );/* drm_update_vblank_count() includes a wmb so we just * need to ensure that the compiler emits the write * to mark the vblank as enabled after the call @@ -1957,7 +1958,7 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe)return false; } -drm_update_vblank_count (dev, pipe, true); +drm_update_vblank_count (vblank, true);spin_unlock (&dev->vblank_time_lock);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 9/24 drm/vblank: pass vblank to drm_handle_vblank_events()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_vblank.c +5 -3
@@ -1889,8 +1889,10 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return ret; } -static void drm_handle_vblank_events (struct drm_device *dev,unsigned int pipe) +static void drm_handle_vblank_events (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe);bool high_prec = false;struct drm_pending_vblank_event *e, *t;
@@ -1911,7 +1913,7 @@ static void drm_handle_vblank_events(struct drm_device *dev, unsigned int pipe) e->sequence, seq);list_del (&e->base.link); -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now); }
@@ -1973,7 +1975,7 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe) vblank->config.offdelay_ms >0 && !atomic_read(&vblank->refcount)); -drm_handle_vblank_events (dev, pipe); +drm_handle_vblank_events (vblank);drm_handle_vblank_works (vblank);spin_unlock_irqrestore (&dev->event_lock, irqflags);
Signature · 1 line
2.47.3
Re: [PATCH 09/24] drm/vblank: pass vblank to drm_handle_vblank_events()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 38 lines
--- drivers/gpu/drm/drm_vblank.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_vblank.c +5
-3@@ -1889,8 +1889,10 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return ret; } -static void drm_handle_vblank_events (struct drm_device *dev,unsigned int pipe) +static void drm_handle_vblank_events (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe);bool high_prec = false;struct drm_pending_vblank_event *e, *t;@@ -1911,7 +1913,7 @@ static void drm_handle_vblank_events(struct drm_device *dev, unsigned int pipe) e->sequence, seq);list_del (&e->base.link); -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now); }@@ -1973,7 +1975,7 @@ bool drm_handle_vblank(struct drm_device *dev, unsigned int pipe) vblank->config.offdelay_ms >0 && !atomic_read(&vblank->refcount)); -drm_handle_vblank_events (dev, pipe); +drm_handle_vblank_events (vblank);drm_handle_vblank_works (vblank);spin_unlock_irqrestore (&dev->event_lock, irqflags);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 10/24 drm/vblank: use the vblank based interfaces more
In reply to Jani NikulaWith the prep work in place, we can get rid of _drm_vblank_get(), _drm_vblank_put(), and _drm_vblank_count().
--- drivers/gpu/drm/drm_vblank.c | 44 ++++++++---------------------------- 1 file changed, 10 insertions(+), 34 deletions(-)
drivers/gpu/drm/drm_vblank.c +10 -34
@@ -403,14 +403,6 @@ u64 drm_vblank_count(struct drm_vblank_crtc *vblank)return count; } -static u64 _drm_vblank_count (struct drm_device *dev,unsigned int pipe) -{ -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return 0 ; - -return drm_vblank_count (drm_vblank_crtc (dev, pipe)); -} -/** * drm_crtc_accurate_vblank_count - retrieve the master vblank counter * @crtc: which counter to retrieve
@@ -940,7 +932,7 @@ drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,*/ u64 drm_crtc_vblank_count (struct drm_crtc *crtc) { -return _drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); +return drm_vblank_count (drm_crtc_vblank_crtc (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_count);
@@ -1238,14 +1230,6 @@ int drm_vblank_get(struct drm_vblank_crtc *vblank)return ret; } -static int _drm_vblank_get (struct drm_device *dev,unsigned int pipe) -{ -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return -EINVAL ; - -return drm_vblank_get (drm_vblank_crtc (dev, pipe)); -} -/** * drm_crtc_vblank_get - get a reference count on vblank events * @crtc: which CRTC to own
@@ -1258,7 +1242,7 @@ static int _drm_vblank_get(struct drm_device *dev, unsigned int pipe)*/ int drm_crtc_vblank_get (struct drm_crtc *crtc) { -return _drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); +return drm_vblank_get (drm_crtc_vblank_crtc (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_get);
@@ -1282,14 +1266,6 @@ void drm_vblank_put(struct drm_vblank_crtc *vblank) } } -static void _drm_vblank_put (struct drm_device *dev,unsigned int pipe) -{ -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; - -drm_vblank_put (drm_vblank_crtc (dev, pipe)); -} -/** * drm_crtc_vblank_put - give up ownership of vblank events * @crtc: which counter to give up
@@ -1300,7 +1276,7 @@ static void _drm_vblank_put(struct drm_device *dev, unsigned int pipe)*/ void drm_crtc_vblank_put (struct drm_crtc *crtc) { -_drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); +drm_vblank_put (drm_crtc_vblank_crtc (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_put);
@@ -1401,7 +1377,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)"wanted %llu, current %llu\n" , e->sequence, seq);list_del (&e->base.link); -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now); }
@@ -1677,7 +1653,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe, e->sequence = req_seq;if (drm_vblank_passed (seq, req_seq)) { -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now); vblwait->reply.sequence = seq; }else {
@@ -1694,7 +1670,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe,spin_unlock_irq (&dev->event_lock);kfree (e); err_put: -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret; }
@@ -1812,14 +1788,14 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return 0 ; } - ret =_drm_vblank_get (dev, pipe); + ret =drm_vblank_get (vblank);if (ret) {drm_dbg_core (dev,"crtc %d failed to acquire vblank counter, %d\n" , pipe, ret);return ret; } - seq =_drm_vblank_count (dev, pipe); + seq =drm_vblank_count (vblank);switch (vblwait->request.type & _DRM_VBLANK_TYPES_MASK) {case _DRM_VBLANK_RELATIVE:
@@ -1855,7 +1831,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , req_seq, pipe); wait =wait_event_interruptible_timeout (vblank->queue, -drm_vblank_passed (_drm_vblank_count (dev, pipe), req_seq) || +drm_vblank_passed (drm_vblank_count (vblank), req_seq) || !READ_ONCE (vblank->enabled),msecs_to_jiffies (3000 ));
@@ -1885,7 +1861,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, } done: -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret; }
Signature · 1 line
2.47.3
Re: [PATCH 10/24] drm/vblank: use the vblank based interfaces more
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 4 lines
With the prep work in place, we can get rid of
_drm_vblank_get(),_drm_vblank_put(), and_drm_vblank_count().Signed-off-by Jani Nikula <[email protected]>
Quoted 142 lines
--- drivers/gpu/drm/drm_vblank.c | 44 ++++++++---------------------------- 1 file changed, 10 insertions(+), 34 deletions(-)drivers/gpu/drm/drm_vblank.c +10
-34@@ -403,14 +403,6 @@ u64 drm_vblank_count(struct drm_vblank_crtc *vblank)return count; } -static u64 _drm_vblank_count (struct drm_device *dev,unsigned int pipe) -{ -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return 0 ; - -return drm_vblank_count (drm_vblank_crtc (dev, pipe)); -} -/** * drm_crtc_accurate_vblank_count - retrieve the master vblank counter * @crtc: which counter to retrieve @@ -940,7 +932,7 @@ drm_get_last_vbltimestamp(struct drm_device *dev, unsigned int pipe,*/ u64 drm_crtc_vblank_count (struct drm_crtc *crtc) { -return _drm_vblank_count (crtc->dev,drm_crtc_index (crtc)); +return drm_vblank_count (drm_crtc_vblank_crtc (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_count);@@ -1238,14 +1230,6 @@ int drm_vblank_get(struct drm_vblank_crtc *vblank)return ret; } -static int _drm_vblank_get (struct drm_device *dev,unsigned int pipe) -{ -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return -EINVAL ; - -return drm_vblank_get (drm_vblank_crtc (dev, pipe)); -} -/** * drm_crtc_vblank_get - get a reference count on vblank events * @crtc: which CRTC to own @@ -1258,7 +1242,7 @@ static int _drm_vblank_get(struct drm_device *dev, unsigned int pipe)*/ int drm_crtc_vblank_get (struct drm_crtc *crtc) { -return _drm_vblank_get (crtc->dev,drm_crtc_index (crtc)); +return drm_vblank_get (drm_crtc_vblank_crtc (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_get);@@ -1282,14 +1266,6 @@ void drm_vblank_put(struct drm_vblank_crtc *vblank) } } -static void _drm_vblank_put (struct drm_device *dev,unsigned int pipe) -{ -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; - -drm_vblank_put (drm_vblank_crtc (dev, pipe)); -} -/** * drm_crtc_vblank_put - give up ownership of vblank events * @crtc: which counter to give up @@ -1300,7 +1276,7 @@ static void _drm_vblank_put(struct drm_device *dev, unsigned int pipe)*/ void drm_crtc_vblank_put (struct drm_crtc *crtc) { -_drm_vblank_put (crtc->dev,drm_crtc_index (crtc)); +drm_vblank_put (drm_crtc_vblank_crtc (crtc)); }EXPORT_SYMBOL (drm_crtc_vblank_put);@@ -1401,7 +1377,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)"wanted %llu, current %llu\n" , e->sequence, seq);list_del (&e->base.link); -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now); }@@ -1677,7 +1653,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe, e->sequence = req_seq;if (drm_vblank_passed (seq, req_seq)) { -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now); vblwait->reply.sequence = seq; }else {@@ -1694,7 +1670,7 @@ static int drm_queue_vblank_event(struct drm_device *dev, unsigned int pipe,spin_unlock_irq (&dev->event_lock);kfree (e); err_put: -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret; }@@ -1812,14 +1788,14 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,return 0 ; } - ret =_drm_vblank_get (dev, pipe); + ret =drm_vblank_get (vblank);if (ret) {drm_dbg_core (dev,"crtc %d failed to acquire vblank counter, %d\n" , pipe, ret);return ret; } - seq =_drm_vblank_count (dev, pipe); + seq =drm_vblank_count (vblank);switch (vblwait->request.type & _DRM_VBLANK_TYPES_MASK) {case _DRM_VBLANK_RELATIVE:@@ -1855,7 +1831,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , req_seq, pipe); wait =wait_event_interruptible_timeout (vblank->queue, -drm_vblank_passed (_drm_vblank_count (dev, pipe), req_seq) || +drm_vblank_passed (drm_vblank_count (vblank), req_seq) || !READ_ONCE (vblank->enabled),msecs_to_jiffies (3000 ));@@ -1885,7 +1861,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, } done: -_drm_vblank_put (dev, pipe); +drm_vblank_put (vblank);return ret; }
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 11/24 drm/vblank: pass vblank to drm_queue_vblank_event()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_vblank.c +4 -3
@@ -1596,12 +1596,13 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_restore); -static int drm_queue_vblank_event (struct drm_device *dev,unsigned int pipe, +static int drm_queue_vblank_event (struct drm_vblank_crtc *vblank,u64 req_seq,union drm_wait_vblank *vblwait,struct drm_file *file_priv) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;struct drm_pending_vblank_event *e;ktime_t now;u64 seq;
@@ -1822,7 +1823,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,/* must hold on to the vblank ref until the event fires * drm_vblank_put will be called asynchronously */ -return drm_queue_vblank_event (dev, pipe, req_seq, vblwait, file_priv); +return drm_queue_vblank_event (vblank, req_seq, vblwait, file_priv); }if (req_seq != seq) {
Signature · 1 line
2.47.3
Re: [PATCH 11/24] drm/vblank: pass vblank to drm_queue_vblank_event()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 33 lines
--- drivers/gpu/drm/drm_vblank.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_vblank.c +4
-3@@ -1596,12 +1596,13 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_restore); -static int drm_queue_vblank_event (struct drm_device *dev,unsigned int pipe, +static int drm_queue_vblank_event (struct drm_vblank_crtc *vblank,u64 req_seq,union drm_wait_vblank *vblwait,struct drm_file *file_priv) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;struct drm_pending_vblank_event *e;ktime_t now;u64 seq;@@ -1822,7 +1823,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,/* must hold on to the vblank ref until the event fires * drm_vblank_put will be called asynchronously */ -return drm_queue_vblank_event (dev, pipe, req_seq, vblwait, file_priv); +return drm_queue_vblank_event (vblank, req_seq, vblwait, file_priv); }if (req_seq != seq) {
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 12/24 drm/vblank: pass vblank to drm_wait_vblank_reply()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_vblank.c +4 -4
@@ -1702,7 +1702,7 @@ static u64 widen_32_to_64(u32 narrow, u64 near)return near + (s32) (narrow - near); } -static void drm_wait_vblank_reply (struct drm_device *dev,unsigned int pipe, +static void drm_wait_vblank_reply (struct drm_vblank_crtc *vblank,struct drm_wait_vblank_reply *reply) {ktime_t now;
@@ -1713,7 +1713,7 @@ static void drm_wait_vblank_reply(struct drm_device *dev, unsigned int pipe,* to store the seconds. This is safe as we always use monotonic * timestamps since linux-4.15. */ - reply->sequence =drm_vblank_count_and_time (dev, pipe, &now); + reply->sequence =drm_vblank_count_and_time (vblank->dev, vblank->pipe, &now); ts =ktime_to_timespec64 (now); reply->tval_sec = (u32 )ts.tv_sec; reply->tval_usec = ts.tv_nsec /1000 ;
@@ -1785,7 +1785,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (vblank->config.disable_immediate &&drm_wait_vblank_is_query (vblwait) &&READ_ONCE (vblank->enabled)) { -drm_wait_vblank_reply (dev, pipe, &vblwait->reply); +drm_wait_vblank_reply (vblank, &vblwait->reply);return 0 ; }
@@ -1852,7 +1852,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, }if (ret != -EINTR ) { -drm_wait_vblank_reply (dev, pipe, &vblwait->reply); +drm_wait_vblank_reply (vblank, &vblwait->reply);drm_dbg_core (dev,"crtc %d returning %u to client\n" , pipe, vblwait->reply.sequence);
Signature · 1 line
2.47.3
Re: [PATCH 12/24] drm/vblank: pass vblank to drm_wait_vblank_reply()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
See my comment below.
Quoted 18 lines
--- drivers/gpu/drm/drm_vblank.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_vblank.c +1
-1@@ -1702,7 +1702,7 @@ static u64 widen_32_to_64(u32 narrow, u64 near)return near + (s32) (narrow - near); } -static void drm_wait_vblank_reply (struct drm_device *dev,unsigned int pipe, +static void drm_wait_vblank_reply (struct drm_vblank_crtc *vblank,struct drm_wait_vblank_reply *reply) {ktime_t now;
drivers/gpu/drm/drm_vblank.c static void drm_wait_vblank_reply(struct drm_device *dev, unsigned int pipe, · line 1716
Quoted 5 lines
drivers/gpu/drm/drm_vblank.c +1
-1@@ -1713,7 +1713,7 @@ static void drm_wait_vblank_reply(struct drm_device *dev, unsigned int pipe,* to store the seconds. This is safe as we always use monotonic * timestamps since linux-4.15. */ - reply->sequence =drm_vblank_count_and_time (dev, pipe, &now); + reply->sequence =drm_vblank_count_and_time (vblank->dev, vblank->pipe, &now);
Did you intentionally miss converting drm_vblank_count_and_time()?
Quoted 21 lines
drivers/gpu/drm/drm_vblank.c +2
-2ts =ktime_to_timespec64 (now); reply->tval_sec = (u32 )ts.tv_sec; reply->tval_usec = ts.tv_nsec /1000 ;@@ -1785,7 +1785,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (vblank->config.disable_immediate &&drm_wait_vblank_is_query (vblwait) &&READ_ONCE (vblank->enabled)) { -drm_wait_vblank_reply (dev, pipe, &vblwait->reply); +drm_wait_vblank_reply (vblank, &vblwait->reply);return 0 ; }@@ -1852,7 +1852,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, }if (ret != -EINTR ) { -drm_wait_vblank_reply (dev, pipe, &vblwait->reply); +drm_wait_vblank_reply (vblank, &vblwait->reply);drm_dbg_core (dev,"crtc %d returning %u to client\n" , pipe, vblwait->reply.sequence);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 13/24 drm/vblank: pass vblank to drm_vblank_count_and_time()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
Drop the pipe check warning, as we can be sure vblank->pipe is within limits.
--- drivers/gpu/drm/drm_vblank.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)
drivers/gpu/drm/drm_vblank.c +11 -17
@@ -950,18 +950,12 @@ EXPORT_SYMBOL(drm_crtc_vblank_count);* * This is the legacy version of drm_crtc_vblank_count_and_time(). */ -static u64 drm_vblank_count_and_time (struct drm_device *dev,unsigned int pipe, +static u64 drm_vblank_count_and_time (struct drm_vblank_crtc *vblank,ktime_t *vblanktime) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);u64 vblank_count;unsigned int seq; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) { - *vblanktime =0 ; -return 0 ; - } - do { seq = read_seqbegin(&vblank->seqlock); vblank_count = atomic64_read(&vblank->count);
@@ -993,7 +987,7 @@ static u64 drm_vblank_count_and_time(struct drm_device *dev, unsigned int pipe,u64 drm_crtc_vblank_count_and_time (struct drm_crtc *crtc,ktime_t *vblanktime) { -return drm_vblank_count_and_time (crtc->dev,drm_crtc_index (crtc), +return drm_vblank_count_and_time (drm_crtc_vblank_crtc (crtc), vblanktime); }EXPORT_SYMBOL (drm_crtc_vblank_count_and_time);
@@ -1136,18 +1130,18 @@ void drm_crtc_send_vblank_event(struct drm_crtc *crtc, struct drm_pending_vblank_event *e) {struct drm_device *dev = crtc->dev; +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);u64 seq; -unsigned int pipe =drm_crtc_index (crtc);ktime_t now;if (drm_dev_has_vblank (dev)) { - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now); }else { seq =0 ; now =ktime_get (); } - e->pipe = pipe; + e->pipe = vblank->pipe;send_vblank_event (dev, e, seq, now); }EXPORT_SYMBOL (drm_crtc_send_vblank_event);
@@ -1368,7 +1362,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)spin_unlock (&dev->vbl_lock);/* Send any queued vblank events, lest the natives grow disquiet */ - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now);list_for_each_entry_safe (e, t, &dev->vblank_event_list, base.link) {if (e->pipe != pipe)
@@ -1645,7 +1639,7 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank,if (ret) goto err_unlock; - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now);drm_dbg_core (dev,"event on vblank count %llu, current %llu, crtc %u\n" , req_seq, seq, pipe);
@@ -1713,7 +1707,7 @@ static void drm_wait_vblank_reply(struct drm_vblank_crtc *vblank,* to store the seconds. This is safe as we always use monotonic * timestamps since linux-4.15. */ - reply->sequence =drm_vblank_count_and_time (vblank->dev, vblank->pipe, &now); + reply->sequence =drm_vblank_count_and_time (vblank, &now); ts =ktime_to_timespec64 (now); reply->tval_sec = (u32 )ts.tv_sec; reply->tval_usec = ts.tv_nsec /1000 ;
@@ -1878,7 +1872,7 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)assert_spin_locked (&dev->event_lock); - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now);list_for_each_entry_safe (e, t, &dev->vblank_event_list, base.link) {if (e->pipe != pipe)
@@ -2040,7 +2034,7 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,else get_seq->active = crtc->enabled;drm_modeset_unlock (&crtc->mutex); - get_seq->sequence =drm_vblank_count_and_time (dev, pipe, &now); + get_seq->sequence =drm_vblank_count_and_time (vblank, &now); get_seq->sequence_ns =ktime_to_ns (now);if (!vblank_enabled)drm_crtc_vblank_put (crtc);
@@ -2101,7 +2095,7 @@ int drm_crtc_queue_sequence_ioctl(struct drm_device *dev, void *data, goto err_free; } - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now); req_seq = queue_seq->sequence;if (flags &DRM_CRTC_SEQUENCE_RELATIVE )
Signature · 1 line
2.47.3
kernel test robot
build botRe: [PATCH 13/24] drm/vblank: pass vblank to drm_vblank_count_and_time()
kernel test robot noticed the following build warnings:
Hi Jani,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20251110]
[cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip drm-misc/drm-misc-next linus/master v6.18-rc5 v6.18-rc4 v6.18-rc3 v6.18-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-vblank-Unexport-drm_wait_one_vblank/20251111-024823 base: next-20251110 patch link: https://lore.kernel.org/r/39a203dcc71aa4bfcf349d9c85672a6b9db4201f.1762791343.git.jani.nikula%40intel.com patch subject: [PATCH 13/24] drm/vblank: pass vblank to drm_vblank_count_and_time() config: openrisc-randconfig-r071-20251111 (https://download.01.org/0day-ci/archive/20251111/[email protected]/config) compiler: or1k-linux-gcc (GCC) 9.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251111/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> Warning: drivers/gpu/drm/drm_vblank.c:954 function parameter 'vblank' not described in 'drm_vblank_count_and_time' >> Warning: drivers/gpu/drm/drm_vblank.c:954 function parameter 'vblank' not described in 'drm_vblank_count_and_time'
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Re: [PATCH 13/24] drm/vblank: pass vblank to drm_vblank_count_and_time()
In reply to Jani NikulaAm 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 6 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Drop the pipe check warning, as we can be sure
vblank->pipeis within limits.Signed-off-by Jani Nikula <[email protected]>
OK, this is what I was looking for in the previous patch. Would it make sense to change order of the patches?
Quoted 113 lines
--- drivers/gpu/drm/drm_vblank.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)drivers/gpu/drm/drm_vblank.c +11
-17@@ -950,18 +950,12 @@ EXPORT_SYMBOL(drm_crtc_vblank_count);* * This is the legacy version of drm_crtc_vblank_count_and_time(). */ -static u64 drm_vblank_count_and_time (struct drm_device *dev,unsigned int pipe, +static u64 drm_vblank_count_and_time (struct drm_vblank_crtc *vblank,ktime_t *vblanktime) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe);u64 vblank_count;unsigned int seq; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) { - *vblanktime =0 ; -return 0 ; - } - do { seq = read_seqbegin(&vblank->seqlock); vblank_count = atomic64_read(&vblank->count);@@ -993,7 +987,7 @@ static u64 drm_vblank_count_and_time(struct drm_device *dev, unsigned int pipe,u64 drm_crtc_vblank_count_and_time (struct drm_crtc *crtc,ktime_t *vblanktime) { -return drm_vblank_count_and_time (crtc->dev,drm_crtc_index (crtc), +return drm_vblank_count_and_time (drm_crtc_vblank_crtc (crtc), vblanktime); }EXPORT_SYMBOL (drm_crtc_vblank_count_and_time);@@ -1136,18 +1130,18 @@ void drm_crtc_send_vblank_event(struct drm_crtc *crtc, struct drm_pending_vblank_event *e) {struct drm_device *dev = crtc->dev; +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);u64 seq; -unsigned int pipe =drm_crtc_index (crtc);ktime_t now;if (drm_dev_has_vblank (dev)) { - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now); }else { seq =0 ; now =ktime_get (); } - e->pipe = pipe; + e->pipe = vblank->pipe;send_vblank_event (dev, e, seq, now); }EXPORT_SYMBOL (drm_crtc_send_vblank_event);@@ -1368,7 +1362,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)spin_unlock (&dev->vbl_lock);/* Send any queued vblank events, lest the natives grow disquiet */ - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now);list_for_each_entry_safe (e, t, &dev->vblank_event_list, base.link) {if (e->pipe != pipe)@@ -1645,7 +1639,7 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank,if (ret) goto err_unlock; - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now);drm_dbg_core (dev,"event on vblank count %llu, current %llu, crtc %u\n" , req_seq, seq, pipe);@@ -1713,7 +1707,7 @@ static void drm_wait_vblank_reply(struct drm_vblank_crtc *vblank,* to store the seconds. This is safe as we always use monotonic * timestamps since linux-4.15. */ - reply->sequence =drm_vblank_count_and_time (vblank->dev, vblank->pipe, &now); + reply->sequence =drm_vblank_count_and_time (vblank, &now); ts =ktime_to_timespec64 (now); reply->tval_sec = (u32 )ts.tv_sec; reply->tval_usec = ts.tv_nsec /1000 ;@@ -1878,7 +1872,7 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)assert_spin_locked (&dev->event_lock); - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now);list_for_each_entry_safe (e, t, &dev->vblank_event_list, base.link) {if (e->pipe != pipe)@@ -2040,7 +2034,7 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,else get_seq->active = crtc->enabled;drm_modeset_unlock (&crtc->mutex); - get_seq->sequence =drm_vblank_count_and_time (dev, pipe, &now); + get_seq->sequence =drm_vblank_count_and_time (vblank, &now); get_seq->sequence_ns =ktime_to_ns (now);if (!vblank_enabled)drm_crtc_vblank_put (crtc);@@ -2101,7 +2095,7 @@ int drm_crtc_queue_sequence_ioctl(struct drm_device *dev, void *data, goto err_free; } - seq =drm_vblank_count_and_time (dev, pipe, &now); + seq =drm_vblank_count_and_time (vblank, &now); req_seq = queue_seq->sequence;if (flags &DRM_CRTC_SEQUENCE_RELATIVE )
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 14/24 drm/vblank: pass vblank to drm_reset_vblank_timestamp()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_vblank.c +4 -2
@@ -245,8 +245,10 @@ static u32 __get_vblank_counter(struct drm_device *dev, unsigned int pipe)* Note: caller must hold &drm_device.vbl_lock since this reads & writes * device vblank fields. */ -static void drm_reset_vblank_timestamp (struct drm_device *dev,unsigned int pipe) +static void drm_reset_vblank_timestamp (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;u32 cur_vblank;bool rc;ktime_t t_vblank;
@@ -1487,7 +1489,7 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc, vblank->inmodeset =0 ; } -drm_reset_vblank_timestamp (dev, pipe); +drm_reset_vblank_timestamp (vblank);/* * re-enable interrupts if there are users left, or the
Signature · 1 line
2.47.3
Re: [PATCH 14/24] drm/vblank: pass vblank to drm_reset_vblank_timestamp()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 29 lines
--- drivers/gpu/drm/drm_vblank.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_vblank.c +4
-2@@ -245,8 +245,10 @@ static u32 __get_vblank_counter(struct drm_device *dev, unsigned int pipe)* Note: caller must hold &drm_device.vbl_lock since this reads & writes * device vblank fields. */ -static void drm_reset_vblank_timestamp (struct drm_device *dev,unsigned int pipe) +static void drm_reset_vblank_timestamp (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;u32 cur_vblank;bool rc;ktime_t t_vblank;@@ -1487,7 +1489,7 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc, vblank->inmodeset =0 ; } -drm_reset_vblank_timestamp (dev, pipe); +drm_reset_vblank_timestamp (vblank);/* * re-enable interrupts if there are users left, or the
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 15/24 drm/vblank: pass vblank to store_vblank()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_vblank.c +4 -4
@@ -188,11 +188,11 @@ drm_crtc_vblank_crtc(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_crtc); -static void store_vblank (struct drm_device *dev,unsigned int pipe, +static void store_vblank (struct drm_vblank_crtc *vblank,u32 vblank_count_inc,ktime_t t_vblank,u32 last) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;assert_spin_locked (&dev->vblank_time_lock);
@@ -277,7 +277,7 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)* +1 to make sure user will never see the same * vblank counter value before and after a modeset */ -store_vblank (dev, pipe,1 , t_vblank, cur_vblank); +store_vblank (vblank,1 , t_vblank, cur_vblank);spin_unlock (&dev->vblank_time_lock); }
@@ -384,7 +384,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,if (!rc && !in_vblank_irq) t_vblank =0 ; -store_vblank (dev, pipe, diff, t_vblank, cur_vblank); +store_vblank (vblank, diff, t_vblank, cur_vblank); }u64 drm_vblank_count (struct drm_vblank_crtc *vblank)
Signature · 1 line
2.47.3
Re: [PATCH 15/24] drm/vblank: pass vblank to store_vblank()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 40 lines
--- drivers/gpu/drm/drm_vblank.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_vblank.c +4
-4@@ -188,11 +188,11 @@ drm_crtc_vblank_crtc(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_crtc); -static void store_vblank (struct drm_device *dev,unsigned int pipe, +static void store_vblank (struct drm_vblank_crtc *vblank,u32 vblank_count_inc,ktime_t t_vblank,u32 last) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;assert_spin_locked (&dev->vblank_time_lock);@@ -277,7 +277,7 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)* +1 to make sure user will never see the same * vblank counter value before and after a modeset */ -store_vblank (dev, pipe,1 , t_vblank, cur_vblank); +store_vblank (vblank,1 , t_vblank, cur_vblank);spin_unlock (&dev->vblank_time_lock); }@@ -384,7 +384,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,if (!rc && !in_vblank_irq) t_vblank =0 ; -store_vblank (dev, pipe, diff, t_vblank, cur_vblank); +store_vblank (vblank, diff, t_vblank, cur_vblank); }u64 drm_vblank_count (struct drm_vblank_crtc *vblank)
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 16/24 drm/vblank: pass vblank to drm_vblank_enable()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/drm_vblank.c +5 -5
@@ -1163,9 +1163,10 @@ static int __enable_vblank(struct drm_device *dev, unsigned int pipe)return -EINVAL ; } -static int drm_vblank_enable (struct drm_device *dev,unsigned int pipe) +static int drm_vblank_enable (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;int ret =0 ;assert_spin_locked (&dev->vbl_lock);
@@ -1204,7 +1205,6 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)int drm_vblank_get (struct drm_vblank_crtc *vblank) {struct drm_device *dev = vblank->dev; -int pipe = vblank->pipe;unsigned long irqflags;int ret =0 ;
@@ -1214,7 +1214,7 @@ int drm_vblank_get(struct drm_vblank_crtc *vblank)spin_lock_irqsave (&dev->vbl_lock, irqflags);/* Going from 0->1 means we have to enable interrupts again */ if (atomic_add_return (1 , &vblank->refcount) ==1 ) { - ret =drm_vblank_enable (dev, pipe); + ret =drm_vblank_enable (vblank); }else {if (!vblank->enabled) {atomic_dec (&vblank->refcount);
@@ -1496,7 +1496,7 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc,* user wishes vblank interrupts to be enabled all the time. */ if (atomic_read (&vblank->refcount) !=0 || !vblank->config.offdelay_ms) -drm_WARN_ON (dev,drm_vblank_enable (dev, pipe)); +drm_WARN_ON (dev,drm_vblank_enable (vblank));spin_unlock_irq (&dev->vbl_lock); }EXPORT_SYMBOL (drm_crtc_vblank_on_config);
Signature · 1 line
2.47.3
Re: [PATCH 16/24] drm/vblank: pass vblank to drm_vblank_enable()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 47 lines
--- drivers/gpu/drm/drm_vblank.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/drm_vblank.c +5
-5@@ -1163,9 +1163,10 @@ static int __enable_vblank(struct drm_device *dev, unsigned int pipe)return -EINVAL ; } -static int drm_vblank_enable (struct drm_device *dev,unsigned int pipe) +static int drm_vblank_enable (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev; +unsigned int pipe = vblank->pipe;int ret =0 ;assert_spin_locked (&dev->vbl_lock);@@ -1204,7 +1205,6 @@ static int drm_vblank_enable(struct drm_device *dev, unsigned int pipe)int drm_vblank_get (struct drm_vblank_crtc *vblank) {struct drm_device *dev = vblank->dev; -int pipe = vblank->pipe;unsigned long irqflags;int ret =0 ;@@ -1214,7 +1214,7 @@ int drm_vblank_get(struct drm_vblank_crtc *vblank)spin_lock_irqsave (&dev->vbl_lock, irqflags);/* Going from 0->1 means we have to enable interrupts again */ if (atomic_add_return (1 , &vblank->refcount) ==1 ) { - ret =drm_vblank_enable (dev, pipe); + ret =drm_vblank_enable (vblank); }else {if (!vblank->enabled) {atomic_dec (&vblank->refcount);@@ -1496,7 +1496,7 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc,* user wishes vblank interrupts to be enabled all the time. */ if (atomic_read (&vblank->refcount) !=0 || !vblank->config.offdelay_ms) -drm_WARN_ON (dev,drm_vblank_enable (dev, pipe)); +drm_WARN_ON (dev,drm_vblank_enable (vblank));spin_unlock_irq (&dev->vbl_lock); }EXPORT_SYMBOL (drm_crtc_vblank_on_config);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 17/24 drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore()
In reply to Jani NikulaThe extra function serves no useful purpose.
This allows us to drop another superfluous pipe check warning.
--- drivers/gpu/drm/drm_vblank.c | 57 +++++++++++++++--------------------- 1 file changed, 23 insertions(+), 34 deletions(-)
drivers/gpu/drm/drm_vblank.c +23 -34
@@ -1524,23 +1524,41 @@ void drm_crtc_vblank_on(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_on); -static void drm_vblank_restore (struct drm_device *dev,unsigned int pipe) +/** +* drm_crtc_vblank_restore - estimate missed vblanks and update vblank count. +* @crtc: CRTC in question +* +* Power manamement features can cause frame counter resets between vblank +* disable and enable. Drivers can use this function in their +* &drm_crtc_funcs.enable_vblank implementation to estimate missed vblanks since +* the last &drm_crtc_funcs.disable_vblank using timestamps and update the +* vblank counter. +* +* Note that drivers must have race-free high-precision timestamping support, +* i.e. &drm_crtc_funcs.get_vblank_timestamp must be hooked up and +* &drm_vblank_crtc_config.disable_immediate must be set to indicate the +* time-stamping functions are race-free against vblank hardware counter +* increments. +*/ +void drm_crtc_vblank_restore (struct drm_crtc *crtc) { +struct drm_device *dev = crtc->dev; +unsigned int pipe =drm_crtc_index (crtc); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);ktime_t t_vblank; -struct drm_vblank_crtc *vblank;int framedur_ns;u64 diff_ns;u32 cur_vblank, diff =1 ;int count =DRM_TIMESTAMP_MAXRETRIES ;u32 max_vblank_count =drm_max_vblank_count (dev, pipe); -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; +drm_WARN_ON_ONCE (dev, !crtc->funcs->get_vblank_timestamp); +drm_WARN_ON_ONCE (dev, vblank->inmodeset); +drm_WARN_ON_ONCE (dev, !vblank->config.disable_immediate);assert_spin_locked (&dev->vbl_lock);assert_spin_locked (&dev->vblank_time_lock); - vblank =drm_vblank_crtc (dev, pipe);drm_WARN_ONCE (dev,drm_debug_enabled (DRM_UT_VBL ) && !vblank->framedur_ns,"Cannot compute missed vblanks without frame duration\n" );
@@ -1561,35 +1579,6 @@ static void drm_vblank_restore(struct drm_device *dev, unsigned int pipe) diff, diff_ns, framedur_ns, cur_vblank - vblank->last); vblank->last = (cur_vblank - diff) & max_vblank_count; } - -/** -* drm_crtc_vblank_restore - estimate missed vblanks and update vblank count. -* @crtc: CRTC in question -* -* Power manamement features can cause frame counter resets between vblank -* disable and enable. Drivers can use this function in their -* &drm_crtc_funcs.enable_vblank implementation to estimate missed vblanks since -* the last &drm_crtc_funcs.disable_vblank using timestamps and update the -* vblank counter. -* -* Note that drivers must have race-free high-precision timestamping support, -* i.e. &drm_crtc_funcs.get_vblank_timestamp must be hooked up and -* &drm_vblank_crtc_config.disable_immediate must be set to indicate the -* time-stamping functions are race-free against vblank hardware counter -* increments. -*/ -void drm_crtc_vblank_restore (struct drm_crtc *crtc) -{ -struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc); -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); - -drm_WARN_ON_ONCE (dev, !crtc->funcs->get_vblank_timestamp); -drm_WARN_ON_ONCE (dev, vblank->inmodeset); -drm_WARN_ON_ONCE (dev, !vblank->config.disable_immediate); - -drm_vblank_restore (dev, pipe); -}EXPORT_SYMBOL (drm_crtc_vblank_restore); static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank,
Signature · 1 line
2.47.3
Re: [PATCH 17/24] drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 5 lines
The extra function serves no useful purpose.
This allows us to drop another superfluous pipe check warning.
Signed-off-by Jani Nikula <[email protected]>
Quoted 91 lines
--- drivers/gpu/drm/drm_vblank.c | 57 +++++++++++++++--------------------- 1 file changed, 23 insertions(+), 34 deletions(-)drivers/gpu/drm/drm_vblank.c +23
-34@@ -1524,23 +1524,41 @@ void drm_crtc_vblank_on(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_on); -static void drm_vblank_restore (struct drm_device *dev,unsigned int pipe) +/** +* drm_crtc_vblank_restore - estimate missed vblanks and update vblank count. +* @crtc: CRTC in question +* +* Power manamement features can cause frame counter resets between vblank +* disable and enable. Drivers can use this function in their +* &drm_crtc_funcs.enable_vblank implementation to estimate missed vblanks since +* the last &drm_crtc_funcs.disable_vblank using timestamps and update the +* vblank counter. +* +* Note that drivers must have race-free high-precision timestamping support, +* i.e. &drm_crtc_funcs.get_vblank_timestamp must be hooked up and +* &drm_vblank_crtc_config.disable_immediate must be set to indicate the +* time-stamping functions are race-free against vblank hardware counter +* increments. +*/ +void drm_crtc_vblank_restore (struct drm_crtc *crtc) { +struct drm_device *dev = crtc->dev; +unsigned int pipe =drm_crtc_index (crtc); +struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);ktime_t t_vblank; -struct drm_vblank_crtc *vblank;int framedur_ns;u64 diff_ns;u32 cur_vblank, diff =1 ;int count =DRM_TIMESTAMP_MAXRETRIES ;u32 max_vblank_count =drm_max_vblank_count (dev, pipe); -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; +drm_WARN_ON_ONCE (dev, !crtc->funcs->get_vblank_timestamp); +drm_WARN_ON_ONCE (dev, vblank->inmodeset); +drm_WARN_ON_ONCE (dev, !vblank->config.disable_immediate);assert_spin_locked (&dev->vbl_lock);assert_spin_locked (&dev->vblank_time_lock); - vblank =drm_vblank_crtc (dev, pipe);drm_WARN_ONCE (dev,drm_debug_enabled (DRM_UT_VBL ) && !vblank->framedur_ns,"Cannot compute missed vblanks without frame duration\n" );@@ -1561,35 +1579,6 @@ static void drm_vblank_restore(struct drm_device *dev, unsigned int pipe) diff, diff_ns, framedur_ns, cur_vblank - vblank->last); vblank->last = (cur_vblank - diff) & max_vblank_count; } - -/** -* drm_crtc_vblank_restore - estimate missed vblanks and update vblank count. -* @crtc: CRTC in question -* -* Power manamement features can cause frame counter resets between vblank -* disable and enable. Drivers can use this function in their -* &drm_crtc_funcs.enable_vblank implementation to estimate missed vblanks since -* the last &drm_crtc_funcs.disable_vblank using timestamps and update the -* vblank counter. -* -* Note that drivers must have race-free high-precision timestamping support, -* i.e. &drm_crtc_funcs.get_vblank_timestamp must be hooked up and -* &drm_vblank_crtc_config.disable_immediate must be set to indicate the -* time-stamping functions are race-free against vblank hardware counter -* increments. -*/ -void drm_crtc_vblank_restore (struct drm_crtc *crtc) -{ -struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc); -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); - -drm_WARN_ON_ONCE (dev, !crtc->funcs->get_vblank_timestamp); -drm_WARN_ON_ONCE (dev, vblank->inmodeset); -drm_WARN_ON_ONCE (dev, !vblank->config.disable_immediate); - -drm_vblank_restore (dev, pipe); -}EXPORT_SYMBOL (drm_crtc_vblank_restore); static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank,
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 18/24 drm/vblank: add drm_crtc_from_vblank() helper
In reply to Jani NikulaWe have a handful of places where we need to get the crtc from the vblank. Add a small helper for it.
--- drivers/gpu/drm/drm_vblank.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_vblank.c +7 -2
@@ -188,6 +188,11 @@ drm_crtc_vblank_crtc(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_crtc); +static struct drm_crtc *drm_crtc_from_vblank (struct drm_vblank_crtc *vblank) +{ +return drm_crtc_from_index (vblank->dev, vblank->pipe); +} +static void store_vblank (struct drm_vblank_crtc *vblank,u32 vblank_count_inc,ktime_t t_vblank,u32 last)
@@ -1605,7 +1610,7 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank, e->event.vbl.user_data = vblwait->request.signal; e->event.vbl.crtc_id =0 ;if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (crtc) e->event.vbl.crtc_id = crtc->base.id;
@@ -1855,7 +1860,7 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank) {struct drm_device *dev = vblank->dev;unsigned int pipe = vblank->pipe; -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);bool high_prec = false;struct drm_pending_vblank_event *e, *t;ktime_t now;
Signature · 1 line
2.47.3
Re: [PATCH 18/24] drm/vblank: add drm_crtc_from_vblank() helper
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 4 lines
We have a handful of places where we need to get the crtc from the vblank. Add a small helper for it.
Signed-off-by Jani Nikula <[email protected]>
Maybe not strictly necessary.
Quoted 38 lines
--- drivers/gpu/drm/drm_vblank.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_vblank.c +7
-2@@ -188,6 +188,11 @@ drm_crtc_vblank_crtc(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_vblank_crtc); +static struct drm_crtc *drm_crtc_from_vblank (struct drm_vblank_crtc *vblank) +{ +return drm_crtc_from_index (vblank->dev, vblank->pipe); +} +static void store_vblank (struct drm_vblank_crtc *vblank,u32 vblank_count_inc,ktime_t t_vblank,u32 last)@@ -1605,7 +1610,7 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank, e->event.vbl.user_data = vblwait->request.signal; e->event.vbl.crtc_id =0 ;if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (crtc) e->event.vbl.crtc_id = crtc->base.id;@@ -1855,7 +1860,7 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank) {struct drm_device *dev = vblank->dev;unsigned int pipe = vblank->pipe; -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);bool high_prec = false;struct drm_pending_vblank_event *e, *t;ktime_t now;
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 19/24 drm/vblank: pass vblank to __get_vblank_counter() and drm_max_vblank_count()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)
drivers/gpu/drm/drm_vblank.c +17 -17
@@ -209,27 +209,27 @@ static void store_vblank(struct drm_vblank_crtc *vblank,write_sequnlock (&vblank->seqlock); } -static u32 drm_max_vblank_count (struct drm_device *dev,unsigned int pipe) +static u32 drm_max_vblank_count (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); - -return vblank->max_vblank_count ?: dev->max_vblank_count; +return vblank->max_vblank_count ?: vblank->dev->max_vblank_count; }/* * "No hw counter" fallback implementation of .get_vblank_counter() hook, * if there is no usable hardware frame counter available. */ -static u32 drm_vblank_no_hw_counter (struct drm_device *dev,unsigned int pipe) +static u32 drm_vblank_no_hw_counter (struct drm_vblank_crtc *vblank) { -drm_WARN_ON_ONCE (dev,drm_max_vblank_count (dev, pipe) !=0 ); +drm_WARN_ON_ONCE (vblank->dev,drm_max_vblank_count (vblank) !=0 );return 0 ; } -static u32 __get_vblank_counter (struct drm_device *dev,unsigned int pipe) +static u32 __get_vblank_counter (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (drm_WARN_ON (dev, !crtc))return 0 ;
@@ -238,7 +238,7 @@ static u32 __get_vblank_counter(struct drm_device *dev, unsigned int pipe)return crtc->funcs->get_vblank_counter (crtc); } -return drm_vblank_no_hw_counter (dev, pipe); +return drm_vblank_no_hw_counter (vblank); }/*
@@ -266,9 +266,9 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)* when drm_vblank_enable() applies the diff */ do { - cur_vblank =__get_vblank_counter (dev, pipe); + cur_vblank =__get_vblank_counter (vblank); rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); - }while (cur_vblank !=__get_vblank_counter (dev, pipe) && --count >0 ); + }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );/* * Only reinitialize corresponding vblank timestamp if high-precision query
@@ -309,7 +309,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,ktime_t t_vblank;int count =DRM_TIMESTAMP_MAXRETRIES ;int framedur_ns = vblank->framedur_ns; -u32 max_vblank_count =drm_max_vblank_count (dev, pipe); +u32 max_vblank_count =drm_max_vblank_count (vblank);/* * Interrupts were disabled prior to this call, so deal with counter
@@ -324,9 +324,9 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,* corresponding vblank timestamp. */ do { - cur_vblank =__get_vblank_counter (dev, pipe); + cur_vblank =__get_vblank_counter (vblank); rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, in_vblank_irq); - }while (cur_vblank !=__get_vblank_counter (dev, pipe) && --count >0 ); + }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );if (max_vblank_count) {/* trust the hw counter when it's around */
@@ -1555,7 +1555,7 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc)u64 diff_ns;u32 cur_vblank, diff =1 ;int count =DRM_TIMESTAMP_MAXRETRIES ; -u32 max_vblank_count =drm_max_vblank_count (dev, pipe); +u32 max_vblank_count =drm_max_vblank_count (vblank);drm_WARN_ON_ONCE (dev, !crtc->funcs->get_vblank_timestamp);drm_WARN_ON_ONCE (dev, vblank->inmodeset);
@@ -1570,9 +1570,9 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc) framedur_ns = vblank->framedur_ns;do { - cur_vblank =__get_vblank_counter (dev, pipe); + cur_vblank =__get_vblank_counter (vblank);drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); - }while (cur_vblank !=__get_vblank_counter (dev, pipe) && --count >0 ); + }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 ); diff_ns =ktime_to_ns (ktime_sub (t_vblank, vblank->time));if (framedur_ns)
Signature · 1 line
2.47.3
Re: [PATCH 19/24] drm/vblank: pass vblank to __get_vblank_counter() and drm_max_vblank_count()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 107 lines
--- drivers/gpu/drm/drm_vblank.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)drivers/gpu/drm/drm_vblank.c +17
-17@@ -209,27 +209,27 @@ static void store_vblank(struct drm_vblank_crtc *vblank,write_sequnlock (&vblank->seqlock); } -static u32 drm_max_vblank_count (struct drm_device *dev,unsigned int pipe) +static u32 drm_max_vblank_count (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); - -return vblank->max_vblank_count ?: dev->max_vblank_count; +return vblank->max_vblank_count ?: vblank->dev->max_vblank_count; }/* * "No hw counter" fallback implementation of .get_vblank_counter() hook, * if there is no usable hardware frame counter available. */ -static u32 drm_vblank_no_hw_counter (struct drm_device *dev,unsigned int pipe) +static u32 drm_vblank_no_hw_counter (struct drm_vblank_crtc *vblank) { -drm_WARN_ON_ONCE (dev,drm_max_vblank_count (dev, pipe) !=0 ); +drm_WARN_ON_ONCE (vblank->dev,drm_max_vblank_count (vblank) !=0 );return 0 ; } -static u32 __get_vblank_counter (struct drm_device *dev,unsigned int pipe) +static u32 __get_vblank_counter (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (drm_WARN_ON (dev, !crtc))return 0 ;@@ -238,7 +238,7 @@ static u32 __get_vblank_counter(struct drm_device *dev, unsigned int pipe)return crtc->funcs->get_vblank_counter (crtc); } -return drm_vblank_no_hw_counter (dev, pipe); +return drm_vblank_no_hw_counter (vblank); }/* @@ -266,9 +266,9 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)* when drm_vblank_enable() applies the diff */ do { - cur_vblank =__get_vblank_counter (dev, pipe); + cur_vblank =__get_vblank_counter (vblank); rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); - }while (cur_vblank !=__get_vblank_counter (dev, pipe) && --count >0 ); + }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );/* * Only reinitialize corresponding vblank timestamp if high-precision query @@ -309,7 +309,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,ktime_t t_vblank;int count =DRM_TIMESTAMP_MAXRETRIES ;int framedur_ns = vblank->framedur_ns; -u32 max_vblank_count =drm_max_vblank_count (dev, pipe); +u32 max_vblank_count =drm_max_vblank_count (vblank);/* * Interrupts were disabled prior to this call, so deal with counter @@ -324,9 +324,9 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,* corresponding vblank timestamp. */ do { - cur_vblank =__get_vblank_counter (dev, pipe); + cur_vblank =__get_vblank_counter (vblank); rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, in_vblank_irq); - }while (cur_vblank !=__get_vblank_counter (dev, pipe) && --count >0 ); + }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );if (max_vblank_count) {/* trust the hw counter when it's around */ @@ -1555,7 +1555,7 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc)u64 diff_ns;u32 cur_vblank, diff =1 ;int count =DRM_TIMESTAMP_MAXRETRIES ; -u32 max_vblank_count =drm_max_vblank_count (dev, pipe); +u32 max_vblank_count =drm_max_vblank_count (vblank);drm_WARN_ON_ONCE (dev, !crtc->funcs->get_vblank_timestamp);drm_WARN_ON_ONCE (dev, vblank->inmodeset);@@ -1570,9 +1570,9 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc) framedur_ns = vblank->framedur_ns;do { - cur_vblank =__get_vblank_counter (dev, pipe); + cur_vblank =__get_vblank_counter (vblank);drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); - }while (cur_vblank !=__get_vblank_counter (dev, pipe) && --count >0 ); + }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 ); diff_ns =ktime_to_ns (ktime_sub (t_vblank, vblank->time));if (framedur_ns)
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 20/24 drm/vblank: pass vblank to __{enable,disable}_vblank()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/gpu/drm/drm_vblank.c +10 -6
@@ -443,10 +443,12 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_accurate_vblank_count); -static void __disable_vblank (struct drm_device *dev,unsigned int pipe) +static void __disable_vblank (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (drm_WARN_ON (dev, !crtc))return ;
@@ -491,7 +493,7 @@ void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe)* between drm_crtc_vblank_on() and drm_crtc_vblank_off(). */ drm_update_vblank_count (vblank, false); -__disable_vblank (dev, pipe); +__disable_vblank (vblank); vblank->enabled = false; out:
@@ -1153,10 +1155,12 @@ void drm_crtc_send_vblank_event(struct drm_crtc *crtc, }EXPORT_SYMBOL (drm_crtc_send_vblank_event); -static int __enable_vblank (struct drm_device *dev,unsigned int pipe) +static int __enable_vblank (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (drm_WARN_ON (dev, !crtc))return 0 ;
@@ -1186,7 +1190,7 @@ static int drm_vblank_enable(struct drm_vblank_crtc *vblank)* timestamps. Filtercode in drm_handle_vblank() will * prevent double-accounting of same vblank interval. */ - ret =__enable_vblank (dev, pipe); + ret =__enable_vblank (vblank);drm_dbg_core (dev,"enabling vblank on crtc %u, ret: %d\n" , pipe, ret);if (ret) {
Signature · 1 line
2.47.3
Re: [PATCH 20/24] drm/vblank: pass vblank to __{enable,disable}_vblank()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 56 lines
--- drivers/gpu/drm/drm_vblank.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)drivers/gpu/drm/drm_vblank.c +10
-6@@ -443,10 +443,12 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc) }EXPORT_SYMBOL (drm_crtc_accurate_vblank_count); -static void __disable_vblank (struct drm_device *dev,unsigned int pipe) +static void __disable_vblank (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (drm_WARN_ON (dev, !crtc))return ;@@ -491,7 +493,7 @@ void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe)* between drm_crtc_vblank_on() and drm_crtc_vblank_off(). */ drm_update_vblank_count (vblank, false); -__disable_vblank (dev, pipe); +__disable_vblank (vblank); vblank->enabled = false; out:@@ -1153,10 +1155,12 @@ void drm_crtc_send_vblank_event(struct drm_crtc *crtc, }EXPORT_SYMBOL (drm_crtc_send_vblank_event); -static int __enable_vblank (struct drm_device *dev,unsigned int pipe) +static int __enable_vblank (struct drm_vblank_crtc *vblank) { +struct drm_device *dev = vblank->dev; +if (drm_core_check_feature (dev,DRIVER_MODESET )) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);if (drm_WARN_ON (dev, !crtc))return 0 ;@@ -1186,7 +1190,7 @@ static int drm_vblank_enable(struct drm_vblank_crtc *vblank)* timestamps. Filtercode in drm_handle_vblank() will * prevent double-accounting of same vblank interval. */ - ret =__enable_vblank (dev, pipe); + ret =__enable_vblank (vblank);drm_dbg_core (dev,"enabling vblank on crtc %u, ret: %d\n" , pipe, ret);if (ret) {
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 21/24 drm/vblank: pass vblank to drm_get_last_vbltimestamp()
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
--- drivers/gpu/drm/drm_vblank.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)
drivers/gpu/drm/drm_vblank.c +8 -12
@@ -162,9 +162,8 @@*/ #define DRM_REDUNDANT_VBLIRQ_THRESH_NS 1000000 -static bool -drm_get_last_vbltimestamp (struct drm_device *dev,unsigned int pipe, -ktime_t *tvblank,bool in_vblank_irq); +static bool drm_get_last_vbltimestamp (struct drm_vblank_crtc *vblank, +ktime_t *tvblank,bool in_vblank_irq);static unsigned int drm_timestamp_precision =20 ;/* Default to 20 usecs. */
@@ -253,7 +252,6 @@ static u32 __get_vblank_counter(struct drm_vblank_crtc *vblank)static void drm_reset_vblank_timestamp (struct drm_vblank_crtc *vblank) {struct drm_device *dev = vblank->dev; -unsigned int pipe = vblank->pipe;u32 cur_vblank;bool rc;ktime_t t_vblank;
@@ -267,7 +265,7 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)*/ do { cur_vblank =__get_vblank_counter (vblank); - rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); + rc =drm_get_last_vbltimestamp (vblank, &t_vblank, false); }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );/*
@@ -325,7 +323,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,*/ do { cur_vblank =__get_vblank_counter (vblank); - rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, in_vblank_irq); + rc =drm_get_last_vbltimestamp (vblank, &t_vblank, in_vblank_irq); }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );if (max_vblank_count) {
@@ -909,11 +907,10 @@ drm_crtc_get_last_vbltimestamp(struct drm_crtc *crtc, ktime_t *tvblank,return ret; } -static bool -drm_get_last_vbltimestamp (struct drm_device *dev,unsigned int pipe, -ktime_t *tvblank,bool in_vblank_irq) +static bool drm_get_last_vbltimestamp (struct drm_vblank_crtc *vblank, +ktime_t *tvblank,bool in_vblank_irq) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);return drm_crtc_get_last_vbltimestamp (crtc, tvblank, in_vblank_irq); }
@@ -1552,7 +1549,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_on);void drm_crtc_vblank_restore (struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);ktime_t t_vblank;int framedur_ns;
@@ -1575,7 +1571,7 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc)do { cur_vblank =__get_vblank_counter (vblank); -drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); +drm_get_last_vbltimestamp (vblank, &t_vblank, false); }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 ); diff_ns =ktime_to_ns (ktime_sub (t_vblank, vblank->time));
Signature · 1 line
2.47.3
Re: [PATCH 21/24] drm/vblank: pass vblank to drm_get_last_vbltimestamp()
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 3 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Signed-off-by Jani Nikula <[email protected]>
Quoted 78 lines
--- drivers/gpu/drm/drm_vblank.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)drivers/gpu/drm/drm_vblank.c +8
-12@@ -162,9 +162,8 @@*/ #define DRM_REDUNDANT_VBLIRQ_THRESH_NS 1000000 -static bool -drm_get_last_vbltimestamp (struct drm_device *dev,unsigned int pipe, -ktime_t *tvblank,bool in_vblank_irq); +static bool drm_get_last_vbltimestamp (struct drm_vblank_crtc *vblank, +ktime_t *tvblank,bool in_vblank_irq);static unsigned int drm_timestamp_precision =20 ;/* Default to 20 usecs. */ @@ -253,7 +252,6 @@ static u32 __get_vblank_counter(struct drm_vblank_crtc *vblank)static void drm_reset_vblank_timestamp (struct drm_vblank_crtc *vblank) {struct drm_device *dev = vblank->dev; -unsigned int pipe = vblank->pipe;u32 cur_vblank;bool rc;ktime_t t_vblank;@@ -267,7 +265,7 @@ static void drm_reset_vblank_timestamp(struct drm_vblank_crtc *vblank)*/ do { cur_vblank =__get_vblank_counter (vblank); - rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); + rc =drm_get_last_vbltimestamp (vblank, &t_vblank, false); }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );/* @@ -325,7 +323,7 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,*/ do { cur_vblank =__get_vblank_counter (vblank); - rc =drm_get_last_vbltimestamp (dev, pipe, &t_vblank, in_vblank_irq); + rc =drm_get_last_vbltimestamp (vblank, &t_vblank, in_vblank_irq); }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 );if (max_vblank_count) {@@ -909,11 +907,10 @@ drm_crtc_get_last_vbltimestamp(struct drm_crtc *crtc, ktime_t *tvblank,return ret; } -static bool -drm_get_last_vbltimestamp (struct drm_device *dev,unsigned int pipe, -ktime_t *tvblank,bool in_vblank_irq) +static bool drm_get_last_vbltimestamp (struct drm_vblank_crtc *vblank, +ktime_t *tvblank,bool in_vblank_irq) { -struct drm_crtc *crtc =drm_crtc_from_index (dev, pipe); +struct drm_crtc *crtc =drm_crtc_from_vblank (vblank);return drm_crtc_get_last_vbltimestamp (crtc, tvblank, in_vblank_irq); }@@ -1552,7 +1549,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_on);void drm_crtc_vblank_restore (struct drm_crtc *crtc) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);ktime_t t_vblank;int framedur_ns;@@ -1575,7 +1571,7 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc)do { cur_vblank =__get_vblank_counter (vblank); -drm_get_last_vbltimestamp (dev, pipe, &t_vblank, false); +drm_get_last_vbltimestamp (vblank, &t_vblank, false); }while (cur_vblank !=__get_vblank_counter (vblank) && --count >0 ); diff_ns =ktime_to_ns (ktime_sub (t_vblank, vblank->time));
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 22/24 drm/vblank: pass vblank to drm_vblank_disable_and_save(), make static
In reply to Jani NikulaUse the vblank pointer instead of a dev, pipe pair to simplify code.
drm_vblank_disable_and_save() is also no longer used outside of drm_vblank.c; make it static while at it.
--- drivers/gpu/drm/drm_internal.h | 1 - drivers/gpu/drm/drm_vblank.c | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-)
drivers/gpu/drm/drm_internal.h +0 -1
@@ -100,7 +100,6 @@ static inline bool drm_vblank_passed(u64 seq, u64 ref)return (seq - ref) <= (1 <<23 ); } -void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe);int drm_vblank_get (struct drm_vblank_crtc *vblank);void drm_vblank_put (struct drm_vblank_crtc *vblank);u64 drm_vblank_count (struct drm_vblank_crtc *vblank);
drivers/gpu/drm/drm_vblank.c +4 -4
@@ -462,9 +462,9 @@ static void __disable_vblank(struct drm_vblank_crtc *vblank)* are preserved, even if there are any spurious vblank irq's after * disable. */ -void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe) +static void drm_vblank_disable_and_save (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;unsigned long irqflags;assert_spin_locked (&dev->vbl_lock);
@@ -509,7 +509,7 @@ static void vblank_disable_fn(struct timer_list *t)spin_lock_irqsave (&dev->vbl_lock, irqflags);if (atomic_read (&vblank->refcount) ==0 && vblank->enabled) {drm_dbg_core (dev,"disabling vblank on crtc %u\n" , pipe); -drm_vblank_disable_and_save (dev, pipe); +drm_vblank_disable_and_save (vblank); }spin_unlock_irqrestore (&dev->vbl_lock, irqflags); }
@@ -1355,7 +1355,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)/* Avoid redundant vblank disables without previous * drm_crtc_vblank_on(). */ if (drm_core_check_feature (dev,DRIVER_ATOMIC ) || !vblank->inmodeset) -drm_vblank_disable_and_save (dev, pipe); +drm_vblank_disable_and_save (vblank);wake_up (&vblank->queue);
Signature · 1 line
2.47.3
Re: [PATCH 22/24] drm/vblank: pass vblank to drm_vblank_disable_and_save(), make static
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 6 lines
Use the vblank pointer instead of a dev, pipe pair to simplify code.
drm_vblank_disable_and_save()is also no longer used outside ofdrm_vblank.c; make it static while at it.Signed-off-by Jani Nikula <[email protected]>
Quoted 51 lines
--- drivers/gpu/drm/drm_internal.h | 1 - drivers/gpu/drm/drm_vblank.c | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-)drivers/gpu/drm/drm_internal.h +0
-1@@ -100,7 +100,6 @@ static inline bool drm_vblank_passed(u64 seq, u64 ref)return (seq - ref) <= (1 <<23 ); } -void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe);int drm_vblank_get (struct drm_vblank_crtc *vblank);void drm_vblank_put (struct drm_vblank_crtc *vblank);u64 drm_vblank_count (struct drm_vblank_crtc *vblank);drivers/gpu/drm/drm_vblank.c +4
-4@@ -462,9 +462,9 @@ static void __disable_vblank(struct drm_vblank_crtc *vblank)* are preserved, even if there are any spurious vblank irq's after * disable. */ -void drm_vblank_disable_and_save (struct drm_device *dev,unsigned int pipe) +static void drm_vblank_disable_and_save (struct drm_vblank_crtc *vblank) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_device *dev = vblank->dev;unsigned long irqflags;assert_spin_locked (&dev->vbl_lock);@@ -509,7 +509,7 @@ static void vblank_disable_fn(struct timer_list *t)spin_lock_irqsave (&dev->vbl_lock, irqflags);if (atomic_read (&vblank->refcount) ==0 && vblank->enabled) {drm_dbg_core (dev,"disabling vblank on crtc %u\n" , pipe); -drm_vblank_disable_and_save (dev, pipe); +drm_vblank_disable_and_save (vblank); }spin_unlock_irqrestore (&dev->vbl_lock, irqflags); }@@ -1355,7 +1355,7 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)/* Avoid redundant vblank disables without previous * drm_crtc_vblank_on(). */ if (drm_core_check_feature (dev,DRIVER_ATOMIC ) || !vblank->inmodeset) -drm_vblank_disable_and_save (dev, pipe); +drm_vblank_disable_and_save (vblank);wake_up (&vblank->queue);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 23/24 drm/vblank: reduce pipe checks
In reply to Jani NikulaNow that drm_vblank_crtc() is the only place that indexes dev->vblank[], and its usage has reduced considerably, add the primary pipe out-of-bounds check there, and return NULL. Expect callers to check it and act accordingly.
In drm_crtc_vblank_crtc(), warn and return NULL, and let it go boom. If the crtc->pipe is out of bounds, it's a driver error that needs to be fixed.
Remove superfluous pipe checks all around.
--- drivers/gpu/drm/drm_vblank.c | 36 +++++++++++++++--------------------- 1 file changed, 15 insertions(+), 21 deletions(-)
drivers/gpu/drm/drm_vblank.c +15 -21
@@ -177,13 +177,22 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");static struct drm_vblank_crtc *drm_vblank_crtc (struct drm_device *dev,unsigned int pipe) { +if (pipe >= dev->num_crtcs) +return NULL ; +return &dev->vblank[pipe]; }struct drm_vblank_crtc *drm_crtc_vblank_crtc (struct drm_crtc *crtc) { -return drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +struct drm_vblank_crtc *vblank; + + vblank =drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +if (drm_WARN_ON (crtc->dev, !vblank)) +return NULL ; + +return vblank; }EXPORT_SYMBOL (drm_crtc_vblank_crtc);
@@ -631,7 +640,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc, const struct drm_display_mode *mode) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int linedur_ns =0 , framedur_ns =0 ;int dotclock = mode->crtc_clock;
@@ -639,9 +647,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,if (!drm_dev_has_vblank (dev))return ; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* Valid dotclock? */ if (dotclock >0 ) {int frame_size = mode->crtc_htotal * mode->crtc_vtotal;
@@ -724,11 +729,6 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(int vpos, hpos, i;int delta_ns, duration_ns; -if (pipe >= dev->num_crtcs) { -drm_err (dev,"Invalid crtc %u\n" , pipe); -return false; - } -/* Scanout position query not supported? Should not happen. */ if (!get_scanout_position) {drm_err (dev,"Called from CRTC w/o get_scanout_position()!?\n" );
@@ -1339,9 +1339,6 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)ktime_t now;u64 seq; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* * Grab event_lock early to prevent vblank work from being scheduled * while we're in the middle of shutting down vblank interrupts
@@ -1480,9 +1477,6 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc,unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -spin_lock_irq (&dev->vbl_lock);drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , pipe, vblank->enabled, vblank->inmodeset);
@@ -1764,10 +1758,9 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, pipe = pipe_index; } -if (pipe >= dev->num_crtcs) -return -EINVAL ; - vblank =drm_vblank_crtc (dev, pipe); +if (!vblank) +return -EINVAL ;/* If the counter is currently enabled and accurate, short-circuit * queries to return the cached timestamp of the last vblank.
@@ -1902,14 +1895,15 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)*/ bool drm_handle_vblank (struct drm_device *dev,unsigned int pipe) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank;unsigned long irqflags;bool disable_irq;if (drm_WARN_ON_ONCE (dev, !drm_dev_has_vblank (dev)))return false; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) + vblank =drm_vblank_crtc (dev, pipe); +if (drm_WARN_ON (dev, !vblank))return false;spin_lock_irqsave (&dev->event_lock, irqflags);
Signature · 1 line
2.47.3
Re: [PATCH 23/24] drm/vblank: reduce pipe checks
Quoted 53 lines · Jani Nikula
Now that
drm_vblank_crtc()is the only place that indexes dev->vblank[], and its usage has reduced considerably, add the primary pipe out-of-bounds check there, and return NULL. Expect callers to check it and act accordingly.In
drm_crtc_vblank_crtc(), warn and return NULL, and let it go boom. If thecrtc->pipeis out of bounds, it's a driver error that needs to be fixed.Remove superfluous pipe checks all around.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_vblank.c | 36 +++++++++++++++--------------------- 1 file changed, 15 insertions(+), 21 deletions(-)drivers/gpu/drm/drm_vblank.c +10
-2@@ -177,13 +177,22 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");static struct drm_vblank_crtc *drm_vblank_crtc (struct drm_device *dev,unsigned int pipe) { +if (pipe >= dev->num_crtcs) +return NULL ; +return &dev->vblank[pipe]; }struct drm_vblank_crtc *drm_crtc_vblank_crtc (struct drm_crtc *crtc) { -return drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +struct drm_vblank_crtc *vblank; + + vblank =drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +if (drm_WARN_ON (crtc->dev, !vblank)) +return NULL ; + +return vblank; }EXPORT_SYMBOL (drm_crtc_vblank_crtc);@@ -631,7 +640,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc, const struct drm_display_mode *mode) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int linedur_ns =0 , framedur_ns =0 ;int dotclock = mode->crtc_clock;
drivers/gpu/drm/drm_vblank.c void drm_calc_timestamping_constants(struct drm_crtc *crtc, · line 648
Quoted 2 lines
drivers/gpu/drm/drm_vblank.c +0
-0@@ -639,9 +647,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,if (!drm_dev_has_vblank (dev))return ;
I belive this at least gets called from the atomic helpers even for drivers that don't have vblank support. In which case the drm_crtc_vblank_crtc() call would have to be done after the drm_dev_has_vblank() check or else you'll get spurious WARNs.
I don't remember if there are other cases like this as well.
Quoted 72 lines
drivers/gpu/drm/drm_vblank.c +5
-19-if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* Valid dotclock? */ if (dotclock >0 ) {int frame_size = mode->crtc_htotal * mode->crtc_vtotal;@@ -724,11 +729,6 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(int vpos, hpos, i;int delta_ns, duration_ns; -if (pipe >= dev->num_crtcs) { -drm_err (dev,"Invalid crtc %u\n" , pipe); -return false; - } -/* Scanout position query not supported? Should not happen. */ if (!get_scanout_position) {drm_err (dev,"Called from CRTC w/o get_scanout_position()!?\n" );@@ -1339,9 +1339,6 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)ktime_t now;u64 seq; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* * Grab event_lock early to prevent vblank work from being scheduled * while we're in the middle of shutting down vblank interrupts @@ -1480,9 +1477,6 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc,unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -spin_lock_irq (&dev->vbl_lock);drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , pipe, vblank->enabled, vblank->inmodeset);@@ -1764,10 +1758,9 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, pipe = pipe_index; } -if (pipe >= dev->num_crtcs) -return -EINVAL ; - vblank =drm_vblank_crtc (dev, pipe); +if (!vblank) +return -EINVAL ;/* If the counter is currently enabled and accurate, short-circuit * queries to return the cached timestamp of the last vblank. @@ -1902,14 +1895,15 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)*/ bool drm_handle_vblank (struct drm_device *dev,unsigned int pipe) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank;unsigned long irqflags;bool disable_irq;if (drm_WARN_ON_ONCE (dev, !drm_dev_has_vblank (dev)))return false; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) + vblank =drm_vblank_crtc (dev, pipe); +if (drm_WARN_ON (dev, !vblank))return false;spin_lock_irqsave (&dev->event_lock, irqflags);Signature · 1 line
2.47.3
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH 23/24] drm/vblank: reduce pipe checks
Quoted 62 lines · Ville Syrjälä
Quoted 53 lines · Jani Nikula
Now that
drm_vblank_crtc()is the only place that indexes dev->vblank[], and its usage has reduced considerably, add the primary pipe out-of-bounds check there, and return NULL. Expect callers to check it and act accordingly.In
drm_crtc_vblank_crtc(), warn and return NULL, and let it go boom. If thecrtc->pipeis out of bounds, it's a driver error that needs to be fixed.Remove superfluous pipe checks all around.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/drm_vblank.c | 36 +++++++++++++++--------------------- 1 file changed, 15 insertions(+), 21 deletions(-)drivers/gpu/drm/drm_vblank.c +10
-2@@ -177,13 +177,22 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");static struct drm_vblank_crtc *drm_vblank_crtc (struct drm_device *dev,unsigned int pipe) { +if (pipe >= dev->num_crtcs) +return NULL ; +return &dev->vblank[pipe]; }struct drm_vblank_crtc *drm_crtc_vblank_crtc (struct drm_crtc *crtc) { -return drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +struct drm_vblank_crtc *vblank; + + vblank =drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +if (drm_WARN_ON (crtc->dev, !vblank)) +return NULL ; + +return vblank; }EXPORT_SYMBOL (drm_crtc_vblank_crtc);@@ -631,7 +640,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc, const struct drm_display_mode *mode) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int linedur_ns =0 , framedur_ns =0 ;int dotclock = mode->crtc_clock;drivers/gpu/drm/drm_vblank.c void drm_calc_timestamping_constants(struct drm_crtc *crtc, · line 648
Quoted 2 lines
drivers/gpu/drm/drm_vblank.c +0
-0@@ -639,9 +647,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,if (!drm_dev_has_vblank (dev))return ;I belive this at least gets called from the atomic helpers even for drivers that don't have vblank support. In which case the
drm_crtc_vblank_crtc()call would have to be done after thedrm_dev_has_vblank()check or else you'll get spurious WARNs.
Quoted 1 line
I don't remember if there are other cases like this as well.
Good catch! Yeah, not all places can be converted to struct drm_vblank_crtc. I need to go through these.
There are a handful of places now that grab the vblank pointer (even with NULL dev->vblank) and check has vblank afterwards, which is a bit iffy. And actually mislead me here.
BR,
Jani.
Quoted 73 lines
Quoted 73 lines
drivers/gpu/drm/drm_vblank.c +5
-19-if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* Valid dotclock? */ if (dotclock >0 ) {int frame_size = mode->crtc_htotal * mode->crtc_vtotal;@@ -724,11 +729,6 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(int vpos, hpos, i;int delta_ns, duration_ns; -if (pipe >= dev->num_crtcs) { -drm_err (dev,"Invalid crtc %u\n" , pipe); -return false; - } -/* Scanout position query not supported? Should not happen. */ if (!get_scanout_position) {drm_err (dev,"Called from CRTC w/o get_scanout_position()!?\n" );@@ -1339,9 +1339,6 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)ktime_t now;u64 seq; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* * Grab event_lock early to prevent vblank work from being scheduled * while we're in the middle of shutting down vblank interrupts @@ -1480,9 +1477,6 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc,unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -spin_lock_irq (&dev->vbl_lock);drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , pipe, vblank->enabled, vblank->inmodeset);@@ -1764,10 +1758,9 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, pipe = pipe_index; } -if (pipe >= dev->num_crtcs) -return -EINVAL ; - vblank =drm_vblank_crtc (dev, pipe); +if (!vblank) +return -EINVAL ;/* If the counter is currently enabled and accurate, short-circuit * queries to return the cached timestamp of the last vblank. @@ -1902,14 +1895,15 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)*/ bool drm_handle_vblank (struct drm_device *dev,unsigned int pipe) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank;unsigned long irqflags;bool disable_irq;if (drm_WARN_ON_ONCE (dev, !drm_dev_has_vblank (dev)))return false; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) + vblank =drm_vblank_crtc (dev, pipe); +if (drm_WARN_ON (dev, !vblank))return false;spin_lock_irqsave (&dev->event_lock, irqflags);Signature · 1 line
2.47.3
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH 23/24] drm/vblank: reduce pipe checks
In reply to Jani NikulaAm 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 5 lines
Now that
drm_vblank_crtc()is the only place that indexes dev->vblank[], and its usage has reduced considerably, add the primary pipe out-of-bounds check there, and return NULL. Expect callers to check it and act accordingly.
Quoted 7 lines
In
drm_crtc_vblank_crtc(), warn and return NULL, and let it go boom. If thecrtc->pipeis out of bounds, it's a driver error that needs to be fixed.Remove superfluous pipe checks all around.
Signed-off-by Jani Nikula <[email protected]>
See my comment below.
Quoted 101 lines
--- drivers/gpu/drm/drm_vblank.c | 36 +++++++++++++++--------------------- 1 file changed, 15 insertions(+), 21 deletions(-)drivers/gpu/drm/drm_vblank.c +13
-20@@ -177,13 +177,22 @@ MODULE_PARM_DESC(timestamp_precision_usec, "Max. error on timestamps [usecs]");static struct drm_vblank_crtc *drm_vblank_crtc (struct drm_device *dev,unsigned int pipe) { +if (pipe >= dev->num_crtcs) +return NULL ; +return &dev->vblank[pipe]; }struct drm_vblank_crtc *drm_crtc_vblank_crtc (struct drm_crtc *crtc) { -return drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +struct drm_vblank_crtc *vblank; + + vblank =drm_vblank_crtc (crtc->dev,drm_crtc_index (crtc)); +if (drm_WARN_ON (crtc->dev, !vblank)) +return NULL ; + +return vblank; }EXPORT_SYMBOL (drm_crtc_vblank_crtc);@@ -631,7 +640,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc, const struct drm_display_mode *mode) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);int linedur_ns =0 , framedur_ns =0 ;int dotclock = mode->crtc_clock;@@ -639,9 +647,6 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,if (!drm_dev_has_vblank (dev))return ; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* Valid dotclock? */ if (dotclock >0 ) {int frame_size = mode->crtc_htotal * mode->crtc_vtotal;@@ -724,11 +729,6 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(int vpos, hpos, i;int delta_ns, duration_ns; -if (pipe >= dev->num_crtcs) { -drm_err (dev,"Invalid crtc %u\n" , pipe); -return false; - } -/* Scanout position query not supported? Should not happen. */ if (!get_scanout_position) {drm_err (dev,"Called from CRTC w/o get_scanout_position()!?\n" );@@ -1339,9 +1339,6 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)ktime_t now;u64 seq; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -/* * Grab event_lock early to prevent vblank work from being scheduled * while we're in the middle of shutting down vblank interrupts @@ -1480,9 +1477,6 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc,unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc); -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) -return ; -spin_lock_irq (&dev->vbl_lock);drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , pipe, vblank->enabled, vblank->inmodeset);@@ -1764,10 +1758,9 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, pipe = pipe_index; } -if (pipe >= dev->num_crtcs) -return -EINVAL ; - vblank =drm_vblank_crtc (dev, pipe); +if (!vblank) +return -EINVAL ;/* If the counter is currently enabled and accurate, short-circuit * queries to return the cached timestamp of the last vblank. @@ -1902,14 +1895,15 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)*/ bool drm_handle_vblank (struct drm_device *dev,unsigned int pipe) { -struct drm_vblank_crtc *vblank =drm_vblank_crtc (dev, pipe); +struct drm_vblank_crtc *vblank;
drivers/gpu/drm/drm_vblank.c static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank) · line 1907
Quoted 10 lines
drivers/gpu/drm/drm_vblank.c +2
-1unsigned long irqflags;bool disable_irq;if (drm_WARN_ON_ONCE (dev, !drm_dev_has_vblank (dev)))return false; -if (drm_WARN_ON (dev, pipe >= dev->num_crtcs)) + vblank =drm_vblank_crtc (dev, pipe); +if (drm_WARN_ON (dev, !vblank))return false;
This can happen on each interrupt. Rather use drm_WARN_ON_ONCE here.
Quoted 2 lines
drivers/gpu/drm/drm_vblank.c +0
-0spin_lock_irqsave (&dev->event_lock, irqflags);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
PATCH 24/24 drm/vblank: clean up debug logging
In reply to Jani NikulaUse the usual [CRTC:%d:%s] when crtc is available. Start using a new uniform [VBLANK:%u] prefix with the pipe when crtc is not available. Remove extra line breaks. Use string choice helpers here and there. Use %pe to decode error returns.
--- drivers/gpu/drm/drm_vblank.c | 109 ++++++++++++++++------------------- 1 file changed, 50 insertions(+), 59 deletions(-)
drivers/gpu/drm/drm_vblank.c +50 -59
@@ -27,6 +27,7 @@#include <linux/export.h> #include <linux/kthread.h> #include <linux/moduleparam.h> +#include <linux/string_choices.h> #include <drm/drm_crtc.h> #include <drm/drm_drv.h>
@@ -347,14 +348,13 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,* frame/field duration. */ -drm_dbg_vbl (dev,"crtc %u: Calculating number of vblanks." -" diff_ns = %lld, framedur_ns = %d)\n" , +drm_dbg_vbl (dev,"[VBLANK:%u] Calculating number of vblanks. diff_ns = %lld, framedur_ns = %d)\n" , pipe, (long long )diff_ns, framedur_ns); diff =DIV_ROUND_CLOSEST_ULL (diff_ns, framedur_ns);if (diff ==0 && in_vblank_irq) -drm_dbg_vbl (dev,"crtc %u: Redundant vblirq ignored\n" , +drm_dbg_vbl (dev,"[VBLANK:%u] Redundant vblirq ignored\n" , pipe); }else {/* some kind of default for drivers w/o accurate vbl timestamping */
@@ -372,13 +372,12 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,*/ if (diff >1 && (vblank->inmodeset &0x2 )) {drm_dbg_vbl (dev, -"clamping vblank bump to 1 on crtc %u: diffr=%u" -" due to pre-modeset.\n" , pipe, diff); +"[VBLANK:%u] clamping vblank bump to 1: diffr=%u due to pre-modeset.\n" , + pipe, diff); diff =1 ; } -drm_dbg_vbl (dev,"updating vblank count on crtc %u:" -" current=%llu, diff=%u, hw=%u hw_last=%u\n" , +drm_dbg_vbl (dev,"[VBLANK:%u] updating vblank count: current=%llu, diff=%u, hw=%u hw_last=%u\n" , pipe, (unsigned long long )atomic64_read (&vblank->count), diff, cur_vblank, vblank->last);
@@ -517,7 +516,7 @@ static void vblank_disable_fn(struct timer_list *t)spin_lock_irqsave (&dev->vbl_lock, irqflags);if (atomic_read (&vblank->refcount) ==0 && vblank->enabled) { -drm_dbg_core (dev,"disabling vblank on crtc %u\n" , pipe); +drm_dbg_core (dev,"[VBLANK:%u] disabling vblank\n" , pipe);drm_vblank_disable_and_save (vblank); }spin_unlock_irqrestore (&dev->vbl_lock, irqflags);
@@ -665,8 +664,8 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,if (mode->flags &DRM_MODE_FLAG_INTERLACE ) framedur_ns /=2 ; }else { -drm_err (dev,"crtc %u: Can't calculate constants, dotclock = 0!\n" , - crtc->base.id); +drm_err (dev,"[CRTC:%d:%s] Can't calculate constants, dotclock = 0!\n" , + crtc->base.id, crtc->name); } vblank->linedur_ns = linedur_ns;
@@ -674,11 +673,11 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,drm_mode_copy (&vblank->hwmode, mode);drm_dbg_core (dev, -"crtc %u: hwmode: htotal %d, vtotal %d, vdisplay %d\n" , - crtc->base.id, mode->crtc_htotal, +"[CRTC:%d:%s] hwmode: htotal %d, vtotal %d, vdisplay %d\n" , + crtc->base.id, crtc->name, mode->crtc_htotal, mode->crtc_vtotal, mode->crtc_vdisplay); -drm_dbg_core (dev,"crtc %u: clock %d kHz framedur %d linedur %d\n" , - crtc->base.id, dotclock, framedur_ns, linedur_ns); +drm_dbg_core (dev,"[CRTC:%d:%s] clock %d kHz framedur %d linedur %d\n" , + crtc->base.id, crtc->name, dotclock, framedur_ns, linedur_ns); }EXPORT_SYMBOL (drm_calc_timestamping_constants);
@@ -731,7 +730,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(/* Scanout position query not supported? Should not happen. */ if (!get_scanout_position) { -drm_err (dev,"Called from CRTC w/o get_scanout_position()!?\n" ); +drm_err (dev,"[CRTC:%d:%s] Called from CRTC w/o get_scanout_position()!?\n" , + crtc->base.id, crtc->name);return false; }
@@ -744,7 +744,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(* Happens during initial modesetting of a crtc. */ if (mode->crtc_clock ==0 ) { -drm_dbg_core (dev,"crtc %u: Noop due to uninitialized mode.\n" , +drm_dbg_core (dev,"[VBLANK:%u] Noop due to uninitialized mode.\n" , pipe);drm_WARN_ON_ONCE (dev,drm_drv_uses_atomic_modeset (dev));return false;
@@ -769,9 +769,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(/* Return as no-op if scanout query unsupported or failed. */ if (!vbl_status) { -drm_dbg_core (dev, -"crtc %u : scanoutpos query failed.\n" , - pipe); +drm_dbg_core (dev,"[CRTC:%d:%s] scanoutpos query failed.\n" , + crtc->base.id, crtc->name);return false; }
@@ -785,9 +784,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(/* Noisy system timing? */ if (i ==DRM_TIMESTAMP_MAXRETRIES ) { -drm_dbg_core (dev, -"crtc %u: Noisy timestamp %d us > %d us [%d reps].\n" , - pipe, duration_ns /1000 , *max_error /1000 , i); +drm_dbg_core (dev,"[CRTC:%d:%s] Noisy timestamp %d us > %d us [%d reps].\n" , + crtc->base.id, crtc->name, duration_ns /1000 , *max_error /1000 , i); }/* Return upper bound of timestamp precision error. */
@@ -811,9 +809,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( ts_etime =ktime_to_timespec64 (etime); ts_vblank_time =ktime_to_timespec64 (*vblank_time); -drm_dbg_vbl (dev, -"crtc %u : v p(%d,%d)@ %lld.%06ld -> %lld.%06ld [e %d us, %d rep]\n" , - pipe, hpos, vpos, +drm_dbg_vbl (dev,"[CRTC:%d:%s] v p(%d,%d)@ %lld.%06ld -> %lld.%06ld [e %d us, %d rep]\n" , + crtc->base.id, crtc->name, hpos, vpos, (u64 )ts_etime.tv_sec, ts_etime.tv_nsec /1000 , (u64 )ts_vblank_time.tv_sec, ts_vblank_time.tv_nsec /1000 , duration_ns /1000 , i);
@@ -1188,7 +1185,7 @@ static int drm_vblank_enable(struct drm_vblank_crtc *vblank)* prevent double-accounting of same vblank interval. */ ret =__enable_vblank (vblank); -drm_dbg_core (dev,"enabling vblank on crtc %u, ret: %d\n" , +drm_dbg_core (dev,"[VBLANK:%u] enabling vblank, ret: %d\n" , pipe, ret);if (ret) {atomic_dec (&vblank->refcount);
@@ -1346,8 +1343,9 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)spin_lock_irq (&dev->event_lock);spin_lock (&dev->vbl_lock); -drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , - pipe, vblank->enabled, vblank->inmodeset); +drm_dbg_vbl (dev,"[CRTC:%d:%s] vblank %s, inmodeset: %s\n" , + crtc->base.id, crtc->name,str_enabled_disabled (vblank->enabled), +str_yes_no (vblank->inmodeset));/* Avoid redundant vblank disables without previous * drm_crtc_vblank_on(). */
@@ -1372,9 +1370,8 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)list_for_each_entry_safe (e, t, &dev->vblank_event_list, base.link) {if (e->pipe != pipe)continue ; -drm_dbg_core (dev,"Sending premature vblank event on disable: " -"wanted %llu, current %llu\n" , - e->sequence, seq); +drm_dbg_core (dev,"[CRTC:%d:%s] Sending premature vblank event on disable: wanted %llu, current %llu\n" , + crtc->base.id, crtc->name, e->sequence, seq);list_del (&e->base.link);drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now);
@@ -1474,12 +1471,12 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc, const struct drm_vblank_crtc_config *config) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);spin_lock_irq (&dev->vbl_lock); -drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , - pipe, vblank->enabled, vblank->inmodeset); +drm_dbg_vbl (dev,"[CRTC:%d:%s] vblank %s, inmodeset: %s\n" , + crtc->base.id, crtc->name,str_enabled_disabled (vblank->enabled), +str_yes_no (vblank->inmodeset)); vblank->config = *config;
@@ -1573,8 +1570,8 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc) diff =DIV_ROUND_CLOSEST_ULL (diff_ns, framedur_ns); -drm_dbg_vbl (dev, -"missed %d vblanks in %lld ns, frame duration=%d ns, hw_diff=%d\n" , +drm_dbg_vbl (dev,"[CRTC:%d:%s] missed %d vblanks in %lld ns, frame duration=%d ns, hw_diff=%d\n" , + crtc->base.id, crtc->name, diff, diff_ns, framedur_ns, cur_vblank - vblank->last); vblank->last = (cur_vblank - diff) & max_vblank_count; }
@@ -1631,8 +1628,8 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank, seq =drm_vblank_count_and_time (vblank, &now); -drm_dbg_core (dev,"event on vblank count %llu, current %llu, crtc %u\n" , - req_seq, seq, pipe); +drm_dbg_core (dev,"[VBLANK:%u] event on vblank count %llu, current %llu\n" , + pipe, req_seq, seq);trace_drm_vblank_event_queued (file_priv, pipe, req_seq);
@@ -1728,8 +1725,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (vblwait->request.type & ~(_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK | _DRM_VBLANK_HIGH_CRTC_MASK)) { -drm_dbg_core (dev, -"Unsupported type value 0x%x, supported mask 0x%x\n" , +drm_dbg_core (dev,"Unsupported type value 0x%x, supported mask 0x%x\n" , vblwait->request.type, (_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK | _DRM_VBLANK_HIGH_CRTC_MASK));
@@ -1774,9 +1770,8 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, ret =drm_vblank_get (vblank);if (ret) { -drm_dbg_core (dev, -"crtc %d failed to acquire vblank counter, %d\n" , - pipe, ret); +drm_dbg_core (dev,"[VBLANK:%u] failed to acquire vblank counter %pe\n" , + pipe,ERR_PTR (ret));return ret; } seq =drm_vblank_count (vblank);
@@ -1812,8 +1807,8 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (req_seq != seq) {int wait; -drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , - req_seq, pipe); +drm_dbg_core (dev,"[VBLANK:%d] waiting on vblank count %llu\n" , + pipe, req_seq); wait = wait_event_interruptible_timeout(vblank->queue, drm_vblank_passed(drm_vblank_count(vblank), req_seq) || !READ_ONCE(vblank->enabled),
@@ -1837,10 +1832,10 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (ret != -EINTR ) {drm_wait_vblank_reply (vblank, &vblwait->reply); -drm_dbg_core (dev,"crtc %d returning %u to client\n" , +drm_dbg_core (dev,"[VBLANK:%u] returning %u to client\n" , pipe, vblwait->reply.sequence); }else { -drm_dbg_core (dev,"crtc %d vblank wait interrupted by signal\n" , +drm_dbg_core (dev,"[VBLANK:%u] vblank wait interrupted by signal\n" , pipe); }
@@ -1869,8 +1864,8 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)if (!drm_vblank_passed (seq, e->sequence))continue ; -drm_dbg_core (dev,"vblank event on %llu, current %llu\n" , - e->sequence, seq); +drm_dbg_core (dev,"[VBLANK:%u] vblank event on %llu, current %llu\n" , + pipe, e->sequence, seq);list_del (&e->base.link);drm_vblank_put (vblank);
@@ -1987,7 +1982,6 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data, {struct drm_crtc *crtc;struct drm_vblank_crtc *vblank; -int pipe;struct drm_crtc_get_sequence *get_seq = data;ktime_t now;bool vblank_enabled;
@@ -2003,8 +1997,6 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,if (!crtc)return -ENOENT ; - pipe =drm_crtc_index (crtc); - vblank =drm_crtc_vblank_crtc (crtc); vblank_enabled =READ_ONCE (vblank->config.disable_immediate) &&READ_ONCE (vblank->enabled);
@@ -2012,9 +2004,8 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,if (!vblank_enabled) { ret =drm_crtc_vblank_get (crtc);if (ret) { -drm_dbg_core (dev, -"crtc %d failed to acquire vblank counter, %d\n" , - pipe, ret); +drm_dbg_core (dev,"[CRTC:%d:%s] failed to acquire vblank counter %pe\n" , + crtc->base.id, crtc->name,ERR_PTR (ret));return ret; } }
@@ -2079,9 +2070,8 @@ int drm_crtc_queue_sequence_ioctl(struct drm_device *dev, void *data, ret =drm_crtc_vblank_get (crtc);if (ret) { -drm_dbg_core (dev, -"crtc %d failed to acquire vblank counter, %d\n" , - pipe, ret); +drm_dbg_core (dev,"[CRTC:%d:%s] failed to acquire vblank counter %pe\n" , + crtc->base.id, crtc->name,ERR_PTR (ret)); goto err_free; }
@@ -2166,7 +2156,8 @@ static enum hrtimer_restart drm_vblank_timer_function(struct hrtimer *timer) ret_overrun =hrtimer_forward_now (&vtimer->timer, interval);if (ret_overrun !=1 ) -drm_dbg_vbl (dev,"vblank timer overrun\n" ); +drm_dbg_vbl (dev,"[CRTC:%d:%s] vblank timer overrun\n" , + crtc->base.id, crtc->name);if (crtc_funcs->handle_vblank_timeout) succ = crtc_funcs->handle_vblank_timeout (crtc);
Signature · 1 line
2.47.3
Re: [PATCH 24/24] drm/vblank: clean up debug logging
Hi
Am 10.11.25 um 17:17 schrieb Jani Nikula:
Quoted 6 lines
Use the usual [CRTC:%d:%s] when crtc is available. Start using a new uniform [VBLANK:%u] prefix with the pipe when crtc is not available. Remove extra line breaks. Use string choice helpers here and there. Use %pe to decode error returns.
Signed-off-by Jani Nikula <[email protected]>
Given Ville's comment on decoupling pipes and CRTCs, would it make sense to prefer [VBLANK] over [CRTC]? This seems to be possible with some of these changes.
Best regards
Thomas
Quoted 320 lines
--- drivers/gpu/drm/drm_vblank.c | 109 ++++++++++++++++------------------- 1 file changed, 50 insertions(+), 59 deletions(-)drivers/gpu/drm/drm_vblank.c +50
-59@@ -27,6 +27,7 @@#include <linux/export.h> #include <linux/kthread.h> #include <linux/moduleparam.h> +#include <linux/string_choices.h> #include <drm/drm_crtc.h> #include <drm/drm_drv.h> @@ -347,14 +348,13 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,* frame/field duration. */ -drm_dbg_vbl (dev,"crtc %u: Calculating number of vblanks." -" diff_ns = %lld, framedur_ns = %d)\n" , +drm_dbg_vbl (dev,"[VBLANK:%u] Calculating number of vblanks. diff_ns = %lld, framedur_ns = %d)\n" , pipe, (long long )diff_ns, framedur_ns); diff =DIV_ROUND_CLOSEST_ULL (diff_ns, framedur_ns);if (diff ==0 && in_vblank_irq) -drm_dbg_vbl (dev,"crtc %u: Redundant vblirq ignored\n" , +drm_dbg_vbl (dev,"[VBLANK:%u] Redundant vblirq ignored\n" , pipe); }else {/* some kind of default for drivers w/o accurate vbl timestamping */ @@ -372,13 +372,12 @@ static void drm_update_vblank_count(struct drm_vblank_crtc *vblank,*/ if (diff >1 && (vblank->inmodeset &0x2 )) {drm_dbg_vbl (dev, -"clamping vblank bump to 1 on crtc %u: diffr=%u" -" due to pre-modeset.\n" , pipe, diff); +"[VBLANK:%u] clamping vblank bump to 1: diffr=%u due to pre-modeset.\n" , + pipe, diff); diff =1 ; } -drm_dbg_vbl (dev,"updating vblank count on crtc %u:" -" current=%llu, diff=%u, hw=%u hw_last=%u\n" , +drm_dbg_vbl (dev,"[VBLANK:%u] updating vblank count: current=%llu, diff=%u, hw=%u hw_last=%u\n" , pipe, (unsigned long long )atomic64_read (&vblank->count), diff, cur_vblank, vblank->last);@@ -517,7 +516,7 @@ static void vblank_disable_fn(struct timer_list *t)spin_lock_irqsave (&dev->vbl_lock, irqflags);if (atomic_read (&vblank->refcount) ==0 && vblank->enabled) { -drm_dbg_core (dev,"disabling vblank on crtc %u\n" , pipe); +drm_dbg_core (dev,"[VBLANK:%u] disabling vblank\n" , pipe);drm_vblank_disable_and_save (vblank); }spin_unlock_irqrestore (&dev->vbl_lock, irqflags);@@ -665,8 +664,8 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,if (mode->flags &DRM_MODE_FLAG_INTERLACE ) framedur_ns /=2 ; }else { -drm_err (dev,"crtc %u: Can't calculate constants, dotclock = 0!\n" , - crtc->base.id); +drm_err (dev,"[CRTC:%d:%s] Can't calculate constants, dotclock = 0!\n" , + crtc->base.id, crtc->name); } vblank->linedur_ns = linedur_ns;@@ -674,11 +673,11 @@ void drm_calc_timestamping_constants(struct drm_crtc *crtc,drm_mode_copy (&vblank->hwmode, mode);drm_dbg_core (dev, -"crtc %u: hwmode: htotal %d, vtotal %d, vdisplay %d\n" , - crtc->base.id, mode->crtc_htotal, +"[CRTC:%d:%s] hwmode: htotal %d, vtotal %d, vdisplay %d\n" , + crtc->base.id, crtc->name, mode->crtc_htotal, mode->crtc_vtotal, mode->crtc_vdisplay); -drm_dbg_core (dev,"crtc %u: clock %d kHz framedur %d linedur %d\n" , - crtc->base.id, dotclock, framedur_ns, linedur_ns); +drm_dbg_core (dev,"[CRTC:%d:%s] clock %d kHz framedur %d linedur %d\n" , + crtc->base.id, crtc->name, dotclock, framedur_ns, linedur_ns); }EXPORT_SYMBOL (drm_calc_timestamping_constants);@@ -731,7 +730,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(/* Scanout position query not supported? Should not happen. */ if (!get_scanout_position) { -drm_err (dev,"Called from CRTC w/o get_scanout_position()!?\n" ); +drm_err (dev,"[CRTC:%d:%s] Called from CRTC w/o get_scanout_position()!?\n" , + crtc->base.id, crtc->name);return false; }@@ -744,7 +744,7 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(* Happens during initial modesetting of a crtc. */ if (mode->crtc_clock ==0 ) { -drm_dbg_core (dev,"crtc %u: Noop due to uninitialized mode.\n" , +drm_dbg_core (dev,"[VBLANK:%u] Noop due to uninitialized mode.\n" , pipe);drm_WARN_ON_ONCE (dev,drm_drv_uses_atomic_modeset (dev));return false;@@ -769,9 +769,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(/* Return as no-op if scanout query unsupported or failed. */ if (!vbl_status) { -drm_dbg_core (dev, -"crtc %u : scanoutpos query failed.\n" , - pipe); +drm_dbg_core (dev,"[CRTC:%d:%s] scanoutpos query failed.\n" , + crtc->base.id, crtc->name);return false; }@@ -785,9 +784,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal(/* Noisy system timing? */ if (i ==DRM_TIMESTAMP_MAXRETRIES ) { -drm_dbg_core (dev, -"crtc %u: Noisy timestamp %d us > %d us [%d reps].\n" , - pipe, duration_ns /1000 , *max_error /1000 , i); +drm_dbg_core (dev,"[CRTC:%d:%s] Noisy timestamp %d us > %d us [%d reps].\n" , + crtc->base.id, crtc->name, duration_ns /1000 , *max_error /1000 , i); }/* Return upper bound of timestamp precision error. */ @@ -811,9 +809,8 @@ drm_crtc_vblank_helper_get_vblank_timestamp_internal( ts_etime =ktime_to_timespec64 (etime); ts_vblank_time =ktime_to_timespec64 (*vblank_time); -drm_dbg_vbl (dev, -"crtc %u : v p(%d,%d)@ %lld.%06ld -> %lld.%06ld [e %d us, %d rep]\n" , - pipe, hpos, vpos, +drm_dbg_vbl (dev,"[CRTC:%d:%s] v p(%d,%d)@ %lld.%06ld -> %lld.%06ld [e %d us, %d rep]\n" , + crtc->base.id, crtc->name, hpos, vpos, (u64 )ts_etime.tv_sec, ts_etime.tv_nsec /1000 , (u64 )ts_vblank_time.tv_sec, ts_vblank_time.tv_nsec /1000 , duration_ns /1000 , i);@@ -1188,7 +1185,7 @@ static int drm_vblank_enable(struct drm_vblank_crtc *vblank)* prevent double-accounting of same vblank interval. */ ret =__enable_vblank (vblank); -drm_dbg_core (dev,"enabling vblank on crtc %u, ret: %d\n" , +drm_dbg_core (dev,"[VBLANK:%u] enabling vblank, ret: %d\n" , pipe, ret);if (ret) {atomic_dec (&vblank->refcount);@@ -1346,8 +1343,9 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)spin_lock_irq (&dev->event_lock);spin_lock (&dev->vbl_lock); -drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , - pipe, vblank->enabled, vblank->inmodeset); +drm_dbg_vbl (dev,"[CRTC:%d:%s] vblank %s, inmodeset: %s\n" , + crtc->base.id, crtc->name,str_enabled_disabled (vblank->enabled), +str_yes_no (vblank->inmodeset));/* Avoid redundant vblank disables without previous * drm_crtc_vblank_on(). */ @@ -1372,9 +1370,8 @@ void drm_crtc_vblank_off(struct drm_crtc *crtc)list_for_each_entry_safe (e, t, &dev->vblank_event_list, base.link) {if (e->pipe != pipe)continue ; -drm_dbg_core (dev,"Sending premature vblank event on disable: " -"wanted %llu, current %llu\n" , - e->sequence, seq); +drm_dbg_core (dev,"[CRTC:%d:%s] Sending premature vblank event on disable: wanted %llu, current %llu\n" , + crtc->base.id, crtc->name, e->sequence, seq);list_del (&e->base.link);drm_vblank_put (vblank);send_vblank_event (dev, e, seq, now);@@ -1474,12 +1471,12 @@ void drm_crtc_vblank_on_config(struct drm_crtc *crtc, const struct drm_vblank_crtc_config *config) {struct drm_device *dev = crtc->dev; -unsigned int pipe =drm_crtc_index (crtc);struct drm_vblank_crtc *vblank =drm_crtc_vblank_crtc (crtc);spin_lock_irq (&dev->vbl_lock); -drm_dbg_vbl (dev,"crtc %d, vblank enabled %d, inmodeset %d\n" , - pipe, vblank->enabled, vblank->inmodeset); +drm_dbg_vbl (dev,"[CRTC:%d:%s] vblank %s, inmodeset: %s\n" , + crtc->base.id, crtc->name,str_enabled_disabled (vblank->enabled), +str_yes_no (vblank->inmodeset)); vblank->config = *config;@@ -1573,8 +1570,8 @@ void drm_crtc_vblank_restore(struct drm_crtc *crtc) diff =DIV_ROUND_CLOSEST_ULL (diff_ns, framedur_ns); -drm_dbg_vbl (dev, -"missed %d vblanks in %lld ns, frame duration=%d ns, hw_diff=%d\n" , +drm_dbg_vbl (dev,"[CRTC:%d:%s] missed %d vblanks in %lld ns, frame duration=%d ns, hw_diff=%d\n" , + crtc->base.id, crtc->name, diff, diff_ns, framedur_ns, cur_vblank - vblank->last); vblank->last = (cur_vblank - diff) & max_vblank_count; }@@ -1631,8 +1628,8 @@ static int drm_queue_vblank_event(struct drm_vblank_crtc *vblank, seq =drm_vblank_count_and_time (vblank, &now); -drm_dbg_core (dev,"event on vblank count %llu, current %llu, crtc %u\n" , - req_seq, seq, pipe); +drm_dbg_core (dev,"[VBLANK:%u] event on vblank count %llu, current %llu\n" , + pipe, req_seq, seq);trace_drm_vblank_event_queued (file_priv, pipe, req_seq);@@ -1728,8 +1725,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (vblwait->request.type & ~(_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK | _DRM_VBLANK_HIGH_CRTC_MASK)) { -drm_dbg_core (dev, -"Unsupported type value 0x%x, supported mask 0x%x\n" , +drm_dbg_core (dev,"Unsupported type value 0x%x, supported mask 0x%x\n" , vblwait->request.type, (_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK | _DRM_VBLANK_HIGH_CRTC_MASK));@@ -1774,9 +1770,8 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data, ret =drm_vblank_get (vblank);if (ret) { -drm_dbg_core (dev, -"crtc %d failed to acquire vblank counter, %d\n" , - pipe, ret); +drm_dbg_core (dev,"[VBLANK:%u] failed to acquire vblank counter %pe\n" , + pipe,ERR_PTR (ret));return ret; } seq =drm_vblank_count (vblank);@@ -1812,8 +1807,8 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (req_seq != seq) {int wait; -drm_dbg_core (dev,"waiting on vblank count %llu, crtc %u\n" , - req_seq, pipe); +drm_dbg_core (dev,"[VBLANK:%d] waiting on vblank count %llu\n" , + pipe, req_seq); wait = wait_event_interruptible_timeout(vblank->queue, drm_vblank_passed(drm_vblank_count(vblank), req_seq) || !READ_ONCE(vblank->enabled),@@ -1837,10 +1832,10 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,if (ret != -EINTR ) {drm_wait_vblank_reply (vblank, &vblwait->reply); -drm_dbg_core (dev,"crtc %d returning %u to client\n" , +drm_dbg_core (dev,"[VBLANK:%u] returning %u to client\n" , pipe, vblwait->reply.sequence); }else { -drm_dbg_core (dev,"crtc %d vblank wait interrupted by signal\n" , +drm_dbg_core (dev,"[VBLANK:%u] vblank wait interrupted by signal\n" , pipe); }@@ -1869,8 +1864,8 @@ static void drm_handle_vblank_events(struct drm_vblank_crtc *vblank)if (!drm_vblank_passed (seq, e->sequence))continue ; -drm_dbg_core (dev,"vblank event on %llu, current %llu\n" , - e->sequence, seq); +drm_dbg_core (dev,"[VBLANK:%u] vblank event on %llu, current %llu\n" , + pipe, e->sequence, seq);list_del (&e->base.link);drm_vblank_put (vblank);@@ -1987,7 +1982,6 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data, {struct drm_crtc *crtc;struct drm_vblank_crtc *vblank; -int pipe;struct drm_crtc_get_sequence *get_seq = data;ktime_t now;bool vblank_enabled;@@ -2003,8 +1997,6 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,if (!crtc)return -ENOENT ; - pipe =drm_crtc_index (crtc); - vblank =drm_crtc_vblank_crtc (crtc); vblank_enabled =READ_ONCE (vblank->config.disable_immediate) &&READ_ONCE (vblank->enabled);@@ -2012,9 +2004,8 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,if (!vblank_enabled) { ret =drm_crtc_vblank_get (crtc);if (ret) { -drm_dbg_core (dev, -"crtc %d failed to acquire vblank counter, %d\n" , - pipe, ret); +drm_dbg_core (dev,"[CRTC:%d:%s] failed to acquire vblank counter %pe\n" , + crtc->base.id, crtc->name,ERR_PTR (ret));return ret; } }@@ -2079,9 +2070,8 @@ int drm_crtc_queue_sequence_ioctl(struct drm_device *dev, void *data, ret =drm_crtc_vblank_get (crtc);if (ret) { -drm_dbg_core (dev, -"crtc %d failed to acquire vblank counter, %d\n" , - pipe, ret); +drm_dbg_core (dev,"[CRTC:%d:%s] failed to acquire vblank counter %pe\n" , + crtc->base.id, crtc->name,ERR_PTR (ret)); goto err_free; }@@ -2166,7 +2156,8 @@ static enum hrtimer_restart drm_vblank_timer_function(struct hrtimer *timer) ret_overrun =hrtimer_forward_now (&vtimer->timer, interval);if (ret_overrun !=1 ) -drm_dbg_vbl (dev,"vblank timer overrun\n" ); +drm_dbg_vbl (dev,"[CRTC:%d:%s] vblank timer overrun\n" , + crtc->base.id, crtc->name);if (crtc_funcs->handle_vblank_timeout) succ = crtc_funcs->handle_vblank_timeout (crtc);
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Patchwork
CI✗ CI.KUnit: failure for drm/vblank: refactoring and cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/vblank: refactoring and cleanups
URL : https://patchwork.freedesktop.org/series/157332/
State : failure
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [17:11:12] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [17:11:16] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [17:11:47] Starting KUnit Kernel (1/1)... [17:11:47] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [17:11:47] ================== guc_buf (11 subtests) =================== [17:11:47] [PASSED] test_smallest [17:11:47] [PASSED] test_largest [17:11:47] [PASSED] test_granular [17:11:47] [PASSED] test_unique [17:11:47] [PASSED] test_overlap [17:11:47] [PASSED] test_reusable [17:11:47] [PASSED] test_too_big [17:11:47] [PASSED] test_flush [17:11:47] [PASSED] test_lookup [17:11:47] [PASSED] test_data [17:11:47] [PASSED] test_class [17:11:47] ===================== [PASSED] guc_buf ===================== [17:11:47] =================== guc_dbm (7 subtests) =================== [17:11:47] [PASSED] test_empty [17:11:47] [PASSED] test_default [17:11:47] ======================== test_size ======================== [17:11:47] [PASSED] 4 [17:11:47] [PASSED] 8 [17:11:47] [PASSED] 32 [17:11:47] [PASSED] 256 [17:11:47] ==================== [PASSED] test_size ==================== [17:11:47] ======================= test_reuse ======================== [17:11:47] [PASSED] 4 [17:11:47] [PASSED] 8 [17:11:47] [PASSED] 32 [17:11:47] [PASSED] 256 [17:11:47] =================== [PASSED] test_reuse ==================== [17:11:47] =================== test_range_overlap ==================== [17:11:47] [PASSED] 4 [17:11:47] [PASSED] 8 [17:11:47] [PASSED] 32 [17:11:47] [PASSED] 256 [17:11:47] =============== [PASSED] test_range_overlap ================ [17:11:47] =================== test_range_compact ==================== [17:11:47] [PASSED] 4 [17:11:47] [PASSED] 8 [17:11:47] [PASSED] 32 [17:11:47] [PASSED] 256 [17:11:47] =============== [PASSED] test_range_compact ================ [17:11:47] ==================== test_range_spare ===================== [17:11:47] [PASSED] 4 [17:11:47] [PASSED] 8 [17:11:47] [PASSED] 32 [17:11:47] [PASSED] 256 [17:11:47] ================ [PASSED] test_range_spare ================= [17:11:47] ===================== [PASSED] guc_dbm ===================== [17:11:47] =================== guc_idm (6 subtests) =================== [17:11:47] [PASSED] bad_init [17:11:47] [PASSED] no_init [17:11:47] [PASSED] init_fini [17:11:47] [PASSED] check_used [17:11:47] [PASSED] check_quota [17:11:47] [PASSED] check_all [17:11:47] ===================== [PASSED] guc_idm ===================== [17:11:47] ================== no_relay (3 subtests) =================== [17:11:47] [PASSED] xe_drops_guc2pf_if_not_ready [17:11:47] [PASSED] xe_drops_guc2vf_if_not_ready [17:11:47] [PASSED] xe_rejects_send_if_not_ready [17:11:47] ==================== [PASSED] no_relay ===================== [17:11:47] ================== pf_relay (14 subtests) ================== [17:11:47] [PASSED] pf_rejects_guc2pf_too_short [17:11:47] [PASSED] pf_rejects_guc2pf_too_long [17:11:47] [PASSED] pf_rejects_guc2pf_no_payload [17:11:47] [PASSED] pf_fails_no_payload [17:11:47] [PASSED] pf_fails_bad_origin [17:11:47] [PASSED] pf_fails_bad_type [17:11:47] [PASSED] pf_txn_reports_error [17:11:47] [PASSED] pf_txn_sends_pf2guc [17:11:47] [PASSED] pf_sends_pf2guc [17:11:47] [SKIPPED] pf_loopback_nop [17:11:47] [SKIPPED] pf_loopback_echo [17:11:47] [SKIPPED] pf_loopback_fail [17:11:47] [SKIPPED] pf_loopback_busy [17:11:47] [SKIPPED] pf_loopback_retry [17:11:47] ==================== [PASSED] pf_relay ===================== [17:11:47] ================== vf_relay (3 subtests) =================== [17:11:47] [PASSED] vf_rejects_guc2vf_too_short [17:11:47] [PASSED] vf_rejects_guc2vf_too_long [17:11:47] [PASSED] vf_rejects_guc2vf_no_payload [17:11:47] ==================== [PASSED] vf_relay ===================== [17:11:47] ================ pf_gt_config (4 subtests) ================= [17:11:47] [PASSED] fair_contexts_1vf [17:11:47] [PASSED] fair_doorbells_1vf [17:11:47] ====================== fair_contexts ====================== [17:11:47] [PASSED] 1 VF [17:11:47] [PASSED] 2 VFs [17:11:47] [PASSED] 3 VFs [17:11:47] [PASSED] 4 VFs [17:11:47] [PASSED] 5 VFs [17:11:47] [PASSED] 6 VFs [17:11:47] [PASSED] 7 VFs [17:11:47] [PASSED] 8 VFs [17:11:47] [PASSED] 9 VFs [17:11:47] [PASSED] 10 VFs [17:11:47] [PASSED] 11 VFs [17:11:47] [PASSED] 12 VFs [17:11:47] [PASSED] 13 VFs [17:11:47] [PASSED] 14 VFs [17:11:47] [PASSED] 15 VFs [17:11:47] [PASSED] 16 VFs [17:11:47] [PASSED] 17 VFs [17:11:47] [PASSED] 18 VFs [17:11:47] [PASSED] 19 VFs [17:11:47] [PASSED] 20 VFs [17:11:47] [PASSED] 21 VFs [17:11:47] [PASSED] 22 VFs [17:11:47] [PASSED] 23 VFs [17:11:47] [PASSED] 24 VFs [17:11:47] [PASSED] 25 VFs [17:11:47] [PASSED] 26 VFs [17:11:47] [PASSED] 27 VFs [17:11:47] [PASSED] 28 VFs [17:11:47] [PASSED] 29 VFs [17:11:47] [PASSED] 30 VFs [17:11:47] [PASSED] 31 VFs [17:11:47] [PASSED] 32 VFs [17:11:47] [PASSED] 33 VFs [17:11:47] [PASSED] 34 VFs [17:11:47] [PASSED] 35 VFs [17:11:47] [PASSED] 36 VFs [17:11:47] [PASSED] 37 VFs [17:11:47] [PASSED] 38 VFs [17:11:47] [PASSED] 39 VFs [17:11:47] [PASSED] 40 VFs [17:11:47] [PASSED] 41 VFs [17:11:47] [PASSED] 42 VFs [17:11:47] [PASSED] 43 VFs [17:11:47] [PASSED] 44 VFs [17:11:47] [PASSED] 45 VFs [17:11:47] [PASSED] 46 VFs [17:11:47] [PASSED] 47 VFs [17:11:47] [PASSED] 48 VFs [17:11:47] [PASSED] 49 VFs [17:11:47] [PASSED] 50 VFs [17:11:47] [PASSED] 51 VFs [17:11:47] [PASSED] 52 VFs [17:11:47] [PASSED] 53 VFs [17:11:47] [PASSED] 54 VFs [17:11:47] [PASSED] 55 VFs [17:11:47] [PASSED] 56 VFs [17:11:47] [PASSED] 57 VFs [17:11:47] [PASSED] 58 VFs [17:11:47] [PASSED] 59 VFs [17:11:47] [PASSED] 60 VFs [17:11:47] [PASSED] 61 VFs [17:11:47] [PASSED] 62 VFs [17:11:47] [PASSED] 63 VFs [17:11:47] ================== [PASSED] fair_contexts ================== [17:11:47] ===================== fair_doorbells ====================== [17:11:47] [PASSED] 1 VF [17:11:47] [PASSED] 2 VFs [17:11:47] [PASSED] 3 VFs [17:11:47] [PASSED] 4 VFs [17:11:47] [PASSED] 5 VFs [17:11:47] [PASSED] 6 VFs [17:11:47] [PASSED] 7 VFs [17:11:47] [PASSED] 8 VFs [17:11:47] [PASSED] 9 VFs [17:11:47] [PASSED] 10 VFs [17:11:47] [PASSED] 11 VFs [17:11:47] [PASSED] 12 VFs [17:11:47] [PASSED] 13 VFs [17:11:47] [PASSED] 14 VFs [17:11:47] [PASSED] 15 VFs [17:11:47] [PASSED] 16 VFs [17:11:47] [PASSED] 17 VFs [17:11:47] [PASSED] 18 VFs [17:11:47] [PASSED] 19 VFs [17:11:47] [PASSED] 20 VFs [17:11:47] [PASSED] 21 VFs [17:11:47] [PASSED] 22 VFs [17:11:47] [PASSED] 23 VFs [17:11:47] [PASSED] 24 VFs [17:11:47] [PASSED] 25 VFs [17:11:47] [PASSED] 26 VFs [17:11:47] [PASSED] 27 VFs [17:11:47] [PASSED] 28 VFs [17:11:47] [PASSED] 29 VFs [17:11:47] [PASSED] 30 VFs [17:11:47] [PASSED] 31 VFs [17:11:47] [PASSED] 32 VFs [17:11:47] [PASSED] 33 VFs [17:11:47] [PASSED] 34 VFs [17:11:47] [PASSED] 35 VFs [17:11:47] [PASSED] 36 VFs [17:11:47] [PASSED] 37 VFs [17:11:47] [PASSED] 38 VFs [17:11:47] [PASSED] 39 VFs [17:11:47] [PASSED] 40 VFs [17:11:47] [PASSED] 41 VFs [17:11:47] [PASSED] 42 VFs [17:11:47] [PASSED] 43 VFs [17:11:47] [PASSED] 44 VFs [17:11:47] [PASSED] 45 VFs [17:11:47] [PASSED] 46 VFs [17:11:47] [PASSED] 47 VFs [17:11:47] [PASSED] 48 VFs [17:11:47] [PASSED] 49 VFs [17:11:47] [PASSED] 50 VFs [17:11:47] [PASSED] 51 VFs [17:11:47] [PASSED] 52 VFs [17:11:47] [PASSED] 53 VFs [17:11:47] [PASSED] 54 VFs [17:11:47] [PASSED] 55 VFs [17:11:47] [PASSED] 56 VFs [17:11:47] [PASSED] 57 VFs [17:11:47] [PASSED] 58 VFs [17:11:47] [PASSED] 59 VFs [17:11:47] [PASSED] 60 VFs [17:11:47] [PASSED] 61 VFs [17:11:47] [PASSED] 62 VFs [17:11:47] [PASSED] 63 VFs [17:11:47] ================= [PASSED] fair_doorbells ================== [17:11:47] ================== [PASSED] pf_gt_config =================== [17:11:47] ===================== lmtt (1 subtest) ===================== [17:11:47] ======================== test_ops ========================= [17:11:47] [PASSED] 2-level [17:11:47] [PASSED] multi-level [17:11:47] ==================== [PASSED] test_ops ===================== [17:11:47] ====================== [PASSED] lmtt ======================= [17:11:47] ================= pf_service (11 subtests) ================= [17:11:47] [PASSED] pf_negotiate_any [17:11:47] [PASSED] pf_negotiate_base_match [17:11:47] [PASSED] pf_negotiate_base_newer [17:11:47] [PASSED] pf_negotiate_base_next [17:11:47] [SKIPPED] pf_negotiate_base_older [17:11:47] [PASSED] pf_negotiate_base_prev [17:11:47] [PASSED] pf_negotiate_latest_match [17:11:47] [PASSED] pf_negotiate_latest_newer [17:11:47] [PASSED] pf_negotiate_latest_next [17:11:47] [SKIPPED] pf_negotiate_latest_older [17:11:47] [SKIPPED] pf_negotiate_latest_prev [17:11:47] =================== [PASSED] pf_service ==================== [17:11:47] ================= xe_guc_g2g (2 subtests) ================== [17:11:47] ============== xe_live_guc_g2g_kunit_default ============== [17:11:47] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [17:11:47] ============== xe_live_guc_g2g_kunit_allmem =============== [17:11:47] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [17:11:47] =================== [SKIPPED] xe_guc_g2g =================== [17:11:47] =================== xe_mocs (2 subtests) =================== [17:11:47] ================ xe_live_mocs_kernel_kunit ================ [17:11:47] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [17:11:47] ================ xe_live_mocs_reset_kunit ================= [17:11:47] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [17:11:47] ==================== [SKIPPED] xe_mocs ===================== [17:11:47] ================= xe_migrate (2 subtests) ================== [17:11:47] ================= xe_migrate_sanity_kunit ================= [17:11:47] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [17:11:47] ================== xe_validate_ccs_kunit ================== [17:11:47] ============= [SKIPPED] xe_validate_ccs_kunit ============== [17:11:47] =================== [SKIPPED] xe_migrate =================== [17:11:47] ================== xe_dma_buf (1 subtest) ================== [17:11:47] ==================== xe_dma_buf_kunit ===================== [17:11:47] ================ [SKIPPED] xe_dma_buf_kunit ================ [17:11:47] =================== [SKIPPED] xe_dma_buf =================== [17:11:47] ================= xe_bo_shrink (1 subtest) ================= [17:11:47] =================== xe_bo_shrink_kunit ==================== [17:11:47] =============== [SKIPPED] xe_bo_shrink_kunit =============== [17:11:47] ================== [SKIPPED] xe_bo_shrink ================== [17:11:47] ==================== xe_bo (2 subtests) ==================== [17:11:47] ================== xe_ccs_migrate_kunit =================== [17:11:47] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [17:11:47] ==================== xe_bo_evict_kunit ==================== [17:11:47] =============== [SKIPPED] xe_bo_evict_kunit ================ [17:11:47] ===================== [SKIPPED] xe_bo ====================== [17:11:47] ==================== args (11 subtests) ==================== [17:11:47] [PASSED] count_args_test [17:11:47] [PASSED] call_args_example [17:11:47] [PASSED] call_args_test [17:11:47] [PASSED] drop_first_arg_example [17:11:47] [PASSED] drop_first_arg_test [17:11:47] [PASSED] first_arg_example [17:11:47] [PASSED] first_arg_test [17:11:47] [PASSED] last_arg_example [17:11:47] [PASSED] last_arg_test [17:11:47] [PASSED] pick_arg_example [17:11:47] [PASSED] sep_comma_example [17:11:47] ====================== [PASSED] args ======================= [17:11:47] =================== xe_pci (3 subtests) ==================== [17:11:47] ==================== check_graphics_ip ==================== [17:11:47] [PASSED] 12.00 Xe_LP [17:11:47] [PASSED] 12.10 Xe_LP+ [17:11:47] [PASSED] 12.55 Xe_HPG [17:11:47] [PASSED] 12.60 Xe_HPC [17:11:47] [PASSED] 12.70 Xe_LPG [17:11:47] [PASSED] 12.71 Xe_LPG [17:11:47] [PASSED] 12.74 Xe_LPG+ [17:11:47] [PASSED] 20.01 Xe2_HPG [17:11:47] [PASSED] 20.02 Xe2_HPG [17:11:47] [PASSED] 20.04 Xe2_LPG [17:11:47] [PASSED] 30.00 Xe3_LPG [17:11:47] [PASSED] 30.01 Xe3_LPG [17:11:47] [PASSED] 30.03 Xe3_LPG [17:11:47] [PASSED] 30.04 Xe3_LPG [17:11:47] [PASSED] 30.05 Xe3_LPG [17:11:47] [PASSED] 35.11 Xe3p_XPC [17:11:47] ================ [PASSED] check_graphics_ip ================ [17:11:47] ===================== check_media_ip ====================== [17:11:47] [PASSED] 12.00 Xe_M [17:11:47] [PASSED] 12.55 Xe_HPM [17:11:47] [PASSED] 13.00 Xe_LPM+ [17:11:47] [PASSED] 13.01 Xe2_HPM [17:11:47] [PASSED] 20.00 Xe2_LPM [17:11:47] [PASSED] 30.00 Xe3_LPM [17:11:47] [PASSED] 30.02 Xe3_LPM [17:11:47] [PASSED] 35.00 Xe3p_LPM [17:11:47] [PASSED] 35.03 Xe3p_HPM [17:11:47] ================= [PASSED] check_media_ip ================== [17:11:47] =================== check_platform_desc =================== [17:11:47] [PASSED] 0x9A60 (TIGERLAKE) [17:11:47] [PASSED] 0x9A68 (TIGERLAKE) [17:11:47] [PASSED] 0x9A70 (TIGERLAKE) [17:11:47] [PASSED] 0x9A40 (TIGERLAKE) [17:11:47] [PASSED] 0x9A49 (TIGERLAKE) [17:11:47] [PASSED] 0x9A59 (TIGERLAKE) [17:11:47] [PASSED] 0x9A78 (TIGERLAKE) [17:11:47] [PASSED] 0x9AC0 (TIGERLAKE) [17:11:47] [PASSED] 0x9AC9 (TIGERLAKE) [17:11:47] [PASSED] 0x9AD9 (TIGERLAKE) [17:11:47] [PASSED] 0x9AF8 (TIGERLAKE) [17:11:47] [PASSED] 0x4C80 (ROCKETLAKE) [17:11:47] [PASSED] 0x4C8A (ROCKETLAKE) [17:11:47] [PASSED] 0x4C8B (ROCKETLAKE) [17:11:47] [PASSED] 0x4C8C (ROCKETLAKE) [17:11:47] [PASSED] 0x4C90 (ROCKETLAKE) [17:11:47] [PASSED] 0x4C9A (ROCKETLAKE) [17:11:47] [PASSED] 0x4680 (ALDERLAKE_S) [17:11:47] [PASSED] 0x4682 (ALDERLAKE_S) [17:11:47] [PASSED] 0x4688 (ALDERLAKE_S) [17:11:47] [PASSED] 0x468A (ALDERLAKE_S) [17:11:47] [PASSED] 0x468B (ALDERLAKE_S) [17:11:47] [PASSED] 0x4690 (ALDERLAKE_S) [17:11:47] [PASSED] 0x4692 (ALDERLAKE_S) [17:11:47] [PASSED] 0x4693 (ALDERLAKE_S) [17:11:47] [PASSED] 0x46A0 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46A1 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46A2 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46A3 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46A6 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46A8 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46AA (ALDERLAKE_P) [17:11:47] [PASSED] 0x462A (ALDERLAKE_P) [17:11:47] [PASSED] 0x4626 (ALDERLAKE_P) [17:11:47] [PASSED] 0x4628 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46B0 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46B1 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46B2 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46B3 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46C0 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46C1 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46C2 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46C3 (ALDERLAKE_P) [17:11:47] [PASSED] 0x46D0 (ALDERLAKE_N) [17:11:47] [PASSED] 0x46D1 (ALDERLAKE_N) [17:11:47] [PASSED] 0x46D2 (ALDERLAKE_N) [17:11:47] [PASSED] 0x46D3 (ALDERLAKE_N) [17:11:47] [PASSED] 0x46D4 (ALDERLAKE_N) [17:11:47] [PASSED] 0xA721 (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7A1 (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7A9 (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7AC (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7AD (ALDERLAKE_P) [17:11:47] [PASSED] 0xA720 (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7A0 (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7A8 (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7AA (ALDERLAKE_P) [17:11:47] [PASSED] 0xA7AB (ALDERLAKE_P) [17:11:47] [PASSED] 0xA780 (ALDERLAKE_S) [17:11:47] [PASSED] 0xA781 (ALDERLAKE_S) [17:11:47] [PASSED] 0xA782 (ALDERLAKE_S) [17:11:47] [PASSED] 0xA783 (ALDERLAKE_S) [17:11:47] [PASSED] 0xA788 (ALDERLAKE_S) [17:11:47] [PASSED] 0xA789 (ALDERLAKE_S) [17:11:47] [PASSED] 0xA78A (ALDERLAKE_S) [17:11:47] [PASSED] 0xA78B (ALDERLAKE_S) [17:11:47] [PASSED] 0x4905 (DG1) [17:11:47] [PASSED] 0x4906 (DG1) [17:11:47] [PASSED] 0x4907 (DG1) [17:11:47] [PASSED] 0x4908 (DG1) [17:11:47] [PASSED] 0x4909 (DG1) [17:11:47] [PASSED] 0x56C0 (DG2) [17:11:47] [PASSED] 0x56C2 (DG2) [17:11:47] [PASSED] 0x56C1 (DG2) [17:11:47] [PASSED] 0x7D51 (METEORLAKE) [17:11:47] [PASSED] 0x7DD1 (METEORLAKE) [17:11:47] [PASSED] 0x7D41 (METEORLAKE) [17:11:47] [PASSED] 0x7D67 (METEORLAKE) [17:11:47] [PASSED] 0xB640 (METEORLAKE) [17:11:47] [PASSED] 0x56A0 (DG2) [17:11:47] [PASSED] 0x56A1 (DG2) [17:11:47] [PASSED] 0x56A2 (DG2) [17:11:47] [PASSED] 0x56BE (DG2) [17:11:47] [PASSED] 0x56BF (DG2) [17:11:47] [PASSED] 0x5690 (DG2) stty: 'standard input': Inappropriate ioctl for device [17:11:47] [PASSED] 0x5691 (DG2) [17:11:47] [PASSED] 0x5692 (DG2) [17:11:47] [PASSED] 0x56A5 (DG2) [17:11:47] [PASSED] 0x56A6 (DG2) [17:11:47] [PASSED] 0x56B0 (DG2) [17:11:47] [PASSED] 0x56B1 (DG2) [17:11:47] [PASSED] 0x56BA (DG2) [17:11:47] [PASSED] 0x56BB (DG2) [17:11:47] [PASSED] 0x56BC (DG2) [17:11:47] [PASSED] 0x56BD (DG2) [17:11:47] [PASSED] 0x5693 (DG2) [17:11:47] [PASSED] 0x5694 (DG2) [17:11:47] [PASSED] 0x5695 (DG2) [17:11:47] [PASSED] 0x56A3 (DG2) [17:11:47] [PASSED] 0x56A4 (DG2) [17:11:47] [PASSED] 0x56B2 (DG2) [17:11:47] [PASSED] 0x56B3 (DG2) [17:11:47] [PASSED] 0x5696 (DG2) [17:11:47] [PASSED] 0x5697 (DG2) [17:11:47] [PASSED] 0xB69 (PVC) [17:11:47] [PASSED] 0xB6E (PVC) [17:11:47] [PASSED] 0xBD4 (PVC) [17:11:47] [PASSED] 0xBD5 (PVC) [17:11:47] [PASSED] 0xBD6 (PVC) [17:11:47] [PASSED] 0xBD7 (PVC) [17:11:47] [PASSED] 0xBD8 (PVC) [17:11:47] [PASSED] 0xBD9 (PVC) [17:11:47] [PASSED] 0xBDA (PVC) [17:11:47] [PASSED] 0xBDB (PVC) [17:11:47] [PASSED] 0xBE0 (PVC) [17:11:47] [PASSED] 0xBE1 (PVC) [17:11:47] [PASSED] 0xBE5 (PVC) [17:11:47] [PASSED] 0x7D40 (METEORLAKE) [17:11:47] [PASSED] 0x7D45 (METEORLAKE) [17:11:47] [PASSED] 0x7D55 (METEORLAKE) [17:11:47] [PASSED] 0x7D60 (METEORLAKE) [17:11:47] [PASSED] 0x7DD5 (METEORLAKE) [17:11:47] [PASSED] 0x6420 (LUNARLAKE) [17:11:47] [PASSED] 0x64A0 (LUNARLAKE) [17:11:47] [PASSED] 0x64B0 (LUNARLAKE) [17:11:47] [PASSED] 0xE202 (BATTLEMAGE) [17:11:47] [PASSED] 0xE209 (BATTLEMAGE) [17:11:47] [PASSED] 0xE20B (BATTLEMAGE) [17:11:47] [PASSED] 0xE20C (BATTLEMAGE) [17:11:47] [PASSED] 0xE20D (BATTLEMAGE) [17:11:47] [PASSED] 0xE210 (BATTLEMAGE) [17:11:47] [PASSED] 0xE211 (BATTLEMAGE) [17:11:47] [PASSED] 0xE212 (BATTLEMAGE) [17:11:47] [PASSED] 0xE216 (BATTLEMAGE) [17:11:47] [PASSED] 0xE220 (BATTLEMAGE) [17:11:47] [PASSED] 0xE221 (BATTLEMAGE) [17:11:47] [PASSED] 0xE222 (BATTLEMAGE) [17:11:47] [PASSED] 0xE223 (BATTLEMAGE) [17:11:47] [PASSED] 0xB080 (PANTHERLAKE) [17:11:47] [PASSED] 0xB081 (PANTHERLAKE) [17:11:47] [PASSED] 0xB082 (PANTHERLAKE) [17:11:47] [PASSED] 0xB083 (PANTHERLAKE) [17:11:47] [PASSED] 0xB084 (PANTHERLAKE) [17:11:47] [PASSED] 0xB085 (PANTHERLAKE) [17:11:47] [PASSED] 0xB086 (PANTHERLAKE) [17:11:47] [PASSED] 0xB087 (PANTHERLAKE) [17:11:47] [PASSED] 0xB08F (PANTHERLAKE) [17:11:47] [PASSED] 0xB090 (PANTHERLAKE) [17:11:47] [PASSED] 0xB0A0 (PANTHERLAKE) [17:11:47] [PASSED] 0xB0B0 (PANTHERLAKE) [17:11:47] [PASSED] 0xD740 (NOVALAKE_S) [17:11:47] [PASSED] 0xD741 (NOVALAKE_S) [17:11:47] [PASSED] 0xD742 (NOVALAKE_S) [17:11:47] [PASSED] 0xD743 (NOVALAKE_S) [17:11:47] [PASSED] 0xD744 (NOVALAKE_S) [17:11:47] [PASSED] 0xD745 (NOVALAKE_S) [17:11:47] [PASSED] 0x674C (CRESCENTISLAND) [17:11:47] [PASSED] 0xFD80 (PANTHERLAKE) [17:11:47] [PASSED] 0xFD81 (PANTHERLAKE) [17:11:47] =============== [PASSED] check_platform_desc =============== [17:11:47] ===================== [PASSED] xe_pci ====================== [17:11:47] =================== xe_rtp (2 subtests) ==================== [17:11:47] =============== xe_rtp_process_to_sr_tests ================ [17:11:47] [PASSED] coalesce-same-reg [17:11:47] [PASSED] no-match-no-add [17:11:47] [PASSED] match-or [17:11:47] [PASSED] match-or-xfail [17:11:47] [PASSED] no-match-no-add-multiple-rules [17:11:47] [PASSED] two-regs-two-entries [17:11:47] [PASSED] clr-one-set-other [17:11:47] [PASSED] set-field [17:11:47] [PASSED] conflict-duplicate [17:11:47] [PASSED] conflict-not-disjoint [17:11:47] [PASSED] conflict-reg-type [17:11:47] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [17:11:47] ================== xe_rtp_process_tests =================== [17:11:47] [PASSED] active1 [17:11:47] [PASSED] active2 [17:11:47] [PASSED] active-inactive [17:11:47] [PASSED] inactive-active [17:11:47] [PASSED] inactive-1st_or_active-inactive [17:11:47] [PASSED] inactive-2nd_or_active-inactive [17:11:47] [PASSED] inactive-last_or_active-inactive [17:11:47] [PASSED] inactive-no_or_active-inactive [17:11:47] ============== [PASSED] xe_rtp_process_tests =============== [17:11:47] ===================== [PASSED] xe_rtp ====================== [17:11:47] ==================== xe_wa (1 subtest) ===================== [17:11:47] ======================== xe_wa_gt ========================= [17:11:47] [PASSED] TIGERLAKE B0 [17:11:47] [PASSED] DG1 A0 [17:11:47] [PASSED] DG1 B0 [17:11:47] [PASSED] ALDERLAKE_S A0 [17:11:47] [PASSED] ALDERLAKE_S B0 [17:11:47] [PASSED] ALDERLAKE_S C0 [17:11:47] [PASSED] ALDERLAKE_S D0 [17:11:47] [PASSED] ALDERLAKE_P A0 [17:11:47] [PASSED] ALDERLAKE_P B0 [17:11:47] [PASSED] ALDERLAKE_P C0 [17:11:47] [PASSED] ALDERLAKE_S RPLS D0 [17:11:47] [PASSED] ALDERLAKE_P RPLU E0 [17:11:47] [PASSED] DG2 G10 C0 [17:11:47] [PASSED] DG2 G11 B1 [17:11:47] [PASSED] DG2 G12 A1 [17:11:47] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [17:11:47] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [17:11:47] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [17:11:47] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [17:11:47] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [17:11:47] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [17:11:47] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [17:11:47] ==================== [PASSED] xe_wa_gt ===================== [17:11:47] ====================== [PASSED] xe_wa ====================== [17:11:47] ============================================================ [17:11:47] Testing complete. Ran 446 tests: passed: 428, skipped: 18 [17:11:47] Elapsed time: 35.361s total, 4.290s configuring, 30.604s building, 0.418s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
stty: 'standard input': Inappropriate ioctl for device
[17:11:47] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [17:11:49] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [17:12:14] Starting KUnit Kernel (1/1)... [17:12:14] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [17:12:14] ============ drm_test_pick_cmdline (2 subtests) ============ [17:12:14] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [17:12:14] =============== drm_test_pick_cmdline_named =============== [17:12:14] [PASSED] NTSC [17:12:14] [PASSED] NTSC-J [17:12:14] [PASSED] PAL [17:12:14] [PASSED] PAL-M [17:12:14] =========== [PASSED] drm_test_pick_cmdline_named =========== [17:12:14] ============== [PASSED] drm_test_pick_cmdline ============== [17:12:14] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [17:12:14] [ERROR] Test: drm_test_atomic_get_connector_for_encoder: missing expected subtest! [17:12:14] ------------[ cut here ]------------ [17:12:14] WARNING: CPU: 0 PID: 28 at drivers/gpu/drm/drm_vblank.c:193 drm_crtc_vblank_crtc+0x94/0xa0 [17:12:14] drm-kunit-mock-device drm_test_drm_atomic_get_connector_for_encoder.drm-kunit-mock-device: [drm] drm_WARN_ON(!vblank) [17:12:14] CPU: 0 UID: 0 PID: 28 Comm: kunit_try_catch Tainted: G W N 6.18.0-rc5-g82292f137e2d #2 NONE [17:12:14] Tainted: [W]=WARN, [N]=TEST [17:12:14] Stack: [17:12:14] 604c25af 00000000 00000000 00000001 [17:12:14] ffffff00 604c25af 602da8d4 00000009 [17:12:14] 000000c1 60046f7a 600237bb ad38bc20 [17:12:14] Call Trace: [17:12:14] [<602da8d4>] ? drm_crtc_vblank_crtc+0x94/0xa0 [17:12:14] [<60046f7a>] ? dump_stack_lvl+0x5b/0x77 [17:12:14] [<600237bb>] ? _printk+0x0/0x65 [17:12:14] [<6001f07a>] ? __warn.cold+0x71/0x10b [17:12:14] [<6001f1a8>] ? warn_slowpath_fmt+0x94/0xa1 [17:12:14] [<602a2ad0>] ? drm_atomic_get_connector_state+0x0/0x2f0 [17:12:14] [<60055bf9>] ? um_set_signals+0x59/0x70 [17:12:14] [<602d3e50>] ? __drm_dev_dbg+0x0/0xb0 [17:12:14] [<602da8d4>] ? drm_crtc_vblank_crtc+0x94/0xa0 [17:12:14] [<602da892>] ? drm_crtc_vblank_crtc+0x52/0xa0 [17:12:14] [<602dab07>] ? drm_calc_timestamping_constants+0x27/0x170 [17:12:14] [<60055ba0>] ? um_set_signals+0x0/0x70 [17:12:14] [<602daae0>] ? drm_calc_timestamping_constants+0x0/0x170 [17:12:14] [<602d3e50>] ? __drm_dev_dbg+0x0/0xb0 [17:12:14] [<602eb0fc>] ? drm_atomic_helper_calc_timestamping_constants+0x6c/0x90 [17:12:14] [<602ee25c>] ? drm_atomic_helper_commit_modeset_disables+0x43c/0x7f0 [17:12:14] [<600ced10>] ? ktime_get+0x0/0x150 [17:12:14] [<602ce6f0>] ? drm_modeset_backoff+0x0/0x1d0 [17:12:14] [<602eef23>] ? drm_atomic_helper_commit_tail+0x23/0xa0 [17:12:14] [<602f0164>] ? commit_tail+0xf4/0x180 [17:12:14] [<602ff510>] ? drm_kunit_helper_enable_crtc_connector+0x0/0x140 [17:12:14] [<602f039f>] ? drm_atomic_helper_commit+0x18f/0x1d0 [17:12:14] [<602a4af9>] ? drm_atomic_commit+0xb9/0xe0 [17:12:14] [<6003db45>] ? __drm_printfn_info+0x0/0x23 [17:12:14] [<602ff870>] ? drm_test_drm_atomic_get_connector_for_encoder+0x220/0x590 [17:12:14] [<6008b2c6>] ? finish_task_switch.isra.0+0x76/0x1b0 [17:12:14] [<600cf290>] ? ktime_get_ts64+0x0/0x1a0 [17:12:14] [<60082650>] ? to_kthread+0x0/0x40 [17:12:14] [<60252ecf>] ? kunit_try_run_case+0x7f/0x100 [17:12:14] [<60082650>] ? to_kthread+0x0/0x40 [17:12:14] [<60255220>] ? kunit_generic_run_threadfn_adapter+0x0/0x30 [17:12:14] [<60255236>] ? kunit_generic_run_threadfn_adapter+0x16/0x30 [17:12:14] [<60083035>] ? kthread+0xf5/0x270 [17:12:14] [<60049595>] ? new_thread_handler+0x45/0x60 [17:12:14] ---[ end trace 0000000000000000 ]--- [17:12:14] ------------[ cut here ]------------ [17:12:14] WARNING: CPU: 0 PID: 28 at drivers/gpu/drm/drm_vblank.c:193 drm_crtc_vblank_crtc+0x94/0xa0 [17:12:14] drm-kunit-mock-device drm_test_drm_atomic_get_connector_for_encoder.drm-kunit-mock-device: [drm] drm_WARN_ON(!vblank) [17:12:14] CPU: 0 UID: 0 PID: 28 Comm: kunit_try_catch Tainted: G W N 6.18.0-rc5-g82292f137e2d #2 NONE [17:12:14] Tainted: [W]=WARN, [N]=TEST [17:12:14] Stack: [17:12:14] 604c25af 00000000 00000000 00000000 [17:12:14] ffffff00 604c25af 602da8d4 00000009 [17:12:14] 000000c1 60046f7a 600237bb ad38bc90 [17:12:14] Call Trace: [17:12:14] [<602da8d4>] ? drm_crtc_vblank_crtc+0x94/0xa0 [17:12:14] [<60046f7a>] ? dump_stack_lvl+0x5b/0x77 [17:12:14] [<600237bb>] ? _printk+0x0/0x65 [17:12:14] [<6001f07a>] ? __warn.cold+0x71/0x10b [17:12:14] [<6001f1a8>] ? warn_slowpath_fmt+0x94/0xa1 [17:12:14] [<602dab07>] ? drm_calc_timestamping_constants+0x27/0x170 [17:12:14] [<60055ba0>] ? um_set_signals+0x0/0x70 [17:12:14] [<602da8d4>] ? drm_crtc_vblank_crtc+0x94/0xa0 [17:12:14] [<602da892>] ? drm_crtc_vblank_crtc+0x52/0xa0 [17:12:14] [<602dad7a>] ? drm_crtc_send_vblank_event+0x1a/0x80 [17:12:14] [<60055ba0>] ? um_set_signals+0x0/0x70 [17:12:14] [<602eb74c>] ? drm_atomic_helper_fake_vblank+0x8c/0xd0 [17:12:14] [<600ced10>] ? ktime_get+0x0/0x150 [17:12:14] [<602ce6f0>] ? drm_modeset_backoff+0x0/0x1d0 [17:12:14] [<602eef58>] ? drm_atomic_helper_commit_tail+0x58/0xa0 [17:12:14] [<602f0164>] ? commit_tail+0xf4/0x180 [17:12:14] [<602ff510>] ? drm_kunit_helper_enable_crtc_connector+0x0/0x140 [17:12:14] [<602f039f>] ? drm_atomic_helper_commit+0x18f/0x1d0 [17:12:14] [<602a4af9>] ? drm_atomic_commit+0xb9/0xe0 [17:12:14] [<6003db45>] ? __drm_printfn_info+0x0/0x23 [17:12:14] [<602ff870>] ? drm_test_drm_atomic_get_connector_for_encoder+0x220/0x590 [17:12:14] [<6008b2c6>] ? finish_task_switch.isra.0+0x76/0x1b0 [17:12:14] [<600cf290>] ? ktime_get_ts64+0x0/0x1a0 [17:12:14] [<60082650>] ? to_kthread+0x0/0x40 [17:12:14] [<60252ecf>] ? kunit_try_run_case+0x7f/0x100 [17:12:14] [<60082650>] ? to_kthread+0x0/0x40 [17:12:14] [<60255220>] ? kunit_generic_run_threadfn_adapter+0x0/0x30 [17:12:14] [<60255236>] ? kunit_generic_run_threadfn_adapter+0x16/0x30 [17:12:14] [<60083035>] ? kthread+0xf5/0x270 [17:12:14] [<60049595>] ? new_thread_handler+0x45/0x60 [17:12:14] ---[ end trace 0000000000000000 ]--- [17:12:14] [17:12:14] Pid: 28, comm: kunit_try_catch Tainted: G W N 6.18.0-rc5-g82292f137e2d [17:12:14] RIP: 0033:drm_crtc_send_vblank_event+0x3f/0x80 [17:12:14] RSP: 00000000ad38bd30 EFLAGS: 00010246 [17:12:14] RAX: 0000000006041f80 RBX: 0000000000000000 RCX: 0000000006041f80 [17:12:14] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [17:12:14] RBP: 000000006daecd80 R08: 0000000000000000 R09: 0000000000000000 [17:12:14] R10: 0000000000000000 R11: 0000000000000000 R12: 000000006da48000 [17:12:14] R13: 000000006daece00 R14: 000000006d880828 R15: 0000000000000001 [17:12:14] Kernel panic - not syncing: Segfault with no mm [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: drm_test_atomic_get_connector_for_encoder: missing subtest result line! [17:12:14] # module: drm_atomic_test [17:12:14] === [CRASHED] drm_test_atomic_get_connector_for_encoder ==== [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] [ERROR] Test: main: missing expected subtest! [17:12:14] [CRASHED] [17:12:14] ============================================================ [17:12:14] Testing complete. Ran 40 tests: passed: 5, crashed: 35, errors: 36 The kernel seems to have crashed; you can decode the stack traces with: $ scripts/decode_stacktrace.sh .kunit/vmlinux .kunit < .kunit/test.log | tee .kunit/decoded.log | /kernel/tools/testing/kunit/kunit.py parse [17:12:14] Elapsed time: 26.922s total, 1.711s configuring, 24.942s building, 0.269s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✓ i915.CI.BAT: success for drm/vblank: refactoring and cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/vblank: refactoring and cleanups
URL : https://patchwork.freedesktop.org/series/157331/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17525 -> Patchwork_157331v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/index.html
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-snb-2520m fi-pnv-d510 bat-adls-6 bat-dg2-13 fi-skl-6600u
Known issues
------------
Here are the changes found in Patchwork_157331v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@workarounds:
- bat-arls-5: [PASS][1] -> [DMESG-FAIL][2] ([i915#12061]) +1 other test dmesg-fail
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/bat-arls-5/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/bat-arls-5/igt@i915_selftest@[email protected]
- bat-mtlp-9: [PASS][3] -> [DMESG-FAIL][4] ([i915#12061]) +1 other test dmesg-fail
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/bat-mtlp-9/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/bat-mtlp-9/igt@i915_selftest@[email protected]
- bat-arls-6: [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/bat-arls-6/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/bat-arls-6/igt@i915_selftest@[email protected]
#### Possible fixes ####
* igt@i915_module_load@load:
- bat-mtlp-9: [DMESG-WARN][7] ([i915#13494]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/bat-mtlp-9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/bat-mtlp-9/igt@[email protected]
* igt@i915_selftest@live:
- bat-adlp-11: [DMESG-WARN][9] ([i915#14872]) -> [PASS][10] +1 other test pass
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/bat-adlp-11/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/bat-adlp-11/igt@[email protected]
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13494]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13494
[i915#14872]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14872
Build changes
-------------
* Linux: CI_DRM_17525 -> Patchwork_157331v1
CI-20190529: 20190529
CI_DRM_17525: a9792b1ab75123e4aceaba953a89809e745919c6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8617: 8617
Patchwork_157331v1: a9792b1ab75123e4aceaba953a89809e745919c6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/index.html
Patchwork
CI✓ i915.CI.Full: success for drm/vblank: refactoring and cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/vblank: refactoring and cleanups
URL : https://patchwork.freedesktop.org/series/157331/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_17525_full -> Patchwork_157331v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
Additional (1): shard-dg2-set2
Missing (1): shard-glk10
Known issues
------------
Here are the changes found in Patchwork_157331v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@crc32:
- shard-dg1: NOTRUN -> [SKIP][1] ([i915#6230])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@device_reset@unbind-cold-reset-rebind:
- shard-mtlp: NOTRUN -> [SKIP][2] ([i915#11078])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_basic@multigpu-create-close:
- shard-tglu: NOTRUN -> [SKIP][3] ([i915#7697])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@gem_ccs@block-multicopy-inplace:
- shard-tglu-1: NOTRUN -> [SKIP][4] ([i915#3555] / [i915#9323])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@gem_ccs@ctrl-surf-copy:
- shard-dg1: NOTRUN -> [SKIP][5] ([i915#3555] / [i915#9323])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_ccs@suspend-resume:
- shard-rkl: NOTRUN -> [SKIP][6] ([i915#9323])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
- shard-tglu-1: NOTRUN -> [SKIP][7] ([i915#9323])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@gem_close_race@multigpu-basic-threads:
- shard-rkl: NOTRUN -> [SKIP][8] ([i915#7697])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@gem_create@create-ext-cpu-access-big:
- shard-tglu-1: NOTRUN -> [SKIP][9] ([i915#6335])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@gem_create@create-ext-set-pat:
- shard-tglu: NOTRUN -> [SKIP][10] ([i915#8562])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-dg1: NOTRUN -> [SKIP][11] ([i915#8555])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_ctx_persistence@heartbeat-many:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#8555])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-hang:
- shard-snb: NOTRUN -> [SKIP][13] ([i915#1099])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-snb5/igt@[email protected]
* igt@gem_ctx_sseu@mmap-args:
- shard-mtlp: NOTRUN -> [SKIP][14] ([i915#280])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-mtlp: [PASS][15] -> [SKIP][16] ([i915#15178])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-mtlp-4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-4/igt@[email protected]
* igt@gem_exec_balancer@invalid-bonds:
- shard-dg2: NOTRUN -> [SKIP][17] ([i915#4036])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_exec_balancer@sliced:
- shard-dg1: NOTRUN -> [SKIP][18] ([i915#4812])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-cpu:
- shard-rkl: NOTRUN -> [SKIP][19] ([i915#3281]) +3 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-rkl: NOTRUN -> [SKIP][20] ([i915#14544] / [i915#3281]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-cpu-noreloc:
- shard-mtlp: NOTRUN -> [SKIP][21] ([i915#3281])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- shard-dg1: NOTRUN -> [SKIP][22] ([i915#3281]) +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_exec_reloc@basic-write-read:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#3281])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_exec_schedule@semaphore-power:
- shard-rkl: NOTRUN -> [SKIP][24] ([i915#7276])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@gem_fence_thrash@bo-write-verify-x:
- shard-dg1: NOTRUN -> [SKIP][25] ([i915#4860])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-rkl: NOTRUN -> [SKIP][26] ([i915#14544] / [i915#4613])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-tglu: NOTRUN -> [SKIP][27] ([i915#4613]) +2 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-tglu-1: NOTRUN -> [SKIP][28] ([i915#4613]) +2 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@gem_lmem_swapping@verify-ccs:
- shard-rkl: NOTRUN -> [SKIP][29] ([i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@gem_mmap@basic:
- shard-dg1: NOTRUN -> [SKIP][30] ([i915#4083])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_mmap_gtt@basic:
- shard-mtlp: NOTRUN -> [SKIP][31] ([i915#4077]) +7 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_mmap_gtt@basic-copy:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#4077]) +2 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_mmap_gtt@ptrace:
- shard-dg1: NOTRUN -> [SKIP][33] ([i915#4077])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_mmap_wc@coherency:
- shard-mtlp: NOTRUN -> [SKIP][34] ([i915#4083])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_mmap_wc@copy:
- shard-dg2: NOTRUN -> [SKIP][35] ([i915#4083])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@reads:
- shard-rkl: NOTRUN -> [SKIP][36] ([i915#3282])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@write:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#3282])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@write-display:
- shard-rkl: NOTRUN -> [SKIP][38] ([i915#14544] / [i915#3282]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-dg1: NOTRUN -> [SKIP][39] ([i915#3282])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: NOTRUN -> [WARN][40] ([i915#14702] / [i915#2658])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-glk1/igt@[email protected]
* igt@gem_pwrite@basic-self:
- shard-mtlp: NOTRUN -> [SKIP][41] ([i915#3282])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_pxp@create-regular-buffer:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#4270])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_pxp@hw-rejects-pxp-context:
- shard-tglu-1: NOTRUN -> [SKIP][43] ([i915#13398])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-rkl: NOTRUN -> [TIMEOUT][44] ([i915#12917] / [i915#12964])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-rkl: [PASS][45] -> [TIMEOUT][46] ([i915#12917] / [i915#12964]) +1 other test timeout
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][47] ([i915#4270])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#4270])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-ccs:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#5190] / [i915#8428])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_render_copy@yf-tiled-ccs-to-yf-tiled-ccs:
- shard-mtlp: NOTRUN -> [SKIP][50] ([i915#8428])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_softpin@evict-snoop:
- shard-dg1: NOTRUN -> [SKIP][51] ([i915#4885])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-rkl: [PASS][52] -> [INCOMPLETE][53] ([i915#13809])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-3/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#3297])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#3297])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-mtlp: NOTRUN -> [SKIP][56] ([i915#3297]) +1 other test skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_wait@wait:
- shard-rkl: [PASS][57] -> [DMESG-WARN][58] ([i915#12964]) +5 other tests dmesg-warn
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-rkl: NOTRUN -> [ABORT][59] ([i915#15131])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@[email protected]
* igt@gen7_exec_parse@cmd-crossing-page:
- shard-mtlp: NOTRUN -> [SKIP][60] +2 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gen9_exec_parse@batch-without-end:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#2856])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@gen9_exec_parse@bb-chained:
- shard-rkl: NOTRUN -> [SKIP][62] ([i915#2527])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-oversize:
- shard-tglu-1: NOTRUN -> [SKIP][63] ([i915#2527] / [i915#2856])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglu: NOTRUN -> [SKIP][64] ([i915#2527] / [i915#2856]) +1 other test skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: NOTRUN -> [DMESG-WARN][65] ([i915#12964]) +7 other tests dmesg-warn
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_freq_api@freq-basic-api:
- shard-rkl: NOTRUN -> [SKIP][66] ([i915#8399])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_freq_api@freq-reset:
- shard-tglu: NOTRUN -> [SKIP][67] ([i915#8399]) +1 other test skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][68] -> [INCOMPLETE][69] ([i915#13729] / [i915#13821])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-snb1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-snb6/igt@[email protected]
* igt@i915_pm_rps@thresholds-idle-park:
- shard-mtlp: NOTRUN -> [SKIP][70] ([i915#11681])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@i915_power@sanity:
- shard-rkl: NOTRUN -> [SKIP][71] ([i915#7984])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@[email protected]
* igt@i915_query@test-query-geometry-subslices:
- shard-tglu: NOTRUN -> [SKIP][72] ([i915#5723])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@i915_selftest@live@workarounds:
- shard-mtlp: [PASS][73] -> [DMESG-FAIL][74] ([i915#12061]) +1 other test dmesg-fail
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-mtlp-4/igt@i915_selftest@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-4/igt@i915_selftest@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-glk: NOTRUN -> [INCOMPLETE][75] ([i915#4817])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-glk1/igt@[email protected]
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg1: NOTRUN -> [SKIP][76] ([i915#9531])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-rkl: NOTRUN -> [SKIP][77] ([i915#1769] / [i915#3555])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-3:
- shard-dg2: [PASS][78] -> [FAIL][79] ([i915#5956]) +1 other test fail
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-6/igt@kms_atomic_transition@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-7/igt@kms_atomic_transition@[email protected]
* igt@kms_big_fb@4-tiled-32bpp-rotate-180:
- shard-rkl: NOTRUN -> [SKIP][80] ([i915#5286]) +1 other test skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_big_fb@4-tiled-32bpp-rotate-270:
- shard-tglu: NOTRUN -> [SKIP][81] ([i915#5286]) +4 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-mtlp: [PASS][82] -> [FAIL][83] ([i915#5138]) +1 other test fail
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-mtlp-3/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-3/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-tglu-1: NOTRUN -> [SKIP][84] ([i915#5286]) +2 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-dg2: NOTRUN -> [SKIP][85] +2 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_big_fb@y-tiled-32bpp-rotate-270:
- shard-dg2: NOTRUN -> [SKIP][86] ([i915#4538] / [i915#5190]) +1 other test skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_ccs@bad-aux-stride-yf-tiled-ccs@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][87] ([i915#6095]) +19 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_ccs@[email protected]
* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-mc-ccs:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#14098] / [i915#6095]) +44 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][89] ([i915#10307] / [i915#6095]) +62 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-4/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs:
- shard-tglu-1: NOTRUN -> [SKIP][90] ([i915#12313])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-mc-ccs@pipe-c-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][91] ([i915#6095]) +49 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs@pipe-d-hdmi-a-1:
- shard-tglu-1: NOTRUN -> [SKIP][92] ([i915#6095]) +39 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][93] ([i915#6095]) +7 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-4/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-rc-ccs-cc@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [ABORT][94] ([i915#12796] / [i915#15132])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- shard-rkl: NOTRUN -> [SKIP][95] ([i915#12313])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][96] ([i915#6095]) +45 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-3/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-rc-ccs-cc@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][97] ([i915#10307] / [i915#10434] / [i915#6095])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-4/igt@kms_ccs@crc-sprite-planes-basic-y-tiled-gen12-rc-ccs-cc@pipe-d-hdmi-a-1.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][98] ([i915#6095]) +157 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-12/igt@kms_ccs@[email protected]
* igt@kms_cdclk@mode-transition:
- shard-glk: NOTRUN -> [SKIP][99] +175 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-glk6/igt@[email protected]
- shard-tglu-1: NOTRUN -> [SKIP][100] ([i915#3742])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_cdclk@mode-transition@pipe-b-dp-3:
- shard-dg2: NOTRUN -> [SKIP][101] ([i915#13781]) +3 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-11/igt@kms_cdclk@[email protected]
* igt@kms_cdclk@plane-scaling:
- shard-tglu: NOTRUN -> [SKIP][102] ([i915#3742])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_chamelium_frames@hdmi-aspect-ratio:
- shard-dg2: NOTRUN -> [SKIP][103] ([i915#11151] / [i915#7828])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_chamelium_frames@hdmi-cmp-planar-formats:
- shard-rkl: NOTRUN -> [SKIP][104] ([i915#11151] / [i915#7828]) +1 other test skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- shard-tglu: NOTRUN -> [SKIP][105] ([i915#11151] / [i915#7828]) +5 other tests skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- shard-tglu-1: NOTRUN -> [SKIP][106] ([i915#11151] / [i915#7828]) +3 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_chamelium_hpd@dp-hpd-for-each-pipe:
- shard-dg1: NOTRUN -> [SKIP][107] ([i915#11151] / [i915#7828]) +1 other test skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode:
- shard-mtlp: NOTRUN -> [SKIP][108] ([i915#11151] / [i915#7828])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@kms_color@gamma:
- shard-rkl: [PASS][109] -> [SKIP][110] ([i915#12655] / [i915#14544])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-mtlp: NOTRUN -> [SKIP][111] ([i915#3299])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@kms_content_protection@dp-mst-type-0:
- shard-tglu: NOTRUN -> [SKIP][112] ([i915#3116] / [i915#3299])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-tglu-1: NOTRUN -> [SKIP][113] ([i915#6944] / [i915#7116] / [i915#7118] / [i915#9424])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_content_protection@legacy@pipe-a-dp-3:
- shard-dg2: NOTRUN -> [FAIL][114] ([i915#7173])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-11/igt@kms_content_protection@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-128x42:
- shard-rkl: NOTRUN -> [FAIL][115] ([i915#13566]) +3 other tests fail
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-256x256:
- shard-rkl: [PASS][116] -> [SKIP][117] ([i915#14544]) +35 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#13049])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-tglu: NOTRUN -> [SKIP][119] ([i915#13049]) +1 other test skip
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-rapid-movement-512x170:
- shard-rkl: NOTRUN -> [SKIP][120] ([i915#13049])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
- shard-tglu-1: NOTRUN -> [SKIP][121] ([i915#13049])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-dg1: NOTRUN -> [SKIP][122] ([i915#13049]) +1 other test skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
- shard-dg2: NOTRUN -> [SKIP][123] ([i915#13046] / [i915#5354])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-dg1: NOTRUN -> [SKIP][124] +7 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-rkl: [PASS][125] -> [FAIL][126] ([i915#2346])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-2/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-tglu: NOTRUN -> [SKIP][127] ([i915#4103]) +1 other test skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_display_modes@extended-mode-basic:
- shard-tglu: NOTRUN -> [SKIP][128] ([i915#13691])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][129] ([i915#3804])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_dither@[email protected]
* igt@kms_dp_link_training@non-uhbr-mst:
- shard-dg1: NOTRUN -> [SKIP][130] ([i915#13749])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_dp_link_training@uhbr-mst:
- shard-dg2: NOTRUN -> [SKIP][131] ([i915#13748])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_dsc@dsc-fractional-bpp:
- shard-tglu: NOTRUN -> [SKIP][132] ([i915#3840])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-rkl: NOTRUN -> [SKIP][133] ([i915#3840])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_dsc@dsc-with-bpc:
- shard-tglu: NOTRUN -> [SKIP][134] ([i915#3555] / [i915#3840])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_feature_discovery@chamelium:
- shard-rkl: NOTRUN -> [SKIP][135] ([i915#14544] / [i915#4854])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_feature_discovery@display-3x:
- shard-rkl: NOTRUN -> [SKIP][136] ([i915#1839])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
- shard-tglu-1: NOTRUN -> [SKIP][137] ([i915#1839])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_feature_discovery@dp-mst:
- shard-tglu: NOTRUN -> [SKIP][138] ([i915#9337])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_feature_discovery@psr1:
- shard-tglu-1: NOTRUN -> [SKIP][139] ([i915#658])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_flip@2x-absolute-wf_vblank:
- shard-mtlp: NOTRUN -> [SKIP][140] ([i915#3637] / [i915#9934]) +1 other test skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_flip@2x-absolute-wf_vblank.html
* igt@kms_flip@2x-blocking-wf_vblank:
- shard-dg1: NOTRUN -> [SKIP][141] ([i915#9934])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@kms_flip@2x-blocking-wf_vblank.html
* igt@kms_flip@2x-flip-vs-dpms-on-nop:
- shard-tglu: NOTRUN -> [SKIP][142] ([i915#9934])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-fences:
- shard-tglu-1: NOTRUN -> [SKIP][143] ([i915#3637] / [i915#9934]) +1 other test skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-tglu: NOTRUN -> [SKIP][144] ([i915#3637] / [i915#9934]) +1 other test skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-rkl: NOTRUN -> [SKIP][145] ([i915#14544] / [i915#9934])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-rkl: NOTRUN -> [SKIP][146] ([i915#9934]) +1 other test skip
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_flip@2x-wf_vblank-ts-check.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-rkl: [PASS][147] -> [SKIP][148] ([i915#14544] / [i915#3637]) +6 other tests skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-glk: NOTRUN -> [INCOMPLETE][149] ([i915#12745] / [i915#4839])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-glk6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@a-hdmi-a1:
- shard-glk: NOTRUN -> [INCOMPLETE][150] ([i915#12745])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling:
- shard-tglu: NOTRUN -> [SKIP][151] ([i915#2672] / [i915#3555])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][152] ([i915#2587] / [i915#2672])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][153] ([i915#2672]) +4 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling:
- shard-rkl: [PASS][154] -> [SKIP][155] ([i915#14544] / [i915#3555]) +1 other test skip
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-upscaling:
- shard-rkl: NOTRUN -> [SKIP][156] ([i915#14544] / [i915#3555])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling:
- shard-dg2: NOTRUN -> [SKIP][157] ([i915#2672] / [i915#3555])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][158] ([i915#2672])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling:
- shard-rkl: NOTRUN -> [SKIP][159] ([i915#2672] / [i915#3555]) +2 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling:
- shard-mtlp: NOTRUN -> [SKIP][160] ([i915#2672] / [i915#3555] / [i915#8813])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][161] ([i915#2672] / [i915#8813])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-rkl: [PASS][162] -> [SKIP][163] ([i915#14544] / [i915#1849] / [i915#5354]) +6 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-blt:
- shard-mtlp: NOTRUN -> [SKIP][164] ([i915#1825]) +4 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
- shard-tglu: NOTRUN -> [SKIP][165] +45 other tests skip
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][166] ([i915#14544] / [i915#1849] / [i915#5354]) +5 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][167] ([i915#8708]) +2 other tests skip
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-rkl: NOTRUN -> [SKIP][168] ([i915#1825]) +12 other tests skip
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-tglu-1: NOTRUN -> [SKIP][169] +24 other tests skip
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][170] +2 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
- shard-dg1: NOTRUN -> [SKIP][171] ([i915#15102] / [i915#3458]) +3 other tests skip
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][172] ([i915#15102] / [i915#3458]) +3 other tests skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc:
- shard-tglu-1: NOTRUN -> [SKIP][173] ([i915#15102]) +11 other tests skip
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-indfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#15104])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-render:
- shard-rkl: NOTRUN -> [SKIP][175] ([i915#15102])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-offscreen-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][176] ([i915#8708]) +2 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-rkl: NOTRUN -> [SKIP][177] ([i915#15102] / [i915#3023]) +2 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-pgflip-blt:
- shard-dg2: NOTRUN -> [SKIP][178] ([i915#5354]) +2 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-tglu: NOTRUN -> [SKIP][179] ([i915#15102]) +15 other tests skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-dg2: [PASS][180] -> [SKIP][181] ([i915#3555] / [i915#8228])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-11/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-4/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-tglu-1: NOTRUN -> [SKIP][182] ([i915#3555] / [i915#8228]) +1 other test skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_hdr@invalid-hdr:
- shard-rkl: NOTRUN -> [SKIP][183] ([i915#3555] / [i915#8228])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_invalid_mode@bad-htotal:
- shard-rkl: [PASS][184] -> [SKIP][185] ([i915#14544] / [i915#3555] / [i915#8826]) +1 other test skip
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_joiner@basic-force-ultra-joiner:
- shard-dg1: NOTRUN -> [SKIP][186] ([i915#12394])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_joiner@invalid-modeset-big-joiner:
- shard-rkl: NOTRUN -> [SKIP][187] ([i915#10656])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@[email protected]
* igt@kms_joiner@invalid-modeset-force-big-joiner:
- shard-tglu: NOTRUN -> [SKIP][188] ([i915#12388])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_pipe_stress@stress-xrgb8888-4tiled:
- shard-tglu: NOTRUN -> [SKIP][189] ([i915#14712])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend:
- shard-rkl: NOTRUN -> [SKIP][190] ([i915#14544] / [i915#8825])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_alpha_blend@alpha-7efc:
- shard-rkl: [PASS][191] -> [SKIP][192] ([i915#14544] / [i915#7294])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_alpha_blend@alpha-transparent-fb:
- shard-snb: NOTRUN -> [SKIP][193] +4 other tests skip
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-snb5/igt@[email protected]
* igt@kms_plane_alpha_blend@constant-alpha-mid:
- shard-rkl: NOTRUN -> [SKIP][194] ([i915#14544] / [i915#7294])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_lowres@tiling-y:
- shard-mtlp: NOTRUN -> [SKIP][195] ([i915#3555] / [i915#8821])
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@kms_plane_lowres@tiling-yf:
- shard-rkl: NOTRUN -> [SKIP][196] ([i915#3555])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-x:
- shard-tglu: NOTRUN -> [SKIP][197] ([i915#13958])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_plane_multiple@tiling-4:
- shard-tglu: NOTRUN -> [SKIP][198] ([i915#14259])
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-c:
- shard-mtlp: NOTRUN -> [SKIP][199] ([i915#12247]) +4 other tests skip
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format:
- shard-rkl: [PASS][200] -> [SKIP][201] ([i915#14544] / [i915#8152]) +1 other test skip
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a:
- shard-tglu-1: NOTRUN -> [SKIP][202] ([i915#12247]) +4 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats:
- shard-rkl: [PASS][203] -> [SKIP][204] ([i915#14544] / [i915#3555] / [i915#8152])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-a:
- shard-rkl: [PASS][205] -> [SKIP][206] ([i915#12247] / [i915#14544]) +3 other tests skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_plane_scaling@[email protected]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d:
- shard-tglu: NOTRUN -> [SKIP][207] ([i915#12247]) +4 other tests skip
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75:
- shard-rkl: [PASS][208] -> [SKIP][209] ([i915#12247] / [i915#14544] / [i915#3555] / [i915#6953] / [i915#8152])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-75@pipe-b:
- shard-rkl: [PASS][210] -> [SKIP][211] ([i915#12247] / [i915#14544] / [i915#8152]) +3 other tests skip
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_plane_scaling@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_pm_backlight@bad-brightness:
- shard-tglu-1: NOTRUN -> [SKIP][212] ([i915#9812])
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_pm_backlight@brightness-with-dpms:
- shard-tglu: NOTRUN -> [SKIP][213] ([i915#12343])
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_pm_dc@dc6-dpms:
- shard-tglu: NOTRUN -> [FAIL][214] ([i915#9295])
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_pm_dc@dc9-dpms:
- shard-tglu-1: NOTRUN -> [SKIP][215] ([i915#4281])
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_pm_rpm@modeset-non-lpsp:
- shard-rkl: [PASS][216] -> [SKIP][217] ([i915#15073])
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-tglu: NOTRUN -> [SKIP][218] ([i915#15073])
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_pm_rpm@system-suspend-modeset:
- shard-dg1: [PASS][219] -> [DMESG-WARN][220] ([i915#4423])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-16/igt@[email protected]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-19/igt@[email protected]
* igt@kms_prime@basic-modeset-hybrid:
- shard-dg2: NOTRUN -> [SKIP][221] ([i915#6524] / [i915#6805])
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_prime@d3hot:
- shard-tglu-1: NOTRUN -> [SKIP][222] ([i915#6524])
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_psr2_sf@fbc-pr-plane-move-sf-dmg-area:
- shard-dg2: NOTRUN -> [SKIP][223] ([i915#11520])
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-exceed-fully-sf:
- shard-mtlp: NOTRUN -> [SKIP][224] ([i915#12316]) +1 other test skip
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-exceed-fully-sf@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][225] ([i915#9808])
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-exceed-fully-sf@pipe-a-edp-1.html
* igt@kms_psr2_sf@fbc-psr2-primary-plane-update-sf-dmg-area:
- shard-tglu: NOTRUN -> [SKIP][226] ([i915#11520]) +5 other tests skip
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_psr2_sf@pr-overlay-plane-move-continuous-sf:
- shard-dg1: NOTRUN -> [SKIP][227] ([i915#11520])
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf:
- shard-tglu-1: NOTRUN -> [SKIP][228] ([i915#11520]) +3 other tests skip
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_psr2_sf@pr-plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][229] ([i915#11520]) +5 other tests skip
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-glk1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-tglu: NOTRUN -> [SKIP][230] ([i915#9683])
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_psr2_su@page_flip-p010:
- shard-rkl: NOTRUN -> [SKIP][231] ([i915#14544] / [i915#9683])
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@fbc-psr-primary-blt@edp-1:
- shard-mtlp: NOTRUN -> [SKIP][232] ([i915#9688]) +4 other tests skip
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@kms_psr@[email protected]
* igt@kms_psr@fbc-psr-primary-render:
- shard-tglu-1: NOTRUN -> [SKIP][233] ([i915#9732]) +9 other tests skip
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_psr@fbc-psr2-primary-page-flip:
- shard-dg1: NOTRUN -> [SKIP][234] ([i915#1072] / [i915#9732]) +1 other test skip
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_psr@fbc-psr2-sprite-blt:
- shard-dg2: NOTRUN -> [SKIP][235] ([i915#1072] / [i915#9732]) +3 other tests skip
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_psr@fbc-psr2-sprite-render:
- shard-rkl: NOTRUN -> [SKIP][236] ([i915#1072] / [i915#14544] / [i915#9732]) +2 other tests skip
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr@psr2-primary-render:
- shard-tglu: NOTRUN -> [SKIP][237] ([i915#9732]) +13 other tests skip
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_psr@psr2-suspend:
- shard-rkl: NOTRUN -> [SKIP][238] ([i915#1072] / [i915#9732]) +4 other tests skip
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@[email protected]
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-dg1: NOTRUN -> [SKIP][239] ([i915#5289])
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglu-1: NOTRUN -> [SKIP][240] ([i915#5289])
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-tglu: NOTRUN -> [SKIP][241] ([i915#5289])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_scaling_modes@scaling-mode-center:
- shard-tglu-1: NOTRUN -> [SKIP][242] ([i915#3555]) +2 other tests skip
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_scaling_modes@scaling-mode-full:
- shard-tglu: NOTRUN -> [SKIP][243] ([i915#3555]) +2 other tests skip
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_sharpness_filter@filter-formats:
- shard-tglu-1: NOTRUN -> [SKIP][244] ([i915#15232]) +1 other test skip
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@[email protected]
* igt@kms_sharpness_filter@filter-modifiers:
- shard-mtlp: NOTRUN -> [SKIP][245] ([i915#15232])
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@kms_sharpness_filter@filter-toggle:
- shard-tglu: NOTRUN -> [SKIP][246] ([i915#15232])
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglu: NOTRUN -> [SKIP][247] ([i915#8623])
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_vrr@lobf:
- shard-tglu: NOTRUN -> [SKIP][248] ([i915#11920])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-tglu: NOTRUN -> [SKIP][249] ([i915#9906])
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@[email protected]
* igt@panthor/panthor_gem@bo_mmap_offset:
- shard-tglu: NOTRUN -> [SKIP][250] ([i915#2575]) +1 other test skip
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-8/igt@panthor/panthor_gem@bo_mmap_offset.html
* igt@panthor/panthor_vm@vm_bind:
- shard-rkl: NOTRUN -> [SKIP][251] ([i915#15265])
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@panthor/panthor_vm@vm_bind.html
* igt@panthor/panthor_vm@vm_create_destroy:
- shard-tglu-1: NOTRUN -> [SKIP][252] ([i915#2575])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@panthor/panthor_vm@vm_create_destroy.html
* igt@perf_pmu@rc6-all-gts:
- shard-dg1: NOTRUN -> [SKIP][253] ([i915#8516])
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@perf_pmu@rc6@other-idle-gt0:
- shard-tglu-1: NOTRUN -> [SKIP][254] ([i915#8516])
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-1/igt@perf_pmu@[email protected]
* igt@prime_vgem@basic-read:
- shard-mtlp: NOTRUN -> [SKIP][255] ([i915#3708])
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@prime_vgem@fence-write-hang:
- shard-dg1: NOTRUN -> [SKIP][256] ([i915#3708])
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@sriov_basic@bind-unbind-vf:
- shard-dg1: NOTRUN -> [SKIP][257] ([i915#9917])
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-13/igt@[email protected]
* igt@sriov_basic@enable-vfs-autoprobe-off:
- shard-rkl: NOTRUN -> [SKIP][258] ([i915#14544] / [i915#9917])
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@testdisplay:
- shard-rkl: NOTRUN -> [SKIP][259] ([i915#14544]) +10 other tests skip
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/[email protected]
#### Possible fixes ####
* igt@fbdev@unaligned-write:
- shard-rkl: [SKIP][260] ([i915#14544] / [i915#2582]) -> [PASS][261]
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-rkl: [DMESG-WARN][262] ([i915#12964]) -> [PASS][263] +9 other tests pass
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-rkl: [INCOMPLETE][264] ([i915#13356]) -> [PASS][265] +1 other test pass
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-5/igt@[email protected]
* igt@gem_mmap_offset@clear-via-pagefault:
- shard-mtlp: [ABORT][266] ([i915#14809]) -> [PASS][267] +1 other test pass
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-mtlp-6/igt@[email protected]
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-8/igt@[email protected]
* igt@gem_pxp@create-valid-protected-context:
- shard-rkl: [SKIP][268] ([i915#14544] / [i915#4270]) -> [PASS][269]
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-rkl: [TIMEOUT][270] ([i915#12917] / [i915#12964]) -> [PASS][271]
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-rkl: [ABORT][272] ([i915#15140]) -> [PASS][273]
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-4/igt@[email protected]
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-2/igt@[email protected]
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-dg2: [FAIL][274] ([i915#5956]) -> [PASS][275] +1 other test pass
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-3/igt@[email protected]
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-6/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-mtlp: [FAIL][276] ([i915#5138]) -> [PASS][277]
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-mtlp-7/igt@[email protected]
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-mtlp-6/igt@[email protected]
* igt@kms_color@ctm-negative:
- shard-rkl: [SKIP][278] ([i915#12655] / [i915#14544]) -> [PASS][279] +1 other test pass
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_dp_linktrain_fallback@dp-fallback:
- shard-dg2: [SKIP][280] ([i915#13707]) -> [PASS][281]
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-7/igt@[email protected]
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-11/igt@[email protected]
* igt@kms_flip@blocking-absolute-wf_vblank-interruptible:
- shard-rkl: [SKIP][282] ([i915#14544] / [i915#3637]) -> [PASS][283] +1 other test pass
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_flip@blocking-absolute-wf_vblank-interruptible.html
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_flip@blocking-absolute-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-rkl: [ABORT][284] ([i915#15132]) -> [PASS][285] +1 other test pass
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-4/igt@[email protected]
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-mmap-gtt:
- shard-rkl: [SKIP][286] ([i915#14544]) -> [PASS][287] +22 other tests pass
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-mmap-gtt.html
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-rkl: [SKIP][288] ([i915#14544] / [i915#1849] / [i915#5354]) -> [PASS][289] +1 other test pass
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-dg2: [ABORT][290] ([i915#15132]) -> [PASS][291]
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-10/igt@[email protected]
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- shard-snb: [SKIP][292] -> [PASS][293]
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-snb5/igt@[email protected]
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-snb1/igt@[email protected]
* igt@kms_invalid_mode@zero-vdisplay:
- shard-rkl: [SKIP][294] ([i915#14544] / [i915#3555] / [i915#8826]) -> [PASS][295] +1 other test pass
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- shard-dg1: [DMESG-WARN][296] ([i915#4423]) -> [PASS][297] +10 other tests pass
[296]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-12/igt@[email protected]
[297]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-14/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc:
- shard-rkl: [SKIP][298] ([i915#11190] / [i915#14544]) -> [PASS][299]
[298]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[299]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_plane@plane-position-hole-dpms:
- shard-rkl: [SKIP][300] ([i915#14544] / [i915#8825]) -> [PASS][301] +2 other tests pass
[300]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[301]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_plane_alpha_blend@alpha-opaque-fb:
- shard-rkl: [SKIP][302] ([i915#14544] / [i915#7294]) -> [PASS][303]
[302]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[303]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25:
- shard-rkl: [SKIP][304] ([i915#14544] / [i915#6953] / [i915#8152]) -> [PASS][305]
[304]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25.html
[305]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5:
- shard-rkl: [SKIP][306] ([i915#12247] / [i915#14544] / [i915#6953] / [i915#8152]) -> [PASS][307]
[306]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5.html
[307]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a:
- shard-rkl: [SKIP][308] ([i915#12247] / [i915#14544]) -> [PASS][309] +2 other tests pass
[308]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_plane_scaling@[email protected]
[309]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b:
- shard-rkl: [SKIP][310] ([i915#12247] / [i915#14544] / [i915#8152]) -> [PASS][311] +3 other tests pass
[310]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_plane_scaling@[email protected]
[311]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_plane_scaling@[email protected]
* igt@kms_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][312] ([i915#14544] / [i915#15073]) -> [PASS][313]
[312]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[313]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg2: [SKIP][314] ([i915#15073]) -> [PASS][315]
[314]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-10/igt@[email protected]
[315]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-4/igt@[email protected]
* igt@kms_universal_plane@cursor-fb-leak:
- shard-dg2: [FAIL][316] ([i915#9196]) -> [PASS][317]
[316]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-7/igt@[email protected]
[317]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-11/igt@[email protected]
* igt@kms_vrr@negative-basic:
- shard-dg2: [SKIP][318] ([i915#3555] / [i915#9906]) -> [PASS][319]
[318]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-7/igt@[email protected]
[319]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-11/igt@[email protected]
* igt@perf_pmu@busy-accuracy-98@rcs0:
- shard-rkl: [FAIL][320] ([i915#4349]) -> [PASS][321] +1 other test pass
[320]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@perf_pmu@[email protected]
[321]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-3/igt@perf_pmu@[email protected]
#### Warnings ####
* igt@api_intel_bb@object-reloc-purge-cache:
- shard-rkl: [SKIP][322] ([i915#14544] / [i915#8411]) -> [SKIP][323] ([i915#8411])
[322]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[323]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_bad_reloc@negative-reloc-lut:
- shard-rkl: [SKIP][324] ([i915#3281]) -> [SKIP][325] ([i915#14544] / [i915#3281]) +4 other tests skip
[324]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[325]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_ccs@block-multicopy-compressed:
- shard-rkl: [SKIP][326] ([i915#14544] / [i915#9323]) -> [SKIP][327] ([i915#9323]) +1 other test skip
[326]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[327]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_ctx_sseu@invalid-args:
- shard-rkl: [SKIP][328] ([i915#280]) -> [SKIP][329] ([i915#14544] / [i915#280])
[328]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[329]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_exec_balancer@parallel-balancer:
- shard-rkl: [SKIP][330] ([i915#4525]) -> [SKIP][331] ([i915#14544] / [i915#4525]) +1 other test skip
[330]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[331]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-rkl: [SKIP][332] ([i915#14544] / [i915#4525]) -> [SKIP][333] ([i915#4525])
[332]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[333]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_exec_reloc@basic-scanout:
- shard-rkl: [SKIP][334] ([i915#14544] / [i915#3281]) -> [SKIP][335] ([i915#3281]) +4 other tests skip
[334]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[335]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-rkl: [SKIP][336] ([i915#4613]) -> [SKIP][337] ([i915#14544] / [i915#4613]) +2 other tests skip
[336]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[337]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_lmem_swapping@random-engines:
- shard-rkl: [SKIP][338] ([i915#14544] / [i915#4613]) -> [SKIP][339] ([i915#4613])
[338]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[339]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gem_pread@bench:
- shard-rkl: [SKIP][340] ([i915#3282]) -> [SKIP][341] ([i915#14544] / [i915#3282]) +2 other tests skip
[340]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[341]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_pwrite_snooped:
- shard-rkl: [SKIP][342] ([i915#14544] / [i915#3282]) -> [SKIP][343] ([i915#3282]) +5 other tests skip
[342]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@gem_pwrite_snooped.html
[343]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@gem_pwrite_snooped.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-rkl: [SKIP][344] ([i915#3297] / [i915#3323]) -> [SKIP][345] ([i915#14544] / [i915#3297] / [i915#3323])
[344]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[345]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gem_userptr_blits@invalid-mmap-offset-unsync:
- shard-rkl: [SKIP][346] ([i915#14544] / [i915#3297]) -> [SKIP][347] ([i915#3297])
[346]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[347]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@gen9_exec_parse@bb-start-out:
- shard-rkl: [SKIP][348] ([i915#2527]) -> [SKIP][349] ([i915#14544] / [i915#2527]) +2 other tests skip
[348]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[349]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@gen9_exec_parse@unaligned-jump:
- shard-rkl: [SKIP][350] ([i915#14544] / [i915#2527]) -> [SKIP][351] ([i915#2527])
[350]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[351]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@i915_pm_freq_api@freq-suspend:
- shard-rkl: [SKIP][352] ([i915#14544] / [i915#8399]) -> [SKIP][353] ([i915#8399])
[352]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[353]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-rkl: [SKIP][354] ([i915#4387]) -> [SKIP][355] ([i915#14544] / [i915#4387])
[354]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[355]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@i915_query@hwconfig_table:
- shard-rkl: [SKIP][356] ([i915#14544] / [i915#6245]) -> [SKIP][357] ([i915#6245])
[356]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@i915_query@hwconfig_table.html
[357]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@i915_query@hwconfig_table.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-rkl: [SKIP][358] ([i915#1769] / [i915#3555]) -> [SKIP][359] ([i915#14544])
[358]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
[359]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-180:
- shard-rkl: [SKIP][360] ([i915#14544]) -> [SKIP][361] ([i915#5286]) +3 other tests skip
[360]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[361]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-rkl: [SKIP][362] ([i915#5286]) -> [SKIP][363] ([i915#14544]) +1 other test skip
[362]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[363]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-rkl: [SKIP][364] ([i915#14544]) -> [SKIP][365] ([i915#3638]) +2 other tests skip
[364]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[365]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-rkl: [SKIP][366] ([i915#3638]) -> [SKIP][367] ([i915#14544]) +4 other tests skip
[366]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[367]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-rkl: [SKIP][368] -> [SKIP][369] ([i915#14544]) +11 other tests skip
[368]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[369]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_ccs@bad-pixel-format-4-tiled-mtl-rc-ccs-cc:
- shard-rkl: [SKIP][370] ([i915#14544]) -> [SKIP][371] ([i915#14098] / [i915#6095]) +8 other tests skip
[370]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[371]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: [SKIP][372] ([i915#6095]) -> [SKIP][373] ([i915#14098] / [i915#6095]) +2 other tests skip
[372]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_ccs@[email protected]
[373]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-3/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-suspend-y-tiled-gen12-rc-ccs-cc:
- shard-rkl: [SKIP][374] ([i915#14544]) -> [ABORT][375] ([i915#15132])
[374]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[375]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-4/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-yf-tiled-ccs:
- shard-rkl: [SKIP][376] ([i915#14098] / [i915#6095]) -> [SKIP][377] ([i915#14544]) +6 other tests skip
[376]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[377]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs:
- shard-rkl: [SKIP][378] ([i915#12313]) -> [SKIP][379] ([i915#14544])
[378]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[379]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: [SKIP][380] ([i915#14098] / [i915#6095]) -> [SKIP][381] ([i915#6095]) +2 other tests skip
[380]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@kms_ccs@[email protected]
[381]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_ccs@[email protected]
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs:
- shard-dg1: [SKIP][382] ([i915#4423] / [i915#6095]) -> [SKIP][383] ([i915#6095]) +1 other test skip
[382]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-14/igt@[email protected]
[383]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-12/igt@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-single:
- shard-rkl: [SKIP][384] ([i915#11151] / [i915#14544] / [i915#7828]) -> [SKIP][385] ([i915#11151] / [i915#7828]) +4 other tests skip
[384]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[385]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_chamelium_hpd@vga-hpd-fast:
- shard-rkl: [SKIP][386] ([i915#11151] / [i915#7828]) -> [SKIP][387] ([i915#11151] / [i915#14544] / [i915#7828]) +6 other tests skip
[386]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[387]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-dg2: [SKIP][388] ([i915#7118] / [i915#9424]) -> [FAIL][389] ([i915#7173])
[388]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-7/igt@[email protected]
[389]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-11/igt@[email protected]
* igt@kms_content_protection@mei-interface:
- shard-rkl: [SKIP][390] ([i915#14544]) -> [SKIP][391] ([i915#9424])
[390]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[391]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_content_protection@type1:
- shard-rkl: [SKIP][392] ([i915#7118] / [i915#9424]) -> [SKIP][393] ([i915#14544]) +1 other test skip
[392]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[393]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-offscreen-32x10:
- shard-rkl: [SKIP][394] ([i915#14544]) -> [SKIP][395] ([i915#3555])
[394]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[395]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-256x85:
- shard-rkl: [FAIL][396] ([i915#13566]) -> [SKIP][397] ([i915#14544]) +1 other test skip
[396]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[397]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-rkl: [SKIP][398] ([i915#14544]) -> [SKIP][399] ([i915#13049]) +1 other test skip
[398]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[399]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_cursor_crc@cursor-rapid-movement-32x10:
- shard-rkl: [SKIP][400] ([i915#3555]) -> [SKIP][401] ([i915#14544]) +1 other test skip
[400]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[401]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-rkl: [SKIP][402] ([i915#14544]) -> [SKIP][403] +11 other tests skip
[402]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
[403]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-rkl: [SKIP][404] ([i915#4103]) -> [SKIP][405] ([i915#14544])
[404]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
[405]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-rkl: [SKIP][406] ([i915#9723]) -> [SKIP][407] ([i915#14544])
[406]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[407]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_dsc@dsc-basic:
- shard-rkl: [SKIP][408] ([i915#11190] / [i915#14544]) -> [SKIP][409] ([i915#3555] / [i915#3840])
[408]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[409]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_dsc@dsc-with-output-formats:
- shard-rkl: [SKIP][410] ([i915#3555] / [i915#3840]) -> [SKIP][411] ([i915#14544])
[410]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[411]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][412] ([i915#14544] / [i915#3955]) -> [SKIP][413] ([i915#3955])
[412]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[413]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-rkl: [SKIP][414] ([i915#14544] / [i915#9934]) -> [SKIP][415] ([i915#9934]) +7 other tests skip
[414]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[415]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_flip@2x-plain-flip:
- shard-rkl: [SKIP][416] ([i915#9934]) -> [SKIP][417] ([i915#14544] / [i915#9934]) +2 other tests skip
[416]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[417]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling:
- shard-rkl: [SKIP][418] ([i915#14544] / [i915#3555]) -> [SKIP][419] ([i915#2672] / [i915#3555]) +1 other test skip
[418]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling.html
[419]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling:
- shard-rkl: [SKIP][420] ([i915#2672] / [i915#3555]) -> [SKIP][421] ([i915#14544] / [i915#3555]) +3 other tests skip
[420]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling.html
[421]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-pwrite:
- shard-rkl: [DMESG-WARN][422] ([i915#12964]) -> [SKIP][423] ([i915#14544])
[422]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-pwrite.html
[423]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt:
- shard-rkl: [SKIP][424] -> [SKIP][425] ([i915#14544] / [i915#1849] / [i915#5354])
[424]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[425]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-dg1: [SKIP][426] ([i915#4423]) -> [SKIP][427] +2 other tests skip
[426]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-14/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
[427]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-12/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-indfb-draw-mmap-gtt:
- shard-rkl: [SKIP][428] ([i915#14544]) -> [SKIP][429] ([i915#15102]) +3 other tests skip
[428]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-indfb-draw-mmap-gtt.html
[429]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-shrfb-draw-mmap-gtt:
- shard-rkl: [SKIP][430] ([i915#15102]) -> [SKIP][431] ([i915#14544]) +1 other test skip
[430]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-shrfb-draw-mmap-gtt.html
[431]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-rkl: [SKIP][432] ([i915#14544] / [i915#1849] / [i915#5354]) -> [SKIP][433] ([i915#15102] / [i915#3023]) +6 other tests skip
[432]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html
[433]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-dg2: [SKIP][434] ([i915#15102] / [i915#3458]) -> [SKIP][435] ([i915#10433] / [i915#15102] / [i915#3458])
[434]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[435]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-cpu:
- shard-rkl: [SKIP][436] ([i915#1825]) -> [SKIP][437] ([i915#14544] / [i915#1849] / [i915#5354]) +21 other tests skip
[436]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
[437]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-blt:
- shard-rkl: [SKIP][438] ([i915#14544] / [i915#1849] / [i915#5354]) -> [SKIP][439] ([i915#1825]) +22 other tests skip
[438]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-blt.html
[439]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-dg1: [SKIP][440] ([i915#4423] / [i915#8708]) -> [SKIP][441] ([i915#8708]) +1 other test skip
[440]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-14/igt@[email protected]
[441]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-12/igt@[email protected]
* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-rkl: [SKIP][442] ([i915#9766]) -> [SKIP][443] ([i915#14544] / [i915#1849] / [i915#5354])
[442]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[443]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-dg1: [SKIP][444] ([i915#15102] / [i915#3458] / [i915#4423]) -> [SKIP][445] ([i915#15102] / [i915#3458])
[444]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-14/igt@[email protected]
[445]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-12/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-rkl: [SKIP][446] ([i915#15102] / [i915#3023]) -> [SKIP][447] ([i915#14544] / [i915#1849] / [i915#5354]) +8 other tests skip
[446]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
[447]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-rkl: [SKIP][448] ([i915#3555] / [i915#8228]) -> [SKIP][449] ([i915#14544]) +2 other tests skip
[448]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[449]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_hdr@brightness-with-hdr:
- shard-dg2: [SKIP][450] ([i915#13331]) -> [SKIP][451] ([i915#12713])
[450]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg2-10/igt@[email protected]
[451]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg2-5/igt@[email protected]
- shard-tglu: [SKIP][452] ([i915#1187] / [i915#12713]) -> [SKIP][453] ([i915#12713])
[452]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-tglu-2/igt@[email protected]
[453]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-tglu-5/igt@[email protected]
* igt@kms_hdr@invalid-metadata-sizes:
- shard-dg1: [SKIP][454] ([i915#3555] / [i915#8228]) -> [SKIP][455] ([i915#3555] / [i915#4423] / [i915#8228])
[454]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-12/igt@[email protected]
[455]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-15/igt@[email protected]
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][456] ([i915#1839] / [i915#4816]) -> [SKIP][457] ([i915#14544] / [i915#4070] / [i915#4816])
[456]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[457]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_panel_fitting@legacy:
- shard-rkl: [SKIP][458] ([i915#14544]) -> [SKIP][459] ([i915#6301])
[458]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[459]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-y:
- shard-rkl: [SKIP][460] ([i915#13958]) -> [SKIP][461] ([i915#14544]) +1 other test skip
[460]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[461]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_pm_dc@dc5-psr:
- shard-rkl: [SKIP][462] ([i915#9685]) -> [SKIP][463] ([i915#14544] / [i915#9685]) +1 other test skip
[462]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[463]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_pm_dc@dc6-dpms:
- shard-rkl: [FAIL][464] ([i915#9295]) -> [SKIP][465] ([i915#3361])
[464]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[465]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_pm_lpsp@kms-lpsp:
- shard-rkl: [SKIP][466] ([i915#3828]) -> [SKIP][467] ([i915#9340])
[466]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-4/igt@[email protected]
[467]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-3/igt@[email protected]
* igt@kms_pm_lpsp@screens-disabled:
- shard-rkl: [SKIP][468] ([i915#14544] / [i915#8430]) -> [SKIP][469] ([i915#8430])
[468]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[469]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-rkl: [SKIP][470] ([i915#15073]) -> [SKIP][471] ([i915#14544] / [i915#15073])
[470]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[471]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr2_sf@psr2-overlay-plane-update-continuous-sf:
- shard-rkl: [SKIP][472] ([i915#11520]) -> [SKIP][473] ([i915#11520] / [i915#14544]) +5 other tests skip
[472]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[473]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr2_sf@psr2-overlay-plane-update-sf-dmg-area:
- shard-rkl: [SKIP][474] ([i915#11520] / [i915#14544]) -> [SKIP][475] ([i915#11520]) +3 other tests skip
[474]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[475]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_psr2_sf@psr2-primary-plane-update-sf-dmg-area:
- shard-dg1: [SKIP][476] ([i915#11520] / [i915#4423]) -> [SKIP][477] ([i915#11520])
[476]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-dg1-17/igt@[email protected]
[477]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-dg1-12/igt@[email protected]
* igt@kms_psr@fbc-pr-primary-render:
- shard-rkl: [SKIP][478] ([i915#1072] / [i915#9732]) -> [SKIP][479] ([i915#1072] / [i915#14544] / [i915#9732]) +11 other tests skip
[478]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[479]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr@fbc-psr2-suspend:
- shard-rkl: [SKIP][480] ([i915#1072] / [i915#14544] / [i915#9732]) -> [SKIP][481] ([i915#1072] / [i915#9732]) +11 other tests skip
[480]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[481]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- shard-rkl: [SKIP][482] ([i915#3555]) -> [SKIP][483] ([i915#14544] / [i915#3555])
[482]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[483]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_setmode@invalid-clone-single-crtc-stealing:
- shard-rkl: [SKIP][484] ([i915#14544] / [i915#3555]) -> [SKIP][485] ([i915#3555])
[484]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[485]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_sharpness_filter@filter-rotations:
- shard-rkl: [SKIP][486] ([i915#14544]) -> [SKIP][487] ([i915#15232]) +1 other test skip
[486]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[487]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@kms_sharpness_filter@filter-suspend:
- shard-rkl: [SKIP][488] ([i915#15232]) -> [SKIP][489] ([i915#14544]) +1 other test skip
[488]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[489]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@ts-continuation-dpms-suspend:
- shard-rkl: [INCOMPLETE][490] ([i915#12276]) -> [SKIP][491] ([i915#14544])
[490]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[491]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_vrr@seamless-rr-switch-vrr:
- shard-rkl: [SKIP][492] ([i915#9906]) -> [SKIP][493] ([i915#14544])
[492]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[493]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-rkl: [SKIP][494] ([i915#2437]) -> [SKIP][495] ([i915#14544] / [i915#2437])
[494]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-2/igt@[email protected]
[495]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_writeback@writeback-fb-id-xrgb2101010:
- shard-rkl: [SKIP][496] ([i915#2437] / [i915#9412]) -> [SKIP][497] ([i915#14544] / [i915#2437] / [i915#9412])
[496]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-8/igt@[email protected]
[497]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-rkl: [SKIP][498] ([i915#14544] / [i915#2437]) -> [SKIP][499] ([i915#2437])
[498]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[499]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@panthor/panthor_gem@bo_create_round_size:
- shard-rkl: [SKIP][500] ([i915#14544] / [i915#15265]) -> [SKIP][501] ([i915#15265])
[500]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@panthor/panthor_gem@bo_create_round_size.html
[501]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@panthor/panthor_gem@bo_create_round_size.html
* igt@perf@per-context-mode-unprivileged:
- shard-rkl: [SKIP][502] ([i915#14544] / [i915#2435]) -> [SKIP][503] ([i915#2435])
[502]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[503]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
* igt@prime_vgem@fence-flip-hang:
- shard-rkl: [SKIP][504] ([i915#3708]) -> [SKIP][505] ([i915#14544] / [i915#3708])
[504]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-5/igt@[email protected]
[505]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-6/igt@[email protected]
* igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all:
- shard-rkl: [SKIP][506] ([i915#14544] / [i915#9917]) -> [SKIP][507] ([i915#9917])
[506]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17525/shard-rkl-6/igt@[email protected]
[507]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/shard-rkl-8/igt@[email protected]
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1099
[i915#11078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11078
[i915#11151]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11151
[i915#11190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11190
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#1187]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1187
[i915#11920]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11920
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12247]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12247
[i915#12276]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12276
[i915#12313]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12313
[i915#12316]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12316
[i915#12343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12343
[i915#12388]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12388
[i915#12394]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12394
[i915#12655]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12655
[i915#12713]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12713
[i915#12745]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12745
[i915#12796]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12796
[i915#12917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12917
[i915#12964]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12964
[i915#13046]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13046
[i915#13049]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13049
[i915#13331]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13331
[i915#13356]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13356
[i915#13398]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13398
[i915#13566]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13566
[i915#13691]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13691
[i915#13707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13707
[i915#13729]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13729
[i915#13748]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13748
[i915#13749]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13749
[i915#13781]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13781
[i915#13809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13809
[i915#13821]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13821
[i915#13958]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13958
[i915#14098]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14098
[i915#14259]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14259
[i915#14544]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14544
[i915#14702]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14702
[i915#14712]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14712
[i915#14809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14809
[i915#15073]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15073
[i915#15102]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15102
[i915#15104]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15104
[i915#15131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15131
[i915#15132]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15132
[i915#15140]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15140
[i915#15178]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15178
[i915#15232]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15232
[i915#15265]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15265
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3323
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
[i915#3828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3828
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#3955]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3955
[i915#4036]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4423
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
[i915#4817]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4817
[i915#4839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4839
[i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4885]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4885
[i915#5138]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5138
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5723
[i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6245
[i915#6301]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6335
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6805]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6805
[i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7276]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7276
[i915#7294]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7294
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7984]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7984
[i915#8152]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8152
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8399
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8562]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8562
[i915#8623]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8813]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8813
[i915#8821]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8821
[i915#8825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8825
[i915#8826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8826
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9295]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9295
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9337]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9337
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9531]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9531
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9766
[i915#9808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9808
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934
Build changes
-------------
* Linux: CI_DRM_17525 -> Patchwork_157331v1
CI-20190529: 20190529
CI_DRM_17525: a9792b1ab75123e4aceaba953a89809e745919c6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8617: 8617
Patchwork_157331v1: a9792b1ab75123e4aceaba953a89809e745919c6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_157331v1/index.html