drm/stm: ltdc: fix warning in ltdc_crtc_update_clut()
Subsystems (4)
PATCH 1/1 drm/stm: ltdc: fix warning in ltdc_crtc_update_clut()
Fix the warning
"warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks as ltdc_crtc_update_clut() is only called from ltdc_crtc_atomic_flush() where crtc and crtc->state are not NULL.
Many thanks to Dan Carpenter for the bug report
https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html
--- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-)
drivers/gpu/drm/stm/ltdc.c +0 -3
@@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc)u32 val;int i; -if (!crtc || !crtc->state) -return ; -if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)return ;
Signature · 6 lines
2.15.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 20 lines · Philippe Cornu
Fix the warning
"warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks asltdc_crtc_update_clut()is only called fromltdc_crtc_atomic_flush()where crtc andcrtc->stateare not NULL.Many thanks to Dan Carpenter for the bug report
https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.htmlSigned-off-by Philippe Cornu <[email protected]>Reported-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-)drivers/gpu/drm/stm/ltdc.c +0
-0
drivers/gpu/drm/stm/ltdc.c static void ltdc_crtc_update_clut(struct drm_crtc *crtc) · line 397
Quoted 9 lines
drivers/gpu/drm/stm/ltdc.c +0
-3@@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc)u32 val;int i; -if (!crtc || !crtc->state) -return ; -if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)return ;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Applied on drm-misc-next.
Many thanks,
Philippe :-)
Quoted 27 lines · Yannick FERTRE
Reviewed-by yannick fertre <[email protected]>Quoted 23 lines · Philippe Cornu
Fix the warning
"warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks asltdc_crtc_update_clut()is only called fromltdc_crtc_atomic_flush()where crtc andcrtc->stateare not NULL.Many thanks to Dan Carpenter for the bug report
https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.htmlSigned-off-by Philippe Cornu <[email protected]>Reported-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-)drivers/gpu/drm/stm/ltdc.c +0
-0@@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc)u32 val;int i;
Quoted 6 lines
drivers/gpu/drm/stm/ltdc.c static void ltdc_crtc_update_clut(struct drm_crtc *crtc) · line 397
Quoted 6 lines
drivers/gpu/drm/stm/ltdc.c +0
-3-if (!crtc || !crtc->state) -return ; -if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)return ;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel