Skip to contentSkip to conversation

drm/stm: ltdc: fix warning in ltdc_crtc_update_clut()

PATCH In review Philippe Cornu 2 participants 3 messages Apr 10, 2018 – Apr 19, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/stm: ltdc: fix warning in ltdc_crtc_update_clut()

Fix the warning
"warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks as ltdc_crtc_update_clut() is only called from ltdc_crtc_atomic_flush() where crtc and crtc->state are not NULL.

Many thanks to Dan Carpenter for the bug report
https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html

---
 drivers/gpu/drm/stm/ltdc.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/stm/ltdc.c +0 -3
index 061d2b6e5157..e3121d9e4230 100644
@@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc)
 	u32 val;
 	int i;
 
-	if (!crtc || !crtc->state)
-		return;
-
 	if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)
 		return;
 
Signature · 6 lines
2.15.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Philippe Cornu

Fix the warning
"warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks as ltdc_crtc_update_clut() is only called from ltdc_crtc_atomic_flush() where crtc and crtc->state are not NULL.

Many thanks to Dan Carpenter for the bug report
https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html

---
  drivers/gpu/drm/stm/ltdc.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/gpu/drm/stm/ltdc.c +0 -0
index 061d2b6e5157..e3121d9e4230 100644

drivers/gpu/drm/stm/ltdc.c static void ltdc_crtc_update_clut(struct drm_crtc *crtc) · line 397

Quoted 9 lines
drivers/gpu/drm/stm/ltdc.c +0 -3
@@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc)
  	u32 val;
  	int i;
 
-	if (!crtc || !crtc->state)
-		return;
-
  	if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)
  		return;
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

Applied on drm-misc-next.
Many thanks,
Philippe :-)

Quoted 27 lines · Yannick FERTRE
Quoted 23 lines · Philippe Cornu

Fix the warning
"warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks as ltdc_crtc_update_clut() is only called from ltdc_crtc_atomic_flush() where crtc and crtc->state are not NULL.

Many thanks to Dan Carpenter for the bug report
https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html

---
   drivers/gpu/drm/stm/ltdc.c | 3 ---
   1 file changed, 3 deletions(-)
drivers/gpu/drm/stm/ltdc.c +0 -0
index 061d2b6e5157..e3121d9e4230 100644
@@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc)
   	u32 val;
   	int i;
 
Quoted 6 lines

drivers/gpu/drm/stm/ltdc.c static void ltdc_crtc_update_clut(struct drm_crtc *crtc) · line 397

Quoted 6 lines
drivers/gpu/drm/stm/ltdc.c +0 -3
-	if (!crtc || !crtc->state)
-		return;
-
   	if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)
   		return;
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel