Skip to contentSkip to conversation

usb: musb-new: sunxi: remove unused define

PATCH Superseded Sam Edwards 2 participants 3 messages Jun 7, 2023 – Jun 8, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: musb-new: sunxi: remove unused define

---
 drivers/usb/musb-new/sunxi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/usb/musb-new/sunxi.c +0 -2
index 2b954601a0..85d815ad75 100644
@@ -81,8 +81,6 @@
  * From usbc/usbc.c
  ******************************************************************************/
 
-#define OFF_SUN6I_AHB_RESET0	0x2c0
-
 struct sunxi_musb_config {
 	struct musb_hdrc_config *config;
 	bool has_sram;
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Sam Edwards
---
  drivers/usb/musb-new/sunxi.c | 2 --
  1 file changed, 2 deletions(-)
drivers/usb/musb-new/sunxi.c +0 -0
index 2b954601a0..85d815ad75 100644

drivers/usb/musb-new/sunxi.c line 86

Quoted 8 lines
drivers/usb/musb-new/sunxi.c +0 -2
@@ -81,8 +81,6 @@
   * From usbc/usbc.c
   ******************************************************************************/
 
-#define OFF_SUN6I_AHB_RESET0	0x2c0
-
  struct sunxi_musb_config {
  	struct musb_hdrc_config *config;
  	bool has_sram;

Please add missing commit message and send V2.

Otherwise

#2 lore raw

Hi Marek,

Quoted 1 line

Please add missing commit message and send V2.

Ah, apologies! I had (mistakenly) believed that the summary line would be a sufficient commit message for something so trivial.

Instead I did a little research into how this got here and wrote a quick explanation of why it's unused. I figure that would be a bit more helpful for someone reading the commit history than just reiterating that "It's, y'know, unused." :)

Quoted 3 lines

Otherwise

Thank you for the speedy review!

Cheers,
Sam