usb: musb-new: sunxi: remove unused define
Subsystems (2)
PATCH 1/1 usb: musb-new: sunxi: remove unused define
Signed-off-by Sam Edwards <[email protected]>
--- drivers/usb/musb-new/sunxi.c | 2 -- 1 file changed, 2 deletions(-)
drivers/usb/musb-new/sunxi.c +0 -2
@@ -81,8 +81,6 @@* From usbc/usbc.c ******************************************************************************/ -#define OFF_SUN6I_AHB_RESET0 0x2c0 -struct sunxi_musb_config {struct musb_hdrc_config *config;bool has_sram;
Signature · 1 line
2.39.2
Quoted 10 lines · Sam Edwards
Signed-off-by Sam Edwards <[email protected]>--- drivers/usb/musb-new/sunxi.c | 2 -- 1 file changed, 2 deletions(-)drivers/usb/musb-new/sunxi.c +0
-0
drivers/usb/musb-new/sunxi.c line 86
Quoted 8 lines
drivers/usb/musb-new/sunxi.c +0
-2@@ -81,8 +81,6 @@* From usbc/usbc.c ******************************************************************************/ -#define OFF_SUN6I_AHB_RESET0 0x2c0 -struct sunxi_musb_config {struct musb_hdrc_config *config;bool has_sram;
Please add missing commit message and send V2.
Otherwise
Reviewed-by Marek Vasut <[email protected]>
Hi Marek,
Quoted 1 line
Please add missing commit message and send V2.
Ah, apologies! I had (mistakenly) believed that the summary line would be a sufficient commit message for something so trivial.
Instead I did a little research into how this got here and wrote a quick explanation of why it's unused. I figure that would be a bit more helpful for someone reading the commit history than just reiterating that "It's, y'know, unused." :)
Quoted 3 lines
Otherwise
Reviewed-by Marek Vasut <[email protected]>
Thank you for the speedy review!
Cheers,
Sam