Skip to contentSkip to conversation

include/global.h: missing struct on FreeBSD

PATCH In review [email protected] 2 participants 5 messages Jan 10, 2015 – Jan 11, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include/global.h: missing struct on FreeBSD

From: Rumko <[email protected]>

On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.

include/global.h +4 -0
index 16a26dc..70be1f9 100644
@@ -31,6 +31,10 @@
 /* for timeval and timespec */
 #include <time.h>
 
+#if defined(__FreeBSD__)
+#include <sys/timespec.h>
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif
Signature · 1 line
2.2.1
#1 lore raw

At Sat, 10 Jan 2015 11:04:59 +0100,

Quoted 8 lines · [email protected] wrote:

From: Rumko <[email protected]>

On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.

If you give your sign-off, please give the full real name.

thanks,

Takashi

Quoted 19 lines
include/global.h +4 -0
index 16a26dc..70be1f9 100644
@@ -31,6 +31,10 @@
 /* for timeval and timespec */
 #include <time.h>
 
+#if defined(__FreeBSD__)
+#include <sys/timespec.h>
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif
Signature · 1 line
2.2.1
author
#2 lore raw
Quoted 5 lines · On Sunday 11 January 2015 11:27:52 Takashi Iwai wrote:

At Sat, 10 Jan 2015 11:04:59 +0100,

Quoted 2 lines · [email protected] wrote:

From: Rumko <[email protected]>

Quoted 7 lines
Quoted 5 lines

On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.

If you give your sign-off, please give the full real name.

Sorry about that, was just following
http://www.alsa-project.org/main/index.php/GIT_Server#Occasional_Developers
It specifically adds the -s flag to format-patch as instructions for generating the patchset.

Should I resubmit without it?

Quoted 3 lines

thanks,

Takashi

Signature · 2 lines
Regards,
Rumko
#3 lore raw

At Sun, 11 Jan 2015 12:17:31 +0100,

Quoted 13 lines · Rumko
Quoted 11 lines · On Sunday 11 January 2015 11:27:52 Takashi Iwai wrote:

At Sat, 10 Jan 2015 11:04:59 +0100,

Quoted 7 lines · [email protected] wrote:

From: Rumko <[email protected]>

On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.

Quoted 8 lines
Quoted 1 line

If you give your sign-off, please give the full real name.

Sorry about that, was just following
http://www.alsa-project.org/main/index.php/GIT_Server#Occasional_Developers
It specifically adds the -s flag to format-patch as instructions for generating the patchset.

Should I resubmit without it?

We follow the policy of Linux kernel development for the user-space stuff in principle. See Documentation/SubmittingPatches of Linux driver tree, "Sign your work" section. You need to give the real name.

thanks,

Takashi

author
#4 lore raw

On Sunday 11 January 2015 16:57:39 Takashi Iwai wrote:
<snip>

Quoted 4 lines

We follow the policy of Linux kernel development for the user-space stuff in principle. See Documentation/SubmittingPatches of Linux driver tree, "Sign your work" section. You need to give the real name.

Ah, in that case, sorry to have bothered you. As far as I'm concerned, this thread can be closed.

Thank you

Quoted 3 lines

thanks,

Takashi

Signature · 2 lines
Regards,
Rumko