tools/testing/cxl: Remove cxl_test modulo math loading messages
[email protected]
maintainerPATCH 1/1 tools/testing/cxl: Remove cxl_test modulo math loading messages
From: Alison Schofield <[email protected]>
Commit "cxl/acpi: Support CXL XOR Interleave Math (CXIMS)" added a module parameter to cxl_test for the interleave_arithmetic option. In doing so, it also added this dev_dbg() message describing which option cxl_test used during load:
"[ 111.743246] (NULL device *): cxl_test loading modulo math option"
That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.
Remove the dev_dbg() messages and make the module_param readable via sysfs in case a lookup is wanted.
The default option is for standard modulo arithmetic, so when the interleave_arithmetic param is not present in sysfs, the cxl_test module is using standard modulo arithmetic.
--- tools/testing/cxl/test/cxl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/cxl/test/cxl.c +1 -3
@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)if (interleave_arithmetic ==1 ) { cfmws_start =CFMWS_XOR_ARRAY_START ; cfmws_end =CFMWS_XOR_ARRAY_END ; -dev_dbg (NULL ,"cxl_test loading xor math option\n" ); }else { cfmws_start =CFMWS_MOD_ARRAY_START ; cfmws_end =CFMWS_MOD_ARRAY_END ; -dev_dbg (NULL ,"cxl_test loading modulo math option\n" ); } rc =populate_cedt ();
@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)unregister_cxl_mock_ops (&cxl_mock_ops); } -module_param (interleave_arithmetic, int,0000 ); +module_param (interleave_arithmetic, int,0444 );MODULE_PARM_DESC (interleave_arithmetic,"Modulo:0, XOR:1" );module_init (cxl_test_init);module_exit (cxl_test_exit);
base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
Signature · 1 line
2.37.3
Quoted 11 lines · alison.schofield@ wrote:
From: Alison Schofield <[email protected]>
Commit "cxl/acpi: Support CXL XOR Interleave Math (CXIMS)" added a module parameter to
cxl_testfor theinterleave_arithmeticoption. In doing so, it also added thisdev_dbg()message describing which optioncxl_testused during load:
"[ 111.743246] (NULL device *):cxl_testloading modulo math option"That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.
Quoted 6 lines
Remove the
dev_dbg()messages and make themodule_paramreadable via sysfs in case a lookup is wanted.The default option is for standard modulo arithmetic, so when the
interleave_arithmeticparam is not present in sysfs, thecxl_testmodule is using standard modulo arithmetic.
Is this correct? I'm always unsure of myself with the module_param code but I believe the sysfs will always be there but the value would be "Modulo:0", wouldn't it?
Quoted 2 lines
Fixes f9db85bfec0d ("cxl/acpi: Support CXL XOR Interleave Math (CXIMS)")
I'm not sure this is the correct patch for the fixes.
Would it be?
Ira
Quoted 36 lines
Suggested-by Dan Williams <[email protected]>Signed-off-by Alison Schofield <[email protected]>--- tools/testing/cxl/test/cxl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)tools/testing/cxl/test/cxl.c +1
-3@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)if (interleave_arithmetic ==1 ) { cfmws_start =CFMWS_XOR_ARRAY_START ; cfmws_end =CFMWS_XOR_ARRAY_END ; -dev_dbg (NULL ,"cxl_test loading xor math option\n" ); }else { cfmws_start =CFMWS_MOD_ARRAY_START ; cfmws_end =CFMWS_MOD_ARRAY_END ; -dev_dbg (NULL ,"cxl_test loading modulo math option\n" ); } rc =populate_cedt ();@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)unregister_cxl_mock_ops (&cxl_mock_ops); } -module_param (interleave_arithmetic, int,0000 ); +module_param (interleave_arithmetic, int,0444 );MODULE_PARM_DESC (interleave_arithmetic,"Modulo:0, XOR:1" );module_init (cxl_test_init);module_exit (cxl_test_exit);base-commit:
589c3357370a596ef7c99c00baca8ac799fce531Signature · 1 line
2.37.3
Alison Schofield
maintainerQuoted 15 lines · Ira Weiny
Quoted 14 lines · alison.schofield@ wrote:
From: Alison Schofield <[email protected]>
Commit "cxl/acpi: Support CXL XOR Interleave Math (CXIMS)" added a module parameter to
cxl_testfor theinterleave_arithmeticoption. In doing so, it also added thisdev_dbg()message describing which optioncxl_testused during load:
"[ 111.743246] (NULL device *):cxl_testloading modulo math option"That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.
Remove the
dev_dbg()messages and make themodule_paramreadable via sysfs in case a lookup is wanted.
Quoted 8 lines
Quoted 3 lines
The default option is for standard modulo arithmetic, so when the
interleave_arithmeticparam is not present in sysfs, thecxl_testmodule is using standard modulo arithmetic.Is this correct? I'm always unsure of myself with the
module_paramcode but I believe the sysfs will always be there but the value would be "Modulo:0", wouldn't it?
You are right. I made that statement based on some trial/error, and I guess mostly error, because when I go back around to it now, it operates just like you say. Thanks!
Quoted 8 lines
Quoted 2 lines
Fixes f9db85bfec0d ("cxl/acpi: Support CXL XOR Interleave Math (CXIMS)")I'm not sure this is the correct patch for the fixes.
Would it be?
Fixes 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
Yes. Thanks Ira.
I'll rev this more carefully, and also update the commit msg. It should have said 'cxl_test module' not 'cxl_test modulo'.
Alison
Quoted 41 lines
Ira
Quoted 36 lines
Suggested-by Dan Williams <[email protected]>Signed-off-by Alison Schofield <[email protected]>--- tools/testing/cxl/test/cxl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)tools/testing/cxl/test/cxl.c +1
-3@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)if (interleave_arithmetic ==1 ) { cfmws_start =CFMWS_XOR_ARRAY_START ; cfmws_end =CFMWS_XOR_ARRAY_END ; -dev_dbg (NULL ,"cxl_test loading xor math option\n" ); }else { cfmws_start =CFMWS_MOD_ARRAY_START ; cfmws_end =CFMWS_MOD_ARRAY_END ; -dev_dbg (NULL ,"cxl_test loading modulo math option\n" ); } rc =populate_cedt ();@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)unregister_cxl_mock_ops (&cxl_mock_ops); } -module_param (interleave_arithmetic, int,0000 ); +module_param (interleave_arithmetic, int,0444 );MODULE_PARM_DESC (interleave_arithmetic,"Modulo:0, XOR:1" );module_init (cxl_test_init);module_exit (cxl_test_exit);base-commit:
589c3357370a596ef7c99c00baca8ac799fce531Signature · 1 line
2.37.3