MAINTAINERS: I don't want to review Renesas Ethernet Switch driver
Subsystems (2)
PATCH 1/1 MAINTAINERS: I don't want to review Renesas Ethernet Switch driver
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
---
The patch is against the 'main' branch of DaveM's 'net.git' repo...
MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)
MAINTAINERS +3 -0
@@ -18358,6 +18358,9 @@ L: [email protected] F: Documentation/devicetree/bindings/net/renesas,*.yaml F: drivers/net/ethernet/renesas/ F: include/linux/sh_eth.h +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* +X: drivers/net/ethernet/renesas/rswitch.* RENESAS IDT821034 ASoC CODEC M: Herve Codina <[email protected]>
Simon Horman
reviewer+ Shimoda-san
Quoted 4 lines · Sergey Shtylyov
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>
Hi Sergey,
I don't know the back story to this, if there is one. But could I suggest that:
1. The patch also updates the title MAINTAINERS section to cover the remaining two drivers.
e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS
Or alternatively, create separate sections for each driver.
n.b.: This may involve moving sections to maintain alphabetical order
by section title
2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
n.b.: It may still be a holiday period in Japan for the rest of the week.
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
Quoted 20 lines
---
The patch is against the 'main' branch of DaveM's 'net.git' repo...MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)Index: net/MAINTAINERS
===================================================================MAINTAINERS +3
-0@@ -18358,6 +18358,9 @@ L: [email protected] F: Documentation/devicetree/bindings/net/renesas,*.yaml F: drivers/net/ethernet/renesas/ F: include/linux/sh_eth.h +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* +X: drivers/net/ethernet/renesas/rswitch.* RENESAS IDT821034 ASoC CODEC M: Herve Codina <[email protected]>
On 1/4/24 12:28 AM, Simon Horman wrote:
[...]
Quoted 6 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Hi Sergey,
Hi Simon, long time, no see... :-)
Quoted 1 line
I don't know the back story to this, if there is one.
Not much of a history: I got a lot of the rswitch patches in my
inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work...
Quoted 9 lines
But could I suggest that:
1. The patch also updates the title
MAINTAINERSsection to cover the remaining two drivers.e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERSOr alternatively, create separate sections for each driver.
Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/Makefile though...
Quoted 8 lines
n.b.: This may involve moving sections to maintain alphabetical order
by section title2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
n.b.: It may still be a holiday period in Japan for the rest of the week.
It's a holiday period here in Russia as well, till the 8th of Jaunary. :-)
Quoted 2 lines
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
[...]
MBR, Sergey
Hello,
Thank you for adding CC to me.
Quoted 24 lines
From: Sergey Shtylyov, Sent: Friday, January 5, 2024 5:47 AM
On 1/4/24 12:28 AM, Simon Horman wrote:
[...]Quoted 6 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Hi Sergey,
Hi Simon, long time, no see... :-)
Quoted 1 line
I don't know the back story to this, if there is one.
Not much of a history: I got a lot of the rswitch patches in my
inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work...Quoted 5 lines
But could I suggest that:
1. The patch also updates the title
MAINTAINERSsection to cover the remaining two drivers.
Quoted 7 lines
Quoted 4 lines
e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERSOr alternatively, create separate sections for each driver.
Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/
Makefilethough...
How about adding "COMMON PARTS" section?
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and sh_eth
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in drivers/net/ethernet/renesas
- RENESAS ETHERNET SWITCH DRIVER : For rswitch
Quoted 6 lines
Quoted 6 lines
n.b.: This may involve moving sections to maintain alphabetical order
by section title2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. So, if my idea above is acceptable, perhaps the maintainers can be:
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda
- RENESAS ETHERNET SWITCH DRIVER : Shimoda
Quoted 3 lines
Quoted 1 line
n.b.: It may still be a holiday period in Japan for the rest of the week.
It's a holiday period here in Russia as well, till the 8th of Jaunary. :-)
I'm back from today, but next Monday (8th) is a holiday in Japan :)
Best regards,
Yoshihiro Shimoda
Quoted 6 lines
Quoted 2 lines
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
[...]
MBR, Sergey
Simon Horman
reviewerQuoted 3 lines · Yoshihiro Shimoda
Hello,
Thank you for adding CC to me.
Likewise, thanks for your response.
Quoted 27 lines
Quoted 27 lines
From: Sergey Shtylyov, Sent: Friday, January 5, 2024 5:47 AM
On 1/4/24 12:28 AM, Simon Horman wrote:
[...]Quoted 6 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Hi Sergey,
Hi Simon, long time, no see... :-)
Quoted 1 line
I don't know the back story to this, if there is one.
Not much of a history: I got a lot of the rswitch patches in my
inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work...Quoted 8 lines
But could I suggest that:
1. The patch also updates the title
MAINTAINERSsection to cover the remaining two drivers.e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Or alternatively, create separate sections for each driver.
Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/
Makefilethough...How about adding "COMMON PARTS" section?
I think that would be fine.
Quoted 1 line
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and
sh_eth
I think Sergey prefers two sections for the above. Perhaps:
- RENESAS ETHERNET AVB DRIVER
- RENESAS SUPERH ETHERNET DRIVER
Whoever drafts the patch, please be sure to maintain alphabetical order by section title.
Quoted 10 lines
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile in
drivers/net/ethernet/renesas
- RENESAS ETHERNET SWITCH DRIVER : For rswitchQuoted 6 lines
Quoted 6 lines
n.b.: This may involve moving sections to maintain alphabetical order
by section title2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
Quoted 6 lines
I'm happy if I'm a maintainer for Renesas Ethernet Switch driver. So, if my idea above is acceptable, perhaps the maintainers can be:
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda
- RENESAS ETHERNET SWITCH DRIVER : Shimoda
Modulo my comments above, this sounds reasonable to me.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
n.b.: It may still be a holiday period in Japan for the rest of the week.
It's a holiday period here in Russia as well, till the 8th of Jaunary. :-)
I'm back from today, but next Monday (8th) is a holiday in Japan :)
Enjoy.
Quoted 10 lines
Best regards,
Yoshihiro ShimodaQuoted 6 lines
Quoted 2 lines
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
[...]
MBR, Sergey
On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote:
[...]
Quoted 25 lines
Quoted 25 lines
Quoted 6 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Hi Sergey,
Hi Simon, long time, no see... :-)
Quoted 1 line
I don't know the back story to this, if there is one.
Not much of a history: I got a lot of the rswitch patches in my
inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work...Quoted 9 lines
But could I suggest that:
1. The patch also updates the title
MAINTAINERSsection to cover the remaining two drivers.e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERSOr alternatively, create separate sections for each driver.
Quoted 8 lines
Quoted 2 lines
Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/
Makefilethough...How about adding "COMMON PARTS" section?
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and
sh_eth
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile indrivers/net/ethernet/renesas
- RENESAS ETHERNET SWITCH DRIVER : For rswitch
No, this seems too much for these poor little couple files. :-)
Listing them in each new MAINTAINERS entry should achieve the same goal and seems a biut cleaner...
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
n.b.: This may involve moving sections to maintain alphabetical order
by section title2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
I'm happy if I'm a maintainer for Renesas Ethernet Switch driver.
Do you want to be a maintainer or just a reviewer (like me)?
Quoted 3 lines
So, if my idea above is acceptable, perhaps the maintainers can be:
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey
There will be separate entries for those...
Quoted 1 line
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda
I'd like to avoid that... :-)
Quoted 7 lines
- RENESAS ETHERNET SWITCH DRIVER : Shimoda
Quoted 3 lines
Quoted 1 line
n.b.: It may still be a holiday period in Japan for the rest of the week.
It's a holiday period here in Russia as well, till the 8th of Jaunary. :-)
I'm back from today, but next Monday (8th) is a holiday in Japan :)
You're back for 1 day? :-)
Quoted 5 lines
Best regards,
Yoshihiro ShimodaQuoted 2 lines
Quoted 2 lines
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
The question that remains still unaddressed: should I do the MAINTAINERS
"directory split" with a single patch?
[...]
MBR, Sergey
Simon Horman
reviewerQuoted 44 lines · Sergey Shtylyov
On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote:
[...]Quoted 25 lines
Quoted 25 lines
Quoted 6 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Hi Sergey,
Hi Simon, long time, no see... :-)
Quoted 1 line
I don't know the back story to this, if there is one.
Not much of a history: I got a lot of the rswitch patches in my
inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work...Quoted 9 lines
But could I suggest that:
1. The patch also updates the title
MAINTAINERSsection to cover the remaining two drivers.e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERSOr alternatively, create separate sections for each driver.
Quoted 8 lines
Quoted 2 lines
Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/
Makefilethough...How about adding "COMMON PARTS" section?
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and
sh_eth
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile indrivers/net/ethernet/renesas
- RENESAS ETHERNET SWITCH DRIVER : For rswitchNo, this seems too much for these poor little couple files. :-)
Listing them in each newMAINTAINERSentry should achieve the same goal and seems a biut cleaner...Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
n.b.: This may involve moving sections to maintain alphabetical order
by section title
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
I'm happy if I'm a maintainer for Renesas Ethernet Switch driver.
Do you want to be a maintainer or just a reviewer (like me)?
FWIIW, either option is fine by me.
Quoted 21 lines
Quoted 4 lines
So, if my idea above is acceptable, perhaps the maintainers can be:
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey
There will be separate entries for those...
Quoted 1 line
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda
I'd like to avoid that... :-)
Quoted 7 lines
- RENESAS ETHERNET SWITCH DRIVER : Shimoda
Quoted 3 lines
Quoted 1 line
n.b.: It may still be a holiday period in Japan for the rest of the week.
It's a holiday period here in Russia as well, till the 8th of Jaunary. :-)
I'm back from today, but next Monday (8th) is a holiday in Japan :)
You're back for 1 day? :-)
Quoted 8 lines
Quoted 5 lines
Best regards,
Yoshihiro ShimodaQuoted 2 lines
Quoted 2 lines
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
The question that remains still unaddressed: should I do the
MAINTAINERS
"directory split" with a single patch?
That seems easiest to me.
Quoted 4 lines
[...]
MBR, Sergey
Jakub Kicinski
maintainerQuoted 5 lines · On Fri, 5 Jan 2024 13:46:32 +0300 Sergey Shtylyov wrote:
Quoted 1 line
- RENESAS ETHERNET SWITCH DRIVER : For rswitch
No, this seems too much for these poor little couple files. :-)
Listing them in each newMAINTAINERSentry should achieve the same goal and seems a biut cleaner...
+1, FWIW, you can add them to both or neither. Series purely changing the Makefile / Kconfig are very rare.
Hello Jakub, Sergey,
Quoted 11 lines
From: Jakub Kicinski, Sent: Friday, January 5, 2024 11:14 PM
Quoted 5 lines · On Fri, 5 Jan 2024 13:46:32 +0300 Sergey Shtylyov wrote:
Quoted 1 line
- RENESAS ETHERNET SWITCH DRIVER : For rswitch
No, this seems too much for these poor little couple files. :-)
Listing them in each newMAINTAINERSentry should achieve the same goal and seems a biut cleaner...+1, FWIW, you can add them to both or neither. Series purely changing the
Makefile/Kconfigare very rare.
I see. It's a nice idea.
Best regards,
Yoshihiro Shimoda
Hi Sergey,
Quoted 35 lines
From: Sergey Shtylyov, Sent: Friday, January 5, 2024 7:47 PM
On 1/5/24 5:42 AM, Yoshihiro Shimoda wrote:
[...]Quoted 30 lines
Quoted 20 lines
Quoted 6 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Hi Sergey,
Hi Simon, long time, no see... :-)
Quoted 1 line
I don't know the back story to this, if there is one.
Not much of a history: I got a lot of the rswitch patches in my
inbox and I mostly ignored them... but kept deferring this patch due to a high load with fixing Svace's reports at work...Quoted 5 lines
But could I suggest that:
1. The patch also updates the title
MAINTAINERSsection to cover the remaining two drivers.Quoted 7 lines
Quoted 4 lines
e.g.: RENESAS ETHERNET DRIVERS ->
RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERSOr alternatively, create separate sections for each driver.
Yeah, this 2nd option seems cleaner. Still not sure about Kconfig/
Makefilethough...How about adding "COMMON PARTS" section?
Quoted 7 lines
Quoted 3 lines
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : For ravb and
sh_eth
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : For Kconfig/Makefile indrivers/net/ethernet/renesas
- RENESAS ETHERNET SWITCH DRIVER : For rswitchNo, this seems too much for these poor little couple files. :-)
Listing them in each newMAINTAINERSentry should achieve the same goal and seems a biut cleaner...
As I replied on other thread, I think Jakub's idea is good.
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
n.b.: This may involve moving sections to maintain alphabetical order
by section title2. Reaching out to Shimoda-san (CCed) or other relevant parties to see if an appropriate maintainer or maintainers for the Renesas Ethernet Switch driver can be found.
I'm happy if I'm a maintainer for Renesas Ethernet Switch driver.
Do you want to be a maintainer or just a reviewer (like me)?
I want just a reviewer.
Quoted 12 lines
Quoted 3 lines
So, if my idea above is acceptable, perhaps the maintainers can be:
- RENESAS ETHERNET AVB AND SUPERH ETHERNET DRIVERS : Sergey
There will be separate entries for those...
Quoted 1 line
- RENESAS ETHERNET DRIVERS (COMMON PARTS) : Sergey and Shimoda
I'd like to avoid that... :-)
Quoted 1 line
- RENESAS ETHERNET SWITCH DRIVER : Shimoda
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
n.b.: It may still be a holiday period in Japan for the rest of the week.
It's a holiday period here in Russia as well, till the 8th of Jaunary. :-)
I'm back from today, but next Monday (8th) is a holiday in Japan :)
You're back for 1 day? :-)
Yes :)
Quoted 8 lines
Quoted 5 lines
Best regards,
Yoshihiro ShimodaQuoted 2 lines
Quoted 2 lines
3. Rephrase the subject and patch description as splitting out maintenance of the Renesas Ethernet Switch driver .
The question that remains still unaddressed: should I do the
MAINTAINERS
"directory split" with a single patch?
As Simon-san mentioned, a single patch is easy, I think.
Best regards,
Yoshihiro Shimoda
Quoted 3 lines
[...]
MBR, Sergey
Jakub Kicinski
maintainerQuoted 10 lines · On Wed, 3 Jan 2024 23:56:15 +0300 Sergey Shtylyov wrote:
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>Index: net/MAINTAINERS
===================================================================
MAINTAINERS L: [email protected] · line 18363
Quoted 6 lines
MAINTAINERS +3
-0@@ -18358,6 +18358,9 @@ L: [email protected] F: Documentation/devicetree/bindings/net/renesas,*.yaml F: drivers/net/ethernet/renesas/ F: include/linux/sh_eth.h +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* +X: drivers/net/ethernet/renesas/rswitch.*
First off, very nice to see a refinement of MAINTAINERS to narrow down the scope and make it more precise. Thanks for doing that.
The solution itself is not very idiomatic, however :( IIUC you want to support SuperH and the AVB implementation. It'd be more usual to make the entry cover only the relevant files. And for bonus points perhaps add an entry covering the switch files, mark that entry as Orphan?
Hi,
a quick two cents from my side.
Quoted 2 lines
First off, very nice to see a refinement of
MAINTAINERSto narrow down the scope and make it more precise. Thanks for doing that.
Ack.
Quoted 2 lines
IIUC you want to support SuperH and the AVB implementation. It'd be more usual to make the entry cover only the relevant files.
Ack again.
Quoted 2 lines
And for bonus points perhaps add an entry covering the switch files, mark that entry as Orphan?
I think Shimoda-san will happily maintain the rswitch driver. He is likely away this week, though. So, my suggestion would be to wait with this discussion another week so he can take part in it?
All the best,
Wolfram
On 1/4/24 12:37 AM, Jakub Kicinski wrote:
[...]
Quoted 5 lines
Quoted 4 lines
I don't know this hardware, I don't have the manuals for it, so I can't provide a good review. Let's exclude the Ethernet Switch related files.
Signed-off-by Sergey Shtylyov <[email protected]>
Quoted 14 lines
MAINTAINERS L: [email protected] · line 18363
Quoted 11 lines
Index: net/MAINTAINERS
===================================================================MAINTAINERS +3
-0@@ -18358,6 +18358,9 @@ L: [email protected] F: Documentation/devicetree/bindings/net/renesas,*.yaml F: drivers/net/ethernet/renesas/ F: include/linux/sh_eth.h +X: Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml +X: drivers/net/ethernet/renesas/rcar_gen4_ptp.* +X: drivers/net/ethernet/renesas/rswitch.*First off, very nice to see a refinement of
MAINTAINERSto narrow down the scope and make it more precise. Thanks for doing that.
It's long overdue. I've got a lot of the rswitch patches in my inbox
which I mostly ignored. Unfortunately, I've been loaded with fixing the Svace (static analyzer) reports for about 2 years now...
Quoted 3 lines
The solution itself is not very idiomatic, however :( IIUC you want to support SuperH and the AVB implementation. It'd be more usual to make the entry cover only the relevant files.
Yeah, figured that out fianally... but still not sure what should
I do with Kconfig and Makefile...
Quoted 2 lines
And for bonus points perhaps add an entry covering the switch files, mark that entry as Orphan?
Will try to loop in Shimoda-san first -- maybe he'd be brave enough
to step in... :-)
MBR, Sergey