Fix non-portable grep usage
PATCH 1/1 Fix non-portable grep usage
# HG changeset patch
# User [email protected]
# Date 1194905356 28800
# Node ID 695e38fa5029bafc9ee9fc08dc4fe3cbec5a7489 # Parent 8b787636c4ac1b0e303c86ed489d91a63626a17e Fix non-portable grep usage
grep -q doesn't exist on the default Solaris grep.
tools/firmware/rombios/32bit/Makefile +1 -1
@@ -34,7 +34,7 @@ clean: $(TARGET): subdirs 32bitbios.o util.o $(LD) $(LDFLAGS_DIRECT) -s -r 32bitbios.o $(MODULES) util.o -o 32bitbios_all.o @nm 32bitbios_all.o | \ - grep -E -q '^ +U ' && { \ + egrep '^ +U ' 2>/dev/null && { \ echo "There are undefined symbols in the BIOS:"; \ nm -u 32bitbios_all.o; \ exit 11; \
[email protected] writes ("[Xen-devel] [PATCH] Fix non-portable grep usage"):
tools/firmware/rombios/32bit/Makefile clean: · line 37
Quoted 2 lines
tools/firmware/rombios/32bit/Makefile +1
-1- grep -E -q '^ +U ' && { \ + egrep '^ +U ' 2>/dev/null && { \
-q suppresses stdout output, not stderr. So I think you mean:
+ egrep '^ +U ' >/dev/null && { \
Ian.
Quoted 6 lines · Ian Jackson
[email protected] writes ("[Xen-devel] [PATCH] Fix non-portable grep usage"):
tools/firmware/rombios/32bit/Makefile clean: · line 37
Quoted 2 lines
tools/firmware/rombios/32bit/Makefile +1
-1- grep -E -q '^ +U ' && { \ + egrep '^ +U ' 2>/dev/null && { \-q suppresses stdout output, not stderr. So I think you mean:
+ egrep '^ +U ' >/dev/null && { \
Right, thanks (I didn't see any output, obviously, so missed this)
regards
john