Exclude certain ns16550 functions from NAND_SPL builds
PATCH 1/1 Exclude certain ns16550 functions from NAND_SPL builds
This patch will exclude all functions from drivers/serial/ns16550.c from NAND_SPL builds with exception of NS16550_putc and NS16550_init. This will save space and remove unused code from already tightly constrained bootstrap images for NAND_SPL builds.
--- drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/serial/ns16550.c +4 -1
@@ -39,6 +39,7 @@ void NS16550_init (NS16550_t com_port, int baud_divisor)#endif } +#ifndef CONFIG_NAND_SPL void NS16550_reinit (NS16550_t com_port,int baud_divisor) { com_port->ier =0x00 ;
@@ -53,6 +54,7 @@ void NS16550_reinit (NS16550_t com_port, int baud_divisor) com_port->dlm = (baud_divisor >>8 ) &0xff ; com_port->lcr = LCRVAL; } +#endif /* CONFIG_NAND_SPL */ void NS16550_putc (NS16550_t com_port,char c) {
@@ -60,6 +62,7 @@ void NS16550_putc (NS16550_t com_port, char c) com_port->thr = c; } +#ifndef CONFIG_NAND_SPL char NS16550_getc (NS16550_t com_port) {while ((com_port->lsr &LSR_DR ) ==0 ) {
@@ -75,5 +78,5 @@ int NS16550_tstc (NS16550_t com_port) {return ((com_port->lsr &LSR_DR ) !=0 ); } - +#endif /* CONFIG_NAND_SPL */ #endif
Signature · 1 line
1.5.5.1
PATCH 1/1 Exclude certain ns16550 functions from NAND_SPL builds
Dear Ron Madrid,
Quoted 9 lines · In message <[email protected]> you…
This patch will exclude all functions from
drivers/serial/ns16550.cfromNAND_SPLbuilds with exception ofNS16550_putcandNS16550_init. This will save space and remove unused code from already tightly constrained bootstrap images forNAND_SPLbuilds.Signed-off-by Ron Madrid <[email protected]>--- drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
This is a global file, so maybe we could use a less specific #define than CONFIG_NAND_SPL for this? Eventually we need this later to boot from device FOO, and I don't want to see this grow into
if !defined(CONFIG_NAND_SPL) && !defined(CONFIG_FOO) && !defined(CONFIG_BAR) && ...
Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de People with narrow minds usually have broad tongues.
PATCH 1/1 Exclude certain ns16550 functions from NAND_SPL builds
Quoted 30 lines · Wolfgang Denk
From: Wolfgang Denk <[email protected]>
Subject: Re: [U-Boot] [PATCH] Exclude certain ns16550 functions fromNAND_SPLbuilds
To: "Ron Madrid" <[email protected]>
Cc: u-boot at lists.denx.de
Date: Thursday, January 29, 2009, 2:24 AM
Dear Ron Madrid,In message <[email protected]>
Quoted 1 line · you
This patch will exclude all functions from
drivers/serial/ns16550.cfromQuoted 1 line
NAND_SPLbuilds with exception ofNS16550_putcand
NS16550_init. This will saveQuoted 1 line
space and remove unused code from already tightly
constrained bootstrap images
Quoted 3 lines
for
NAND_SPLbuilds.Signed-off-by Ron MadridQuoted 3 lines
--- drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)This is a global file, so maybe we could use a less specific #define
thanCONFIG_NAND_SPLfor this? Eventually we need this later to boot
from device FOO, and I don't want to see this grow into
Quoted 3 lines
if !defined(CONFIG_NAND_SPL) &&
!defined(CONFIG_FOO) && !defined(CONFIG_BAR)
&& ...
I understand your concern. I am not sure what other #define would work. Are you suggesting the creation of a new #define such as #define CONFIG_NS16550_BASIC_OPS or something like that which can be put into the board specific config files?
Ron
PATCH 1/1 Exclude certain ns16550 functions from NAND_SPL builds
Dear Ron Madrid,
Quoted 5 lines · In message <[email protected]> you wrote:
I understand your concern. I am not sure what other #define would work. Are you suggesting the creation of a new #define such as #define
CONFIG_NS16550_BASIC_OPSor something like that which can be put into the board specific config files?
Yes. The name should make clear that this is a minimal configuration only, i. e. something that restricts the recular functions.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There's no future in time travel.