Skip to contentSkip to conversation

ALSA: hda/realtek: fix bad indentation for alc269

PATCH Applied Lei Huang 3 participants 3 messages Mar 31 – Apr 1 Sound

lore
Share & tools
lore

Lei Huang

author
#0 lore raw

PATCH v2 1/1 ALSA: hda/realtek: fix bad indentation for alc269

From: Lei Huang <[email protected]>

Mention complains about this coding style:

ERROR: code indent should use tabs where possible #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

fix it up.

Fixes 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")
---
 sound/hda/codecs/realtek/alc269.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
sound/hda/codecs/realtek/alc269.c +4 -4
index b6a58852752a..09af4d378b30 100644
@@ -6637,10 +6637,10 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc288_fixup_surface_swap_dacs,
 	},
-        [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
-                .type = HDA_FIXUP_FUNC,
-                .v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
-        },
+	[ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
+	},
 	[ALC245_FIXUP_BASS_HP_DAC] = {
 		.type = HDA_FIXUP_FUNC,
 		/* Borrow the DAC routing selected for those Thinkpads */
Signature · 1 line
2.25.1
Applied
#1 lore raw
Quoted 5 lines · Lei Huang

From: Lei Huang <[email protected]>

Mention complains about this coding style:

Quoted 8 lines

ERROR: code indent should use tabs where possible #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

fix it up.

Fixes 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")

Applied to for-next branch now. Thanks.

Takashi

#2 lore raw
In reply to Lei Huang
Quoted 11 lines · Lei Huang

From: Lei Huang <[email protected]>

Mention complains about this coding style:

ERROR: code indent should use tabs where possible #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

fix it up.

Fixes 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")

Really, no. This is not a bug, otherwise explain user observable problem here.

Best regards,
Krzysztof