Skip to contentSkip to conversation

mmc: sdhci-esdhc-imx: improve ESDHC_FLAG_ERR010450

PATCH In review Giulio Benetti 4 participants 9 messages Aug 11, 2023 – Aug 18, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci-esdhc-imx: improve ESDHC_FLAG_ERR010450

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Cc Jim Reinhart <[email protected]>
Cc James Autry <[email protected]>
Cc Matthew Maron <[email protected]>
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +4 -3
index eebf94604a7f..cddecc1e1ac2 100644
@@ -171,8 +171,8 @@
 #define ESDHC_FLAG_HS400		BIT(9)
 /*
  * The IP has errata ERR010450
- * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't
- * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
+ * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card
+ * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
  */
 #define ESDHC_FLAG_ERR010450		BIT(10)
 /* The IP supports HS400ES mode */
@@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,
 		| ESDHC_CLOCK_MASK);
 	sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
 
-	if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) {
+	if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) &&
+	    (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) {
 		unsigned int max_clock;
 
 		max_clock = imx_data->is_ddr ? 45000000 : 150000000;
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw
Quoted 9 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Cc Jim Reinhart <[email protected]>
Cc James Autry <[email protected]>
Cc Matthew Maron <[email protected]>

Haibo Chen, can we get an Acked-by from you?

Quoted 20 lines
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +2 -2
index eebf94604a7f..cddecc1e1ac2 100644
@@ -171,8 +171,8 @@
 #define ESDHC_FLAG_HS400		BIT(9)
 /*
  * The IP has errata ERR010450
- * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't
- * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
+ * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card
+ * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
  */
 #define ESDHC_FLAG_ERR010450		BIT(10)
 /* The IP supports HS400ES mode */

drivers/mmc/host/sdhci-esdhc-imx.c static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, · line 968

Quoted 9 lines
drivers/mmc/host/sdhci-esdhc-imx.c +2 -1
@@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,
 		| ESDHC_CLOCK_MASK);
 	sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
 
-	if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) {
+	if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) &&
+	    (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) {
 		unsigned int max_clock;
 
 		max_clock = imx_data->is_ddr ? 45000000 : 150000000;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Acked-by
#2 lore raw
Quoted 19 lines

-----Original Message-----
From: Adrian Hunter <[email protected]>
Sent: 2023年8月15日 20:08
To: Giulio Benetti <[email protected]>; Bough Chen <[email protected]>; Ulf Hansson <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Fabio Estevam <[email protected]>; dl-linux-imx <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>; [email protected]; [email protected]; [email protected]; Jim Reinhart <[email protected]>; James Autry <[email protected]>; Matthew Maron <[email protected]>
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: improve ESDHC_FLAG_ERR010450

Quoted 3 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the

frequency.

Quoted 1 line
Quoted 7 lines
Quoted 5 lines

Sponsored by: Tekvox Inc.

Cc Jim Reinhart <[email protected]>
Cc James Autry <[email protected]>
Cc Matthew Maron <[email protected]>

Haibo Chen, can we get an Acked-by from you?

Sorry for the delay, I just forget this mail.

I just double check the Errata doc, yes, the limitation is only for 1.8v I/O timing. So

Thanks
Best Regards
Haibo Chen.

Quoted 28 lines
Quoted 15 lines
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +0 -1
index eebf94604a7f..cddecc1e1ac2 100644
@@ -171,8 +171,8 @@
 #define ESDHC_FLAG_HS400		BIT(9)
 /*
  * The IP has errata ERR010450
- * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock
Quoted 4 lines

can't
- * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
+ * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card
+ * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed

45MHz.

drivers/mmc/host/sdhci-esdhc-imx.c static inline void esdhc_pltfm_set_clock(struct

Quoted 4 lines

*/
#define ESDHC_FLAG_ERR010450 BIT(10)
/* The IP supports HS400ES mode */

drivers/mmc/host/sdhci-esdhc-imx.c +0 -0
@@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct

sdhci_host *host,

Quoted 3 lines
drivers/mmc/host/sdhci-esdhc-imx.c +0 -0
 		| ESDHC_CLOCK_MASK);
 	sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
 
Quoted 6 lines

drivers/mmc/host/sdhci-esdhc-imx.c static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, · line 968

Quoted 6 lines
drivers/mmc/host/sdhci-esdhc-imx.c +2 -1
-	if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) {
+	if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) &&
+	    (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) {
 		unsigned int max_clock;
 
 		max_clock = imx_data->is_ddr ? 45000000 : 150000000;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Giulio Benetti
Quoted 9 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Cc Jim Reinhart <[email protected]>
Cc James Autry <[email protected]>
Cc Matthew Maron <[email protected]>
Quoted 20 lines
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +2 -2
index eebf94604a7f..cddecc1e1ac2 100644
@@ -171,8 +171,8 @@
 #define ESDHC_FLAG_HS400		BIT(9)
 /*
  * The IP has errata ERR010450
- * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't
- * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
+ * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card
+ * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
  */
 #define ESDHC_FLAG_ERR010450		BIT(10)
 /* The IP supports HS400ES mode */

drivers/mmc/host/sdhci-esdhc-imx.c static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, · line 968

Quoted 9 lines
drivers/mmc/host/sdhci-esdhc-imx.c +2 -1
@@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,
 		| ESDHC_CLOCK_MASK);
 	sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
 
-	if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) {
+	if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) &&
+	    (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) {
 		unsigned int max_clock;
 
 		max_clock = imx_data->is_ddr ? 45000000 : 150000000;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
In reply to Giulio Benetti
Quoted 6 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Didn't know we have this kind of tag. Can you point me to the documentation of it?

Quoted 4 lines
Cc Jim Reinhart <[email protected]>
Cc James Autry <[email protected]>
Cc Matthew Maron <[email protected]>

Kind regards
Uffe

Quoted 30 lines
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +4 -4
index eebf94604a7f..cddecc1e1ac2 100644
@@ -171,8 +171,8 @@
 #define ESDHC_FLAG_HS400               BIT(9)
 /*
  * The IP has errata ERR010450
- * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't
- * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
+ * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card
+ * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
  */
 #define ESDHC_FLAG_ERR010450           BIT(10)
 /* The IP supports HS400ES mode */
@@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,
                | ESDHC_CLOCK_MASK);
        sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
 
-       if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) {
+       if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) &&
+           (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) {
                unsigned int max_clock;
 
                max_clock = imx_data->is_ddr ? 45000000 : 150000000;
--
Quoted 2 lines

2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

Hello Ulf, and All,

+Cc Andrew Lunn,

Quoted 11 lines · Ulf Hansson
Quoted 6 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Didn't know we have this kind of tag. Can you point me to the documentation of it?

I've been pointed by Andew Lunn almost the same question here:
https://lore.kernel.org/lkml/[email protected]/t/

and also asked to update:
Documentation/process/submitting-patches.rst

I've taken inspiration by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=73c289bac05919286f8c7e1660fcaf6ec0468363

where there is "Sponsored by:" and not "Sponsored-by:" otherwise checkpatch.pl script complains about it.

Other commits already have that sort of tag.

I could add Sponsored-by tag documentation and in checkpatch.pl script as well as other possible scripts where required as pointed by Andrew.

I think this is a good way to give credits to companies that sponsor patches and it could be more interesting for companies in general to pay someone to upstream patches because they have their name on it. Otherwise it's not an everyday task to add a driver from scratch and write in the top comment that is sponsored by some company. Also now there is SPDX so that part would be dropped too.

What do you All think about this? Do I go for a RFC patchset to add the Sponsored-by: tag?

Best regards

Signature · 2 lines
Giulio Benetti
CEO&CTO@Benetti Engineering sas
Quoted 36 lines
Quoted 4 lines
Cc Jim Reinhart <[email protected]>
Cc James Autry <[email protected]>
Cc Matthew Maron <[email protected]>

Kind regards
Uffe

Quoted 28 lines
---
  drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +4 -3
index eebf94604a7f..cddecc1e1ac2 100644
@@ -171,8 +171,8 @@
  #define ESDHC_FLAG_HS400               BIT(9)
  /*
   * The IP has errata ERR010450
- * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't
- * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
+ * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card
+ * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz.
   */
  #define ESDHC_FLAG_ERR010450           BIT(10)
  /* The IP supports HS400ES mode */
@@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host,
                 | ESDHC_CLOCK_MASK);
         sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL);
 
-       if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) {
+       if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) &&
+           (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) {
                 unsigned int max_clock;
 
Quoted 4 lines
Quoted 4 lines
drivers/mmc/host/sdhci-esdhc-imx.c +0 -1
                 max_clock = imx_data->is_ddr ? 45000000 : 150000000;
--

2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw
Quoted 24 lines · Giulio Benetti

Hello Ulf, and All,

+Cc Andrew Lunn,

Quoted 11 lines · Ulf Hansson
Quoted 6 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Didn't know we have this kind of tag. Can you point me to the documentation of it?

I've been pointed by Andew Lunn almost the same question here:
https://lore.kernel.org/lkml/[email protected]/t/

and also asked to update:
Documentation/process/submitting-patches.rst

Quoted 7 lines

I've taken inspiration by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=73c289bac05919286f8c7e1660fcaf6ec0468363

where there is "Sponsored by:" and not "Sponsored-by:" otherwise checkpatch.pl script complains about it.

Other commits already have that sort of tag.

Yes, but that seems silly to me.

We should not be using tags in this way. First there needs to be an agreement of what kind of tags we should allow in the commit messages, before we start using them.

Quoted 11 lines

I could add Sponsored-by tag documentation and in checkpatch.pl script as well as other possible scripts where required as pointed by Andrew.

I think this is a good way to give credits to companies that sponsor patches and it could be more interesting for companies in general to pay someone to upstream patches because they have their name on it. Otherwise it's not an everyday task to add a driver from scratch and write in the top comment that is sponsored by some company. Also now there is SPDX so that part would be dropped too.

Quoted 2 lines

What do you All think about this? Do I go for a RFC patchset to add the Sponsored-by: tag?

My opinion is just one voice here, so at this point it doesn't really matter what I think.

If *you* think this is a good idea, I encourage you to submit an RFC to the kernel docs for this. In this way we can collect the comments and see if people think this is a good idea.

That said, do you want me to apply $subject patch without the tag or would you rather proceed with submitting an RFC first?

[...]

Kind regards
Uffe

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw

Hello Ulf,

Quoted 54 lines · Ulf Hansson
Quoted 24 lines · Giulio Benetti

Hello Ulf, and All,

+Cc Andrew Lunn,

Quoted 11 lines · Ulf Hansson
Quoted 6 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Didn't know we have this kind of tag. Can you point me to the documentation of it?

I've been pointed by Andew Lunn almost the same question here:
https://lore.kernel.org/lkml/[email protected]/t/

and also asked to update:
Documentation/process/submitting-patches.rst

Quoted 7 lines

I've taken inspiration by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=73c289bac05919286f8c7e1660fcaf6ec0468363

where there is "Sponsored by:" and not "Sponsored-by:" otherwise checkpatch.pl script complains about it.

Other commits already have that sort of tag.

Yes, but that seems silly to me.

We should not be using tags in this way. First there needs to be an agreement of what kind of tags we should allow in the commit messages, before we start using them.

Quoted 11 lines

I could add Sponsored-by tag documentation and in checkpatch.pl script as well as other possible scripts where required as pointed by Andrew.

I think this is a good way to give credits to companies that sponsor patches and it could be more interesting for companies in general to pay someone to upstream patches because they have their name on it. Otherwise it's not an everyday task to add a driver from scratch and write in the top comment that is sponsored by some company. Also now there is SPDX so that part would be dropped too.

Quoted 2 lines

What do you All think about this? Do I go for a RFC patchset to add the Sponsored-by: tag?

Quoted 6 lines

My opinion is just one voice here, so at this point it doesn't really matter what I think.

If *you* think this is a good idea, I encourage you to submit an RFC to the kernel docs for this. In this way we can collect the comments and see if people think this is a good idea.

Ok, I will go with a RFC soon,

Quoted 2 lines

That said, do you want me to apply $subject patch without the tag or would you rather proceed with submitting an RFC first?

It would be great if you can apply the patch without the tag please.

Thank you
Best regards

Signature · 2 lines
Giulio Benetti
CEO&CTO@Benetti Engineering sas
#8 lore raw
Quoted 65 lines · Giulio Benetti

Hello Ulf,

Quoted 54 lines · Ulf Hansson
Quoted 24 lines · Giulio Benetti

Hello Ulf, and All,

+Cc Andrew Lunn,

Quoted 11 lines · Ulf Hansson
Quoted 6 lines · Giulio Benetti

Errata ERR010450 only shows up if voltage is 1.8V, but if the device is supplied by 3v3 the errata can be ignored. So let's check for if quirk SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency.

Sponsored by: Tekvox Inc.

Didn't know we have this kind of tag. Can you point me to the documentation of it?

I've been pointed by Andew Lunn almost the same question here:
https://lore.kernel.org/lkml/[email protected]/t/

and also asked to update:
Documentation/process/submitting-patches.rst

Quoted 7 lines

I've taken inspiration by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=73c289bac05919286f8c7e1660fcaf6ec0468363

where there is "Sponsored by:" and not "Sponsored-by:" otherwise checkpatch.pl script complains about it.

Other commits already have that sort of tag.

Yes, but that seems silly to me.

We should not be using tags in this way. First there needs to be an agreement of what kind of tags we should allow in the commit messages, before we start using them.

Quoted 11 lines

I could add Sponsored-by tag documentation and in checkpatch.pl script as well as other possible scripts where required as pointed by Andrew.

I think this is a good way to give credits to companies that sponsor patches and it could be more interesting for companies in general to pay someone to upstream patches because they have their name on it. Otherwise it's not an everyday task to add a driver from scratch and write in the top comment that is sponsored by some company. Also now there is SPDX so that part would be dropped too.

Quoted 2 lines

What do you All think about this? Do I go for a RFC patchset to add the Sponsored-by: tag?

Quoted 6 lines

My opinion is just one voice here, so at this point it doesn't really matter what I think.

If *you* think this is a good idea, I encourage you to submit an RFC to the kernel docs for this. In this way we can collect the comments and see if people think this is a good idea.

Quoted 6 lines

Ok, I will go with a RFC soon,

Quoted 2 lines

That said, do you want me to apply $subject patch without the tag or would you rather proceed with submitting an RFC first?

It would be great if you can apply the patch without the tag please.

Patch applied for next, thanks!

Kind regards
Uffe