ARM: dts: add Kobo Clara 2E
Subsystems (3)
v2 cover ARM: dts: add Kobo Clara 2E
Add a basic device tree for the Kobo Clara 2E Ebook reader. It is equipped with an i.MX6SLL SoC. EPDC PMIC drivers are not ready for mainline yet.
Changes in V2:
- improved commit message about devices without binding
Andreas Kemnade (3):
dt-bindings: arm: fsl: add compatible strings for Kobo Clara 2E
ARM: dts: imx: Add devicetree for Kobo Clara 2E
ARM: imx_v6_v7_defconfig: Enable drivers for Kobo Clara 2E
.../devicetree/bindings/arm/fsl.yaml | 8 + arch/arm/boot/dts/nxp/imx/Makefile | 2 + .../dts/nxp/imx/imx6sll-kobo-clara2e-a.dts | 23 + .../dts/nxp/imx/imx6sll-kobo-clara2e-b.dts | 23 + .../nxp/imx/imx6sll-kobo-clara2e-common.dtsi | 514 ++++++++++++++++++ arch/arm/configs/imx_v6_v7_defconfig | 2 + 6 files changed, 572 insertions(+) create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dts create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi
Signature · 1 line
2.39.5
PATCH v2 1/3 dt-bindings: arm: fsl: add compatible strings for Kobo Clara 2E
Adds compatible strings for the Kobo Clara 2E eBook reader. There are two variants differing in the EPD PMIC used.
--- Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +8 -0
@@ -620,6 +620,14 @@ properties: - kobo,librah2o - const: fsl,imx6sll + - description: i.MX6SLL Kobo Clara 2e Rev. A/B + items: + - enum: + - kobo,clara2e-a + - kobo,clara2e-b + - const: kobo,clara2e + - const: fsl,imx6sll + - description: i.MX6SX based Boards items: - enum:
Signature · 1 line
2.39.5
PATCH v2 2/3 ARM: dts: imx: Add devicetree for Kobo Clara 2E
In reply to Andreas KemnadeAdds a devicetree for the Kobo Clara 2E Ebook reader. It is based on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is equipped with an i.MX6SLL SoC.
Expected to work:
- Buttons
- Wifi
- Bluetooth
(if Wifi is initialized first, driver does not handle regulators
yet)
- LED
- uSD
- USB
- RTC
- Touchscreen
Add human-readable comments for devices without mainlined driver and binding. Such comments can e.g. be help to find testers if someone starts to work on the missing drivers.
--- arch/arm/boot/dts/nxp/imx/Makefile | 2 + .../dts/nxp/imx/imx6sll-kobo-clara2e-a.dts | 23 + .../dts/nxp/imx/imx6sll-kobo-clara2e-b.dts | 23 + .../nxp/imx/imx6sll-kobo-clara2e-common.dtsi | 514 ++++++++++++++++++ 4 files changed, 562 insertions(+) create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dts create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi
arch/arm/boot/dts/nxp/imx/Makefile +2 -0
@@ -290,6 +290,8 @@ dtb-$(CONFIG_SOC_IMX6SL) += \ dtb-$(CONFIG_SOC_IMX6SLL) += \ imx6sll-evk.dtb \ imx6sll-kobo-clarahd.dtb \ + imx6sll-kobo-clara2e-a.dtb \ + imx6sll-kobo-clara2e-b.dtb \ imx6sll-kobo-librah2o.dtb dtb-$(CONFIG_SOC_IMX6SX) += \ imx6sx-nitrogen6sx.dtb \
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts new file +23 -0
@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0) +/* + * Device tree for the Kobo Clara 2E rev A ebook reader + * + * Name on mainboard is: 37NB-E60K2M+4A2 + * Serials start with: E60K2M (a number also seen in + * vendor kernel sources) + * + * Copyright 2024 Andreas Kemnade + */ + +/dts-v1/; + +#include "imx6sll-kobo-clara2e-common.dtsi" + +/ { + model = "Kobo Clara 2E"; + compatible = "kobo,clara2e-b", "kobo,clara2e", "fsl,imx6sll"; +}; + +&i2c2 { + /* EPD PMIC SY7636 at 0x62 */ +};
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dts new file +23 -0
@@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0) +/* + * Device tree for the Kobo Clara 2E rev B ebook reader + * + * Name on mainboard is: 37NB-E60K2M+4B0 + * Serials start with: E60K2M (a number also seen in + * vendor kernel sources) + * + * Copyright 2024 Andreas Kemnade + */ + +/dts-v1/; + +#include "imx6sll-kobo-clara2e-common.dtsi" + +/ { + model = "Kobo Clara 2E"; + compatible = "kobo,clara2e-b", "kobo,clara2e", "fsl,imx6sll"; +}; + +&i2c2 { + /* EPD PMIC JD9930 at 0x18 */ +};
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +514 -0
514 lines not on this page · raw message
Signature · 1 line
2.39.5
Re: [PATCH v2 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E
Quoted 17 lines · Andreas Kemnade
Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is equipped with an i.MX6SLL SoC.
Expected to work:
- Buttons
- Wifi
- Bluetooth
(if Wifi is initialized first, driver does not handle regulators
yet)
- LED
- uSD
- USB
- RTC
- Touchscreen
Quoted 3 lines
Add human-readable comments for devices without mainlined driver and binding. Such comments can e.g. be help to find testers if someone starts to work on the missing drivers.
In case me not responding would case this to get delayed or w/e, thanks for adding that.
Re: [PATCH v2 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E
In reply to Andreas KemnadeQuoted 21 lines · Andreas Kemnade
Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is equipped with an i.MX6SLL SoC.
Expected to work:
- Buttons
- Wifi
- Bluetooth
(if Wifi is initialized first, driver does not handle regulators
yet)
- LED
- uSD
- USB
- RTC
- TouchscreenAdd human-readable comments for devices without mainlined driver and binding. Such comments can e.g. be help to find testers if someone starts to work on the missing drivers.
Signed-off-by Andreas Kemnade <[email protected]>
...
Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +10
-0+ + pmic@4b { + compatible = "rohm,bd71879", "rohm,bd71828"; + reg = <0x4b>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_bd71828>; + + interrupt-parent = <&gpio4>; + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; + system-power-controller;
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi line 138
Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +10
-0+ + clocks = <&clks 0>; + #clock-cells = <0>; + clock-output-names = "bd71828-32k-out"; + + gpio-controller; + #gpio-cells = <2>; + gpio-reserved-ranges = <0 1>, <2 1>; + + rohm,charger-sense-resistor-ohms = <30000000>;
I am afraid that this one is _my_ very much terrible brainfart. Yeah, pile up the stones and start casting ;)
I am fairly sure the sense resistor is 30 mOhm (0,030 Ohm), not 30 MOhm (30 000 000 Ohm). (And I am the one who misinterpreted the M in some email/data-sheet in the past - and never questioned the sanity).
In short, AFAICS the sense resistor is added "in series" to the system load. Eg:
--------
---| Rsense |-----
| -------- |
--------- -------
| VSupply | | Rload |
--------- -------
| |
------------------Hence, by measuring the voltage drop on the Rsense gives us the current flowing through the system ( good old U = RI ).
I believe having 30 Mohm (30 000 000 Ohm) resistor there would not make much of sense... With a Fermi estimate that the system works with voltage magnitude of 1V and current magnitude of 1A and then applying good old P = UI and U = RI would give us wonderful results :) Quite a battery on poor Kobo, right? You'd better to not touch the battery termninals ;) Oh, and looking the driver code I've written for handling this property... Sometimes I really don't like mirrors :)
Well, now that I got this out - I suppose this could be rohm,charger-sense-resistor-milli-ohms = <30>; or
rohm,charger-sense-resistor-micro-ohms = <30000>;
I further guess there is no upstreamn binding doc for this property. I think there is also no upstream charger driver for the BD71828/BD71879 - only an early RFC and some downstream mess - but stil it'd be nice to have the property in place as the size of the sense resistor is needed when converting coulomb counter register values to current.
Yours,
-- Matti
Re: [PATCH v2 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E
Am Tue, 29 Oct 2024 09:53:33 +0200
schrieb Matti Vaittinen <[email protected]>:
Quoted 40 lines · Andreas Kemnade
Quoted 21 lines
Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is equipped with an i.MX6SLL SoC.
Expected to work:
- Buttons
- Wifi
- Bluetooth
(if Wifi is initialized first, driver does not handle
regulators yet)
- LED
- uSD
- USB
- RTC
- TouchscreenAdd human-readable comments for devices without mainlined driver and binding. Such comments can e.g. be help to find testers if someone starts to work on the missing drivers.
Signed-off-by Andreas Kemnade <[email protected]>...
Quoted 15 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +15
-0+ + pmic@4b { + compatible = "rohm,bd71879", "rohm,bd71828"; + reg = <0x4b>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_bd71828>; + + interrupt-parent = <&gpio4>; + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; + system-power-controller; + + clocks = <&clks 0>; + #clock-cells = <0>; + clock-output-names = "bd71828-32k-out"; +
Quoted 9 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi line 138
Quoted 5 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +5
-0+ gpio-controller; + #gpio-cells = <2>; + gpio-reserved-ranges = <0 1>, <2 1>; + + rohm,charger-sense-resistor-ohms = <30000000>;I am afraid that this one is _my_ very much terrible brainfart. Yeah, pile up the stones and start casting ;)
... at everyone who had looked at this and did not question it ;-)
Quoted 4 lines
I am fairly sure the sense resistor is 30 mOhm (0,030 Ohm), not 30 MOhm (30 000 000 Ohm). (And I am the one who misinterpreted the M in some email/data-sheet in the past - and never questioned the sanity).
Well, I did question it, but then thought, ok there might be some current mirror to scale things down so that the massive rsense might make sense. Well, no schematics here.
Quoted 12 lines
In short, AFAICS the sense resistor is added "in series" to the system load. Eg:
-------- ---| Rsense |----- | -------- | --------- ------- | VSupply | | Rload | --------- ------- | | ------------------
Quoted 3 lines
Hence, by measuring the voltage drop on the Rsense gives us the current flowing through the system ( good old U = RI ).
Yes, that is the way I did know how these things are usually done. So I am still on track.
Quoted 9 lines
I believe having 30 Mohm (30 000 000 Ohm) resistor there would not make much of sense... With a Fermi estimate that the system works with voltage magnitude of 1V and current magnitude of 1A and then applying good old P = UI and U = RI would give us wonderful results :) Quite a battery on poor Kobo, right? You'd better to not touch the battery termninals ;) Oh, and looking the driver code I've written for handling this property... Sometimes I really don't like mirrors :)
Quoted 6 lines
Well, now that I got this out - I suppose this could be rohm,charger-sense-resistor-milli-ohms = <30>; or
rohm,charger-sense-resistor-micro-ohms = <30000>;I further guess there is no upstreamn binding doc for this property.
The binding doc is upstream. So an impressive amount of maintainers had a look at it...
Well, everyone seem to entrust Rohm Semiconductors to do magic... wonderful reputation.
So how to proceed? As this property is not required, I can simply remove it and add a comment.
Quoted 6 lines
I think there is also no upstream charger driver for the BD71828/BD71879 - only an early RFC and some downstream mess - but stil it'd be nice to have the property in place as the size of the sense resistor is needed when converting coulomb counter register values to current.
What are you upstreaming plans here? For all:
I rebased the charger stuff to v6.11 on
https://github.com/akemnade/linux branch kobo/power-6.11
Regards,
Andreas
Re: [PATCH v2 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E
In reply to Matti VaittinenAm Tue, 29 Oct 2024 09:53:33 +0200
schrieb Matti Vaittinen <[email protected]>:
Quoted 40 lines · Andreas Kemnade
Quoted 21 lines
Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is equipped with an i.MX6SLL SoC.
Expected to work:
- Buttons
- Wifi
- Bluetooth
(if Wifi is initialized first, driver does not handle
regulators yet)
- LED
- uSD
- USB
- RTC
- TouchscreenAdd human-readable comments for devices without mainlined driver and binding. Such comments can e.g. be help to find testers if someone starts to work on the missing drivers.
Signed-off-by Andreas Kemnade <[email protected]>...
Quoted 15 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +15
-0+ + pmic@4b { + compatible = "rohm,bd71879", "rohm,bd71828"; + reg = <0x4b>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_bd71828>; + + interrupt-parent = <&gpio4>; + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; + system-power-controller; + + clocks = <&clks 0>; + #clock-cells = <0>; + clock-output-names = "bd71828-32k-out"; +
Quoted 9 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi line 138
Quoted 5 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +5
-0+ gpio-controller; + #gpio-cells = <2>; + gpio-reserved-ranges = <0 1>, <2 1>; + + rohm,charger-sense-resistor-ohms = <30000000>;I am afraid that this one is _my_ very much terrible brainfart. Yeah, pile up the stones and start casting ;)
... at everyone who had looked at this and did not question it ;-)
Quoted 4 lines
I am fairly sure the sense resistor is 30 mOhm (0,030 Ohm), not 30 MOhm (30 000 000 Ohm). (And I am the one who misinterpreted the M in some email/data-sheet in the past - and never questioned the sanity).
Well, I did question it, but then thought, ok there might be some current mirror to scale things down so that the massive rsense might make sense. Well, no schematics here.
Quoted 12 lines
In short, AFAICS the sense resistor is added "in series" to the system load. Eg:
-------- ---| Rsense |----- | -------- | --------- ------- | VSupply | | Rload | --------- ------- | | ------------------
Quoted 3 lines
Hence, by measuring the voltage drop on the Rsense gives us the current flowing through the system ( good old U = RI ).
Yes, that is the way I did know how these things are usually done. So I am still on track.
Quoted 9 lines
I believe having 30 Mohm (30 000 000 Ohm) resistor there would not make much of sense... With a Fermi estimate that the system works with voltage magnitude of 1V and current magnitude of 1A and then applying good old P = UI and U = RI would give us wonderful results :) Quite a battery on poor Kobo, right? You'd better to not touch the battery termninals ;) Oh, and looking the driver code I've written for handling this property... Sometimes I really don't like mirrors :)
Quoted 6 lines
Well, now that I got this out - I suppose this could be rohm,charger-sense-resistor-milli-ohms = <30>; or
rohm,charger-sense-resistor-micro-ohms = <30000>;I further guess there is no upstreamn binding doc for this property.
The binding doc is upstream. So an impressive amount of maintainers had a look at it...
Well, everyone seem to entrust Rohm Semiconductors to do magic... wonderful reputation.
So how to proceed? As this property is not required, I can simply remove it and add a comment.
Quoted 6 lines
I think there is also no upstream charger driver for the BD71828/BD71879 - only an early RFC and some downstream mess - but stil it'd be nice to have the property in place as the size of the sense resistor is needed when converting coulomb counter register values to current.
What are you upstreaming plans here? For all:
I rebased the charger stuff to v6.11 on
https://github.com/akemnade/linux branch kobo/power-6.11
Regards,
Andreas
Re: [PATCH v2 2/3] ARM: dts: imx: Add devicetree for Kobo Clara 2E
Quoted 54 lines · Andreas Kemnade
Am Tue, 29 Oct 2024 09:53:33 +0200
schrieb Matti Vaittinen <[email protected]>:Quoted 51 lines · Andreas Kemnade
Quoted 21 lines
Adds a devicetree for the Kobo Clara 2E Ebook reader. It is based on boards marked with "37NB-E60K2M+4A2" or "37NB-E60K2M+4B0". It is equipped with an i.MX6SLL SoC.
Expected to work:
- Buttons
- Wifi
- Bluetooth
(if Wifi is initialized first, driver does not handle
regulators yet)
- LED
- uSD
- USB
- RTC
- TouchscreenAdd human-readable comments for devices without mainlined driver and binding. Such comments can e.g. be help to find testers if someone starts to work on the missing drivers.
Signed-off-by Andreas Kemnade <[email protected]>...
Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +10
-0+ + pmic@4b { + compatible = "rohm,bd71879", "rohm,bd71828"; + reg = <0x4b>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_bd71828>; + + interrupt-parent = <&gpio4>; + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; + system-power-controller;arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi line 138
Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi new file +10
-0+ + clocks = <&clks 0>; + #clock-cells = <0>; + clock-output-names = "bd71828-32k-out"; + + gpio-controller; + #gpio-cells = <2>; + gpio-reserved-ranges = <0 1>, <2 1>; + + rohm,charger-sense-resistor-ohms = <30000000>;Well, now that I got this out - I suppose this could be rohm,charger-sense-resistor-milli-ohms = <30>; or
rohm,charger-sense-resistor-micro-ohms = <30000>;
Quoted 4 lines
Quoted 1 line
I further guess there is no upstreamn binding doc for this property.
The binding doc is upstream. So an impressive amount of maintainers had a look at it...
Oh. So I have upstreamed it at some point... I suppose there is no users though.
Quoted 2 lines
Well, everyone seem to entrust Rohm Semiconductors to do magic... wonderful reputation.
:)
Quoted 2 lines
So how to proceed? As this property is not required, I can simply remove it and add a comment.
I would like to suggest adding:
rohm,charger-sense-resistor-milli-ohms = <30>;
and a binding with minimum 1 and maximum 50. Those should be sane enough limits. At the same time the 'rohm,charger-sense-resistor-ohms' could probably be deprecated.
This, however, is an extra mile for you. So, if you don't feel like doing it, then dropping the entry is Ok as well.
Quoted 10 lines
Quoted 7 lines
I think there is also no upstream charger driver for the BD71828/BD71879 - only an early RFC and some downstream mess - but stil it'd be nice to have the property in place as the size of the sense resistor is needed when converting coulomb counter register values to current.
What are you upstreaming plans here? For all:
I rebased the charger stuff to v6.11 on
https://github.com/akemnade/linux branch kobo/power-6.11
Excellent question.
The reason why this driver is not upstream is that (as far as I know) the PMIC variants supported by the driver have always been tailored for a specific customer's needs. I don't think these PMICs have been sold for anyone else besides the specific customers. Hence, there has been little benefit for creating an upstream driver.
For the charger there has been additional complexity because the bd71827-charger driver implements also an in-kernel battery fuel gauge which computes the SOC values and sends them to the user-space. Like you know, this is very battery specific and requires correct battery parameters to be given.
I think your work changes things a bit. Seems we will be having an upstream board (kobo) using the PMIC drivers - and it might also use some information from the charger block. I know you also implemented some control logic to get the charging working with limited power-supplies.
(I think the BD71815 is also used in some projects which wanted to have upstream drivers - but I haven't seen upstream dts using it).
Furthermore, we still seem to be having new variants - I am right now writing drivers for another customer specific PMIC using somewhat similar charging logic. Having upstream driver would help in work like that. (By the way, I took your rebased kobo patches and continued my work on top of those - so thanks for the rebasing!)
So - in my opinion, upstreaming would be beneficial and I will push for this direction - but it will be slow process.
Also, I think that maybe the downstream driver shouldn't be upstreamed as such. I am not 100% convinced the SOC should be computed in-kernel. It'd might be easier to implement the SOC computation in a user-space library which just gets the details from the kernel. On the other hand, I think the driver should support a few currently unsupported features like setting the currents for different charge phases based on device-tree properties.
Giving I am the only guy at ROHM working on these Linux drivers (and not only these drivers), and knowing I don't have a system which is equipped with a real battery - I wouldn't hold my breath waiting :(
Yours,
-- Matti
Quoted 2 lines
Regards,
Andreas
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Enable drivers for Kobo Clara 2E
In reply to Andreas KemnadeEnable drivers used on Kobo Clara 2E
--- arch/arm/configs/imx_v6_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +2 -0
@@ -68,6 +68,7 @@ CONFIG_BT=y CONFIG_BT_BNEP=m CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_LL=y +CONFIG_BT_NXPUART=m CONFIG_CFG80211=y CONFIG_CFG80211_WEXT=y CONFIG_MAC80211=y
@@ -253,6 +254,7 @@ CONFIG_MFD_ROHM_BD71828=y CONFIG_REGULATOR_FIXED_VOLTAGE=y CONFIG_REGULATOR_ANATOP=y CONFIG_REGULATOR_BD71815=y +CONFIG_REGULATOR_BD71828=y CONFIG_REGULATOR_DA9052=y CONFIG_REGULATOR_DA9062=y CONFIG_REGULATOR_DA9063=y
Signature · 1 line
2.39.5
Rob Herring (Arm)
maintainerQuoted 23 lines · Andreas Kemnade
Add a basic device tree for the Kobo Clara 2E Ebook reader. It is equipped with an i.MX6SLL SoC. EPDC PMIC drivers are not ready for mainline yet.
Changes in V2:
- improved commit message about devices without bindingAndreas Kemnade (3):
dt-bindings: arm: fsl: add compatible strings for Kobo Clara 2E
ARM: dts: imx: Add devicetree for Kobo Clara 2E
ARM:imx_v6_v7_defconfig: Enable drivers for Kobo Clara 2E.../devicetree/bindings/arm/fsl.yaml | 8 + arch/arm/boot/dts/nxp/imx/Makefile | 2 + .../dts/nxp/imx/imx6sll-kobo-clara2e-a.dts | 23 + .../dts/nxp/imx/imx6sll-kobo-clara2e-b.dts | 23 + .../nxp/imx/imx6sll-kobo-clara2e-common.dtsi | 514 ++++++++++++++++++ arch/arm/configs/imx_v6_v7_defconfig | 2 + 6 files changed, 572 insertions(+) create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dts create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dts create mode 100644 arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi
Quoted 5 lines
--
2.39.5
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y nxp/imx/imx6sll-kobo-clara2e-a.dtb nxp/imx/imx6sll-kobo-clara2e-b.dtb' for [email protected]:
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: spdif@2004000: compatible:0: 'fsl,imx6sl-spdif' is not one of ['fsl,imx35-spdif', 'fsl,vf610-spdif', 'fsl,imx6sx-spdif', 'fsl,imx8qm-spdif', 'fsl,imx8qxp-spdif', 'fsl,imx8mq-spdif', 'fsl,imx8mm-spdif', 'fsl,imx8mn-spdif', 'fsl,imx8ulp-spdif']
from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: spdif@2004000: compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif'] is too long
from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: spdif@2004000: clock-names:9: 'spba' was expected
from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: spdif@2004000: compatible:0: 'fsl,imx6sl-spdif' is not one of ['fsl,imx35-spdif', 'fsl,vf610-spdif', 'fsl,imx6sx-spdif', 'fsl,imx8qm-spdif', 'fsl,imx8qxp-spdif', 'fsl,imx8mq-spdif', 'fsl,imx8mm-spdif', 'fsl,imx8mn-spdif', 'fsl,imx8ulp-spdif']
from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: spdif@2004000: compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif'] is too long
from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: spdif@2004000: clock-names:9: 'spba' was expected
from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: /soc/bus@2000000/spba-bus@2000000/spdif@2004000: failed to match any schema with compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif']arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: /soc/bus@2000000/spba-bus@2000000/spdif@2004000: failed to match any schema with compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif']arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: serial@2034000: dma-name: b'rx\x00tx\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: serial@2034000: dma-name: b'rx\x00tx\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: timer@2098000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sl-gpt'] is too short
'fsl,imx1-gpt' was expected
'fsl,imx21-gpt' was expected
'fsl,imx27-gpt' was expected
'fsl,imx31-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt', 'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
'fsl,imx6dl-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx6ul-gpt', 'fsl,imx7d-gpt']
from schema $id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: timer@2098000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sl-gpt'] is too short
'fsl,imx1-gpt' was expected
'fsl,imx21-gpt' was expected
'fsl,imx27-gpt' was expected
'fsl,imx31-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt', 'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
'fsl,imx6dl-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx6ul-gpt', 'fsl,imx7d-gpt']
from schema $id: http://devicetree.org/schemas/timer/fsl,imxgpt.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: anatop@20c8000: '#address-cells', '#size-cells', 'regulator-3p0@20c8120' do not match any of the regexes: 'pinctrl-[0-9]+', 'regulator-((1p1)|(2p5)|(3p0)|(vddcore)|(vddpu)|(vddsoc))$'
from schema $id: http://devicetree.org/schemas/soc/imx/fsl,imx-anatop.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: anatop@20c8000: '#address-cells', '#size-cells', 'regulator-3p0@20c8120' do not match any of the regexes: 'pinctrl-[0-9]+', 'regulator-((1p1)|(2p5)|(3p0)|(vddcore)|(vddpu)|(vddsoc))$'
from schema $id: http://devicetree.org/schemas/soc/imx/fsl,imx-anatop.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: regulator-3p0@20c8120: Unevaluated properties are not allowed ('reg' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/anatop-regulator.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: regulator-3p0@20c8120: Unevaluated properties are not allowed ('reg' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/anatop-regulator.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: interrupt-controller@20dc000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-gpc', 'fsl,imx6q-gpc'] is too long 'fsl,imx6sll-gpc' is not one of ['fsl,imx6q-gpc'] 'fsl,imx6sll-gpc' is not one of ['fsl,imx6qp-gpc', 'fsl,imx6sl-gpc', 'fsl,imx6sx-gpc', 'fsl,imx6ul-gpc'] from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: interrupt-controller@20dc000: 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: interrupt-controller@20dc000: 'clock-names' is a required property
from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: interrupt-controller@20dc000: 'pgc' is a required property
from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: interrupt-controller@20dc000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-gpc', 'fsl,imx6q-gpc'] is too long 'fsl,imx6sll-gpc' is not one of ['fsl,imx6q-gpc'] 'fsl,imx6sll-gpc' is not one of ['fsl,imx6qp-gpc', 'fsl,imx6sl-gpc', 'fsl,imx6sx-gpc', 'fsl,imx6ul-gpc'] from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: interrupt-controller@20dc000: 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: interrupt-controller@20dc000: 'clock-names' is a required property
from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: interrupt-controller@20dc000: 'pgc' is a required property
from schema $id: http://devicetree.org/schemas/power/fsl,imx-gpc.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: /soc/bus@2000000/interrupt-controller@20dc000: failed to match any schema with compatible: ['fsl,imx6sll-gpc', 'fsl,imx6q-gpc'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: /soc/bus@2000000/interrupt-controller@20dc000: failed to match any schema with compatible: ['fsl,imx6sll-gpc', 'fsl,imx6q-gpc'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: /soc/bus@2000000/pinctrl@20e0000: failed to match any schema with compatible: ['fsl,imx6sll-iomuxc'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: /soc/bus@2000000/pinctrl@20e0000: failed to match any schema with compatible: ['fsl,imx6sll-iomuxc'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi'] arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: lcd-controller@20f8000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long 'fsl,imx6sll-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif', 'fsl,imx6sx-lcdif', 'fsl,imx8mp-lcdif', 'fsl,imx93-lcdif'] 'fsl,imx6sx-lcdif' was expected from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: lcd-controller@20f8000: clocks: [[2, 129], [2, 123], [2, 0]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtb: lcd-controller@20f8000: clock-names: ['pix', 'axi', 'disp_axi'] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: lcd-controller@20f8000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long 'fsl,imx6sll-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif', 'fsl,imx6sx-lcdif', 'fsl,imx8mp-lcdif', 'fsl,imx93-lcdif'] 'fsl,imx6sx-lcdif' was expected from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: lcd-controller@20f8000: clocks: [[2, 129], [2, 123], [2, 0]] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtb: lcd-controller@20f8000: clock-names: ['pix', 'axi', 'disp_axi'] is too long
from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
Quoted 33 lines · On Fri, 25 Oct 2024 08:55:18 -0500 "Rob Herring (Arm)" <[email protected]> wrote:
Quoted 20 lines · Andreas Kemnade
Add a basic device tree for the Kobo Clara 2E Ebook reader. It is equipped with an i.MX6SLL SoC. EPDC PMIC drivers are not ready for mainline yet.
Changes in V2:
- improved commit message about devices without bindingAndreas Kemnade (3):
dt-bindings: arm: fsl: add compatible strings for Kobo Clara 2E
ARM: dts: imx: Add devicetree for Kobo Clara 2E
ARM:imx_v6_v7_defconfig: Enable drivers for Kobo Clara 2E.../devicetree/bindings/arm/fsl.yaml | 8 + arch/arm/boot/dts/nxp/imx/Makefile | 2 + .../dts/nxp/imx/imx6sll-kobo-clara2e-a.dts | 23 + .../dts/nxp/imx/imx6sll-kobo-clara2e-b.dts | 23 + .../nxp/imx/imx6sll-kobo-clara2e-common.dtsi | 514 ++++++++++++++++++ arch/arm/configs/imx_v6_v7_defconfig | 2 + 6 files changed, 572 insertions(+) create mode 100644Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-a.dtscreate mode 100644arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-b.dtscreate mode 100644arch/arm/boot/dts/nxp/imx/imx6sll-kobo-clara2e-common.dtsi--
2.39.5
Quoted 3 lines
My bot found new DTB warnings on the .dts files added or changed in this series.
I think they all come from existing dtsi.
Regards,
Andreas