Skip to contentSkip to conversation

drivers: most: add ALSA sound driver

PATCH Superseded Christian Gromm 2 participants 5 messages Nov 6, 2020 – Nov 17, 2020

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Christian Gromm

author maintainer
#0 lore raw

PATCH v2 1/1 drivers: most: add ALSA sound driver

This patch moves the ALSA sound driver out of the staging area and adds it to the stable part of the MOST driver. Modifications to the Makefiles and Kconfigs are done accordingly to not break the build.

---
v2:

submitted patch that fixes issue found during code audit to staging version first to be able to resend single patch that adds the driver. The patch series included:

- use swabXX functions of kernel

 drivers/most/Kconfig                |  10 +
 drivers/most/Makefile               |   1 +
 drivers/most/most_snd.c             | 743 ++++++++++++++++++++++++++++++++++++
 drivers/staging/most/Kconfig        |   2 -
 drivers/staging/most/Makefile       |   1 -
 drivers/staging/most/sound/Kconfig  |  14 -
 drivers/staging/most/sound/Makefile |   4 -
 drivers/staging/most/sound/sound.c  | 743 ------------------------------------
 8 files changed, 754 insertions(+), 764 deletions(-)
 create mode 100644 drivers/most/most_snd.c
 delete mode 100644 drivers/staging/most/sound/Kconfig
 delete mode 100644 drivers/staging/most/sound/Makefile
 delete mode 100644 drivers/staging/most/sound/sound.c
drivers/most/Kconfig +10 -0
index ebfe84e..4b8145b 100644
@@ -32,4 +32,14 @@ config MOST_CDEV
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called most_cdev.
+
+config MOST_SND
+	tristate "Sound"
+	depends on SND
+	select SND_PCM
+	help
+	  Say Y here if you want to commumicate via ALSA/sound devices.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called most_sound.
 endif
drivers/most/Makefile +1 -0
index 8b53ca4..60db6cd 100644
@@ -5,3 +5,4 @@ most_core-y :=	core.o \
 
 obj-$(CONFIG_MOST_USB_HDM) += most_usb.o
 obj-$(CONFIG_MOST_CDEV) += most_cdev.o
+obj-$(CONFIG_MOST_SND) += most_snd.o
drivers/most/most_snd.c new file +743 -0

743 lines not on this page · raw message

drivers/staging/most/Kconfig +0 -2
index 535e6de..6f420cb 100644
@@ -20,8 +20,6 @@ if MOST_COMPONENTS
 
 source "drivers/staging/most/net/Kconfig"
 
-source "drivers/staging/most/sound/Kconfig"
-
 source "drivers/staging/most/video/Kconfig"
 
 source "drivers/staging/most/dim2/Kconfig"
drivers/staging/most/Makefile +0 -1
index be94673..8b3fc5a 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 obj-$(CONFIG_MOST_NET)	+= net/
-obj-$(CONFIG_MOST_SOUND)	+= sound/
 obj-$(CONFIG_MOST_VIDEO)	+= video/
 obj-$(CONFIG_MOST_DIM2)	+= dim2/
 obj-$(CONFIG_MOST_I2C)	+= i2c/
drivers/staging/most/sound/Kconfig deleted +0 -14
deleted file mode 100644
index ad9f782..0000000
@@ -1,14 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-#
-# MOST ALSA configuration
-#
-
-config MOST_SOUND
-	tristate "Sound"
-	depends on SND
-	select SND_PCM
-	help
-	  Say Y here if you want to commumicate via ALSA/sound devices.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called most_sound.
drivers/staging/most/sound/Makefile deleted +0 -4
deleted file mode 100644
index f0cd9d8..0000000
@@ -1,4 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_MOST_SOUND) += most_sound.o
-
-most_sound-objs := sound.o
drivers/staging/most/sound/sound.c deleted +0 -743

743 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw
Quoted 13 lines · Christian Gromm
drivers/most/most_snd.c new file +13 -0
+static struct list_head adpt_list;
+
+#define MOST_PCM_INFO (SNDRV_PCM_INFO_MMAP | \
+		       SNDRV_PCM_INFO_MMAP_VALID | \
+		       SNDRV_PCM_INFO_BATCH | \
+		       SNDRV_PCM_INFO_INTERLEAVED | \
+		       SNDRV_PCM_INFO_BLOCK_TRANSFER)
+
+static void swap_copy16(u16 *dest, const u16 *source, unsigned int bytes)
+{
+	unsigned int i = 0;
+
+	while (i < (bytes / 2)) {

drivers/most/most_snd.c line 89

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+		dest[i] = swab16(source[i]);
+		i++;
+	}
+}
+
+static void swap_copy24(u8 *dest, const u8 *source, unsigned int bytes)
+{
+	unsigned int i = 0;
+
+	while (i < bytes - 2) {

Can bytes ever be zero? If so then this will corrupt memory and crash.

Generally "int i;" is less risky than "unsigned int i;". Of course, I recently almost introduced a situation where we were copying up to ULONG_MAX bytes so there are times when iterators should be size_t so that does happen. It could be buggy either way is what I'm saying but generally "unsigned int i;" is more often buggy.

Quoted 66 lines
drivers/most/most_snd.c new file +66 -0
+		dest[i] = source[i + 2];
+		dest[i + 1] = source[i + 1];
+		dest[i + 2] = source[i];
+		i += 3;
+	}
+}
+
+static void swap_copy32(u32 *dest, const u32 *source, unsigned int bytes)
+{
+	unsigned int i = 0;
+
+	while (i < bytes / 4) {
+		dest[i] = swab32(source[i]);
+		i++;
+	}
+}
+
+static void alsa_to_most_memcpy(void *alsa, void *most, unsigned int bytes)
+{
+	memcpy(most, alsa, bytes);
+}
+
+static void alsa_to_most_copy16(void *alsa, void *most, unsigned int bytes)
+{
+	swap_copy16(most, alsa, bytes);
+}
+
+static void alsa_to_most_copy24(void *alsa, void *most, unsigned int bytes)
+{
+	swap_copy24(most, alsa, bytes);
+}
+
+static void alsa_to_most_copy32(void *alsa, void *most, unsigned int bytes)
+{
+	swap_copy32(most, alsa, bytes);
+}
+
+static void most_to_alsa_memcpy(void *alsa, void *most, unsigned int bytes)
+{
+	memcpy(alsa, most, bytes);
+}
+
+static void most_to_alsa_copy16(void *alsa, void *most, unsigned int bytes)
+{
+	swap_copy16(alsa, most, bytes);
+}
+
+static void most_to_alsa_copy24(void *alsa, void *most, unsigned int bytes)
+{
+	swap_copy24(alsa, most, bytes);
+}
+
+static void most_to_alsa_copy32(void *alsa, void *most, unsigned int bytes)
+{
+	swap_copy32(alsa, most, bytes);
+}
+
+/**
+ * get_channel - get pointer to channel
+ * @iface: interface structure
+ * @channel_id: channel ID
+ *
+ * This traverses the channel list and returns the channel matching the
+ * ID and interface.
+ *
+ * Returns pointer to channel on success or NULL otherwise.

drivers/most/most_snd.c line 165

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+ */
+static struct channel *get_channel(struct most_interface *iface,
+				   int channel_id)
+{
+	struct sound_adapter *adpt = iface->priv;
+	struct channel *channel, *tmp;
+
+	list_for_each_entry_safe(channel, tmp, &adpt->dev_list, list) {
+		if ((channel->iface = iface) && (channel->id = channel_id))
+			return channel;

No need to use the _safe() version of this loop macro. You're not freeing anything. My concern is that sometimes people think the _safe() has something to do with locking and it does not.

Quoted 4 lines
drivers/most/most_snd.c new file +4 -0
+	}
+	return NULL;
+}
+

[ Snip ]

Quoted 33 lines
drivers/most/most_snd.c new file +33 -0
+/**
+ * audio_probe_channel - probe function of the driver module
+ * @iface: pointer to interface instance
+ * @channel_id: channel index/ID
+ * @cfg: pointer to actual channel configuration
+ * @arg_list: string that provides the name of the device to be created in /dev
+ *	      plus the desired audio resolution
+ *
+ * Creates sound card, pcm device, sets pcm ops and registers sound card.
+ *
+ * Returns 0 on success or error code otherwise.
+ */
+static int audio_probe_channel(struct most_interface *iface, int channel_id,
+			       struct most_channel_config *cfg,
+			       char *device_name, char *arg_list)
+{
+	struct channel *channel;
+	struct sound_adapter *adpt;
+	struct snd_pcm *pcm;
+	int playback_count = 0;
+	int capture_count = 0;
+	int ret;
+	int direction;
+	u16 ch_num;
+	char *sample_res;
+	char arg_list_cpy[STRING_SIZE];
+
+	if (cfg->data_type != MOST_CH_SYNC) {
+		pr_err("Incompatible channel type\n");
+		return -EINVAL;
+	}
+	strlcpy(arg_list_cpy, arg_list, STRING_SIZE);
+	ret = split_arg_list(arg_list_cpy, &ch_num, &sample_res);

drivers/most/most_snd.c line 539

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+	if (ret < 0)
+		return ret;
+
+	list_for_each_entry(adpt, &adpt_list, list) {
+		if (adpt->iface != iface)
+			continue;
+		if (adpt->registered)
+			return -ENOSPC;
+		adpt->pcm_dev_idx++;
+		goto skip_adpt_alloc;

It's weird how if the "channel = " allocation fails, then we free this "adpt" which we didn't allocate.

Quoted 42 lines
drivers/most/most_snd.c new file +42 -0
+	}
+	adpt = kzalloc(sizeof(*adpt), GFP_KERNEL);
+	if (!adpt)
+		return -ENOMEM;
+
+	adpt->iface = iface;
+	INIT_LIST_HEAD(&adpt->dev_list);
+	iface->priv = adpt;
+	list_add_tail(&adpt->list, &adpt_list);
+	ret = snd_card_new(iface->driver_dev, -1, "INIC", THIS_MODULE,
+			   sizeof(*channel), &adpt->card);
+	if (ret < 0)
+		goto err_free_adpt;
+	snprintf(adpt->card->driver, sizeof(adpt->card->driver),
+		 "%s", DRIVER_NAME);
+	snprintf(adpt->card->shortname, sizeof(adpt->card->shortname),
+		 "Microchip INIC");
+	snprintf(adpt->card->longname, sizeof(adpt->card->longname),
+		 "%s at %s", adpt->card->shortname, iface->description);
+skip_adpt_alloc:
+	if (get_channel(iface, channel_id)) {
+		pr_err("channel (%s:%d) is already linked\n",
+		       iface->description, channel_id);
+		return -EEXIST;
+	}
+
+	if (cfg->direction = MOST_CH_TX) {
+		playback_count = 1;
+		direction = SNDRV_PCM_STREAM_PLAYBACK;
+	} else {
+		capture_count = 1;
+		direction = SNDRV_PCM_STREAM_CAPTURE;
+	}
+	channel = kzalloc(sizeof(*channel), GFP_KERNEL);
+	if (!channel) {
+		ret = -ENOMEM;
+		goto err_free_adpt;
+	}
+	channel->card = adpt->card;
+	channel->cfg = cfg;
+	channel->iface = iface;
+	channel->id = channel_id;

drivers/most/most_snd.c line 591

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+	init_waitqueue_head(&channel->playback_waitq);
+	list_add_tail(&channel->list, &adpt->dev_list);
+
+	ret = audio_set_hw_params(&channel->pcm_hardware, ch_num, sample_res,
+				  cfg);
+	if (ret)
+		goto err_free_adpt;
+
+	ret = snd_pcm_new(adpt->card, device_name, adpt->pcm_dev_idx,
+			  playback_count, capture_count, &pcm);

I don't see any snd_pcm_free() to match this snd_pcm_new().

Quoted 4 lines
drivers/most/most_snd.c new file +4 -0
+
+	if (ret < 0)
+		goto err_free_adpt;
+

drivers/most/most_snd.c line 605

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+	pcm->private_data = channel;
+	strscpy(pcm->name, device_name, sizeof(pcm->name));
+	snd_pcm_set_ops(pcm, direction, &pcm_ops);
+	snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC, NULL, 0, 0);
+	return 0;
+
+err_free_adpt:
+	release_adapter(adpt);
+	return ret;
+}

regards,
dan carpenter

author maintainer
#2 lore raw

T24gVHVlLCAyMDIwLTExLTEwIGF0IDExOjQ4ICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K PiBFWFRFUk5BTCBFTUFJTDogRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMg dW5sZXNzIHlvdSBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUNCj4gDQo+IE9uIEZyaSwgTm92IDA2 LCAyMDIwIGF0IDA1OjMwOjU0UE0gKzAxMDAsIENocmlzdGlhbiBHcm9tbSB3cm90ZToNCj4gPiAr c3RhdGljIHN0cnVjdCBsaXN0X2hlYWQgYWRwdF9saXN0Ow0KPiA+ICsNCj4gPiArI2RlZmluZSBN T1NUX1BDTV9JTkZPIChTTkRSVl9QQ01fSU5GT19NTUFQIHwgXA0KPiA+ICsgICAgICAgICAgICAg ICAgICAgIFNORFJWX1BDTV9JTkZPX01NQVBfVkFMSUQgfCBcDQo+ID4gKyAgICAgICAgICAgICAg ICAgICAgU05EUlZfUENNX0lORk9fQkFUQ0ggfCBcDQo+ID4gKyAgICAgICAgICAgICAgICAgICAg U05EUlZfUENNX0lORk9fSU5URVJMRUFWRUQgfCBcDQo+ID4gKyAgICAgICAgICAgICAgICAgICAg U05EUlZfUENNX0lORk9fQkxPQ0tfVFJBTlNGRVIpDQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBz d2FwX2NvcHkxNih1MTYgKmRlc3QsIGNvbnN0IHUxNiAqc291cmNlLCB1bnNpZ25lZCBpbnQgYnl0 ZXMpDQo+ID4gK3sNCj4gPiArICAgICB1bnNpZ25lZCBpbnQgaSA9IDA7DQo+ID4gKw0KPiA+ICsg ICAgIHdoaWxlIChpIDwgKGJ5dGVzIC8gMikpIHsNCj4gPiArICAgICAgICAgICAgIGRlc3RbaV0g PSBzd2FiMTYoc291cmNlW2ldKTsNCj4gPiArICAgICAgICAgICAgIGkrKzsNCj4gPiArICAgICB9 DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIHN3YXBfY29weTI0KHU4ICpkZXN0LCBj b25zdCB1OCAqc291cmNlLCB1bnNpZ25lZCBpbnQgYnl0ZXMpDQo+ID4gK3sNCj4gPiArICAgICB1 bnNpZ25lZCBpbnQgaSA9IDA7DQo+ID4gKw0KPiA+ICsgICAgIHdoaWxlIChpIDwgYnl0ZXMgLSAy KSB7DQo+IA0KPiBDYW4gYnl0ZXMgZXZlciBiZSB6ZXJvPyAgSWYgc28gdGhlbiB0aGlzIHdpbGwg Y29ycnVwdCBtZW1vcnkgYW5kIGNyYXNoLg0KPiANCj4gR2VuZXJhbGx5ICJpbnQgaTsiIGlzIGxl c3Mgcmlza3kgdGhhbiAidW5zaWduZWQgaW50IGk7Ii4gIE9mIGNvdXJzZSwgSQ0KPiByZWNlbnRs eSBhbG1vc3QgaW50cm9kdWNlZCBhIHNpdHVhdGlvbiB3aGVyZSB3ZSB3ZXJlIGNvcHlpbmcgdXAg dG8NCj4gVUxPTkdfTUFYIGJ5dGVzIHNvIHRoZXJlIGFyZSB0aW1lcyB3aGVuIGl0ZXJhdG9ycyBz aG91bGQgYmUgc2l6ZV90IHNvDQo+IHRoYXQgZG9lcyBoYXBwZW4uICBJdCBjb3VsZCBiZSBidWdn eSBlaXRoZXIgd2F5IGlzIHdoYXQgSSdtIHNheWluZyBidXQNCj4gZ2VuZXJhbGx5ICJ1bnNpZ25l ZCBpbnQgaTsiIGlzIG1vcmUgb2Z0ZW4gYnVnZ3kuDQo+IA0KPiA+ICsgICAgICAgICAgICAgZGVz dFtpXSA9IHNvdXJjZVtpICsgMl07DQo+ID4gKyAgICAgICAgICAgICBkZXN0W2kgKyAxXSA9IHNv dXJjZVtpICsgMV07DQo+ID4gKyAgICAgICAgICAgICBkZXN0W2kgKyAyXSA9IHNvdXJjZVtpXTsN Cj4gPiArICAgICAgICAgICAgIGkgKz0gMzsNCj4gPiArICAgICB9DQo+ID4gK30NCj4gPiArDQo+ ID4gK3N0YXRpYyB2b2lkIHN3YXBfY29weTMyKHUzMiAqZGVzdCwgY29uc3QgdTMyICpzb3VyY2Us IHVuc2lnbmVkIGludCBieXRlcykNCj4gPiArew0KPiA+ICsgICAgIHVuc2lnbmVkIGludCBpID0g MDsNCj4gPiArDQo+ID4gKyAgICAgd2hpbGUgKGkgPCBieXRlcyAvIDQpIHsNCj4gPiArICAgICAg ICAgICAgIGRlc3RbaV0gPSBzd2FiMzIoc291cmNlW2ldKTsNCj4gPiArICAgICAgICAgICAgIGkr KzsNCj4gPiArICAgICB9DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIGFsc2FfdG9f bW9zdF9tZW1jcHkodm9pZCAqYWxzYSwgdm9pZCAqbW9zdCwgdW5zaWduZWQgaW50IGJ5dGVzKQ0K PiA+ICt7DQo+ID4gKyAgICAgbWVtY3B5KG1vc3QsIGFsc2EsIGJ5dGVzKTsNCj4gPiArfQ0KPiA+ ICsNCj4gPiArc3RhdGljIHZvaWQgYWxzYV90b19tb3N0X2NvcHkxNih2b2lkICphbHNhLCB2b2lk ICptb3N0LCB1bnNpZ25lZCBpbnQgYnl0ZXMpDQo+ID4gK3sNCj4gPiArICAgICBzd2FwX2NvcHkx Nihtb3N0LCBhbHNhLCBieXRlcyk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIGFs c2FfdG9fbW9zdF9jb3B5MjQodm9pZCAqYWxzYSwgdm9pZCAqbW9zdCwgdW5zaWduZWQgaW50IGJ5 dGVzKQ0KPiA+ICt7DQo+ID4gKyAgICAgc3dhcF9jb3B5MjQobW9zdCwgYWxzYSwgYnl0ZXMpOw0K PiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBhbHNhX3RvX21vc3RfY29weTMyKHZvaWQg KmFsc2EsIHZvaWQgKm1vc3QsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiArew0KPiA+ICsgICAg IHN3YXBfY29weTMyKG1vc3QsIGFsc2EsIGJ5dGVzKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3Rh dGljIHZvaWQgbW9zdF90b19hbHNhX21lbWNweSh2b2lkICphbHNhLCB2b2lkICptb3N0LCB1bnNp Z25lZCBpbnQgYnl0ZXMpDQo+ID4gK3sNCj4gPiArICAgICBtZW1jcHkoYWxzYSwgbW9zdCwgYnl0 ZXMpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBtb3N0X3RvX2Fsc2FfY29weTE2 KHZvaWQgKmFsc2EsIHZvaWQgKm1vc3QsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiArew0KPiA+ ICsgICAgIHN3YXBfY29weTE2KGFsc2EsIG1vc3QsIGJ5dGVzKTsNCj4gPiArfQ0KPiA+ICsNCj4g PiArc3RhdGljIHZvaWQgbW9zdF90b19hbHNhX2NvcHkyNCh2b2lkICphbHNhLCB2b2lkICptb3N0 LCB1bnNpZ25lZCBpbnQgYnl0ZXMpDQo+ID4gK3sNCj4gPiArICAgICBzd2FwX2NvcHkyNChhbHNh LCBtb3N0LCBieXRlcyk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIG1vc3RfdG9f YWxzYV9jb3B5MzIodm9pZCAqYWxzYSwgdm9pZCAqbW9zdCwgdW5zaWduZWQgaW50IGJ5dGVzKQ0K PiA+ICt7DQo+ID4gKyAgICAgc3dhcF9jb3B5MzIoYWxzYSwgbW9zdCwgYnl0ZXMpOw0KPiA+ICt9 DQo+ID4gKw0KPiA+ICsvKioNCj4gPiArICogZ2V0X2NoYW5uZWwgLSBnZXQgcG9pbnRlciB0byBj aGFubmVsDQo+ID4gKyAqIEBpZmFjZTogaW50ZXJmYWNlIHN0cnVjdHVyZQ0KPiA+ICsgKiBAY2hh bm5lbF9pZDogY2hhbm5lbCBJRA0KPiA+ICsgKg0KPiA+ICsgKiBUaGlzIHRyYXZlcnNlcyB0aGUg Y2hhbm5lbCBsaXN0IGFuZCByZXR1cm5zIHRoZSBjaGFubmVsIG1hdGNoaW5nIHRoZQ0KPiA+ICsg KiBJRCBhbmQgaW50ZXJmYWNlLg0KPiA+ICsgKg0KPiA+ICsgKiBSZXR1cm5zIHBvaW50ZXIgdG8g Y2hhbm5lbCBvbiBzdWNjZXNzIG9yIE5VTEwgb3RoZXJ3aXNlLg0KPiA+ICsgKi8NCj4gPiArc3Rh dGljIHN0cnVjdCBjaGFubmVsICpnZXRfY2hhbm5lbChzdHJ1Y3QgbW9zdF9pbnRlcmZhY2UgKmlm YWNlLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBjaGFubmVsX2lk KQ0KPiA+ICt7DQo+ID4gKyAgICAgc3RydWN0IHNvdW5kX2FkYXB0ZXIgKmFkcHQgPSBpZmFjZS0+ cHJpdjsNCj4gPiArICAgICBzdHJ1Y3QgY2hhbm5lbCAqY2hhbm5lbCwgKnRtcDsNCj4gPiArDQo+ ID4gKyAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKGNoYW5uZWwsIHRtcCwgJmFkcHQtPmRl dl9saXN0LCBsaXN0KSB7DQo+ID4gKyAgICAgICAgICAgICBpZiAoKGNoYW5uZWwtPmlmYWNlID09 IGlmYWNlKSAmJiAoY2hhbm5lbC0+aWQgPT0gY2hhbm5lbF9pZCkpDQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgIHJldHVybiBjaGFubmVsOw0KPiANCj4gTm8gbmVlZCB0byB1c2UgdGhlIF9zYWZl KCkgdmVyc2lvbiBvZiB0aGlzIGxvb3AgbWFjcm8uICBZb3UncmUgbm90DQo+IGZyZWVpbmcgYW55 dGhpbmcuICBNeSBjb25jZXJuIGlzIHRoYXQgc29tZXRpbWVzIHBlb3BsZSB0aGluayB0aGUgX3Nh ZmUoKQ0KPiBoYXMgc29tZXRoaW5nIHRvIGRvIHdpdGggbG9ja2luZyBhbmQgaXQgZG9lcyBub3Qu DQo+IA0KPiA+ICsgICAgIH0NCj4gPiArICAgICByZXR1cm4gTlVMTDsNCj4gPiArfQ0KPiA+ICsN Cj4gDQo+IFsgU25pcCBdDQo+IA0KPiA+ICsvKioNCj4gPiArICogYXVkaW9fcHJvYmVfY2hhbm5l bCAtIHByb2JlIGZ1bmN0aW9uIG9mIHRoZSBkcml2ZXIgbW9kdWxlDQo+ID4gKyAqIEBpZmFjZTog cG9pbnRlciB0byBpbnRlcmZhY2UgaW5zdGFuY2UNCj4gPiArICogQGNoYW5uZWxfaWQ6IGNoYW5u ZWwgaW5kZXgvSUQNCj4gPiArICogQGNmZzogcG9pbnRlciB0byBhY3R1YWwgY2hhbm5lbCBjb25m aWd1cmF0aW9uDQo+ID4gKyAqIEBhcmdfbGlzdDogc3RyaW5nIHRoYXQgcHJvdmlkZXMgdGhlIG5h bWUgb2YgdGhlIGRldmljZSB0byBiZSBjcmVhdGVkIGluIC9kZXYNCj4gPiArICogICAgICAgICBw bHVzIHRoZSBkZXNpcmVkIGF1ZGlvIHJlc29sdXRpb24NCj4gPiArICoNCj4gPiArICogQ3JlYXRl cyBzb3VuZCBjYXJkLCBwY20gZGV2aWNlLCBzZXRzIHBjbSBvcHMgYW5kIHJlZ2lzdGVycyBzb3Vu ZCBjYXJkLg0KPiA+ICsgKg0KPiA+ICsgKiBSZXR1cm5zIDAgb24gc3VjY2VzcyBvciBlcnJvciBj b2RlIG90aGVyd2lzZS4NCj4gPiArICovDQo+ID4gK3N0YXRpYyBpbnQgYXVkaW9fcHJvYmVfY2hh bm5lbChzdHJ1Y3QgbW9zdF9pbnRlcmZhY2UgKmlmYWNlLCBpbnQgY2hhbm5lbF9pZCwNCj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBtb3N0X2NoYW5uZWxfY29uZmlnICpj ZmcsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFyICpkZXZpY2VfbmFtZSwg Y2hhciAqYXJnX2xpc3QpDQo+ID4gK3sNCj4gPiArICAgICBzdHJ1Y3QgY2hhbm5lbCAqY2hhbm5l bDsNCj4gPiArICAgICBzdHJ1Y3Qgc291bmRfYWRhcHRlciAqYWRwdDsNCj4gPiArICAgICBzdHJ1 Y3Qgc25kX3BjbSAqcGNtOw0KPiA+ICsgICAgIGludCBwbGF5YmFja19jb3VudCA9IDA7DQo+ID4g KyAgICAgaW50IGNhcHR1cmVfY291bnQgPSAwOw0KPiA+ICsgICAgIGludCByZXQ7DQo+ID4gKyAg ICAgaW50IGRpcmVjdGlvbjsNCj4gPiArICAgICB1MTYgY2hfbnVtOw0KPiA+ICsgICAgIGNoYXIg KnNhbXBsZV9yZXM7DQo+ID4gKyAgICAgY2hhciBhcmdfbGlzdF9jcHlbU1RSSU5HX1NJWkVdOw0K PiA+ICsNCj4gPiArICAgICBpZiAoY2ZnLT5kYXRhX3R5cGUgIT0gTU9TVF9DSF9TWU5DKSB7DQo+ ID4gKyAgICAgICAgICAgICBwcl9lcnIoIkluY29tcGF0aWJsZSBjaGFubmVsIHR5cGVcbiIpOw0K PiA+ICsgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICAgfQ0KPiA+ICsgICAg IHN0cmxjcHkoYXJnX2xpc3RfY3B5LCBhcmdfbGlzdCwgU1RSSU5HX1NJWkUpOw0KPiA+ICsgICAg IHJldCA9IHNwbGl0X2FyZ19saXN0KGFyZ19saXN0X2NweSwgJmNoX251bSwgJnNhbXBsZV9yZXMp Ow0KPiA+ICsgICAgIGlmIChyZXQgPCAwKQ0KPiA+ICsgICAgICAgICAgICAgcmV0dXJuIHJldDsN Cj4gPiArDQo+ID4gKyAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeShhZHB0LCAmYWRwdF9saXN0LCBs aXN0KSB7DQo+ID4gKyAgICAgICAgICAgICBpZiAoYWRwdC0+aWZhY2UgIT0gaWZhY2UpDQo+ID4g KyAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KPiA+ICsgICAgICAgICAgICAgaWYgKGFk cHQtPnJlZ2lzdGVyZWQpDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PU1BD Ow0KPiA+ICsgICAgICAgICAgICAgYWRwdC0+cGNtX2Rldl9pZHgrKzsNCj4gPiArICAgICAgICAg ICAgIGdvdG8gc2tpcF9hZHB0X2FsbG9jOw0KPiANCj4gSXQncyB3ZWlyZCBob3cgaWYgdGhlICJj aGFubmVsID0gIiBhbGxvY2F0aW9uIGZhaWxzLCB0aGVuIHdlIGZyZWUgdGhpcw0KPiAiYWRwdCIg d2hpY2ggd2UgZGlkbid0IGFsbG9jYXRlLg0KDQpXZSBhY3R1YWxseSBkaWQgYWxsb2NhdGUgaXQg aW4gYSBwcmV2aW91cyBjYWxsIHRvIHRoaXMgZnVuY3Rpb24uDQpPdGhlcndpc2Ugd2Ugd291bGQg bm90IGp1bXAgdG8gdGhlIHNraXBfYWRwdF9hbGxvYyBsYWJlbC4gQW5kIGlmDQp3ZSBkb24ndCBq dW1wIHRoZXJlLCB3ZSBhcmUgYWxsb2NhdGluZyBpdCByaWdodCBhd2F5Lg0KDQp0aGFua3MsDQpD aHJpcw0KDQo

#3 lore raw
Quoted 171 lines · On Tue, Nov 17, 2020 at 08:08:50AM +0000, [email protected] wrote:
Quoted 161 lines · Dan Carpenter

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 13 lines · Christian Gromm
drivers/most/most_snd.c new file +13 -0
+static struct list_head adpt_list;
+
+#define MOST_PCM_INFO (SNDRV_PCM_INFO_MMAP | \
+                    SNDRV_PCM_INFO_MMAP_VALID | \
+                    SNDRV_PCM_INFO_BATCH | \
+                    SNDRV_PCM_INFO_INTERLEAVED | \
+                    SNDRV_PCM_INFO_BLOCK_TRANSFER)
+
+static void swap_copy16(u16 *dest, const u16 *source, unsigned int bytes)
+{
+     unsigned int i = 0;
+
+     while (i < (bytes / 2)) {

drivers/most/most_snd.c line 89

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+             dest[i] = swab16(source[i]);
+             i++;
+     }
+}
+
+static void swap_copy24(u8 *dest, const u8 *source, unsigned int bytes)
+{
+     unsigned int i = 0;
+
+     while (i < bytes - 2) {

Can bytes ever be zero? If so then this will corrupt memory and crash.

Generally "int i;" is less risky than "unsigned int i;". Of course, I recently almost introduced a situation where we were copying up to ULONG_MAX bytes so there are times when iterators should be size_t so that does happen. It could be buggy either way is what I'm saying but generally "unsigned int i;" is more often buggy.

Quoted 66 lines
drivers/most/most_snd.c new file +66 -0
+             dest[i] = source[i + 2];
+             dest[i + 1] = source[i + 1];
+             dest[i + 2] = source[i];
+             i += 3;
+     }
+}
+
+static void swap_copy32(u32 *dest, const u32 *source, unsigned int bytes)
+{
+     unsigned int i = 0;
+
+     while (i < bytes / 4) {
+             dest[i] = swab32(source[i]);
+             i++;
+     }
+}
+
+static void alsa_to_most_memcpy(void *alsa, void *most, unsigned int bytes)
+{
+     memcpy(most, alsa, bytes);
+}
+
+static void alsa_to_most_copy16(void *alsa, void *most, unsigned int bytes)
+{
+     swap_copy16(most, alsa, bytes);
+}
+
+static void alsa_to_most_copy24(void *alsa, void *most, unsigned int bytes)
+{
+     swap_copy24(most, alsa, bytes);
+}
+
+static void alsa_to_most_copy32(void *alsa, void *most, unsigned int bytes)
+{
+     swap_copy32(most, alsa, bytes);
+}
+
+static void most_to_alsa_memcpy(void *alsa, void *most, unsigned int bytes)
+{
+     memcpy(alsa, most, bytes);
+}
+
+static void most_to_alsa_copy16(void *alsa, void *most, unsigned int bytes)
+{
+     swap_copy16(alsa, most, bytes);
+}
+
+static void most_to_alsa_copy24(void *alsa, void *most, unsigned int bytes)
+{
+     swap_copy24(alsa, most, bytes);
+}
+
+static void most_to_alsa_copy32(void *alsa, void *most, unsigned int bytes)
+{
+     swap_copy32(alsa, most, bytes);
+}
+
+/**
+ * get_channel - get pointer to channel
+ * @iface: interface structure
+ * @channel_id: channel ID
+ *
+ * This traverses the channel list and returns the channel matching the
+ * ID and interface.
+ *
+ * Returns pointer to channel on success or NULL otherwise.

drivers/most/most_snd.c line 165

Quoted 10 lines
drivers/most/most_snd.c new file +10 -0
+ */
+static struct channel *get_channel(struct most_interface *iface,
+                                int channel_id)
+{
+     struct sound_adapter *adpt = iface->priv;
+     struct channel *channel, *tmp;
+
+     list_for_each_entry_safe(channel, tmp, &adpt->dev_list, list) {
+             if ((channel->iface = iface) && (channel->id = channel_id))
+                     return channel;

No need to use the _safe() version of this loop macro. You're not freeing anything. My concern is that sometimes people think the _safe() has something to do with locking and it does not.

Quoted 4 lines
drivers/most/most_snd.c new file +4 -0
+     }
+     return NULL;
+}
+

[ Snip ]

Quoted 38 lines
drivers/most/most_snd.c new file +38 -0
+/**
+ * audio_probe_channel - probe function of the driver module
+ * @iface: pointer to interface instance
+ * @channel_id: channel index/ID
+ * @cfg: pointer to actual channel configuration
+ * @arg_list: string that provides the name of the device to be created in /dev
+ *         plus the desired audio resolution
+ *
+ * Creates sound card, pcm device, sets pcm ops and registers sound card.
+ *
+ * Returns 0 on success or error code otherwise.
+ */
+static int audio_probe_channel(struct most_interface *iface, int channel_id,
+                            struct most_channel_config *cfg,
+                            char *device_name, char *arg_list)
+{
+     struct channel *channel;
+     struct sound_adapter *adpt;
+     struct snd_pcm *pcm;
+     int playback_count = 0;
+     int capture_count = 0;
+     int ret;
+     int direction;
+     u16 ch_num;
+     char *sample_res;
+     char arg_list_cpy[STRING_SIZE];
+
+     if (cfg->data_type != MOST_CH_SYNC) {
+             pr_err("Incompatible channel type\n");
+             return -EINVAL;
+     }
+     strlcpy(arg_list_cpy, arg_list, STRING_SIZE);
+     ret = split_arg_list(arg_list_cpy, &ch_num, &sample_res);
+     if (ret < 0)
+             return ret;
+
+     list_for_each_entry(adpt, &adpt_list, list) {
+             if (adpt->iface != iface)
Quoted 8 lines

drivers/most/most_snd.c line 539

Quoted 5 lines
drivers/most/most_snd.c new file +5 -0
+                     continue;
+             if (adpt->registered)
+                     return -ENOSPC;
+             adpt->pcm_dev_idx++;
+             goto skip_adpt_alloc;

It's weird how if the "channel = " allocation fails, then we free this "adpt" which we didn't allocate.

Quoted 4 lines

We actually did allocate it in a previous call to this function. Otherwise we would not jump to the skip_adpt_alloc label. And if we don't jump there, we are allocating it right away.

I mean obviously everyone can see that it was allocated by an earlier call to the function. What I mean is that it's a layering violation. The unwind would normally be done in the caller.

Is it okay to delete the adapter without emptying the mdev_link_list as well?

regards,
dan carpenter

author maintainer
#4 lore raw

T24gVHVlLCAyMDIwLTExLTE3IGF0IDExOjQxICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K PiBFWFRFUk5BTCBFTUFJTDogRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMg dW5sZXNzIHlvdSBrbm93IHRoZSBjb250ZW50IGlzIHNhZmUNCj4gDQo+IE9uIFR1ZSwgTm92IDE3 LCAyMDIwIGF0IDA4OjA4OjUwQU0gKzAwMDAsIENocmlzdGlhbi5Hcm9tbUBtaWNyb2NoaXAuY29t IHdyb3RlOg0KPiA+IE9uIFR1ZSwgMjAyMC0xMS0xMCBhdCAxMTo0OCArMDMwMCwgRGFuIENhcnBl bnRlciB3cm90ZToNCj4gPiA+IEVYVEVSTkFMIEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Ig b3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQ0KPiA+ ID4gDQo+ID4gPiBPbiBGcmksIE5vdiAwNiwgMjAyMCBhdCAwNTozMDo1NFBNICswMTAwLCBDaHJp c3RpYW4gR3JvbW0gd3JvdGU6DQo+ID4gPiA+ICtzdGF0aWMgc3RydWN0IGxpc3RfaGVhZCBhZHB0 X2xpc3Q7DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyNkZWZpbmUgTU9TVF9QQ01fSU5GTyAoU05EUlZf UENNX0lORk9fTU1BUCB8IFwNCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgU05EUlZfUENN X0lORk9fTU1BUF9WQUxJRCB8IFwNCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgU05EUlZf UENNX0lORk9fQkFUQ0ggfCBcDQo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgIFNORFJWX1BD TV9JTkZPX0lOVEVSTEVBVkVEIHwgXA0KPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICBTTkRS Vl9QQ01fSU5GT19CTE9DS19UUkFOU0ZFUikNCj4gPiA+ID4gKw0KPiA+ID4gPiArc3RhdGljIHZv aWQgc3dhcF9jb3B5MTYodTE2ICpkZXN0LCBjb25zdCB1MTYgKnNvdXJjZSwgdW5zaWduZWQgaW50 IGJ5dGVzKQ0KPiA+ID4gPiArew0KPiA+ID4gPiArICAgICB1bnNpZ25lZCBpbnQgaSA9IDA7DQo+ ID4gPiA+ICsNCj4gPiA+ID4gKyAgICAgd2hpbGUgKGkgPCAoYnl0ZXMgLyAyKSkgew0KPiA+ID4g PiArICAgICAgICAgICAgIGRlc3RbaV0gPSBzd2FiMTYoc291cmNlW2ldKTsNCj4gPiA+ID4gKyAg ICAgICAgICAgICBpKys7DQo+ID4gPiA+ICsgICAgIH0NCj4gPiA+ID4gK30NCj4gPiA+ID4gKw0K PiA+ID4gPiArc3RhdGljIHZvaWQgc3dhcF9jb3B5MjQodTggKmRlc3QsIGNvbnN0IHU4ICpzb3Vy Y2UsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiA+ID4gK3sNCj4gPiA+ID4gKyAgICAgdW5zaWdu ZWQgaW50IGkgPSAwOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsgICAgIHdoaWxlIChpIDwgYnl0ZXMg LSAyKSB7DQo+ID4gPiANCj4gPiA+IENhbiBieXRlcyBldmVyIGJlIHplcm8/ICBJZiBzbyB0aGVu IHRoaXMgd2lsbCBjb3JydXB0IG1lbW9yeSBhbmQgY3Jhc2guDQo+ID4gPiANCj4gPiA+IEdlbmVy YWxseSAiaW50IGk7IiBpcyBsZXNzIHJpc2t5IHRoYW4gInVuc2lnbmVkIGludCBpOyIuICBPZiBj b3Vyc2UsIEkNCj4gPiA+IHJlY2VudGx5IGFsbW9zdCBpbnRyb2R1Y2VkIGEgc2l0dWF0aW9uIHdo ZXJlIHdlIHdlcmUgY29weWluZyB1cCB0bw0KPiA+ID4gVUxPTkdfTUFYIGJ5dGVzIHNvIHRoZXJl IGFyZSB0aW1lcyB3aGVuIGl0ZXJhdG9ycyBzaG91bGQgYmUgc2l6ZV90IHNvDQo+ID4gPiB0aGF0 IGRvZXMgaGFwcGVuLiAgSXQgY291bGQgYmUgYnVnZ3kgZWl0aGVyIHdheSBpcyB3aGF0IEknbSBz YXlpbmcgYnV0DQo+ID4gPiBnZW5lcmFsbHkgInVuc2lnbmVkIGludCBpOyIgaXMgbW9yZSBvZnRl biBidWdneS4NCj4gPiA+IA0KPiA+ID4gPiArICAgICAgICAgICAgIGRlc3RbaV0gPSBzb3VyY2Vb aSArIDJdOw0KPiA+ID4gPiArICAgICAgICAgICAgIGRlc3RbaSArIDFdID0gc291cmNlW2kgKyAx XTsNCj4gPiA+ID4gKyAgICAgICAgICAgICBkZXN0W2kgKyAyXSA9IHNvdXJjZVtpXTsNCj4gPiA+ ID4gKyAgICAgICAgICAgICBpICs9IDM7DQo+ID4gPiA+ICsgICAgIH0NCj4gPiA+ID4gK30NCj4g PiA+ID4gKw0KPiA+ID4gPiArc3RhdGljIHZvaWQgc3dhcF9jb3B5MzIodTMyICpkZXN0LCBjb25z dCB1MzIgKnNvdXJjZSwgdW5zaWduZWQgaW50IGJ5dGVzKQ0KPiA+ID4gPiArew0KPiA+ID4gPiAr ICAgICB1bnNpZ25lZCBpbnQgaSA9IDA7DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgICAgd2hpbGUg KGkgPCBieXRlcyAvIDQpIHsNCj4gPiA+ID4gKyAgICAgICAgICAgICBkZXN0W2ldID0gc3dhYjMy KHNvdXJjZVtpXSk7DQo+ID4gPiA+ICsgICAgICAgICAgICAgaSsrOw0KPiA+ID4gPiArICAgICB9 DQo+ID4gPiA+ICt9DQo+ID4gPiA+ICsNCj4gPiA+ID4gK3N0YXRpYyB2b2lkIGFsc2FfdG9fbW9z dF9tZW1jcHkodm9pZCAqYWxzYSwgdm9pZCAqbW9zdCwgdW5zaWduZWQgaW50IGJ5dGVzKQ0KPiA+ ID4gPiArew0KPiA+ID4gPiArICAgICBtZW1jcHkobW9zdCwgYWxzYSwgYnl0ZXMpOw0KPiA+ID4g PiArfQ0KPiA+ID4gPiArDQo+ID4gPiA+ICtzdGF0aWMgdm9pZCBhbHNhX3RvX21vc3RfY29weTE2 KHZvaWQgKmFsc2EsIHZvaWQgKm1vc3QsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiA+ID4gK3sN Cj4gPiA+ID4gKyAgICAgc3dhcF9jb3B5MTYobW9zdCwgYWxzYSwgYnl0ZXMpOw0KPiA+ID4gPiAr fQ0KPiA+ID4gPiArDQo+ID4gPiA+ICtzdGF0aWMgdm9pZCBhbHNhX3RvX21vc3RfY29weTI0KHZv aWQgKmFsc2EsIHZvaWQgKm1vc3QsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiA+ID4gK3sNCj4g PiA+ID4gKyAgICAgc3dhcF9jb3B5MjQobW9zdCwgYWxzYSwgYnl0ZXMpOw0KPiA+ID4gPiArfQ0K PiA+ID4gPiArDQo+ID4gPiA+ICtzdGF0aWMgdm9pZCBhbHNhX3RvX21vc3RfY29weTMyKHZvaWQg KmFsc2EsIHZvaWQgKm1vc3QsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiA+ID4gK3sNCj4gPiA+ ID4gKyAgICAgc3dhcF9jb3B5MzIobW9zdCwgYWxzYSwgYnl0ZXMpOw0KPiA+ID4gPiArfQ0KPiA+ ID4gPiArDQo+ID4gPiA+ICtzdGF0aWMgdm9pZCBtb3N0X3RvX2Fsc2FfbWVtY3B5KHZvaWQgKmFs c2EsIHZvaWQgKm1vc3QsIHVuc2lnbmVkIGludCBieXRlcykNCj4gPiA+ID4gK3sNCj4gPiA+ID4g KyAgICAgbWVtY3B5KGFsc2EsIG1vc3QsIGJ5dGVzKTsNCj4gPiA+ID4gK30NCj4gPiA+ID4gKw0K PiA+ID4gPiArc3RhdGljIHZvaWQgbW9zdF90b19hbHNhX2NvcHkxNih2b2lkICphbHNhLCB2b2lk ICptb3N0LCB1bnNpZ25lZCBpbnQgYnl0ZXMpDQo+ID4gPiA+ICt7DQo+ID4gPiA+ICsgICAgIHN3 YXBfY29weTE2KGFsc2EsIG1vc3QsIGJ5dGVzKTsNCj4gPiA+ID4gK30NCj4gPiA+ID4gKw0KPiA+ ID4gPiArc3RhdGljIHZvaWQgbW9zdF90b19hbHNhX2NvcHkyNCh2b2lkICphbHNhLCB2b2lkICpt b3N0LCB1bnNpZ25lZCBpbnQgYnl0ZXMpDQo+ID4gPiA+ICt7DQo+ID4gPiA+ICsgICAgIHN3YXBf Y29weTI0KGFsc2EsIG1vc3QsIGJ5dGVzKTsNCj4gPiA+ID4gK30NCj4gPiA+ID4gKw0KPiA+ID4g PiArc3RhdGljIHZvaWQgbW9zdF90b19hbHNhX2NvcHkzMih2b2lkICphbHNhLCB2b2lkICptb3N0 LCB1bnNpZ25lZCBpbnQgYnl0ZXMpDQo+ID4gPiA+ICt7DQo+ID4gPiA+ICsgICAgIHN3YXBfY29w eTMyKGFsc2EsIG1vc3QsIGJ5dGVzKTsNCj4gPiA+ID4gK30NCj4gPiA+ID4gKw0KPiA+ID4gPiAr LyoqDQo+ID4gPiA+ICsgKiBnZXRfY2hhbm5lbCAtIGdldCBwb2ludGVyIHRvIGNoYW5uZWwNCj4g PiA+ID4gKyAqIEBpZmFjZTogaW50ZXJmYWNlIHN0cnVjdHVyZQ0KPiA+ID4gPiArICogQGNoYW5u ZWxfaWQ6IGNoYW5uZWwgSUQNCj4gPiA+ID4gKyAqDQo+ID4gPiA+ICsgKiBUaGlzIHRyYXZlcnNl cyB0aGUgY2hhbm5lbCBsaXN0IGFuZCByZXR1cm5zIHRoZSBjaGFubmVsIG1hdGNoaW5nIHRoZQ0K PiA+ID4gPiArICogSUQgYW5kIGludGVyZmFjZS4NCj4gPiA+ID4gKyAqDQo+ID4gPiA+ICsgKiBS ZXR1cm5zIHBvaW50ZXIgdG8gY2hhbm5lbCBvbiBzdWNjZXNzIG9yIE5VTEwgb3RoZXJ3aXNlLg0K PiA+ID4gPiArICovDQo+ID4gPiA+ICtzdGF0aWMgc3RydWN0IGNoYW5uZWwgKmdldF9jaGFubmVs KHN0cnVjdCBtb3N0X2ludGVyZmFjZSAqaWZhY2UsDQo+ID4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGludCBjaGFubmVsX2lkKQ0KPiA+ID4gPiArew0KPiA+ID4gPiArICAg ICBzdHJ1Y3Qgc291bmRfYWRhcHRlciAqYWRwdCA9IGlmYWNlLT5wcml2Ow0KPiA+ID4gPiArICAg ICBzdHJ1Y3QgY2hhbm5lbCAqY2hhbm5lbCwgKnRtcDsNCj4gPiA+ID4gKw0KPiA+ID4gPiArICAg ICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUoY2hhbm5lbCwgdG1wLCAmYWRwdC0+ZGV2X2xpc3Qs IGxpc3QpIHsNCj4gPiA+ID4gKyAgICAgICAgICAgICBpZiAoKGNoYW5uZWwtPmlmYWNlID09IGlm YWNlKSAmJiAoY2hhbm5lbC0+aWQgPT0gY2hhbm5lbF9pZCkpDQo+ID4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICByZXR1cm4gY2hhbm5lbDsNCj4gPiA+IA0KPiA+ID4gTm8gbmVlZCB0byB1c2Ug dGhlIF9zYWZlKCkgdmVyc2lvbiBvZiB0aGlzIGxvb3AgbWFjcm8uICBZb3UncmUgbm90DQo+ID4g PiBmcmVlaW5nIGFueXRoaW5nLiAgTXkgY29uY2VybiBpcyB0aGF0IHNvbWV0aW1lcyBwZW9wbGUg dGhpbmsgdGhlIF9zYWZlKCkNCj4gPiA+IGhhcyBzb21ldGhpbmcgdG8gZG8gd2l0aCBsb2NraW5n IGFuZCBpdCBkb2VzIG5vdC4NCj4gPiA+IA0KPiA+ID4gPiArICAgICB9DQo+ID4gPiA+ICsgICAg IHJldHVybiBOVUxMOw0KPiA+ID4gPiArfQ0KPiA+ID4gPiArDQo+ID4gPiANCj4gPiA+IFsgU25p cCBdDQo+ID4gPiANCj4gPiA+ID4gKy8qKg0KPiA+ID4gPiArICogYXVkaW9fcHJvYmVfY2hhbm5l bCAtIHByb2JlIGZ1bmN0aW9uIG9mIHRoZSBkcml2ZXIgbW9kdWxlDQo+ID4gPiA+ICsgKiBAaWZh Y2U6IHBvaW50ZXIgdG8gaW50ZXJmYWNlIGluc3RhbmNlDQo+ID4gPiA+ICsgKiBAY2hhbm5lbF9p ZDogY2hhbm5lbCBpbmRleC9JRA0KPiA+ID4gPiArICogQGNmZzogcG9pbnRlciB0byBhY3R1YWwg Y2hhbm5lbCBjb25maWd1cmF0aW9uDQo+ID4gPiA+ICsgKiBAYXJnX2xpc3Q6IHN0cmluZyB0aGF0 IHByb3ZpZGVzIHRoZSBuYW1lIG9mIHRoZSBkZXZpY2UgdG8gYmUgY3JlYXRlZCBpbiAvZGV2DQo+ ID4gPiA+ICsgKiAgICAgICAgIHBsdXMgdGhlIGRlc2lyZWQgYXVkaW8gcmVzb2x1dGlvbg0KPiA+ ID4gPiArICoNCj4gPiA+ID4gKyAqIENyZWF0ZXMgc291bmQgY2FyZCwgcGNtIGRldmljZSwgc2V0 cyBwY20gb3BzIGFuZCByZWdpc3RlcnMgc291bmQgY2FyZC4NCj4gPiA+ID4gKyAqDQo+ID4gPiA+ ICsgKiBSZXR1cm5zIDAgb24gc3VjY2VzcyBvciBlcnJvciBjb2RlIG90aGVyd2lzZS4NCj4gPiA+ ID4gKyAqLw0KPiA+ID4gPiArc3RhdGljIGludCBhdWRpb19wcm9iZV9jaGFubmVsKHN0cnVjdCBt b3N0X2ludGVyZmFjZSAqaWZhY2UsIGludCBjaGFubmVsX2lkLA0KPiA+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBtb3N0X2NoYW5uZWxfY29uZmlnICpjZmcsDQo+ID4g PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2hhciAqZGV2aWNlX25hbWUsIGNoYXIg KmFyZ19saXN0KQ0KPiA+ID4gPiArew0KPiA+ID4gPiArICAgICBzdHJ1Y3QgY2hhbm5lbCAqY2hh bm5lbDsNCj4gPiA+ID4gKyAgICAgc3RydWN0IHNvdW5kX2FkYXB0ZXIgKmFkcHQ7DQo+ID4gPiA+ ICsgICAgIHN0cnVjdCBzbmRfcGNtICpwY207DQo+ID4gPiA+ICsgICAgIGludCBwbGF5YmFja19j b3VudCA9IDA7DQo+ID4gPiA+ICsgICAgIGludCBjYXB0dXJlX2NvdW50ID0gMDsNCj4gPiA+ID4g KyAgICAgaW50IHJldDsNCj4gPiA+ID4gKyAgICAgaW50IGRpcmVjdGlvbjsNCj4gPiA+ID4gKyAg ICAgdTE2IGNoX251bTsNCj4gPiA+ID4gKyAgICAgY2hhciAqc2FtcGxlX3JlczsNCj4gPiA+ID4g KyAgICAgY2hhciBhcmdfbGlzdF9jcHlbU1RSSU5HX1NJWkVdOw0KPiA+ID4gPiArDQo+ID4gPiA+ ICsgICAgIGlmIChjZmctPmRhdGFfdHlwZSAhPSBNT1NUX0NIX1NZTkMpIHsNCj4gPiA+ID4gKyAg ICAgICAgICAgICBwcl9lcnIoIkluY29tcGF0aWJsZSBjaGFubmVsIHR5cGVcbiIpOw0KPiA+ID4g PiArICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ID4gPiArICAgICB9DQo+ID4gPiA+ ICsgICAgIHN0cmxjcHkoYXJnX2xpc3RfY3B5LCBhcmdfbGlzdCwgU1RSSU5HX1NJWkUpOw0KPiA+ ID4gPiArICAgICByZXQgPSBzcGxpdF9hcmdfbGlzdChhcmdfbGlzdF9jcHksICZjaF9udW0sICZz YW1wbGVfcmVzKTsNCj4gPiA+ID4gKyAgICAgaWYgKHJldCA8IDApDQo+ID4gPiA+ICsgICAgICAg ICAgICAgcmV0dXJuIHJldDsNCj4gPiA+ID4gKw0KPiA+ID4gPiArICAgICBsaXN0X2Zvcl9lYWNo X2VudHJ5KGFkcHQsICZhZHB0X2xpc3QsIGxpc3QpIHsNCj4gPiA+ID4gKyAgICAgICAgICAgICBp ZiAoYWRwdC0+aWZhY2UgIT0gaWZhY2UpDQo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBj b250aW51ZTsNCj4gPiA+ID4gKyAgICAgICAgICAgICBpZiAoYWRwdC0+cmVnaXN0ZXJlZCkNCj4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PU1BDOw0KPiA+ID4gPiArICAg ICAgICAgICAgIGFkcHQtPnBjbV9kZXZfaWR4Kys7DQo+ID4gPiA+ICsgICAgICAgICAgICAgZ290 byBza2lwX2FkcHRfYWxsb2M7DQo+ID4gPiANCj4gPiA+IEl0J3Mgd2VpcmQgaG93IGlmIHRoZSAi Y2hhbm5lbCA9ICIgYWxsb2NhdGlvbiBmYWlscywgdGhlbiB3ZSBmcmVlIHRoaXMNCj4gPiA+ICJh ZHB0IiB3aGljaCB3ZSBkaWRuJ3QgYWxsb2NhdGUuDQo+ID4gDQo+ID4gV2UgYWN0dWFsbHkgZGlk IGFsbG9jYXRlIGl0IGluIGEgcHJldmlvdXMgY2FsbCB0byB0aGlzIGZ1bmN0aW9uLg0KPiA+IE90 aGVyd2lzZSB3ZSB3b3VsZCBub3QganVtcCB0byB0aGUgc2tpcF9hZHB0X2FsbG9jIGxhYmVsLiBB bmQgaWYNCj4gPiB3ZSBkb24ndCBqdW1wIHRoZXJlLCB3ZSBhcmUgYWxsb2NhdGluZyBpdCByaWdo dCBhd2F5Lg0KPiA+IA0KPiANCj4gSSBtZWFuIG9idmlvdXNseSBldmVyeW9uZSBjYW4gc2VlIHRo YXQgaXQgd2FzIGFsbG9jYXRlZCBieSBhbiBlYXJsaWVyDQo+IGNhbGwgdG8gdGhlIGZ1bmN0aW9u LiAgV2hhdCBJIG1lYW4gaXMgdGhhdCBpdCdzIGEgbGF5ZXJpbmcgdmlvbGF0aW9uLg0KPiBUaGUg dW53aW5kIHdvdWxkIG5vcm1hbGx5IGJlIGRvbmUgaW4gdGhlIGNhbGxlci4NCj4gDQo+IElzIGl0 IG9rYXkgdG8gZGVsZXRlIHRoZSBhZGFwdGVyIHdpdGhvdXQgZW1wdHlpbmcgdGhlIG1kZXZfbGlu a19saXN0DQo+IGFzIHdlbGw/DQo+IA0KTm90IG5lY2Vzc2FyaWx5LCBhcyB3aGVuIHdlIGFyZSBh dCB0aGlzIHBvaW50IHRoZSBzZXR1cCBpcyBhbHJlYWR5DQptZXNzZWQgdXAgYW5kIG5lZWRzIHRv IGJlIHJlY29uZmlndXJlZCBmcm9tIHNjcmF0Y2ggYW55d2F5LiBUaGlzDQppbnZvbHZlcyB0aGUg Y2FsbCB0byBtZGV2X2xpbmtfZGVzdHJveV9saW5rX3N0b3JlKCkgdGhhdCBjbGVhbnMgdXANCmV2 ZXJ5dGhpbmcuDQoNCnRoYW5rcywNCkNocmlzDQoNCj4gcmVnYXJkcywNCj4gZGFuIGNhcnBlbnRl cg0KPiANCg=