Skip to contentSkip to conversation

dt-bindings: phy: rockchip-emmc-phy: Convert to dtschema

PATCH Superseded Shresth Prasad 2 participants 5 messages Jun 17, 2024 – Jun 18, 2024

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 dt-bindings: phy: rockchip-emmc-phy: Convert to dtschema

Convert txt bindings of Rockchip EMMC PHY to dtschema to allow for validation.

---
Request for an Ack from the PHY maintainers, so that the DT maintainer Heiko can merge it to grf.yaml in the order that he likes.

Changes in v4:
- change license to GPL-2.0-only
- change dt-binding file name
- remove descriptions
- move #phy-cells to the bottom
- add Heiko to maintainers
- fix patternProperties regex in grf.yaml
- change description to $ref in grf.yaml

Tested against rockchip/rk3399-firefly.dtb, rockchip/rk3399-orangepi.dtb and rockchip/rk3399-pinebook-pro.dtb.

---
 .../phy/rockchip,rk3399-emmc-phy.yaml         | 72 +++++++++++++++++++
 .../bindings/phy/rockchip-emmc-phy.txt        | 43 -----------
 .../devicetree/bindings/soc/rockchip/grf.yaml |  9 ++-
 3 files changed, 78 insertions(+), 46 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +72 -0
new file mode 100644
index 000000000000..e61ba2b0abcd
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/rockchip,rk3399-emmc-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip EMMC PHY
+
+maintainers:
+  - Heiko Stuebner <[email protected]>
+  - Shresth Prasad <[email protected]>
+
+properties:
+  compatible:
+    const: rockchip,rk3399-emmc-phy
+
+  reg:
+    maxItems: 1
+
+  clock-names:
+    const: emmcclk
+
+  clocks:
+    maxItems: 1
+
+  drive-impedance-ohm:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Specifies the drive impedance in Ohm.
+    enum: [33, 40, 50, 66, 100]
+    default: 50
+
+  rockchip,enable-strobe-pulldown:
+    type: boolean
+    description: |
+      Enable internal pull-down for the strobe
+      line.  If not set, pull-down is not used.
+
+  rockchip,output-tapdelay-select:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Specifies the phyctrl_otapdlysec register.
+    default: 0x4
+    maximum: 0xf
+
+  "#phy-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    grf: syscon@ff770000 {
+      compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
+      reg = <0xff770000 0x10000>;
+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      emmcphy: phy@f780 {
+        compatible = "rockchip,rk3399-emmc-phy";
+        reg = <0xf780 0x20>;
+        clocks = <&sdhci>;
+        clock-names = "emmcclk";
+        drive-impedance-ohm = <50>;
+        #phy-cells = <0>;
+      };
+    };
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt deleted +0 -43

43 lines not on this page · raw message

Documentation/devicetree/bindings/soc/rockchip/grf.yaml +6 -3
index 79798c747476..6e1b1cdea680 100644
@@ -176,9 +176,12 @@ allOf:
             Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
 
       patternProperties:
-        "phy@[0-9a-f]+$":
-          description:
-            Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+        "^phy@[0-9a-f]+$":
+          type: object
+
+          $ref: /schemas/phy/rockchip,rk3399-emmc-phy.yaml#
+
+          unevaluatedProperties: false
 
   - if:
       properties:
Signature · 1 line
2.45.2
#1 lore raw
Quoted 5 lines · Shresth Prasad

Convert txt bindings of Rockchip EMMC PHY to dtschema to allow for validation.

---

...

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 24

Quoted 9 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +9 -0
+
+  reg:
+    maxItems: 1
+
+  clock-names:
+    const: emmcclk
+
+  clocks:
+    maxItems: 1

Keep order from DTS coding style, so clocks then clock-names.

Quoted 24 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +24 -0
+
+  drive-impedance-ohm:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Specifies the drive impedance in Ohm.
+    enum: [33, 40, 50, 66, 100]
+    default: 50
+
+  rockchip,enable-strobe-pulldown:
+    type: boolean
+    description: |
+      Enable internal pull-down for the strobe
+      line.  If not set, pull-down is not used.
+
+  rockchip,output-tapdelay-select:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Specifies the phyctrl_otapdlysec register.
+    default: 0x4
+    maximum: 0xf
+
+  "#phy-cells":
+    const: 0
+

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 58

Quoted 10 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    grf: syscon@ff770000 {

Drop label... actually entire node looks not needed.

Quoted 1 line

+ compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";

Drop

Quoted 1 line

+ reg = <0xff770000 0x10000>;

Drop

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 64

Quoted 4 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +4 -0
+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      emmcphy: phy@f780 {

Drop label

Quoted 62 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +8 -0
+        compatible = "rockchip,rk3399-emmc-phy";
+        reg = <0xf780 0x20>;
+        clocks = <&sdhci>;
+        clock-names = "emmcclk";
+        drive-impedance-ohm = <50>;
+        #phy-cells = <0>;
+      };
+    };
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt deleted +0 -43
deleted file mode 100644
index 57d28c0d5696..000000000000
@@ -1,43 +0,0 @@
-Rockchip EMMC PHY
------------------------
-
-Required properties:
- - compatible: rockchip,rk3399-emmc-phy
- - #phy-cells: must be 0
- - reg: PHY register address offset and length in "general
-   register files"
-
-Optional properties:
- - clock-names: Should contain "emmcclk".  Although this is listed as optional
-		(because most boards can get basic functionality without having
-		access to it), it is strongly suggested.
-		See ../clock/clock-bindings.txt for details.
- - clocks: Should have a phandle to the card clock exported by the SDHCI driver.
- - drive-impedance-ohm: Specifies the drive impedance in Ohm.
-                        Possible values are 33, 40, 50, 66 and 100.
-                        If not set, the default value of 50 will be applied.
- - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
-                                    line.  If not set, pull-down is not used.
- - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
-                                    If not set, the register defaults to 0x4.
-                                    Maximum value 0xf.
-
-Example:
-
-
-grf: syscon@ff770000 {
-	compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
-	#address-cells = <1>;
-	#size-cells = <1>;
-
-...
-
-	emmcphy: phy@f780 {
-		compatible = "rockchip,rk3399-emmc-phy";
-		reg = <0xf780 0x20>;
-		clocks = <&sdhci>;
-		clock-names = "emmcclk";
-		drive-impedance-ohm = <50>;
-		#phy-cells = <0>;
-	};
-};
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +0 -0
index 79798c747476..6e1b1cdea680 100644

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 181

Quoted 9 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +3 -3
@@ -176,9 +176,12 @@ allOf:
             Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
 
       patternProperties:
-        "phy@[0-9a-f]+$":
-          description:
-            Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+        "^phy@[0-9a-f]+$":
+          type: object
+

Drop blank line

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 183

Quoted 2 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +2 -0
+          $ref: /schemas/phy/rockchip,rk3399-emmc-phy.yaml#
+

Drop blank line

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 187

Quoted 4 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +1 -0
+          unevaluatedProperties: false
 
   - if:
       properties:

Nothing in example? Isn't the example for 3399?

We want only one complete example of such multi-children devices, so the example can be moved and included in existing one here.

Best regards,
Krzysztof

#2 lore raw
Quoted 52 lines · Krzysztof Kozlowski
Quoted 5 lines · Shresth Prasad

Convert txt bindings of Rockchip EMMC PHY to dtschema to allow for validation.

---

...

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 24

Quoted 9 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +9 -0
+
+  reg:
+    maxItems: 1
+
+  clock-names:
+    const: emmcclk
+
+  clocks:
+    maxItems: 1

Keep order from DTS coding style, so clocks then clock-names.

Quoted 28 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +28 -0
+
+  drive-impedance-ohm:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Specifies the drive impedance in Ohm.
+    enum: [33, 40, 50, 66, 100]
+    default: 50
+
+  rockchip,enable-strobe-pulldown:
+    type: boolean
+    description: |
+      Enable internal pull-down for the strobe
+      line.  If not set, pull-down is not used.
+
+  rockchip,output-tapdelay-select:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Specifies the phyctrl_otapdlysec register.
+    default: 0x4
+    maximum: 0xf
+
+  "#phy-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - "#phy-cells"
Quoted 8 lines

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 58

Quoted 6 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +6 -0
+
+additionalProperties: false
+
+examples:
+  - |
+    grf: syscon@ff770000 {

Drop label... actually entire node looks not needed.

From what I understand, this phy node should be a sub-node of a grf node which is why it is part of the example.

Quoted 8 lines
Quoted 2 lines

+ compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";

Drop

Quoted 1 line

+ reg = <0xff770000 0x10000>;

Drop

Removing reg causes the following warning:
Warning (unit_address_vs_reg): /example-0/syscon@ff770000: node has a unit name, but no reg or ranges property

Please let me know what the prefered solution would be here.

Quoted 83 lines

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 64

Quoted 6 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +4 -0
+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      emmcphy: phy@f780 {

Drop label

Quoted 62 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +8 -0
+        compatible = "rockchip,rk3399-emmc-phy";
+        reg = <0xf780 0x20>;
+        clocks = <&sdhci>;
+        clock-names = "emmcclk";
+        drive-impedance-ohm = <50>;
+        #phy-cells = <0>;
+      };
+    };
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt deleted +0 -43
deleted file mode 100644
index 57d28c0d5696..000000000000
@@ -1,43 +0,0 @@
-Rockchip EMMC PHY
------------------------
-
-Required properties:
- - compatible: rockchip,rk3399-emmc-phy
- - #phy-cells: must be 0
- - reg: PHY register address offset and length in "general
-   register files"
-
-Optional properties:
- - clock-names: Should contain "emmcclk".  Although this is listed as optional
-             (because most boards can get basic functionality without having
-             access to it), it is strongly suggested.
-             See ../clock/clock-bindings.txt for details.
- - clocks: Should have a phandle to the card clock exported by the SDHCI driver.
- - drive-impedance-ohm: Specifies the drive impedance in Ohm.
-                        Possible values are 33, 40, 50, 66 and 100.
-                        If not set, the default value of 50 will be applied.
- - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
-                                    line.  If not set, pull-down is not used.
- - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
-                                    If not set, the register defaults to 0x4.
-                                    Maximum value 0xf.
-
-Example:
-
-
-grf: syscon@ff770000 {
-     compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
-     #address-cells = <1>;
-     #size-cells = <1>;
-
-...
-
-     emmcphy: phy@f780 {
-             compatible = "rockchip,rk3399-emmc-phy";
-             reg = <0xf780 0x20>;
-             clocks = <&sdhci>;
-             clock-names = "emmcclk";
-             drive-impedance-ohm = <50>;
-             #phy-cells = <0>;
-     };
-};
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +0 -0
index 79798c747476..6e1b1cdea680 100644

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 181

Quoted 9 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +3 -3
@@ -176,9 +176,12 @@ allOf:
             Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
 
       patternProperties:
-        "phy@[0-9a-f]+$":
-          description:
-            Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+        "^phy@[0-9a-f]+$":
+          type: object
+

Drop blank line

Quoted 4 lines

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 183

Quoted 2 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +2 -0
+          $ref: /schemas/phy/rockchip,rk3399-emmc-phy.yaml#
+

Drop blank line

The rest of the document also has these blank lines, which is why I've also kept them here. Are you sure I should remove them?

Quoted 10 lines

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 187

Quoted 5 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +1 -0
+          unevaluatedProperties: false
 
   - if:
       properties:

Nothing in example? Isn't the example for 3399?

We want only one complete example of such multi-children devices, so the example can be moved and included in existing one here.

The example in this file is actually for rockchip,rk3399-usb2phy and not rockchip,rk3399-emmc-phy which is why I haven't touched it.

Should I add to the example in grf.yaml ?

Quoted 5 lines

Best regards,
Krzysztof

Please let me know if I've misunderstood anything or if there are any other changes I should make.

Regards,
Shresth

#3 lore raw
Quoted 16 lines · Shresth Prasad
Quoted 5 lines

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 58

Quoted 3 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +3 -0
+examples:
+  - |
+    grf: syscon@ff770000 {

Drop label... actually entire node looks not needed.

From what I understand, this phy node should be a sub-node of a grf node which is why it is part of the example.

Quoted 7 lines
Quoted 2 lines

+ compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";

Drop

Quoted 1 line

+ reg = <0xff770000 0x10000>;

Quoted 7 lines
Quoted 1 line

Drop

Removing reg causes the following warning:
Warning (unit_address_vs_reg): /example-0/syscon@ff770000: node has a unit name, but no reg or ranges property

Please let me know what the prefered solution would be here.

Obviously you need to drop entire node... You cannot just drop reg and leave unit address.

Quoted 84 lines
Quoted 84 lines

Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml line 64

Quoted 7 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +4 -0
+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      emmcphy: phy@f780 {

Drop label

Quoted 62 lines
Documentation/devicetree/bindings/phy/rockchip,rk3399-emmc-phy.yaml new file +8 -0
+        compatible = "rockchip,rk3399-emmc-phy";
+        reg = <0xf780 0x20>;
+        clocks = <&sdhci>;
+        clock-names = "emmcclk";
+        drive-impedance-ohm = <50>;
+        #phy-cells = <0>;
+      };
+    };
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt deleted +0 -43
deleted file mode 100644
index 57d28c0d5696..000000000000
@@ -1,43 +0,0 @@
-Rockchip EMMC PHY
------------------------
-
-Required properties:
- - compatible: rockchip,rk3399-emmc-phy
- - #phy-cells: must be 0
- - reg: PHY register address offset and length in "general
-   register files"
-
-Optional properties:
- - clock-names: Should contain "emmcclk".  Although this is listed as optional
-             (because most boards can get basic functionality without having
-             access to it), it is strongly suggested.
-             See ../clock/clock-bindings.txt for details.
- - clocks: Should have a phandle to the card clock exported by the SDHCI driver.
- - drive-impedance-ohm: Specifies the drive impedance in Ohm.
-                        Possible values are 33, 40, 50, 66 and 100.
-                        If not set, the default value of 50 will be applied.
- - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
-                                    line.  If not set, pull-down is not used.
- - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
-                                    If not set, the register defaults to 0x4.
-                                    Maximum value 0xf.
-
-Example:
-
-
-grf: syscon@ff770000 {
-     compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
-     #address-cells = <1>;
-     #size-cells = <1>;
-
-...
-
-     emmcphy: phy@f780 {
-             compatible = "rockchip,rk3399-emmc-phy";
-             reg = <0xf780 0x20>;
-             clocks = <&sdhci>;
-             clock-names = "emmcclk";
-             drive-impedance-ohm = <50>;
-             #phy-cells = <0>;
-     };
-};
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +0 -0
index 79798c747476..6e1b1cdea680 100644

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 181

Quoted 9 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +3 -3
@@ -176,9 +176,12 @@ allOf:
             Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
 
       patternProperties:
-        "phy@[0-9a-f]+$":
-          description:
-            Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+        "^phy@[0-9a-f]+$":
+          type: object
+

Drop blank line

Quoted 7 lines
Quoted 4 lines

Documentation/devicetree/bindings/soc/rockchip/grf.yaml allOf: · line 183

Quoted 2 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +2 -0
+          $ref: /schemas/phy/rockchip,rk3399-emmc-phy.yaml#
+

Drop blank line

The rest of the document also has these blank lines, which is why I've also kept them here. Are you sure I should remove them?

Yes

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +1 -0
+          unevaluatedProperties: false
 
   - if:
       properties:
Quoted 7 lines
Quoted 4 lines

Nothing in example? Isn't the example for 3399?

We want only one complete example of such multi-children devices, so the example can be moved and included in existing one here.

The example in this file is actually for rockchip,rk3399-usb2phy and not rockchip,rk3399-emmc-phy which is why I haven't touched it.

What? That's gref, not usb2phy.

This patch and your explanations are very confusing.

Best regards,
Krzysztof

#4 lore raw

18 June 2024 11:50:41 am Krzysztof Kozlowski <[email protected]>:

Quoted 138 lines · Shresth Prasad
Quoted 17 lines
Quoted 6 lines
Quoted 4 lines

+examples:
+  - |
+    grf: syscon@ff770000 {

Drop label... actually entire node looks not needed.

From what I understand, this phy node should be a sub-node of a grf node which is why it is part of the example.

Quoted 7 lines
Quoted 2 lines

+      compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";

Drop

Quoted 1 line

+      reg = <0xff770000 0x10000>;

Quoted 7 lines
Quoted 1 line

Drop

Removing reg causes the following warning:
Warning (unit_address_vs_reg): /example-0/syscon@ff770000: node has a unit name, but no reg or ranges property

Please let me know what the prefered solution would be here.

Obviously you need to drop entire node... You cannot just drop reg and leave unit address.

Quoted 84 lines
Quoted 84 lines
Quoted 7 lines

+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      emmcphy: phy@f780 {

Drop label

Quoted 64 lines

+        compatible = "rockchip,rk3399-emmc-phy";
+        reg = <0xf780 0x20>;
+        clocks = <&sdhci>;
+        clock-names = "emmcclk";
+        drive-impedance-ohm = <50>;
+        #phy-cells = <0>;
+      };
+    };

Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt deleted +0 -43
deleted file mode 100644
index 57d28c0d5696..000000000000
@@ -1,43 +0,0 @@
-Rockchip EMMC PHY
------------------------
-
-Required properties:
- - compatible: rockchip,rk3399-emmc-phy
- - #phy-cells: must be 0
- - reg: PHY register address offset and length in "general
-   register files"
-
-Optional properties:
- - clock-names: Should contain "emmcclk".  Although this is listed as optional
-             (because most boards can get basic functionality without having
-             access to it), it is strongly suggested.
-             See ../clock/clock-bindings.txt for details.
- - clocks: Should have a phandle to the card clock exported by the SDHCI driver.
- - drive-impedance-ohm: Specifies the drive impedance in Ohm.
-                        Possible values are 33, 40, 50, 66 and 100.
-                        If not set, the default value of 50 will be applied.
- - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe
-                                    line.  If not set, pull-down is not used.
- - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
-                                    If not set, the register defaults to 0x4.
-                                    Maximum value 0xf.
-
-Example:
-
-
-grf: syscon@ff770000 {
-     compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
-     #address-cells = <1>;
-     #size-cells = <1>;
-
-...
-
-     emmcphy: phy@f780 {
-             compatible = "rockchip,rk3399-emmc-phy";
-             reg = <0xf780 0x20>;
-             clocks = <&sdhci>;
-             clock-names = "emmcclk";
-             drive-impedance-ohm = <50>;
-             #phy-cells = <0>;
-     };
-};
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +0 -0
index 79798c747476..6e1b1cdea680 100644
@@ -176,9 +176,12 @@ allOf:

             Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt

Quoted 7 lines

       patternProperties:
-        "phy@[0-9a-f]+$":
-          description:
-            Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +        "^phy@[0-9a-f]+$":
+          type: object
+

Drop blank line

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

+          $ref: /schemas/phy/rockchip,rk3399-emmc-phy.yaml# +

Drop blank line

The rest of the document also has these blank lines, which is why I've also kept them here. Are you sure I should remove them?

Yes

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

+          unevaluatedProperties: false

   - if:
       properties:

Quoted 7 lines
Quoted 4 lines

Nothing in example? Isn't the example for 3399?

We want only one complete example of such multi-children devices, so the example can be moved and included in existing one here.

The example in this file is actually for rockchip,rk3399-usb2phy and not rockchip,rk3399-emmc-phy which is why I haven't touched it.

Quoted 8 lines

What? That's gref, not usb2phy.

This patch and your explanations are very confusing.

Best regards,
Krzysztof

Sorry about this, I'm still quite new to doing this.
I ask that you be a bit more patient with me, I'm still trying to learn how things work here...

Regards,
Shresth