Fix DM zone resource limits stacking
Subsystems (3)
Damien Le Moal
maintainerv5 cover Fix DM zone resource limits stacking
This is the updated patch 4/4 of the series "Zone write plugging and DM zone fixes". This patch fixes DM zone resource limits stacking (max open zones and max active zones limits). Patch 1 is new and is added to help catch problems and eventual regressions of the handling of these limits.
Changes from v4:
- Fixed a typo in a comment in patch 1
- Added patch 2 and changed patch 3 accordingly
- Added review tags
Changes from v3:
- Modify patch 1 to always check the zone resource limits values in disk_update_zone_resources(), including for DM devices that do not use zone write plugging. Simplify patch 2 accordingly by removing the same check and adjustment of the zone resource limits.
- Added patch 3
Changes from v2:
- Modify patch 1 to return an error for the case where the max open zones limit is greater than the max active zones limit.
- Modify patch 2 to avoid duplicated actions on the limits and to remove warnings for unusual zone limits.
Changes from v1:
- Added patch 1
- Modified patch 2 to not cap the limits for a target with the number of sequential zones mapped but rather to use the device limits as is when more zones than the limits are mapped and 0 otherwise (no limits).
Damien Le Moal (4):
block: Improve checks on zone resource limits
dm: Call dm_revalidate_zones() after setting the queue limits
dm: Improve zone resource limits handling
dm: Remove unused macro DM_ZONE_INVALID_WP_OFST
block/blk-settings.c | 8 ++ block/blk-zoned.c | 20 +++- drivers/md/dm-table.c | 15 ++- drivers/md/dm-zone.c | 220 ++++++++++++++++++++++++++++++++---------- drivers/md/dm.h | 1 + 5 files changed, 207 insertions(+), 57 deletions(-)
Signature · 1 line
2.45.2
Damien Le Moal
maintainerPATCH v5 1/4 block: Improve checks on zone resource limits
Make sure that the zone resource limits of a zoned block device are correct by checking that:
(a) If the device has a max active zones limit, make sure that the max open zones limit is lower than the max active zones limit.
(b) If the device has zone resource limits, check that the limits values are lower than the number of sequential zones of the device. If it is not, assume that the zoned device has no limits by setting the limits to 0.
For (a), a check is added to blk_validate_zoned_limits() and an error returned if the max open zones limit exceeds the value of the max active zone limit (if there is one).
For (b), given that we need the number of sequential zones of the zoned device, this check is added to disk_update_zone_resources(). This is safe to do as that function is executed with the disk queue frozen and the check executed after queue_limits_start_update() which takes the queue limits lock. Of note is that the early return in this function for zoned devices that do not use zone write plugging (e.g. DM devices using native zone append) is moved to after the new check and adjustment of the zone resource limits so that the check applies to any zoned device.
--- block/blk-settings.c | 8 ++++++++ block/blk-zoned.c | 20 ++++++++++++++++---- 2 files changed, 24 insertions(+), 4 deletions(-)
block/blk-settings.c +8 -0
@@ -80,6 +80,14 @@ static int blk_validate_zoned_limits(struct queue_limits *lim)if (WARN_ON_ONCE (!IS_ENABLED (CONFIG_BLK_DEV_ZONED )))return -EINVAL ; +/* +* Given that active zones include open zones, the maximum number of +* open zones cannot be larger than the maximum number of active zones. +*/ +if (lim->max_active_zones && + lim->max_open_zones > lim->max_active_zones) +return -EINVAL ; +if (lim->zone_write_granularity < lim->logical_block_size) lim->zone_write_granularity = lim->logical_block_size;
block/blk-zoned.c +16 -4
@@ -1647,8 +1647,22 @@ static int disk_update_zone_resources(struct gendisk *disk,return -ENODEV ; } + lim =queue_limits_start_update (q); + +/* +* Some devices can advertize zone resource limits that are larger than +* the number of sequential zones of the zoned block device, e.g. a +* small ZNS namespace. For such case, assume that the zoned device has +* no zone resource limits. +*/ + nr_seq_zones = disk->nr_zones - nr_conv_zones; +if (lim.max_open_zones >= nr_seq_zones) + lim.max_open_zones =0 ; +if (lim.max_active_zones >= nr_seq_zones) + lim.max_active_zones =0 ; +if (!disk->zone_wplugs_pool) -return 0 ; + goto commit;/* * If the device has no limit on the maximum number of open and active
@@ -1657,9 +1671,6 @@ static int disk_update_zone_resources(struct gendisk *disk,* dynamic zone write plug allocation when simultaneously writing to * more zones than the size of the mempool. */ - lim =queue_limits_start_update (q); - - nr_seq_zones = disk->nr_zones - nr_conv_zones; pool_size =max (lim.max_open_zones, lim.max_active_zones);if (!pool_size) pool_size =min (BLK_ZONE_WPLUG_DEFAULT_POOL_SIZE , nr_seq_zones);
@@ -1673,6 +1684,7 @@ static int disk_update_zone_resources(struct gendisk *disk, lim.max_open_zones =0 ; } +commit:return queue_limits_commit_update (q, &lim); }
Signature · 1 line
2.45.2
Damien Le Moal
maintainerPATCH v5 2/4 dm: Call dm_revalidate_zones() after setting the queue limits
In reply to Damien Le Moaldm_revalidate_zones() is called from dm_set_zone_restrictions() when the mapped device queue limits are not yet set. However, dm_revalidate_zones() calls blk_revalidate_disk_zones() and this function consults and modifies the mapped device queue limits. Thus, currently, blk_revalidate_disk_zones() operates on limits that are not yet initialized.
Fix this by moving the call to dm_revalidate_zones() out of dm_set_zone_restrictions() and into dm_table_set_restrictions() after executing queue_limits_set().
To further cleanup dm_set_zones_restrictions(), the message about the type of zone append (native or emulated) is also moved inside dm_revalidate_zones().
--- drivers/md/dm-table.c | 15 +++++++++++---- drivers/md/dm-zone.c | 25 ++++++++++--------------- drivers/md/dm.h | 1 + 3 files changed, 22 insertions(+), 19 deletions(-)
drivers/md/dm-table.c +11 -4
@@ -2028,10 +2028,7 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, dm_table_any_dev_attr(t, device_is_not_random, NULL))blk_queue_flag_clear (QUEUE_FLAG_ADD_RANDOM , q); -/* -* For a zoned target, setup the zones related queue attributes -* and resources necessary for zone append emulation if necessary. -*/ +/* For a zoned table, setup the zones related queue attributes. */ if (IS_ENABLED (CONFIG_BLK_DEV_ZONED ) && limits->zoned) { r =dm_set_zones_restrictions (t, q, limits);if (r)
@@ -2042,6 +2039,16 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,if (r)return r; +/* +* Now that the limits are set, check the zones mapped by the table +* and setup the resources for zone append emulation if necessary. +*/ +if (IS_ENABLED (CONFIG_BLK_DEV_ZONED ) && limits->zoned) { + r =dm_revalidate_zones (t, q); +if (r) +return r; + } +dm_update_crypto_profile (q, t);/*
drivers/md/dm-zone.c +10 -15
@@ -166,14 +166,22 @@ static int dm_check_zoned_cb(struct blk_zone *zone, unsigned int idx,* blk_revalidate_disk_zones() function here as the mapped device is suspended * (this is called from __bind() context). */ -static int dm_revalidate_zones (struct mapped_device *md,struct dm_table *t) +int dm_revalidate_zones (struct dm_table *t,struct request_queue *q) { +struct mapped_device *md = t->md;struct gendisk *disk = md->disk;int ret; +if (!get_capacity (disk)) +return 0 ; +/* Revalidate only if something changed. */ -if (!disk->nr_zones || disk->nr_zones != md->nr_zones) +if (!disk->nr_zones || disk->nr_zones != md->nr_zones) { +DMINFO ("%s using %s zone append" , + disk->disk_name, +queue_emulates_zone_append (q) ?"emulated" :"native" ); md->nr_zones =0 ; + }if (md->nr_zones)return 0 ;
@@ -240,9 +248,6 @@ int dm_set_zones_restrictions(struct dm_table *t, struct request_queue *q, lim->max_zone_append_sectors =0 ; } -if (!get_capacity (md->disk)) -return 0 ; -/* * Count conventional zones to check that the mapped device will indeed * have sequential write required zones.
@@ -269,16 +274,6 @@ int dm_set_zones_restrictions(struct dm_table *t, struct request_queue *q,return 0 ; } -if (!md->disk->nr_zones) { -DMINFO ("%s using %s zone append" , - md->disk->disk_name, -queue_emulates_zone_append (q) ?"emulated" :"native" ); - } - - ret =dm_revalidate_zones (md, t); -if (ret <0 ) -return ret; -if (!static_key_enabled (&zoned_enabled.key))static_branch_enable (&zoned_enabled);return 0 ;
drivers/md/dm.h +1 -0
@@ -103,6 +103,7 @@ int dm_setup_md_queue(struct mapped_device *md, struct dm_table *t);*/ int dm_set_zones_restrictions (struct dm_table *t,struct request_queue *q,struct queue_limits *lim); +int dm_revalidate_zones (struct dm_table *t,struct request_queue *q);void dm_zone_endio (struct dm_io *io,struct bio *clone);#ifdef CONFIG_BLK_DEV_ZONED int dm_blk_report_zones(struct gendisk *disk, sector_t sector,
Signature · 1 line
2.45.2
Re: [PATCH v5 2/4] dm: Call dm_revalidate_zones() after setting the queue limits
Quoted 28 lines · Damien Le Moal
dm_revalidate_zones()is called fromdm_set_zone_restrictions()when the mapped device queue limits are not yet set. However,dm_revalidate_zones()callsblk_revalidate_disk_zones()and this function consults and modifies the mapped device queue limits. Thus, currently,blk_revalidate_disk_zones()operates on limits that are not yet initialized.Fix this by moving the call to
dm_revalidate_zones()out ofdm_set_zone_restrictions()and intodm_table_set_restrictions()after executingqueue_limits_set().To further cleanup
dm_set_zones_restrictions(), the message about the type of zone append (native or emulated) is also moved insidedm_revalidate_zones().Fixes 1c0e720228ad ("dm: use queue_limits_set")Signed-off-by Damien Le Moal <[email protected]>--- drivers/md/dm-table.c | 15 +++++++++++---- drivers/md/dm-zone.c | 25 ++++++++++--------------- drivers/md/dm.h | 1 + 3 files changed, 22 insertions(+), 19 deletions(-)drivers/md/dm-table.c +0
-0
drivers/md/dm-table.c int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, · line 2031
Quoted 8 lines
drivers/md/dm-table.c +1
-4@@ -2028,10 +2028,7 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, dm_table_any_dev_attr(t, device_is_not_random, NULL))blk_queue_flag_clear (QUEUE_FLAG_ADD_RANDOM , q); -/* -* For a zoned target, setup the zones related queue attributes -* and resources necessary for zone append emulation if necessary. -*/ +/* For a zoned table, setup the zones related queue attributes. */
s/zones/zone/ ? Or is my grammar dector way off?
Otherwise looks good:
Damien Le Moal
maintainerRe: [PATCH v5 2/4] dm: Call dm_revalidate_zones() after setting the queue limits
Quoted 32 lines · Christoph Hellwig
Quoted 31 lines · Damien Le Moal
dm_revalidate_zones()is called fromdm_set_zone_restrictions()when the mapped device queue limits are not yet set. However,dm_revalidate_zones()callsblk_revalidate_disk_zones()and this function consults and modifies the mapped device queue limits. Thus, currently,blk_revalidate_disk_zones()operates on limits that are not yet initialized.Fix this by moving the call to
dm_revalidate_zones()out ofdm_set_zone_restrictions()and intodm_table_set_restrictions()after executingqueue_limits_set().To further cleanup
dm_set_zones_restrictions(), the message about the type of zone append (native or emulated) is also moved insidedm_revalidate_zones().Fixes 1c0e720228ad ("dm: use queue_limits_set")Signed-off-by Damien Le Moal <[email protected]>--- drivers/md/dm-table.c | 15 +++++++++++---- drivers/md/dm-zone.c | 25 ++++++++++--------------- drivers/md/dm.h | 1 + 3 files changed, 22 insertions(+), 19 deletions(-)drivers/md/dm-table.c +0
-0@@ -2028,10 +2028,7 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, dm_table_any_dev_attr(t, device_is_not_random, NULL))blk_queue_flag_clear (QUEUE_FLAG_ADD_RANDOM , q);
Quoted 7 lines
drivers/md/dm-table.c int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, · line 2031
Quoted 5 lines
drivers/md/dm-table.c +1
-4-/* -* For a zoned target, setup the zones related queue attributes -* and resources necessary for zone append emulation if necessary. -*/ +/* For a zoned table, setup the zones related queue attributes. */ s/zones/zone/ ? Or is my grammar dector way off?
Nope, it is my fingers and brain which are off :)
Will fix that.
Quoted 3 lines
Otherwise looks good:
Reviewed-by Christoph Hellwig <[email protected]>
Thanks.
Signature · 2 lines
Damien Le Moal Western Digital Research
Damien Le Moal
maintainerPATCH v5 3/4 dm: Improve zone resource limits handling
In reply to Damien Le MoalThe generic stacking of limits implemented in the block layer cannot correctly handle stacking of zone resource limits (max open zones and max active zones) because these limits are for an entire device but the stacking may be for a portion of that device (e.g. a dm-linear target that does not cover an entire block device). As a result, when DM devices are created on top of zoned block devices, the DM device never has any zone resource limits advertized, which is only correct if all underlying target devices also have no zone resource limits. If at least one target device has resource limits, the user may see either performance issues (if the max open zone limit of the device is exceeded) or write I/O errors if the max active zone limit of one of the underlying target devices is exceeded.
While it is very difficult to correctly and reliably stack zone resource limits in general, cases where targets are not sharing zone resources of the same device can be dealt with relatively easily. Such situation happens when a target maps all sequential zones of a zoned block device:
for such mapping, other targets mapping other parts of the same zoned block device can only contain conventional zones and thus will not require any zone resource to correctly handle write operations.
For a mapped device constructed with such targets, which includes mapped devices constructed with targets mapping entire zoned block devices, the zone resource limits can be reliably determined using the non-zero minimum of the zone resource limits of all targets.
For mapped devices that include targets partially mapping the set of sequential write required zones of zoned block devices, instead of advertizing no zone resource limits, it is also better to set the mapped device limits to the non-zero minimum of the limits of all targets. In this case the limits for a target depend on the number of sequential zones being mapped: if this number of zone is larger than the limits, then the limits of the device apply and can be used. If on the other hand the target maps a number of zones smaller than the limits, then no limits is needed and we can assume that the target has no limits (limits set to 0).
This commit improves zone resource limits handling as described above using the function dm_set_zone_resource_limits(). This function is executed from dm_set_zones_restrictions() and iterates the targets of a mapped device to evaluate the max open and max active zone limits. This relies on an internal "stacking" of the limits of the target devices combined with a direct counting of the number of sequential zones mapped by the targets.
1) For a target mapping an entire zoned block device, the limits for the target are set to the limits of the device.
2) For a target partially mapping a zoned block device, the number of mapped sequential zones is used to determine the limits: if the target maps more sequential write required zones than the device limits, then the limits of the device are used as-is. If the number of mapped sequential zones is lower than the limits, then we assume that the target has no limits (limits set to 0).
As this evaluation is done for each target, the zone resource limits for the mapped device are evaluated as the non-zero minimum of the limits of all the targets.
For configurations resulting in unreliable limits, i.e. a table containing a target partially mapping a zoned device, a warning message is issued.
The counting of mapped sequential zones for the target is done using the new function dm_device_count_zones() which performs a report zones on the entire block device with the callback dm_device_count_zones_cb(). This count of mapped sequential zones is used to determine if the mapped device contains only conventional zones. This allows simplifying dm_set_zones_restrictions() to not do a report zones. For mapped devices mapping only conventional zones, dm_set_zone_resource_limits() changes the mapped device to a regular device by setting the zoned limit to false and clearing all zone related limits.
--- drivers/md/dm-zone.c | 193 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 161 insertions(+), 32 deletions(-)
drivers/md/dm-zone.c +161 -32
@@ -145,17 +145,164 @@ bool dm_is_zone_write(struct mapped_device *md, struct bio *bio) } } +struct dm_device_zone_count { +sector_t start; +sector_t len; +unsigned int total_nr_seq_zones; +unsigned int target_nr_seq_zones; +}; +/* -* Count conventional zones of a mapped zoned device. If the device -* only has conventional zones, do not expose it as zoned. +* Count the total number of and the number of mapped sequential zones of a +* target zoned device. */ -static int dm_check_zoned_cb (struct blk_zone *zone,unsigned int idx, -void *data) +static int dm_device_count_zones_cb (struct blk_zone *zone, +unsigned int idx,void *data) { -unsigned int *nr_conv_zones = data; +struct dm_device_zone_count *zc = data; + +if (zone->type !=BLK_ZONE_TYPE_CONVENTIONAL ) { + zc->total_nr_seq_zones++; +if (zone->start >= zc->start && + zone->start < zc->start + zc->len) + zc->target_nr_seq_zones++; + } + +return 0 ; +} -if (zone->type ==BLK_ZONE_TYPE_CONVENTIONAL ) - (*nr_conv_zones)++; +static int dm_device_count_zones (struct dm_dev *dev, +struct dm_device_zone_count *zc) +{ +int ret; + + ret =blkdev_report_zones (dev->bdev,0 ,BLK_ALL_ZONES , + dm_device_count_zones_cb, zc); +if (ret <0 ) +return ret; +if (!ret) +return -EIO ; +return 0 ; +} + +struct dm_zone_resource_limits { +unsigned int mapped_nr_seq_zones; +struct queue_limits *lim; +bool reliable_limits; +}; + +static int device_get_zone_resource_limits (struct dm_target *ti, +struct dm_dev *dev,sector_t start, +sector_t len,void *data) +{ +struct dm_zone_resource_limits *zlim = data; +struct gendisk *disk = dev->bdev->bd_disk; +unsigned int max_open_zones, max_active_zones; +int ret; +struct dm_device_zone_count zc = { + .start = start, + .len = len, + }; + +/* +* If the target is not the whole device, the device zone resources may +* be shared between different targets. Check this by counting the +* number of mapped sequential zones: if this number is smaller than the +* total number of sequential zones of the target device, then resource +* sharing may happen and the zone limits will not be reliable. +*/ + ret =dm_device_count_zones (dev, &zc); +if (ret) { +DMERR ("Count %s zones failed %d" , disk->disk_name, ret); +return ret; + } + + zlim->mapped_nr_seq_zones += zc.target_nr_seq_zones; + +/* +* If the target does not map any sequential zones, then we do not need +* any zone resource limits. +*/ +if (!zc.target_nr_seq_zones) +return 0 ; + +/* +* If the target does not map all sequential zones, the limits +* will not be reliable. +*/ +if (zc.target_nr_seq_zones < zc.total_nr_seq_zones) + zlim->reliable_limits = false; + +/* +* If the target maps less sequential zones than the limit values, then +* we do not have limits for this target. +*/ + max_active_zones = disk->queue->limits.max_active_zones; +if (max_active_zones >= zc.target_nr_seq_zones) + max_active_zones =0 ; + zlim->lim->max_active_zones = +min_not_zero (max_active_zones, zlim->lim->max_active_zones); + + max_open_zones = disk->queue->limits.max_open_zones; +if (max_open_zones >= zc.target_nr_seq_zones) + max_open_zones =0 ; + zlim->lim->max_open_zones = +min_not_zero (max_open_zones, zlim->lim->max_open_zones); + +return 0 ; +} + +static int dm_set_zone_resource_limits (struct mapped_device *md, +struct dm_table *t,struct queue_limits *lim) +{ +struct gendisk *disk = md->disk; +struct dm_zone_resource_limits zlim = { + .reliable_limits = true, + .lim = lim, + }; + +/* Get the zone resource limits from the targets. */ +for (unsigned int i =0 ; i < t->num_targets; i++) { +struct dm_target *ti =dm_table_get_target (t, i); + +if (!ti->type->iterate_devices || + ti->type->iterate_devices (ti, + device_get_zone_resource_limits, &zlim)) { +DMERR ("Could not determine %s zone resource limits" , + disk->disk_name); +return -ENODEV ; + } + } + +/* +* If we only have conventional zones mapped, expose the mapped device ++ as a regular device. +*/ +if (!zlim.mapped_nr_seq_zones) { + lim->max_open_zones =0 ; + lim->max_active_zones =0 ; + lim->max_zone_append_sectors =0 ; + lim->zone_write_granularity =0 ; + lim->chunk_sectors =0 ; + lim->zoned = false; +clear_bit (DMF_EMULATE_ZONE_APPEND , &md->flags); + md->nr_zones =0 ; + disk->nr_zones =0 ; +return 0 ; + } + +/* +* Warn once (when the capacity is not yet set) if the mapped device is +* partially using zone resources of the target devices as that leads to +* unreliable limits, i.e. if another mapped device uses the same +* underlying devices, we cannot enforce zone limits to guarantee that +* writing will not lead to errors. Note that we really should return +* an error for such case but there is no easy way to find out if +* another mapped device uses the same underlying zoned devices. +*/ +if (!get_capacity (disk) && !zlim.reliable_limits) +DMWARN ("%s zone resource limits may be unreliable" , + disk->disk_name);return 0 ; }
@@ -232,8 +379,6 @@ int dm_set_zones_restrictions(struct dm_table *t, struct request_queue *q, struct queue_limits *lim) {struct mapped_device *md = t->md; -struct gendisk *disk = md->disk; -unsigned int nr_conv_zones =0 ;int ret;/*
@@ -249,32 +394,16 @@ int dm_set_zones_restrictions(struct dm_table *t, struct request_queue *q, }/* -* Count conventional zones to check that the mapped device will indeed -* have sequential write required zones. +* Determine the max open and max active zone limits for the mapped +* device. For a mapped device containing only conventional zones, the +* mapped device is changed to be a regular block device, so exit early +* for such case. */ - md->zone_revalidate_map = t; - ret =dm_blk_report_zones (disk,0 ,UINT_MAX , - dm_check_zoned_cb, &nr_conv_zones); - md->zone_revalidate_map =NULL ; -if (ret <0 ) { -DMERR ("Check zoned failed %d" , ret); + ret =dm_set_zone_resource_limits (md, t, lim); +if (ret)return ret; - } - -/* -* If we only have conventional zones, expose the mapped device as -* a regular device. -*/ -if (nr_conv_zones >= ret) { - lim->max_open_zones =0 ; - lim->max_active_zones =0 ; - lim->zoned = false; -clear_bit (DMF_EMULATE_ZONE_APPEND , &md->flags); - disk->nr_zones =0 ; -return 0 ; - } -if (!static_key_enabled (&zoned_enabled.key)) +if (lim->zoned && !static_key_enabled (&zoned_enabled.key))static_branch_enable (&zoned_enabled);return 0 ; }
Signature · 1 line
2.45.2
Re: [PATCH v5 3/4] dm: Improve zone resource limits handling
drivers/md/dm-zone.c bool dm_is_zone_write(struct mapped_device *md, struct bio *bio) · line 256
Quoted 2 lines
drivers/md/dm-zone.c +2
-0+static int dm_set_zone_resource_limits (struct mapped_device *md, +struct dm_table *t,struct queue_limits *lim)
Is there much of a point in splitting this out of dm_set_zones_restrictions when almost nothing is left in dm_set_zone_resource_limits after this changes?
Either way the logic looks good to me:
Damien Le Moal
maintainerRe: [PATCH v5 3/4] dm: Improve zone resource limits handling
Quoted 6 lines · Christoph Hellwig
drivers/md/dm-zone.c bool dm_is_zone_write(struct mapped_device *md, struct bio *bio) · line 256
Quoted 2 lines
drivers/md/dm-zone.c +2
-0+static int dm_set_zone_resource_limits (struct mapped_device *md, +struct dm_table *t,struct queue_limits *lim)Is there much of a point in splitting this out of
dm_set_zones_restrictionswhen almost nothing is left indm_set_zone_resource_limitsafter this changes?
Indeed, we can merge the code and avoid the additional function. Will do that.
Quoted 4 lines
Either way the logic looks good to me:
Reviewed-by Christoph Hellwig <[email protected]>
Signature · 2 lines
Damien Le Moal Western Digital Research
Damien Le Moal
maintainerPATCH v5 4/4 dm: Remove unused macro DM_ZONE_INVALID_WP_OFST
In reply to Damien Le MoalWith the switch to using the zone append emulation of the block layer zone write plugging, the macro DM_ZONE_INVALID_WP_OFST is no longer used in dm-zone.c. Remove its definition.
--- drivers/md/dm-zone.c | 2 -- 1 file changed, 2 deletions(-)
drivers/md/dm-zone.c +0 -2
@@ -13,8 +13,6 @@#define DM_MSG_PREFIX "zone" -#define DM_ZONE_INVALID_WP_OFST UINT_MAX -/* * For internal zone reports bypassing the top BIO submission path. */
Signature · 1 line
2.45.2
Vaguely related: should we add you to MAINTAINERS for drivers/md/dm-zone* so that you always are in the loop for changes to this code?
Damien Le Moal
maintainerQuoted 3 lines · Christoph Hellwig
Vaguely related: should we add you to
MAINTAINERSfordrivers/md/dm-zone*so that you always are in the loop for changes to this code?
Sure, fine with me.
Note that I am working with Shin'ichiro to add test cases to better cover this. So either way, our weekly runs on rc and -next will catch any issue/regression sneaking in.
Signature · 2 lines
Damien Le Moal Western Digital Research