net: openvswitch: Check vport netdev name
Subsystems (3)
PATCH v4 1/1 net: openvswitch: Check vport netdev name
Ensure that the provided netdev name is not one of its aliases to prevent unnecessary creation and destruction of the vport by ovs-vswitchd.
--- net/openvswitch/vport-netdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
net/openvswitch/vport-netdev.c +4 -1
@@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)int err; vport->dev =dev_get_by_name (ovs_dp_get_net (vport->dp), name); -if (!vport->dev) { +/* Ensure that the device exists and that the provided +* name is not one of its aliases. +*/ +if (!vport->dev ||strcmp (name,ovs_vport_name (vport))) { err = -ENODEV ; goto error_free_vport; }
Signature · 1 line
2.25.1
Jakub Kicinski
maintainernet/openvswitch/vport-netdev.c struct vport *ovs_netdev_link(struct vport *vport, const char *name) · line 87
Quoted 9 lines · On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
net/openvswitch/vport-netdev.c +4
-1vport->dev =dev_get_by_name (ovs_dp_get_net (vport->dp), name); -if (!vport->dev) { +/* Ensure that the device exists and that the provided +* name is not one of its aliases. +*/ +if (!vport->dev ||strcmp (name,ovs_vport_name (vport))) { err = -ENODEV ; goto error_free_vport; }
Sorry I applied this before I realised that it's buggy. dev_get_by_name() will give you a reference on the device. You must free it, so the error handling is different. Please follow up ASAP to fix that.
My mistake, I'm wondering that I need to submit a new patch or a v5 version based on this patch?
Quoted 16 lines · Jakub Kicinski
net/openvswitch/vport-netdev.c struct vport *ovs_netdev_link(struct vport *vport, const char *name) · line 87
Quoted 9 lines · On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);net/openvswitch/vport-netdev.c +4
-1-if (!vport->dev) { +/* Ensure that the device exists and that the provided +* name is not one of its aliases. +*/ +if (!vport->dev ||strcmp (name,ovs_vport_name (vport))) { err = -ENODEV ; goto error_free_vport; }Sorry I applied this before I realised that it's buggy.
dev_get_by_name()will give you a reference on the device. You must free it, so the error handling is different. Please follow up ASAP to fix that.
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 19 Apr 2024 14:14:25 +0800 you wrote:
Ensure that the provided netdev name is not one of its aliases to prevent unnecessary creation and destruction of the vport by ovs-vswitchd.
Signed-off-by Jun Gu <[email protected]>Acked-by Eelco Chaudron <[email protected]>[...]
Here is the summary with links:
- [net-next,v4] net: openvswitch: Check vport netdev name
https://git.kernel.org/netdev/net-next/c/2540088b836f
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html